[05:29:05] 6Multimedia: Meeting : Wiki for makers / #3dFiles and otherssubjects - https://phabricator.wikimedia.org/T99453#1324789 (10Qgil) 5Open>3declined p:5Triage>3Low [05:30:04] 6Multimedia: Meeting : Wiki for makers / #3dFiles and otherssubjects - https://phabricator.wikimedia.org/T99453#1292073 (10Qgil) I couldn't find this session at https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2015/Program and I resolved this task accordingly. If the meeting actually happened, or if you want t... [06:21:31] 6Multimedia, 10MediaWiki-File-management: PHP thumbnailer as a service - https://phabricator.wikimedia.org/T91104#1324897 (10Qgil) [06:23:20] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Remove Flickr checking from client side - https://phabricator.wikimedia.org/T100062#1324901 (10Qgil) [06:23:23] 6Multimedia: Enable Flickr import for all users on Commons - https://phabricator.wikimedia.org/T90004#1324900 (10Qgil) [06:24:04] 6Multimedia: Enable Flickr import for all users on Commons - https://phabricator.wikimedia.org/T90004#1051277 (10Qgil) > See blocking tasks (TBD) for more. I listed an obvious blocking task (the one you showcased in Lyon), but I have no idea about the rest. [07:07:46] 6Multimedia: Enable Flickr import for all users on Commons - https://phabricator.wikimedia.org/T90004#1324963 (10Revi) >>! In T90004#1284013, @Mattflaschen wrote: > There are no blocking tasks listed. General issue is, will the average user know how to recognize likely flickr-washing? I want to know about this... [10:53:35] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1325258 (10Bawolff) 3NEW [11:03:23] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1325283 (10Bawolff) [04:03] ok, that should have cleaned it up [04:04] there should be a script that, given the xml file name and the user account, can... [11:16:29] gilles: poke [11:16:41] or should i poke bawolff ? [11:16:53] matanya: That depends on what you're poking about? [11:17:02] What's up? [11:17:12] when there is a name clash in UW there is no way to fix the name re-try the upload, is that known ? [11:17:25] For that, you should poke marktraceur [11:17:36] All i found in phab is https://phabricator.wikimedia.org/T42893 [11:17:43] which is close, but not the same [11:18:01] thanks bawolff [11:18:15] marktraceur is the king of the upload wizard [11:20:47] not much game of thrones warring over that crown [11:21:40] lol [11:27:15] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UW doesn't allow to fix a name clashing issue - https://phabricator.wikimedia.org/T100975#1325309 (10Matanya) 3NEW [11:27:34] bawolff: ^ [11:27:39] see the pain in action [11:28:12] the best part is the name is picked automaticlly, so if you missed it, you are screwed [11:32:23] Eddard Mark :P [11:40:30] http://commons.wikimedia.org/wiki/File:Melanthera_biflora847.JPG < images with unknown date in EXIF fail badly :P [11:42:09] bawolff: do we currently use exiftool? [11:42:18] no [11:42:43] We use php's builtin crap exif support [11:43:04] However, not sure I see what's wrong with that file? [11:44:09] comets: --^ [11:44:21] I see something like [11:44:23] Date and time of data generation Unknown date [11:44:28] which is what I'd expect [11:44:39] yep and thus the date noted after uplaod is Novemebr 1899 [11:44:53] oh [11:45:14] You mean, as was auto-filled in upload wizard? [11:45:30] I think upload wizard uses a different js library to extract exif. I'm not sure [11:45:54] yep [11:46:33] I've been playing around with tinyrgb and ironically I spot a hue difference with it, whereas I don't by just stripping the profile. I assume this is because Preview.app defaults to sRGB when there's no profile, like most things will [11:47:01] it would be good to know what browsers/devices would be impacted by stripping sRGB (and leaving other profiles alone) [11:50:23] https://www.dropbox.com/s/4ihub0mt8ij97qv/tinyrgb.jpg?dl=0 [11:50:33] https://www.dropbox.com/s/8ic5fh2gaks95x4/noprofile.jpg?dl=0 [11:50:40] https://www.dropbox.com/s/e04iczcok8mverg/original.jpg?dl=0 [11:52:52] Would be nice if we could steal facebook's tiny rgb profile [11:52:57] that's what I did [11:53:17] what I'm saying is that it does have an effect on colors, unforunately [11:53:18] oh cool. Is it open source/copyright compatible [11:53:54] well that's the funny part, they have no copyright information in it, but the stock sRGB we embed in a ton if images is copyrighted [11:54:15] I'm sure we could ask FB to open source it clearly to be safe [11:55:12] but what I'm seeing so far is that not embedding sRGB might be even better, since most software will default to assuming that general sRGB profile when no profile is embedded [11:55:48] other profiles are useful to embed, but they're the minority by far. most of our images either have no profile or use sRGB [11:56:25] Copyright (c) 1998 Hewlett-Packard Company [11:56:34] this is the one found everywhere [11:57:03] also has mentions of MSFT and IEC in it, but the copyright is to HP [11:59:07] I always thought, that without a colour profile, browsers default to whatever the computers default profile is, which is usually but not always sRGB [11:59:11] But I could be wrong [11:59:22] I'm reading conflicting information about that [11:59:32] some say it may default to the monitor's profile [11:59:37] might be OS-dependent too [12:00:02] we can play it safe and use FB'stinyrgb, but I already see a hue difference with desktop software on the first image I've picked... [12:00:50] I have a vague memory that computers with adobe photoshop installed had a different default colour profile then people without that installed. If you know someone who has that software, that might be a good thing to test [12:01:29] the thing is, we serve a ton of thumbnails without profiles [12:01:45] so if it were a huge issue, wouldn't we hear about "some thumbnails looking funny"? [12:03:47] so far I've tried in 3 different browsers and they all look the same (srgb, tinyrgb, no profile). but I don't have a native windows machine around to check that [12:05:29] I think on commons there was a complain once that png files and our svgs rendered to pngs look different, which came down to the PNG having sRGB set, but our svg renderings don't have a profile set [12:07:42] it's really silly that we can't just refer to the profile without embedding it [12:08:26] I wonder how many times a day one downloads that profile as part of a jpg while browsing the web [12:10:00] and indeed it seems like SVG supports them and seems to be smart enough to support pointing to a common profile, instead of having to embed it [12:10:40] Actually I believe not including a profile in SVG is supposed to mean default to sRGB [12:11:02] but rsvg doesn't set the bit on the png file (pngs also support just pointing to them) [12:11:06] maybe the issue lies with software reading SVGs not implementing that properly in practice [12:12:34] "2) Apple® (as of 10.7), Windows® 8 7 Vista XP and smart devices Web browsers iOS, Android, Blackberry devices already assume color on the Internet is sRGB." [12:12:36] Lots of issue lies that way [12:12:58] Android/iOS don't support colour profiles at all [12:13:16] I think the complaints would come from the fact that in media viewer we encourage people to download smaller versions than the original [12:13:22] and those would be thumbnails, technically [12:13:42] and if there are any issues with profile-less images, they are likely to happen on desktop software [12:13:45] not inside the browser [12:14:03] just like I experienced, seeing those 3 images identical in all browsers, but one looking different on desktop software [12:14:06] fwiw, all three of those files you linked to earlier, look exactly the same on my laptop to me [12:14:19] in chrome [12:14:22] even using desktop image viewers? [12:14:37] try that, and look at angel's dress's purple [12:14:40] angela [12:17:27] Looks the same to me (Using image magick display, which I believe ignores colour profiles) [12:19:19] ok, so it seems like the only people having problems would be those who have wide gamut monitors, on specific browsers that kind of support color profiles [12:19:59] I think all desktop browsers support colour profiles now (but none of the mobile) [12:20:08] but the article I'm reading suggests that even on those browsers all the other elements on the page (I assume they mean things colored by CSS) will look oversaturated just like the profile-less images do [12:20:42] I guess facebook still includes one for a reason, but I'm disappointed to find color differences right away [12:20:57] my screen is definitely not wide gaumet [12:21:33] it can be a color shift on regular monitors [12:21:55] in my case only the purple changes, it's not an issue of all colors looking saturated [12:22:31] and I forgot to mention that it only happens on my laptop's monitor, not on the external one [12:23:19] but if I recall correctly, I calibrated the external monitor with a sensor but never did that for the laptop's monitor [12:23:43] most people have wildly uncalibrated monitors, which makes those issues a lot worse [12:24:17] which is kin of ironic because people will complain that the images look funny but their monitor's lack of calibration certainly guarantees that they *never* see the proper colors :) [12:33:14] gilles: One file I really noticed the difference was: https://upload.wikimedia.org/wikipedia/test/1/19/Dobrolet_logo_%28Russian%29.svg-conv.png vs https://upload.wikimedia.org/wikipedia/commons/thumb/0/09/Dobrolet_logo_%28Russian%29.svg/800px-Dobrolet_logo_%28Russian%29.svg.png [13:02:34] The log entries on gwtoolset, so aren't following how they're supposed to be done [13:02:45] * marktraceur wanders in [13:02:54] OK which of the uploadwizard fires need to be put out most [13:03:22] I have three fatal issues from rillke that I assume are most important. [13:03:33] Er, no, Romaine. [13:10:39] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Issues with Upload Wizard - https://phabricator.wikimedia.org/T100935#1325542 (10MarkTraceur) Efforts to reproduce: # Chrome loads fine, uploads fine, proceeds to deed step without issue # Firefox loads fine, uploads fine, proceeds to deed step without issue #... [13:14:30] gilles: Hmm, in theory there's an exif tag to say "This image is sRGB, interpret as such". Doesn't look like its universially respected :s [13:14:51] * bawolff reading http://regex.info/blog/photo-tech/color-spaces-page7 [13:15:35] None of them actually happened, what's next [13:16:05] matanya: I think that's a known issue, I don't think it's ever worked really [13:16:43] matanya: https://phabricator.wikimedia.org/T42893 (the task you found) is actually going to be pretty much the same issue [13:16:44] thanks marktraceur i didn't find a task in phab though [13:16:58] matanya: It's just a matter of differentiating between "errors" and "warnings" [13:17:01] * matanya takes the last line back [13:17:07] Right now UW is too stupid to do so [13:17:15] marktraceur: feel free to merge [13:17:59] marktraceur: i can understand when it is complicated to do before publishing, but can you run a check before one clicks upload ? [13:18:17] bawolff: sad but predictable [13:18:44] matanya: Uhhh, merge what? [13:19:00] marktraceur: the two tickets [13:19:02] matanya: Also, "upload" is now an automatic process, once you choose a file [13:19:22] Oh. [13:20:09] matanya: Technically I guess they're different tasks, just the first one we solve is going to be a doozy. [13:20:17] The rest will be easier. [13:21:09] ok, thanks much for your time marktraceur [13:21:22] My pleasure! :) [13:21:40] I guess I will continue the long haul to OOUI-ification [13:32:33] (03CR) 10Paladox: "Has this been fixed to work." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [13:35:45] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: TMH Fatal error: Call to a member function getText() on a non-object - https://phabricator.wikimedia.org/T43642#1325627 (10hashar) [13:37:31] (03PS2) 10Paladox: Update ogv.js from upstream commit bbd24dafd [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212901 (owner: 10Brion VIBBER) [13:37:34] (03PS33) 10Paladox: ogv.js media player for desktop Safari/IE/Edge (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [13:38:57] (03PS3) 10Paladox: Update ogv.js from upstream commit bbd24dafd [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212901 (owner: 10Brion VIBBER) [13:39:21] (03CR) 10Paladox: [C: 031] "I doint rember updating this I updated https://gerrit.wikimedia.org/r/#/c/165478/" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212901 (owner: 10Brion VIBBER) [13:40:39] (03PS34) 10Paladox: ogv.js media player for desktop Safari/IE/Edge (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [13:41:28] (03CR) 10Paladox: [C: 031] ogv.js media player for desktop Safari/IE/Edge (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [13:49:02] O.O [13:55:46] marktraceur: Well good thing somebody reviewed that [13:55:55] Should be safe now, we can just merge [13:58:50] Oh, good [14:26:52] So there is appearently a whole whack of files created over the last three days, that are missing description pages [14:27:07] mostly either by flickr2commons or gwtoolset [14:27:41] https://commons.wikimedia.org/wiki/User:Ilmari_Karonen/Queries/Zombie_images [14:38:11] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Description page sometimes not created during upload - https://phabricator.wikimedia.org/T68355#1325875 (10Bawolff) p:5Normal>3High [14:39:16] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Description page sometimes not created during upload - https://phabricator.wikimedia.org/T68355#684562 (10Bawolff) I'm raising priority, as there was a significant uptick in this happening over the past few days. See https://commons.wikimedia.org/w/index.php?titl... [15:17:19] 6Multimedia, 10MediaWiki-extensions-VipsScaler, 7Performance: Apply jpgcrush (mozjpeg) over all thumbnails - https://phabricator.wikimedia.org/T70145#1326012 (10Gilles) Gave mozjpeg a spin, based on production IM parameters: convert obama.jpg -background white -define jpeg:size=220x275 -thumbnail 220x275! -... [15:23:12] 6Multimedia, 10MediaWiki-extensions-VipsScaler, 7Performance: Apply jpgcrush (mozjpeg) over all thumbnails - https://phabricator.wikimedia.org/T70145#1326032 (10Gilles) As I suspected, the IM one contains the sRGB profile, the mozjpeg one doesn't have any. Adding the sRGB profile back into the mozjpeg one wi... [15:28:23] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1326052 (10jcrespo) The import seems to be ongoing, so what was done was not enough https://logstash.wikimedia.org/#/dashboard/temp/ATwrcvoFRCm7q-0IGwXU8A [15:59:26] MatmaRex: Hey, have you seen the very silly destinationChecker file in UploadWizard? [15:59:36] It's a jQuery plugin. [15:59:42] Why? Nobody knows. [15:59:59] nnnno [16:00:08] I was going to say something like "how hard would it be to port that to something OOUI-y?" but then I came to my senses [16:00:24] So now I'm just causing you internal anguish [16:01:01] * marktraceur sets about making this patch bigger [16:01:10] MatmaRex: Out of curiosity, what are you working on? [16:02:19] marktraceur: OOUI maintenance [16:02:26] marktraceur: and then hopefully the date picker widget at last [16:02:29] Neat. [16:03:15] 6Multimedia, 10MediaWiki-extensions-Score: Unable to convert ABC file to LilyPond format: IndexError: list index out of range - https://phabricator.wikimedia.org/T73893#1326124 (10Gerardduenas) 5Open>3Invalid a:3Gerardduenas [16:04:59] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1326134 (10Bawolff) >>! In T100972#1326052, @jcrespo wrote: > The import seems to be ongoing, so what was done was not enough https://logstash.wikimedia.org/#/dashboard/te... [16:23:34] marktraceur: Might be helpful for you to be in #wikimedia-editing too, so you can catch the occasional OOUI chatter. [16:29:12] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1326249 (10Chandres) and an interesting point is that now the upload are successful.... at least since 3:17 UTC [16:29:36] Aha. [17:10:31] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Epic, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1326364 (10Jdlrobson) [17:10:47] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Epic, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1311313 (10Jdlrobson) @tgr I hear you wrote this. Was enabling it on mobile an oversight or is it serving a purpose? [17:17:40] 6Multimedia, 10MediaWiki-extensions-VipsScaler, 7Performance: Apply jpgcrush (mozjpeg) over all thumbnails - https://phabricator.wikimedia.org/T70145#1326387 (10Gilles) a:3Gilles [17:26:15] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1326430 (10Tgr) The metadata job automatically recreates itself when it's done, so deleting it from redis is not so easy. Also, a high-level extension directly interacting... [17:55:21] (03PS1) 10Ori.livneh: Don't log null fallbackFullLoadingTime [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/215072 [17:58:08] (03CR) 10jenkins-bot: [V: 04-1] Don't log null fallbackFullLoadingTime [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/215072 (owner: 10Ori.livneh) [18:30:50] (03PS2) 10Gergő Tisza: Don't log null fallbackFullLoadingTime [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/215072 (owner: 10Ori.livneh) [18:41:29] (03CR) 10Gergő Tisza: [C: 032] Don't log null fallbackFullLoadingTime [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/215072 (owner: 10Ori.livneh) [18:46:43] (03Merged) 10jenkins-bot: Don't log null fallbackFullLoadingTime [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/215072 (owner: 10Ori.livneh) [18:52:52] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Epic, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1326758 (10Tgr) It's collecting image loading times for the big images on file pages, and information about CORS support. The... [19:16:26] 6Multimedia, 10Beta-Cluster, 10MediaWiki-JobRunner, 10MediaWiki-extensions-TimedMediaHandler: deployment-videoscaler01 PHP Fatal error: /srv/mediawiki/wikiversions-labs.cdb has no version entry for `webVideoTranscode%2Fdewiki/webVideoTranscode%2Fdewiki`.#0... - https://phabricator.wikimedia.org/T100694#1326858 [19:17:06] 6Multimedia, 10Beta-Cluster, 10MediaWiki-JobRunner, 10MediaWiki-extensions-TimedMediaHandler: deployment-videoscaler01 PHP Fatal error: /srv/mediawiki/wikiversions-labs.cdb has no version entry for `webVideoTranscode%2Fdewiki/webVideoTranscode%2Fdewiki`.#0... - https://phabricator.wikimedia.org/T100694#1318564 [19:31:06] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset needs cancel functionality - https://phabricator.wikimedia.org/T100972#1326889 (10Bawolff) I like option 2. [20:06:33] (03CR) 10Krinkle: Use promises for getting image info (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [20:09:03] O.O [20:09:07] That's an old patch [20:09:59] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Epic, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1327005 (10Jdlrobson) @tgr despite the size the concern is about whether it needs to be loaded in the head. Thanks for looki... [20:42:28] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Epic, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1327065 (10Tgr) It is top-loaded so that it can capture the load event of the image, which can happen before normal scripts a... [20:43:37] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Mobile-Web, 7Performance: ext.imageMetrics.head shouldn't be loaded on mobile - https://phabricator.wikimedia.org/T100378#1327067 (10Tgr)