[04:57:59] hey marktraceur u guys made changes to uploadwiz/flickr? i think you broke its ability to use the "date" info from the image's EXIF .. i added an image from 2013, it said it was from 1899 .. [07:20:30] (03CR) 10Siebrand: [C: 032] Remove i18n shim [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/213544 (owner: 10Paladox) [07:24:27] (03Merged) 10jenkins-bot: Remove i18n shim [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/213544 (owner: 10Paladox) [07:28:14] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [07:28:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/213763 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [08:03:08] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1313965 (10TheDJ) @Paladox, thanks for some of the plugin suggestions. Please do note however that the quality of some of the plugins is not up to Wikimedia standards... [08:55:06] 6Multimedia, 6Commons, 10Wikimedia-Media-storage, 7Tracking: Thumbnail/imagescaler (tracking) - https://phabricator.wikimedia.org/T43371#1314027 (10zhuyifei1999) [08:58:51] (03PS1) 10Paladox: Remove i18n shim [extensions/UploadWizard] (REL1_25) - 10https://gerrit.wikimedia.org/r/214008 [10:58:26] (03PS1) 10Galorefitz: mmv.mixins.less: Remove '-ms-linear-gradient' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) [11:09:37] 6Multimedia, 10VisualEditor: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon - https://phabricator.wikimedia.org/T100453#1314188 (10Josve05a) [12:01:46] comets: Hm, not sure. File ze bug? :) [12:15:56] apparently the image had no date in the exif (odd), though the image on flickr did :P [12:33:05] comets: Oh, weird. Maybe they pulled out some magical data from the uploader or defaulted to the upload date [12:35:07] yeah 1899 lol [12:35:32] they had cameras back then with EXIF data?.. interesting :P [13:30:13] (03CR) 10Edokter: [C: 04-1] "Agree with removal. However, background-image without vendor prefix should come last." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) (owner: 10Galorefitz) [13:56:59] (03CR) 10Galorefitz: "@Edokter: Thank you for pointing that out. There are also two other instances in the file where filter without the vendor prefix is before" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) (owner: 10Galorefitz) [14:12:19] (03PS2) 10Galorefitz: mmv.mixins.less: Remove '-ms-linear-gradient' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) [15:26:11] (03PS3) 10Bartosz Dziewoński: mmv.mixins.less: Remove '-ms-linear-gradient' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) (owner: 10Galorefitz) [15:26:17] (03CR) 10Bartosz Dziewoński: [C: 032] mmv.mixins.less: Remove '-ms-linear-gradient' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) (owner: 10Galorefitz) [15:27:30] (03Merged) 10jenkins-bot: mmv.mixins.less: Remove '-ms-linear-gradient' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214032 (https://phabricator.wikimedia.org/T100285) (owner: 10Galorefitz) [15:43:27] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Vector, 10Wikimedia-General-or-Unknown, and 2 others: Remove obsolete ms-linear-gradient declaration - https://phabricator.wikimedia.org/T100285#1314755 (10matmarex) 5Open>3Resolved p:5Triage>3Normal a:3Galorefitz [18:28:14] 6Multimedia, 10MediaWiki-File-management, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-05-27_(1.26wmf8): InstantCommons broken for some images: Error creating thumbnail: Invalid thumbnail parameters - https://phabricator.wikimedia.org/T34387#1315174 (10Umherirrender) 5Open>3Resolved [18:35:12] 6Multimedia, 10MediaWiki-extensions-UploadWizard: "Get from Flickr" does nothing - https://phabricator.wikimedia.org/T100540#1315193 (10Rillke) 3NEW [18:43:00] 6Multimedia, 10MediaWiki-extensions-UploadWizard: "Get from Flickr" does nothing - https://phabricator.wikimedia.org/T100540#1315227 (10Rillke) Yees, an the course for that is that the button is of type button now where before it was of type submit (or default). Thus, the form is not submitted when the button... [18:43:21] 6Multimedia, 10MediaWiki-extensions-UploadWizard: "Get from Flickr" does nothing - https://phabricator.wikimedia.org/T100540#1315229 (10Rillke) a:3Rillke [19:16:06] (03PS1) 10Rillke: FlickrUpload form: Button needs to be of type `submit` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) [19:23:27] (03CR) 10Polybuildr: "Code looks fine, but the commit message could be changed to match the convention." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:25:38] (03PS2) 10Rillke: Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) [19:27:04] (03CR) 10Polybuildr: [C: 031] Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:31:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: "Get from Flickr" does nothing - https://phabricator.wikimedia.org/T100540#1315365 (10Rillke) d639454893a04b413b2013b0a67bd35a2f36bff6 is to blame for this regression. Also very subjective commit message. [19:32:39] ^^ marktraceur [19:35:21] rillke: I think comets may have reported that already... [19:35:48] Oh, no, different thing [19:35:48] then I suggest the fix is quickly merged and backported [19:35:50] * marktraceur is a bit hazy [19:36:08] Oh, right [19:36:14] rillke: I think I fixed that already actually [19:36:28] rillke: Hitting entter in the text field still works fwiw [19:36:38] https://gerrit.wikimedia.org/r/213489 [19:37:25] (03Abandoned) 10MarkTraceur: Fix "Get from Flickr" button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/213489 (owner: 10MarkTraceur) [19:37:28] (03CR) 10MarkTraceur: [C: 032] "Identical to I1d891e0feb20d47e12e6acac625b50b7053ec9aa but I can merge this one." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:37:48] (03Abandoned) 10Rillke: Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:37:56] rillke: No no unabandon [19:38:03] (03Restored) 10MarkTraceur: Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:38:29] They're the same, but I can actually merge yours [19:38:42] okay [19:39:17] rillke: Do you know how to do submodule updates for branches? [19:39:40] I'm still very much reeling from my cross-atlantic trip, so I'd prefer not trying to do it myself [19:41:17] You mean you have some submodules only in one branch, don't want to update this branch but update the subodules? I have no clue but I most likely would fiddle something in the .git directory directly [19:41:48] rillke: No, like [19:41:56] *dont want to checkout this branch but to update the submodule [19:42:18] rillke: mediawiki/core.git has branches like wmf/1.26wmf7 that have submodules for extensions deployed on the cluster [19:42:39] If you haven't done it before then you might not be able to do it [19:43:29] (03CR) 10MarkTraceur: Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:43:30] Oh, I didn't know that core.git has submodules. [19:43:34] (03CR) 10MarkTraceur: [C: 032] Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:43:46] Only in some branches [19:44:22] https://github.com/wikimedia/mediawiki/tree/wmf/1.26wmf6/extensions [19:44:27] I see :) [19:44:29] (03Merged) 10jenkins-bot: Flickr upload form: Make button of type=submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [19:49:55] In this case, I would checkout the branch init the submodules, go into the submodule directory, checkout the commit I need, return to mediawiki core directory and commit [19:50:20] but this sounds like being overly complicated [19:50:30] http://stackoverflow.com/a/5828396 [20:22:14] rillke: Yeah, it may not be worth it... [20:48:14] (03CR) 10Bartosz Dziewoński: "Arr :(" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/214112 (https://phabricator.wikimedia.org/T100540) (owner: 10Rillke) [20:53:17] MatmaRex, arr? [20:53:41] i should have caught the bug you just fixed before it caused problems :) [20:55:24] Actually mark-traceur was faster but didn't ask anybody for doing code review... [20:56:21] and in the end it's some oojs ui weirdness setting type="button" by default [20:56:37] on button elements [21:14:16] Yeah. [21:14:35] rillke: For a frontend UI library that makes a lot of sense, because submitting is such a rare thing for Ajaxy apps [21:15:08] It isn't, really, if you listen to the submit event. [21:15:38] This often has the advantage of autosuggest by browsers being enabled while it isn't on "normal" inputs. [21:16:16] "normal" inputs in terms of "inputs without form" [21:16:54] you still often have the "form" pattern despite ajax - an input and a submit button [21:38:25] 6Multimedia, 10MediaWiki-File-management: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#1315813 (10Spage) [22:00:14] (03CR) 10Kaldari: [C: 04-1] "README looks like code, not a README. This will confuse people." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [22:08:15] (03CR) 10Paladox: "Oh how can I make it a README without having to remove a lot since this is code but is a documentation." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [22:23:45] 6Multimedia, 10MediaWiki-File-management: PHP thumbnailer as a service - https://phabricator.wikimedia.org/T91104#1315959 (10Qgil) Did someone work on this project during #Wikimedia-Hackathon-2015? If so, please update the task with the results. If not, please remove the label. [23:22:09] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1316111 (10TheDJ) [23:52:48] (03PS1) 10Legoktm: Avoid not caching meta=filerepoinfo calls for logged in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214269 [23:56:03] (03CR) 10MaxSem: [C: 031] Avoid not caching meta=filerepoinfo calls for logged in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214269 (owner: 10Legoktm) [23:56:08] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1316219 (10Paladox) Ok. Thanks for noting my feedback. It was only feedback if someone the plugins doing make it into the extension it doesn't matter it is only feedb... [23:59:51] (03CR) 10MarkTraceur: [C: 032] Avoid not caching meta=filerepoinfo calls for logged in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/214269 (owner: 10Legoktm)