[04:00:16] marktraceur: How do you usually run your tests? http://localhost:8080/wiki/Special:JavaScriptTest/ ? [04:47:05] prtksxna: Yup. Plus the browser tests. cd tests/browser && bundle exec cucumber [04:47:25] Will try that too :) [04:48:13] marktraceur: I am done with all tasks that were assigned to me from previous projects (except one). I am working on T77600 right now. I understand that we'll have to re-do most of that in OOjs UI, but I am using it to get familiar with the project. [04:49:26] Sweet. [04:49:36] What bug is that? [04:50:08] marktraceur: Description field embetterments [04:50:26] marktraceur: One of the tasks tracked in - Improve UploadWizard UX [04:50:40] Right. [04:50:49] Sounds perfect, thanks :) [05:22:47] (03PS1) 10Prtksxna: Increase space between "Add new description" link and the text box [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208581 (https://phabricator.wikimedia.org/T77600) [05:22:50] (03PS1) 10Prtksxna: Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) [05:22:53] (03PS1) 10Prtksxna: Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) [05:23:46] (03CR) 10jenkins-bot: [V: 04-1] Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [05:23:54] (03CR) 10jenkins-bot: [V: 04-1] Increase space between "Add new description" link and the text box [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208581 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [05:24:50] (03CR) 10jenkins-bot: [V: 04-1] Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [05:48:27] (03PS2) 10Prtksxna: Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) [05:48:30] (03PS2) 10Prtksxna: Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) [05:48:33] (03PS1) 10Prtksxna: Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) [05:49:37] (03CR) 10jenkins-bot: [V: 04-1] Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [05:51:52] (03CR) 10Prtksxna: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208581 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [05:52:14] (03PS2) 10Prtksxna: Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) [10:29:35] 6Multimedia, 6Commons, 6operations, 7HHVM, 5Patch-For-Review: Create an HHVM 3.6.0 package, adding Tim's streaming patch - https://phabricator.wikimedia.org/T93194#1256428 (10Joe) The change in jit size had a positive effect in beta, where it prevented hhvm from crashing. [11:37:02] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard fails uploading pdf with error message - https://phabricator.wikimedia.org/T94562#1256489 (10Tgr) >>! In T94562#1254143, @555 wrote: > I'm getting the very same error on all possible u... [11:45:19] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1256508 (10Tgr) > I just retried the uploading process, and one of the files failed to upload with the error me... [11:45:39] 6Multimedia, 10MediaWiki-extensions-UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1256509 (10Tgr) [13:06:52] 6Multimedia, 10MediaWiki-Vagrant, 7Epic: All multimedia extensions/systems should have a MW-Vagrant role - https://phabricator.wikimedia.org/T88072#1256694 (10Tgr) [13:08:28] 6Multimedia, 10MediaWiki-File-management: Create poolcounter group for expensive thumbnails - https://phabricator.wikimedia.org/T77536#1256696 (10Tgr) [13:08:30] 6Multimedia, 10MediaWiki-File-management, 7Performance: Limit the number or expensive thumbnails that can be processed by the scalers in parallel - https://phabricator.wikimedia.org/T67691#1256697 (10Tgr) [13:09:11] 6Multimedia, 10MediaWiki-Vagrant: InstantCommons does not work in Vagrant - https://phabricator.wikimedia.org/T77286#1256702 (10Tgr) [13:10:12] 6Multimedia, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-MultimediaViewer, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Include templates into multimedia role - https://phabricator.wikimedia.org/T596#1256710 (10Tgr) [13:10:15] 6Multimedia, 10MediaWiki-Vagrant, 7Documentation: Add documentation/gallery/test suite to multimedia-related vagrant roles where needed - https://phabricator.wikimedia.org/T94977#1256709 (10Tgr) [15:31:19] (03CR) 10MarkTraceur: [C: 032] Increase space between "Add new description" link and the text box [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208581 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:33:15] (03Merged) 10jenkins-bot: Increase space between "Add new description" link and the text box [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208581 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:39:49] 6Multimedia, 6Reading-Infrastructure-Team, 6Release-Engineering, 6Scrum-of-Scrums, and 3 others: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#1257170 (10faidon) >>! In T84956#1166762, @hashar wrote: > @Gilles and I had a quick conf call yesterday. Seems the Debian packagi... [15:44:06] prtksxna: "Mention things depicted in the image" is hardly an encompassing description of what could be part of an image page... [15:44:24] prtksxna: I mean, if you have a good reason, I'm game, but I figured I'd ask [15:46:24] 6Multimedia, 6Reading-Infrastructure-Team, 6Release-Engineering, 5Patch-For-Review, 7Puppet: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#1257199 (10bd808) [15:46:50] (03CR) 10MarkTraceur: [C: 04-1] "Small message question" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:48:41] marktraceur: I am bad with copy, I wanted to put something there so I copied text from the tooltip. I figured someone will come along with better text and I'd change it. [15:49:05] Ah. [15:49:23] 6Multimedia, 6Reading-Infrastructure-Team, 6Release-Engineering, 5Patch-For-Review, 7Puppet: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#1257228 (10bd808) I removed the scrum of scrums and blocked on releng tags. I'll work with @tgr to come up with a basic plan on how t... [15:49:25] "Describe the image in detail" or something [15:51:26] marktraceur: Changed as per your comment on Gerrit :) [15:51:39] I'll be off to bed now… [15:51:42] (03PS3) 10Prtksxna: Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) [15:51:45] (03PS3) 10Prtksxna: Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) [15:51:47] K! [15:51:48] (03PS3) 10Prtksxna: Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) [15:52:56] (03CR) 10MarkTraceur: [C: 032] Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:53:12] Bye prtksxna. [15:53:18] James_F: o/ [15:53:37] (03CR) 10MarkTraceur: [C: 032] Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:53:46] marktraceur: Could I grab a +2 on https://gerrit.wikimedia.org/r/#/c/208337/ please? [15:55:09] (03Merged) 10jenkins-bot: Add placeholder text for the Description field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208582 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:55:12] (03Merged) 10jenkins-bot: Call requiredFieldLabel() after text() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208583 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [15:56:48] (03PS2) 10MarkTraceur: build: Bump grunt-jscs to latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208337 (owner: 10Jforrester) [15:56:53] (03CR) 10MarkTraceur: [C: 032] build: Bump grunt-jscs to latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208337 (owner: 10Jforrester) [15:57:48] Ta. [15:58:12] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Description field embetterments - https://phabricator.wikimedia.org/T77600#1257259 (10Prtksxna) [15:58:45] (03Merged) 10jenkins-bot: build: Bump grunt-jscs to latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208337 (owner: 10Jforrester) [15:59:09] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Description field embetterments - https://phabricator.wikimedia.org/T77600#829398 (10Prtksxna) Could we address the //maybe//s in the task description? [16:00:38] James_F: My pleasure. [16:00:46] (03CR) 10MarkTraceur: [C: 032] Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [16:04:25] (03CR) 10jenkins-bot: [V: 04-1] Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [16:10:15] (03CR) 10Prtksxna: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [16:10:52] prtksxna: That's not sleeping! :) [16:11:07] marktraceur: :P [16:11:19] marktraceur: https://phabricator.wikimedia.org/T77600#1257259 [16:12:53] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Description field embetterments - https://phabricator.wikimedia.org/T77600#1257299 (10MarkTraceur) I'd say this is enough for now. The other stuff should be done when we switch to OOUI. [16:13:08] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Tracking: [Tracking] Improve UploadWizard UX - https://phabricator.wikimedia.org/T96911#1257302 (10MarkTraceur) [16:13:11] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Description field embetterments - https://phabricator.wikimedia.org/T77600#1257300 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur [16:13:56] marktraceur: Recheck only does the main test build? Will the gate pipeline build happen automatically? [16:15:20] Hm, no, I think you need to touch the patch somehow [16:16:41] Rebase? Review? [16:32:21] Maybe I can review. [16:32:36] (03CR) 10MarkTraceur: Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [16:32:42] (03CR) 10MarkTraceur: [C: 032] Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [16:33:33] (03Merged) 10jenkins-bot: Move "x" control to the top-right of the description div and make it a bit bigger [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208588 (https://phabricator.wikimedia.org/T77600) (owner: 10Prtksxna) [17:58:46] hey marktraceur [18:00:11] marktraceur: i did some uploadwizard exploration on friday, submitted two cruft removals and a patch that tried to fix token handling (has a core dependency): https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/UploadWizard+owner:%22Bartosz+Dziewo%25C5%2584ski%22,n,z [18:00:47] marktraceur: and a bunch of OOUI changes, most of which are blocking HTMLForm. https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+owner:%22Bartosz+Dziewo%25C5%2584ski+%253Cmatma.rex%2540gmail.com%253E%22,n,z [18:03:26] OK [18:03:33] MatmaRex: I'll take a look :) [18:04:08] (03CR) 10MarkTraceur: [C: 032] Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208009 (owner: 10Bartosz Dziewoński) [18:04:25] marktraceur: i'll probably spend most of today and tomorrow catching up on university stuff, eh. [18:04:40] That's understandable :) [18:04:49] (03CR) 10MarkTraceur: [C: 032] Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [18:05:11] it's awful [18:05:39] MatmaRex: Any reason 208044 depends on the OOUI patch? [18:05:42] (the badtoken one) [18:06:16] marktraceur: oh, probably not. i guess i had that checked out at the time [18:06:25] marktraceur: it depends on the core patch that i need to write a test for, though [18:07:20] Right. [18:08:02] (03CR) 10jenkins-bot: [V: 04-1] Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208009 (owner: 10Bartosz Dziewoński) [18:09:18] (03CR) 10jenkins-bot: [V: 04-1] Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [18:09:32] Womp womp. [18:09:37] ehh [18:55:05] (03PS3) 10Jdlrobson: WIP: Commence introducing templating to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/206493 (https://phabricator.wikimedia.org/T96520) [18:55:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Commence introducing templating to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/206493 (https://phabricator.wikimedia.org/T96520) (owner: 10Jdlrobson) [19:10:26] 6Multimedia, 10MediaWiki-extensions-PdfHandler: Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1258272 (10Jdforrester-WMF) [19:11:16] (03CR) 10Jforrester: [C: 032] "…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [19:20:33] (03CR) 10jenkins-bot: [V: 04-1] Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [19:23:00] (03CR) 10Jforrester: "Looks like this is needed for tests?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [19:25:53] 6Multimedia, 10MediaWiki-extensions-ImageMap, 5Patch-For-Review: Convert ImageMap to use extension registration - https://phabricator.wikimedia.org/T87929#1258328 (10Jdforrester-WMF) [19:56:00] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 5Patch-For-Review: Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1258520 (10Legoktm) 5Open>3Resolved a:3Legoktm [20:05:23] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 5Patch-For-Review, 5WMF-deploy-2015-05-06_(1.26wmf5): Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1258553 (10Jdforrester-WMF) [20:21:57] 6Multimedia, 10MediaWiki-extensions-ImageMap, 5Patch-For-Review: Convert ImageMap to use extension registration - https://phabricator.wikimedia.org/T87929#1258617 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [20:22:00] 6Multimedia, 10MediaWiki-extensions-ImageMap, 5WMF-deploy-2015-05-06_(1.26wmf5): Convert ImageMap to use extension registration - https://phabricator.wikimedia.org/T87929#1258622 (10Jdforrester-WMF) [20:59:55] marktraceur: tgr: I assume you're both available for me to nominate you as reviewers, right? [20:59:55] as in yearly review reviewers, not gerrit reviewers... [21:14:23] There's basically no option there. :) [21:41:46] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6operations: Support VP9 in TMH (Unable to decode) - https://phabricator.wikimedia.org/T55863#1258898 (10Multichill) Someone uploaded this really nice video at https://commons.wikimedia.org/wiki/File:Snowdonia_by_drone.webm . Transcoding failed: ``` '/u...