[00:22:58] 3MediaWiki-Uploading, Multimedia: media namespace backlinks not purged on file upload - https://phabricator.wikimedia.org/T68527#1048612 (10nevermind85) We can reproduce this with Mediawiki 1.23.8. [00:35:18] (03CR) 10Gergő Tisza: [C: 031] "+2. I'll wait for the dependency just in case the format needs to be changed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190823 (https://phabricator.wikimedia.org/T89088) (owner: 10Gilles) [04:51:12] ...did the bots get really quiet or are they broken again [04:51:22] Oh, OK, -dev has messages. [06:27:50] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer footer overlaps bottom ~31 pixels of images - https://phabricator.wikimedia.org/T89935#1049046 (10kaldari) 3NEW [06:42:33] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Remove GetLocalURL::Internal hack from CommonsMetadata - https://phabricator.wikimedia.org/T89937#1049069 (10Tgr) 3NEW a:3Tgr [06:43:15] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Remove GetLocalURL::Internal hack from CommonsMetadata - https://phabricator.wikimedia.org/T89937#1049078 (10Tgr) [06:43:59] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Remove GetLocalURL::Internal hack from CommonsMetadata - https://phabricator.wikimedia.org/T89937#1049069 (10Tgr) [07:13:25] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer footer overlaps bottom ~31 pixels of images - https://phabricator.wikimedia.org/T89935#1049109 (10Tgr) [07:13:26] 3§Multimedia-Sprint-2015-02-18, Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer crops bottom of images - https://phabricator.wikimedia.org/T89631#1049110 (10Tgr) [07:23:38] (03PS1) 10Gergő Tisza: Fix canvas height calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191545 (https://phabricator.wikimedia.org/T89631) [07:23:57] oh my >.> [07:24:02] hacks on hacks [08:28:47] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1049182 (10Gilles) That works, thanks. I think that the issue is what I expected: OS X's mime detection thinks this is a text file. Linux's mime detection probably does the same.... [08:30:15] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1049191 (10Gilles) So I think that it's smaller bug than expected. Extension-less images that are correctly mime-detected (which would be the vast majority) seem to work fine in UW. [08:30:23] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1049194 (10Gilles) p:5Triage>3Low [08:52:10] (03CR) 10Gilles: [C: 032] Fix canvas height calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191545 (https://phabricator.wikimedia.org/T89631) (owner: 10Gergő Tisza) [08:53:03] (03Merged) 10jenkins-bot: Fix canvas height calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191545 (https://phabricator.wikimedia.org/T89631) (owner: 10Gergő Tisza) [12:59:44] (03PS1) 10Ebrahim: i18n: Native digits for parts of TimedMedia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/191586 [13:33:36] 3§Multimedia-Sprint-2015-02-18, MediaWiki-extensions-UploadWizard, Multimedia: Browser tests no longer work on Chrome - https://phabricator.wikimedia.org/T86770#1049661 (10Gilles) a:3Gilles [13:40:15] (03CR) 10Ebrahim: "I don't know if getLanguage is available on $this." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/191586 (owner: 10Ebrahim) [16:07:04] Coffee for breakfast. *yawn* [16:26:31] ChromeDriver is plotting to kill us [16:27:39] What else is new [16:28:26] there are 3 mysterious sleeps I can't get rid of, the describe page one is the most wtf [16:28:34] the one you or chrismcmahonput in [16:28:54] for several seconds before the test is entering data on the page [16:29:07] the next button is there, if it's visible it means that its handler is active, as per the UW code [16:29:19] gi11es: I'm in a meeting right now, but do you see an error? [16:29:24] yet if you don't take a breath with a sleep for a minimum of 0.5 seconds, the driver swallows the click [16:30:03] chrismcmahon: actually I have a question for you, is it possible to break and open the browser's debugger from the cucumber test? [16:30:16] that seems like a pie-in-the-sky feature, but who knows... [16:30:24] That would be *so nice* [16:30:52] the main painful thing I'm dealing with is the inability to stop the JS execution to figure this out [16:30:57] gi11es: set an environment variable 'KEEP_BROWSER_OPEN=true", then alter the test to end or sleep at the step you want to stop at. browser controls will be available [16:31:01] gi11es: Maybe because of the validation method? [16:31:14] It might hide the "next" button while it validates on a blur event or something [16:31:19] Which is stupid but you never know [16:31:28] chrismcmahon: right, but the JS execution doesn't stop [16:31:58] I should try just running the "debugger;" JS command from cucumber to see what happens [16:32:21] marktraceur: hide or disable? [16:32:29] gi11es: try it and let us know what happens on the QA mail list... [16:32:42] right on, the hunt continues [16:33:34] gi11es: One or the other, either would stop the test from completing probably [16:37:53] I'll poke at this in about an hour [16:39:43] fyi debugger; doesn't work because the inspector needs to be open in the first place [16:41:16] apparently poltergeist supports something like that http://mscottford.com/post/30910962407/getting-spooky-remote-debugging-with-poltergeist [16:41:25] but I can't find the same feature for ChromeDriver [16:47:19] gi11es: #selenium on freenode is often helpful also [16:49:06] ok, I think I have definite proof that it's ChromeDriver being crazy. if I modify the code to trigger the click from JS (to itself, basically) at the exact point where the test should stop waiting (appearance of a specific element) [16:49:11] the checbox is ticked [16:49:24] with the test, the click doesn't tick the checkbox [16:49:45] sleep for half a second at the beginning of the step and the issue goes away [16:51:30] there's no ajax happening in the background, since waiting for ajax at the beginning of the step doesn't fix the issue [16:52:06] it might be a different problem for the describe page as marktraceur saif, but for the tutorial page there's really not much going on [16:52:08] said [16:52:31] anyway, seems like we're stuck with a few sleeps for now [16:53:05] I'll try running the tests in phantomjs to see if it's also affected [16:53:23] if I don't have a zillion things to fix before they work in phantomjs, that is... [17:36:01] gi11es: when you see the problem with the Next button, do you get the error "...Element is not clickable..."? or something else? [17:36:03] phantomjs isn't affected (too slow?) except for the describe page one, there's probably no point pursuing the poltergeist debug mode [17:36:16] chrismcmahon: no error, the click just does nothing [17:36:30] now I have the right prerequisites before trying to click [17:36:42] I know the click handler is initialised and everything [17:36:49] the driver just seems to eat the click [17:37:01] I'll commit what I have in a sec, so you can take a look [17:38:44] (03PS1) 10Gilles: Fix browser tests in Chrome [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191645 (https://phabricator.wikimedia.org/T86770) [17:38:56] in current master I am getting "Element is not clickable" for I click Next button at Release rights page, which is a z-axis thing, ChromeDriver thinks that
is "on top" of the Next button [17:39:08] right, I managed to get rid of that [17:39:13] by waiting for the right thing first [17:39:56] OK [17:40:03] been there done that [17:40:34] the remaining issue is on another level of mysteriousness [17:41:08] let me know when that is in gerrit, I will poke at it [17:41:27] trying to reproduce the tests's behaviour in UW's JS directly (basically click on the element ASAP after the condition the test is waiting for is true) doesn't trigger the problem [17:41:37] and presumably chrome runs as fast as the chrome running through chromedriver [17:42:02] so I doubt it's a timing issue with the code itself, especially seeing how things are set up, the click handlers are added way before the elements are visible [17:42:14] chrismcmahon: it's the link above that grrrit-wm just wrote [17:42:38] and regardless of click handlers, even the native ticking of the checkbox doesn't happen [17:44:11] the describe page one *might* be different since I can reproduce it in phantomjs as well, the real mystery is "I click the Skip checkbox" [17:45:14] if the click was landing on another element, cucumber would whine as usual [17:45:39] I'll try the last thing I haven't yet, clicking through a JS snippet [17:48:13] gi11es: The release rights page one was because it didn't wait for the "own work" radio button, right? [17:48:23] I was going to fix that and maybe forgot to submit a patch for it. [17:48:36] I've fixed so many, I can't remember, let me check [17:49:10] I missed that, so there's a sleep on that one too [17:49:23] weird. review/gilles/T86770 upload_wizard.feature is green for me in Chrome [17:49:31] we can add the waiting condition [17:49:36] running again [17:49:53] chrismcmahon: it would be, you need to remove the sleeps to trigger the issue [17:49:57] oh, because sleep [17:50:26] remove the sleep from on line 56 of steps.rb and run the feature starting at :28 [17:51:18] to see the issue fully add a pause of something kind right after line 58 (the check_tutorial_skip) [17:51:25] look in the browser, the element isn't checked [17:51:47] it's the tickbox at the bottom, below the dead image [17:53:35] oops, I committed the thing that auto-clicks the item in JS [17:53:44] let me remove that quickly [17:54:20] wouldn't matter if you were targetting beta [17:55:03] (03PS2) 10Gilles: Fix browser tests in Chrome [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191645 (https://phabricator.wikimedia.org/T86770) [17:56:26] hah, I really didn't expect that, it seems like clicking through JS works [17:56:36] an alternative horrible hack is born [17:57:20] it'll be a good way to check if the release rights and describe pages sleeps are of the same nature [17:59:25] (03PS3) 10Gilles: Fix browser tests in Chrome [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191645 (https://phabricator.wikimedia.org/T86770) [17:59:30] ^ version with JS clicking for the checkbox step [18:05:32] I guess it's possible that the driver tries to click while it's reflowing, thinks it hit the right element but actually didn't and hit some blank space next to it [18:05:39] but that would be a bug in the driver [18:07:08] Chrome is doing something to the button http://imgur.com/gca5uC2 [18:07:19] yep, it's highlighting it [18:07:22] I spotted that [18:07:24] I wonder if the driver is confused because it is a span inside of a button [18:07:27] but not quite clicking it [18:07:45] doesn't explain the checkbox doing nothing [18:07:50] it's just a plain checkbox [18:10:49] (03PS4) 10Gilles: Fix browser tests in Chrome [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191645 (https://phabricator.wikimedia.org/T86770) [18:10:57] here's a new update, with the same hack working on another of the sleeps. I'll look at the remaining 2 in a few hours, gotta go for now [18:11:40] by the way, do we have something like that available? https://github.com/mattheworiordan/capybara-screenshot [18:11:54] would be interesting to capture a screenshot of the state right when it would have clicked [18:12:09] just to confirm that it doesn't need to reflow at that point [18:13:56] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050304 (10Anomie) 3NEW [18:15:02] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050319 (10Anomie) [18:15:03] 3MediaWiki-API, Multimedia: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#972595 (10Anomie) [18:15:03] we do, one sec... [18:16:24] 3MediaWiki-Uploading, MediaWiki-API, Multimedia: Set user when uploading StashFile - https://phabricator.wikimedia.org/T36954#1050322 (10Anomie) There's some sort of weird dependency on ApiQueryImageInfo going on here, so see also T89971. [18:18:11] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb line 139 and on [18:22:20] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050359 (10brion) Plans sound good to me. :D [18:38:11] Well this is fucking impossible [18:38:14] There's no other way to say it [18:38:37] cancelPositionTracking gets called before every addition of a stopTracking function, and yet somehow, they slip through [18:47:52] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050501 (10Anomie) [18:49:38] The best way to fix this may be to move the new upload handler around [18:49:43] I will...postpone that [18:54:52] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050542 (10Anomie) [18:55:34] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050304 (10Anomie) [19:09:14] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1050632 (10Aklapper) [19:20:14] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: "Error, running transcode job, for job that has already started" notices - https://phabricator.wikimedia.org/T89977#1050698 (10Bawolff) [19:32:44] 3MediaWiki-extensions-GWToolset, Multimedia, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1050759 (10Bawolff) I can't reproduce this (locally using the username Léna, and on beta commons using username Léna2). For example, I successfully uploaded http://com... [19:37:39] Here's hoping this new browser test works... [19:58:44] chrismcmalunch: I've figure it out. it's definitely a chrome webdriver bug/quirk [19:58:47] *figured [20:00:05] it only happens when the item you want to be clicked happens to be out of view at first because the page is taller than the browser window [20:00:18] (03PS4) 10MarkTraceur: WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [20:00:19] I've verified this by manually changing the height of the tutorial window [20:00:20] Blam [20:00:22] (03CR) 10jenkins-bot: [V: 04-1] WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) (owner: 10MarkTraceur) [20:00:24] Damn it [20:00:32] tutorial image, sorry [20:01:26] I believe that the drivers needs a bit of time to scroll to the element, or to assess the page's height or something like that [20:01:41] there's some race condition in the driver for this situation [20:02:01] and that's why the next button is affected on a variety of pages: it's way at the bottom [20:03:21] I bet that if we made the browser window for chrome extra tall on the integration server, the tests would pass without any trick [20:06:44] (03PS5) 10MarkTraceur: WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [20:07:30] (03CR) 10jenkins-bot: [V: 04-1] WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) (owner: 10MarkTraceur) [20:07:33] sadly doing scroll_into_view on the element doesn't seem to be a functioning workaround [20:07:47] on the screenshot the browser isn't scrolled yet after that call [20:08:22] so yeah, JS click seems like the way to go for that particular pickle :( [20:14:47] (03PS6) 10MarkTraceur: Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [20:15:05] marktraceur: FYI https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080899.html [20:15:11] gi11es: that does sound like a ChromeDriver glitch, at least with the UW pages. As I understand it, Selenium itself is required to do scrollIntoView for each element located [20:15:12] marktraceur: No real-world breaking changes. [20:19:02] James_F: Thank you! [21:00:50] 3MediaWiki-API, Multimedia: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1051185 (10Anomie) [21:17:11] (03PS3) 10TheDJ: Fix an undeclared and RL dependency [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/173538 [21:17:33] (03CR) 10jenkins-bot: [V: 04-1] Fix an undeclared and RL dependency [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/173538 (owner: 10TheDJ) [21:23:14] (03PS6) 10TheDJ: [WIP] Improve live loading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://bugzilla.wikimedia.org/72675) [21:28:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Improve live loading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://bugzilla.wikimedia.org/72675) (owner: 10TheDJ) [21:30:40] 3Structured-Multimedia-Data, Multimedia: Convert Template:Authority_control to LUA and use Wikidata - https://phabricator.wikimedia.org/T89598#1051274 (10Jheald) It's not in Lua, but there's some work to push data from arbitrary-access wikidata through the existing Authority Control template at https://www.wikid... [21:32:36] 3Multimedia: Enable Flickr import for all users on Commons - https://phabricator.wikimedia.org/T90004#1051277 (10MarkTraceur) 3NEW [21:33:39] (03CR) 10TheDJ: [C: 04-1] "Like Ib2bad1f0c35a13b72bda538c5ceb849fb65853af, this uses mw.addDialog, so it should depend on the mw.MwEmbedSupport which has a mw.load w" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff) [21:35:06] (03CR) 10TheDJ: "or was the intent to 'preload' the module ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff) [21:36:54] 3Wikimedia-Hackathon-2015, Multimedia: Enable Flickr import for all users on Commons - https://phabricator.wikimedia.org/T90004#1051345 (10MarkTraceur) [21:39:27] 3Structured-Multimedia-Data, Multimedia: Convert Template:Creator to LUA and use Wikidata - https://phabricator.wikimedia.org/T89597#1051350 (10Jheald) It's not in Lua, but some work towards pushing data from wikidata through the existing Creator template can be found at https://www.wikidata.org/wiki/Template:Cr... [21:40:11] 3Structured-Multimedia-Data, Multimedia: Template:Institution to LUA and use Wikidata - https://phabricator.wikimedia.org/T89599#1051358 (10Jheald) It's not in Lua, but some work towards pushing data from wikidata through the existing Institution template can be found at https://www.wikidata.org/wiki/Template:In... [21:56:40] (03CR) 10TheDJ: "Seems duplicate with https://gerrit.wikimedia.org/r/#/c/97999" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/191586 (owner: 10Ebrahim) [22:16:51] gi11es: re debugging, I usually just put in sleep 20 in the step definition and use it to open the debugger and look around [22:17:41] you can probably set up breakpoints then and have another sleep after the intercepted command to make sure watir does not time out [22:18:26] also you can probably use a ruby debugger to go through the test step by step and mess around in the browser [22:18:52] I used to do that when I used php+selenium, worked nice [22:20:04] also selenium has an option to use an existing browser profile so you can install Firebug and whatnot [22:20:16] not sure if that's possible with watir [23:31:32] (03PS2) 10Gergő Tisza: Remove delay when logging link clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190705 (https://phabricator.wikimedia.org/T89533) [23:31:34] (03PS1) 10Gergő Tisza: Make logging less noisy in debug mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191810 [23:32:07] (03CR) 10Gergő Tisza: "No reason beyond laziness. Re-did properly." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190705 (https://phabricator.wikimedia.org/T89533) (owner: 10Gergő Tisza) [23:32:27] (03CR) 10jenkins-bot: [V: 04-1] Remove delay when logging link clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190705 (https://phabricator.wikimedia.org/T89533) (owner: 10Gergő Tisza) [23:32:33] (03CR) 10jenkins-bot: [V: 04-1] Make logging less noisy in debug mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191810 (owner: 10Gergő Tisza) [23:37:42] (03PS2) 10Gergő Tisza: Make logging less noisy in debug mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191810 [23:37:44] (03PS3) 10Gergő Tisza: Remove delay when logging link clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190705 (https://phabricator.wikimedia.org/T89533) [23:38:22] (03CR) 10jenkins-bot: [V: 04-1] Make logging less noisy in debug mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191810 (owner: 10Gergő Tisza) [23:50:19] (03PS3) 10Gergő Tisza: Make logging less noisy in debug mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/191810