[00:01:04] 3Multimedia, MediaWiki-extensions-UploadWizard: "Uncaught TypeError: Cannot read property 'mozilla' of undefined" makes UW unusable - https://phabricator.wikimedia.org/T89330#1035715 (10Jasonblewis) 5Open>3Resolved a:3Jasonblewis i must have failed to update git correctly, your instructions fixed it. Thanks. [01:03:39] tgr: Aaron said he'd put reviewing your core patch for the metadata stuff next on his list. He was working on some patches of his own that he didn't want to stop in the middle of today. If it's not reviewed by Tuesday poke me. I'll try to remember too. [01:36:26] bd808: thanks! [09:15:16] 3Multimedia: Deal with minified scripts in JS error logging - https://phabricator.wikimedia.org/T520#1036238 (10Krinkle) Large web apps in JavaScript don't allow for an interconnected IDE. True debugging in an editor therefore doesn't exist. One can tie an editor to V8's remote debugging and tie that to an edito... [10:35:28] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Reduce EL consumption - https://phabricator.wikimedia.org/T89150#1036346 (10Gilles) @nuria the rate of MediaViewer events is now down to an average of 12 events/sec over the last 10 hours. Do you want me to cut it down more? I'm not sure what we should be aimin... [10:55:54] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Clicking the image closes the download menu" browser test failing on IE - https://phabricator.wikimedia.org/T89087#1036351 (10Gilles) This wasn't sufficient, the issue turns out to be that in IE the test will have the image click land on the download dialog, w... [11:04:21] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download options drop-down broken on beta - https://phabricator.wikimedia.org/T89444#1036354 (10Gilles) 3NEW [11:19:07] (03PS1) 10Gilles: Click in the top-left corner of the image when trying to close the download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190430 (https://phabricator.wikimedia.org/T89087) [11:19:58] (03CR) 10jenkins-bot: [V: 04-1] Click in the top-left corner of the image when trying to close the download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190430 (https://phabricator.wikimedia.org/T89087) (owner: 10Gilles) [11:22:04] (03PS2) 10Gilles: Click in the top-left corner of the image when trying to close the download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190430 (https://phabricator.wikimedia.org/T89087) [11:52:57] (03PS1) 10Gilles: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) [11:53:37] (03CR) 10jenkins-bot: [V: 04-1] Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [11:53:45] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download options drop-down broken on beta - https://phabricator.wikimedia.org/T89444#1036412 (10Gilles) a:3Gilles [11:58:59] (03PS2) 10Gilles: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) [12:11:06] (03CR) 10Gilles: "OK, so the plan is to run this for a little bit, then revert the code? Isn't it making an assumption about the fact that we're going to se" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182766 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [12:18:04] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1036427 (10Gilles) @hashar should we be doing the same as https://gerrit.wikimedia.org/r/#/c/188115/1/ZeroPortal.php,unified for TMH fo... [12:19:26] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1036431 (10Gilles) p:5Triage>3High [12:20:13] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1018966 (10Gilles) Making this high priority since all TMH changesets are blocked on this. [13:06:50] (03CR) 10Krinkle: Measure CORS script loading support (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182766 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [14:00:11] 3Multimedia, MediaWiki-API: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#1036611 (10Tpt) It looks like it is not specific to the Imageinfo API. Some files seem to be affected on Commons. Example: https://commons.wikimedia.org/wiki/File:Dictionary_of_Gr... [14:59:49] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Reduce EL consumption - https://phabricator.wikimedia.org/T89150#1036704 (10Nuria) Puf that is pretty great, THANKS again for your fast response. [15:40:46] tgr|away: Did your conversation about defeating duplication in the uw browser tests go anywhere (with chrismcmahonbrb)? [15:43:03] Also, is anyone else seeing a missing "next" button at the deed step? [15:44:40] Like, half the time. [15:46:08] Maybe more than that [15:50:33] marktraceur: tgr|away and marxarelli and I chatted a bit late yesterday. We didn't get all that far, though. [15:51:22] marktraceur: the existing tests have been pretty stable for ~2 years. there is some cruft in there, but not much. I'm kind of inclined to not fix it if it ain't broke. [15:53:51] marktraceur: also, as I understand you are discussing making each step in the upload process a unique page. Doing that would be a good opportunity re-design the tests as you re-design the UI. [15:55:24] Yeah, that's the plan I think [15:58:48] * marktraceur adds moar sleep 1 [15:59:03] chrismcmahon: I'm just sitting here wondering how someone talked me into writing Ruby [16:01:14] marktraceur: the goal is to provide such high-level abstraction to test creators that the fact that it's Ruby underneath is nearly invisible [16:03:16] marktraceur: we should talk like maybe on a hangout sometime about the details and design principles. IRC is a bit low-bandwidth [16:04:25] Maybe [16:08:19] chrismcmahon: Is there perhaps a document about it on mw.org? :D [16:09:18] marktraceur: I wrote something I think would be useful, one moment while I find it... [16:11:14] chrismcmahon: In other more nitty-gritty news, do you know if there's a special trick to getting the value of a textarea in watir? [16:11:32] marktraceur: it can be done pretty easily. [16:11:37] marktraceur: I'm in a meeting now [16:11:57] Right now I'm doing div.textarea(xpath: './/textarea[@class="mwe-upwiz-desc-lang-text mwe-grow-textarea"]').value which is apparently giving me ''; whenever you're done with your meeting is fine :) [16:12:03] marktraceur: a couple of links to think over: https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Refactoring_2014 https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Guidelines_and_good_practices [16:12:31] also perhaps https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Writing_tests [16:12:52] 'kay, thanks :) [17:31:29] marktraceur: all .rb files are shared by all tests so any logic you put there can be reused without duplication [17:31:47] Oh, cool. [17:32:25] also, marxarelli pointed me at https://doc.wikimedia.org/rubygems/mediawiki-selenium/index.html which is a pretty thorough collection of documentation [17:34:47] tgr: yes, once a "step" exists it can be called from any Scenario. also, there are a number of steps shared across repos: https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Shared_features [18:33:34] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#1037188 (10polybuildr) 5Open>3Resolved [18:36:01] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#1037194 (10polybuildr) [18:59:07] 3MediaWiki-Uploading, Multimedia: URL input should be enabled on click and option should be toggled to upload by url - https://phabricator.wikimedia.org/T70778#1037271 (10Rillke) a:3Rillke [19:02:49] 3Wikimedia-Media-storage, Multimedia: Several versions uploaded but only one record in history - https://phabricator.wikimedia.org/T67339#1037295 (10Rillke) 5Open>3stalled [19:11:23] 3MediaWiki-Uploading, Multimedia: [REGRESSION] i18n fallback uses message from i18n file before message from db. - https://phabricator.wikimedia.org/T57473#1037355 (10Rillke) [[ https://commons.wikimedia.org/wiki/Commons:Administrators%27_noticeboard#User_contributions_footer | The user contributions footer ]] a... [19:12:42] 3MediaWiki-Uploading, Multimedia: [[Special:Upload]] should not offer "Submit modified file description" when duplicate files (by SHA1) are encountered - https://phabricator.wikimedia.org/T56704#1037365 (10Rillke) a:3Rillke Claiming tasks I am possibly interested in fixing. [19:13:26] 3Multimedia, MediaWiki-extensions-UploadWizard: Revision history of campaign pages is lacking title - https://phabricator.wikimedia.org/T56012#1037370 (10Rillke) a:3Rillke Claiming tasks I am possibly interested in fixing. [19:22:30] 3Multimedia, MediaWiki-File-management: Deleting files and redirects leaves stuff behind - https://phabricator.wikimedia.org/T50978#1037390 (10Rillke) 5Open>3stalled [19:26:40] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#1037406 (10polybuildr) @Tgr, I'm slightly confused about the restructuring of these classes. `UploadStashFile` has a comment that says "Arguably UnregisteredLocalFile should be handling its own... [19:30:47] 3Multimedia, MediaWiki-extensions-UploadWizard: [performance] Interval not cleared: 2 Intervals per file - https://phabricator.wikimedia.org/T39997#1037412 (10Rillke) still an issue; timeouts must not be used for adjusting positions; use resize events or/and mutation observers [19:32:18] 3Multimedia, MediaWiki-extensions-UploadWizard: [performance] Interval not cleared: 2 Intervals per file - https://phabricator.wikimedia.org/T39997#1037413 (10Rillke) [19:51:40] * marktraceur waves from a coffee shop with subbu [19:54:15] chrismcmalunch: Did you have advice about getting a textarea's value? [20:03:57] chrismcmalunch: I can't find anything obvious in the documentation tgr|away linked to... [20:11:52] a textarea's value? A DOM textarea? [20:13:05] rillke: Yeah, in cucumber [20:13:06] Or watir [20:13:10] Or webdriver [20:13:20] Or whichever of the fifteen thousand libraries we use for browser tests [20:13:31] I keep getting an empty value even though there's text in it [20:16:00] http://stackoverflow.com/questions/7452548/how-to-retrieve-textarea-value-in-ruby-cucumber-unit-testing-tool suggests there must be something like a value property [20:16:12] That's what gives me '' [20:16:45] Maybe I need to defocus it? [20:16:48] BTW, why is all this browser test stuff written in languages like ruby? [20:16:52] rillke: Who knows [20:17:29] I mean JavaScript would be so fine since that's what we use from inside the browser [20:18:59] rillke: I think they're going for ease of writing tests, and they found this nice library for Ruby, and decided it wasn't good in other languages (just a rough guess) [20:19:36] marktraceur, is there a method/property to get the .textContent ? [20:19:46] I...will check [20:19:51] I doubt it, but I could be wrong [20:21:50] Argh, where was that documentation [20:26:47] marktraceur: lemmee look, couple minutes... [20:26:57] I am 90% sure it can be done pretty easily [20:27:04] I found the .text method, but it doesn't think there's text either [20:27:07] Maybe I'm wrong... [20:27:38] Maybe there actually isn't text [20:27:44] Maybe I've been dead this whole time [20:27:46] rillke, marktraceur: i believe you would do `some_element.value` to get the text area value/text-node content [20:28:22] marxarelli: That's what I thought, but it didn't work [20:28:43] hmm... try `some_element.when_present.value` [20:28:54] It's definitely loaded, but I'll try [20:29:05] that will essentially do another poll with selenium [20:29:06] Aha [20:29:15] Never mind, .value worked when I used the right .should call [20:29:19] i've run into that problem before [20:29:32] oh, good [20:29:38] Sorry for the noise :) [20:30:21] i really want to add a "common patterns" section to https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Writing_tests [20:33:33] OK, this test step is super broken [20:38:01] (03PS1) 10Cmcmahon: DO NOT MERGE DEMO ONLY [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190507 [20:38:36] :) [20:38:48] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE DEMO ONLY [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190507 (owner: 10Cmcmahon) [20:38:51] marktraceur: https://gerrit.wikimedia.org/r/#/c/190507 [20:39:05] I see that [20:39:10] I got it sorted actually chrismcmahon [20:39:18] I'll push the patch soon, needed to iron out a few things [20:40:10] marxarelli: ^^ https://gerrit.wikimedia.org/r/#/c/190507 [20:49:55] Sha blam [20:49:55] (03PS1) 10MarkTraceur: Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [20:50:30] (03CR) 10jenkins-bot: [V: 04-1] Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) (owner: 10MarkTraceur) [20:50:35] Dick [20:51:32] chrismcmahon: What on earth does "method has too many lines" mean [20:51:57] marktraceur: it's our style guide linter. it thinks your method is too long [20:52:04] Buh wuh huh [20:52:12] It's a case switch [20:52:18] What am I supposed to do about that [20:52:31] dunno. can I see the code somewhere? [20:52:41] chrismcmahon: https://gerrit.wikimedia.org/r/190511 describe_page.rb [20:52:45] Line 41 [20:53:12] I shouldn't split that up, I think [20:53:37] Maybe replace each call to div with a method call, and put the query in that method [20:53:42] That'll bring it down to ten [20:54:59] (03PS2) 10MarkTraceur: Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [20:55:10] marktraceur: if it were me, I would not use case at all, just make each locator its own element. simpler that way. also, css is a lot nicer than xpath [20:55:25] chrismcmahon: I was copying something in that file I think [20:55:30] Or in the upload step file [20:55:40] But it works now! [20:55:48] Don't fix it :) [20:58:07] OK [20:59:07] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037649 (10Jdforrester-WMF) 3NEW [20:59:16] marktraceur: I might spike a refactor of it later :-) it's a nice test the way it's written [20:59:17] * James_F beams at marktraceur. [20:59:30] but the steps are a little funky [20:59:55] chrismcmahon: Yeah, I was mostly interested in getting it working, my ability to make Ruby look nice is basically nil-adjacent [21:00:13] (get it? nil? it's a Ruby joke) [21:00:24] marktraceur: yeah, it's a matter mostly of trusting the framework. comes with just a little practice [21:00:36] Knowing and trusting, I guess [21:00:38] browser testing is weird [21:00:41] +1 [21:02:52] James_F: https://gerrit.wikimedia.org/r/190433 where's my ooui-announce list!?!?!?! [21:03:38] marktraceur: https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080736.html [21:03:49] (03CR) 10MarkTraceur: [C: 04-1] "I agree with MatmaRex, I bet his solution will be less fragile in the future too." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:03:58] Thanks James_F. [21:04:03] marktraceur: Though that didn't cover it, because you were relying on internal details of the implementation. [21:04:15] marktraceur: Which aren't part of the API and so can break at any time without notice. :-( [21:04:18] Yeah [21:04:26] Hence the shiny new -1 [21:04:38] * James_F nods. [21:05:08] Is that C-1-and-I-will-follow-up-with-a-patchset-that-fixes? ;-) [21:05:36] (03CR) 10MarkTraceur: [C: 032] Bring back needed getJsonData functionality into Campaign class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189704 (https://phabricator.wikimedia.org/T89239) (owner: 10Gilles) [21:05:46] Hm...I bet gi11es is asleep [21:06:02] If you fix it I'll +2. [21:06:06] James_F: Is that is-that-C-1-and-I-will-follow-up-with-a-patchset-that-fixes-and-James-will-merge...oh perfect [21:06:22] * James_F grins. [21:06:42] marktraceur: Also, observe the magic that is cscott: https://gerrit.wikimedia.org/r/190368 [21:06:54] marktraceur: Actual real rennervation. [21:08:06] (03Merged) 10jenkins-bot: Bring back needed getJsonData functionality into Campaign class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189704 (https://phabricator.wikimedia.org/T89239) (owner: 10Gilles) [21:09:03] Just add water! [21:09:09] (03PS3) 10MarkTraceur: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:09:15] James_F: All you bro [21:09:53] (03CR) 10jenkins-bot: [V: 04-1] Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:10:03] (03PS3) 10Chad: ID3: Protect against playtime_seconds and bitrate being undefined [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/190248 [21:10:06] marktraceur: Rightbackatcha. [21:10:10] Bollocks [21:10:18] Rebase? [21:10:24] Ooh, even worse. [21:10:26] (03CR) 10jenkins-bot: [V: 04-1] ID3: Protect against playtime_seconds and bitrate being undefined [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/190248 (owner: 10Chad) [21:10:34] 21:09:50 >> mmv.ui.download.pane - attach()/unattach(): [21:10:35] 21:09:50 >> Message: Expected 2 assertions, but 1 were run [21:10:35] 21:09:50 >> Actual: null [21:10:36] 21:09:50 >> Expected: undefined [21:10:56] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037700 (10TheDJ) although a worthy goal to use oojs-ui, i'd say cleanup TMH itself first :) [21:12:01] Oh, because we depended on the implementation details in the test too [21:12:04] STUPID. [21:14:13] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037705 (10Jdforrester-WMF) >>! In T89496#1037700, @TheDJ wrote: > although a worthy goal to use oojs-ui, i'd say cleanup TMH itself first :) From IRC, select... [21:15:51] (03PS4) 10MarkTraceur: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:15:56] Try that on fer size [21:16:30] (03CR) 10jenkins-bot: [V: 04-1] Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:16:34] H. [21:16:35] +a [21:17:21] rrrrg [21:17:21] (03Abandoned) 10Cmcmahon: DO NOT MERGE DEMO ONLY [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190507 (owner: 10Cmcmahon) [21:18:09] (03PS5) 10MarkTraceur: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:18:18] James_F: Don't worry, it's only because I'm incompetent and forgetful [21:18:23] * James_F grins. [21:18:50] (03CR) 10jenkins-bot: [V: 04-1] Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:19:03] * marktraceur sighs [21:20:43] marktraceur: Maybe run the tests before committing? ;-) [21:21:05] (03PS6) 10MarkTraceur: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:21:07] Yeah, I did this time [21:21:16] If it fails again, it's not my fault [21:21:29] * James_F grins. [21:21:55] James_F: +2 from Jenkins [21:22:02] I will be right back. [21:22:15] marktraceur: Did you want me to +1 your changes so you could +2 the overall patch (Gi11es's work), or for me to just +2? [21:24:03] (03CR) 10Jforrester: [C: 031] "Mark should probably be the one to C+2 as it's more his repo than mine; this LGTM." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:24:09] * James_F picks the former. [21:35:49] 3Multimedia, MediaWiki-extensions-UploadWizard: Special:UploadWizard gives undescriptive error message upon too long filename - https://phabricator.wikimedia.org/T87314#1037732 (10Sn1per) p:5Triage>3Low [21:36:01] (03CR) 10MarkTraceur: [C: 032] "Okieeee" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:36:38] (03Merged) 10jenkins-bot: Adapt to OOUI change in dropdown widget [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190433 (https://phabricator.wikimedia.org/T89444) (owner: 10Gilles) [21:37:03] * marktraceur waits five minutes [21:37:26] 3operations, MediaWiki-extensions-GWToolset, Multimedia: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1037743 (10Dzahn) p:5Triage>3Normal [21:40:47] Whoa, it's ten minutes now [21:40:49] Whaaaat [21:43:09] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download size select control is busted, does not open - https://phabricator.wikimedia.org/T89500#1037800 (10Cmcmahon) 3NEW [21:43:25] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download size select control is busted, does not open - https://phabricator.wikimedia.org/T89500#1037808 (10Cmcmahon) [21:43:50] chrismcmahon: We just fixed that, waiting on beta-code-update [21:44:00] marktraceur: OK [21:44:22] I'm all like 'gotta fix the test... oh wait that's a bug..." [21:44:36] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download size select control is busted, does not open - https://phabricator.wikimedia.org/T89500#1037814 (10MarkTraceur) [21:44:37] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download options drop-down broken on beta - https://phabricator.wikimedia.org/T89444#1037815 (10MarkTraceur) [21:44:37] Heh [21:44:59] chrismcmahon: beta-scap is taking a while [21:45:43] https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/41578/console [21:45:52] marktraceur: Ick: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox#mediaviewer/File:Ophelia_-_Hybrid_Tea.jpg [21:46:23] James_F: What ick? [21:48:01] marktraceur: Sorry, the file cannot be displayed [21:48:03] Etc. [21:48:20] Oh. [21:48:32] James_F: Worked for me, probably it was the first time the file got thumbnailed [21:48:50] Hmm. [21:49:07] Not sure if beta has thumb.php 404 handling set up [21:50:13] chrismcmahon: I think https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/41578/ is stuck, do you have the ability to kick it? [21:50:19] marktraceur: Ah. [21:50:35] marktraceur: I dont' think so but I can complain [21:50:50] I can, just need to dig up my login info... [21:51:16] Or it's just the ldap login and that's easy [21:51:39] marktraceur: I can. [21:52:00] I killed it [21:52:08] Here's hoping things work [21:52:13] it wasn't stuck [21:52:18] It is now. :-) [21:52:19] https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/41578/console [21:52:39] greg-g: The previous build took less than 30 seconds, that one was stalled for 20 minutes [21:53:09] stalled is the wrong word for "updating l10n cache" [21:53:17] 21:47:20 21:47:20 Finished mw-update-l10n (duration: 11m 32s) [21:53:43] Ugh [21:53:53] none of that output log is wrong/indicating stuckness [21:54:14] Well it didn't die [21:54:34] (there's a reason I suggested the timeout for that job to be set to 45 minutes for times when l10n takes a really long time to regen) [21:54:53] it started again you mean [21:54:56] https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/ [21:55:00] Right [21:55:12] greg-g: I mean I didn't explodify anything by kicking it in the kidneys [21:55:26] Except maybe its kidneys [21:55:36] that's the best mixed metaphor I've read all day [21:55:39] right, and it's self-esteem [21:55:46] It's bad and it should feel bad [21:55:50] every keeps kicking it thinking it's broken when it's just doing everything you tell it to [21:55:56] everyone* [21:56:24] I only want it to sync the JS files! I didn't ask for l10n update! :P [21:56:26] (please don't kill it this time :) ) [21:56:31] marktraceur: too bad, welcome to scap [21:56:35] :) [21:56:43] I won't kill it again, I learned my lesson [21:57:45] Working again on beta! [21:58:11] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Download options drop-down broken on beta - https://phabricator.wikimedia.org/T89444#1037861 (10MarkTraceur) 5Open>3Resolved [21:59:24] greg-g: * its. [21:59:39] James_F: yes yes [21:59:42] * James_F grins. [21:59:46] :) [22:18:14] (03CR) 10MarkTraceur: "We did that and it broke links in descriptions entered in UploadWizard, e.g. [[:en:Minneapolis, Minnesota|Minneapolis]]" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/188823 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [22:18:29] (03CR) 10MarkTraceur: "That's why we had to revert the patch and do it this way instead" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/188823 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [22:32:18] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037956 (10Tgr) jQUI is ~200K minified/uncompressed, OOUI is 300K, so as long as OOUI is not included on every page this will actually increase the payload. I... [22:43:01] (03CR) 10MarkTraceur: [C: 032] Click in the top-left corner of the image when trying to close the download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190430 (https://phabricator.wikimedia.org/T89087) (owner: 10Gilles) [22:45:01] (03Merged) 10jenkins-bot: Click in the top-left corner of the image when trying to close the download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190430 (https://phabricator.wikimedia.org/T89087) (owner: 10Gilles) [23:11:52] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1038055 (10matmarex) >>! In T89496#1037705, @Jdforrester-WMF wrote: > ``` > ori: that's 300kb of javascript on barack obama for the media player http://i.imgur... [23:20:12] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1038083 (10Krinkle) [23:20:38] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1018966 (10Krinkle) Removing Jenkins association as it isn't related to the Jenkins service. [23:39:59] (03PS4) 10Gergő Tisza: Invalidate the metadata when the file page of a remote file changes [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188743 (https://phabricator.wikimedia.org/T86955) [23:40:29] (03CR) 10jenkins-bot: [V: 04-1] Invalidate the metadata when the file page of a remote file changes [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188743 (https://phabricator.wikimedia.org/T86955) (owner: 10Gergő Tisza)