[00:32:38] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1029620 (10Tgr) 5Open>3Resolved a:3Tgr Backported to wmf16; this should be fixed on Commons n... [00:35:13] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizard progress bar restarts for each chunk when doing chunked upload - https://phabricator.wikimedia.org/T89194#1029628 (10Tgr) 3NEW [00:36:55] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1029638 (10Tgr) [00:36:57] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizard progress bar restarts for each chunk when doing chunked upload - https://phabricator.wikimedia.org/T89194#1029637 (10Tgr) [00:36:58] 3Multimedia, MediaWiki-Uploading: Chunked upload (tracking) - https://phabricator.wikimedia.org/T61914#1029636 (10Tgr) [01:12:09] 3Multimedia, MediaWiki-extensions-UploadWizard: Chunked (>100MB) upload failed with "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T89197#1029669 (10Ijon) 3NEW [04:21:58] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1029890 (10BBlack) I pulled that log line from looking directly at /var/log/nginx/wikimedia.org.err... [06:56:49] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1030066 (10Krassotkin) In my opinion, progress bar still work incorrectly. It displays the download... [08:48:41] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1030142 (10Tgr) >>! In T89018#1030066, @Krassotkin wrote: > In my opinion, progress bar still work... [09:11:06] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1030174 (10akosiaris) @BBlack, I have a different theory regarding the nginx 1.1.x vs 1.6.x behavio... [09:15:14] (03CR) 10Gilles: [C: 04-1] "While this fix works, I see two issues:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/188823 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [09:23:08] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1030182 (10Gilles) @akosiaris that sounds consistent with what we've been experiencing when reprodu... [09:46:55] (03CR) 10Gilles: [C: 032] Refactor code to be more modular [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182762 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [09:49:54] (03Merged) 10jenkins-bot: Refactor code to be more modular [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182762 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [10:10:56] (03CR) 10Gilles: [C: 04-1] "I'm not a fan of this multi-purpose idea, for these reasons:" (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182766 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [10:52:00] (03CR) 10Gergő Tisza: "> This would be a whole lot cleaner if there was a separate CORSMetrics exension, extending the same JS library as ImageMetrics does and a" (031 comment) [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/182766 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [12:50:16] 3Multimedia, MediaWiki-File-management: "thumb.php" should not throw fatal MWException when missing query parameters - https://phabricator.wikimedia.org/T88508#1030691 (10Gilles) Fix confirmed: http://en.wikipedia.beta.wmflabs.org/w/thumb.php?f=Bust_orant_Louvre_AO17557_local.jpg&h=100 [12:54:56] 3Multimedia, operations: Errors when generating thumbnails should result in HTTP 400, not HTTP 500 - https://phabricator.wikimedia.org/T88412#1030703 (10Gilles) Should we also change the 500 happening when people request a larger (or equal) size than the original to a 400? [12:55:12] 3Multimedia, operations: Errors when generating thumbnails should result in HTTP 400, not HTTP 500 - https://phabricator.wikimedia.org/T88412#1030705 (10Gilles) p:5Triage>3Normal [12:58:21] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#1030724 (10Gilles) p:5High>3Normal [12:58:32] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#1030725 (10Gilles) a:5Gilles>3None [12:59:34] 3Multimedia, MediaWiki-extensions-UploadWizard: Make a real, bonafide Flickr UI class - https://phabricator.wikimedia.org/T88880#1030729 (10Gilles) Bumping this back to the cycle, there are already 2 high risk big refactoring changesets in the review pipeline, browser tests should be higher priority. [13:00:37] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizard progress bar restarts for each chunk when doing chunked upload - https://phabricator.wikimedia.org/T89194#1030734 (10Gilles) p:5Triage>3Normal [13:00:51] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizard progress bar restarts for each chunk when doing chunked upload - https://phabricator.wikimedia.org/T89194#1030736 (10Gilles) a:3MarkTraceur [13:02:29] 3Multimedia, MediaWiki-extensions-UploadWizard: Thumbnails in Upload Wizard do not always show - https://phabricator.wikimedia.org/T89170#1030742 (10Gilles) When the selected batch is over a certain size, a link is displayed for each one to make the thumbnail appear, instead of automatically displaying it right... [13:02:51] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizardFlowEvent schema violation - https://phabricator.wikimedia.org/T89167#1030743 (10Gilles) p:5Triage>3Normal [13:04:26] 3Multimedia, MediaWiki-extensions-UploadWizard: Thumbnails in Upload Wizard do not always show - https://phabricator.wikimedia.org/T89170#1030751 (10Gilles) Ah, I've just realized that this feature is partially broken at the moment. I'm pretty sure that's what you're running into. I'll merge the tasks. [13:04:51] 3Multimedia, MediaWiki-extensions-UploadWizard: Thumbnails in Upload Wizard do not always show - https://phabricator.wikimedia.org/T89170#1030752 (10Gilles) [13:04:52] 3Multimedia, MediaWiki-extensions-UploadWizard: "show thumbnail" option disappears once file is uploaded - https://phabricator.wikimedia.org/T89114#1027663 (10Gilles) [13:04:59] 3Multimedia, MediaWiki-extensions-UploadWizard: "show thumbnail" option disappears once file is uploaded - https://phabricator.wikimedia.org/T89114#1030755 (10Gilles) p:5Low>3High [13:05:11] 3Multimedia, MediaWiki-extensions-UploadWizard: "show thumbnail" option disappears once file is uploaded - https://phabricator.wikimedia.org/T89114#1030756 (10Gilles) a:3MarkTraceur [13:07:20] 3Multimedia, MediaWiki-extensions-UploadWizard: Chunked (>100MB) upload failed with "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T89197#1029669 (10Gilles) [13:07:21] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1030766 (10Gilles) [13:18:38] 3Multimedia, Analytics: Set up varnish 204 beacon endpoint for virtual image views - https://phabricator.wikimedia.org/T89088#1030789 (10Gilles) a:3Gilles [13:20:16] 3Multimedia, MediaWiki-Uploading: Warning: was not stored with SHA-1 metadata - https://phabricator.wikimedia.org/T76487#1030790 (10Gilles) 5Open>3Resolved Chaining is disabled for now, not worth pursuing this [13:20:32] 3Multimedia, MediaWiki-Uploading: Internal error: Could not determine if the copy succeeded. - https://phabricator.wikimedia.org/T45967#1030792 (10Gilles) a:5Gilles>3None [13:21:12] 3Multimedia, MediaWiki-extensions-UploadWizard: Upload Wizard broken on Commons beta - https://phabricator.wikimedia.org/T77861#1030793 (10Gilles) 5Open>3Resolved This was the permission issue (apache user) which has been fixed since. [13:21:50] 3Multimedia, MediaWiki-extensions-UploadWizard: Beta Cluster: "error while storing the file in the stash.' - https://phabricator.wikimedia.org/T75229#1030795 (10Gilles) a:5Gilles>3None [13:22:23] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1030796 (10Gilles) a:5Gilles>3None [13:22:30] 3Multimedia, MediaWiki-extensions-UploadWizard: Convert UploadWizard to use extension registration - https://phabricator.wikimedia.org/T87988#1030798 (10Gilles) a:5Gilles>3None [13:25:45] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Improve reliability of cucumber tests - https://phabricator.wikimedia.org/T87831#1030803 (10Gilles) [13:26:30] 3Multimedia, MediaWiki-extensions-CommonsMetadata: Ignore EXIF data in CommonsMetadata - https://phabricator.wikimedia.org/T73719#1030807 (10Gilles) a:3Tgr [13:26:58] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Record performance log hits regardless of ResourceTiming data contents - https://phabricator.wikimedia.org/T87877#1030808 (10Gilles) 5Open>3Resolved [13:27:08] 3Multimedia, MediaWiki-extensions-Sentry: Implement module wrapping for Sentry - https://phabricator.wikimedia.org/T78809#1030809 (10Gilles) 5Open>3Resolved [13:27:11] 3Multimedia, WMF-Legal: Set up and test Sentry on Labs for JS error logging - https://phabricator.wikimedia.org/T1345#1030810 (10Gilles) [13:27:12] 3Multimedia, MediaWiki-extensions-Sentry: Improve Sentry coverage - https://phabricator.wikimedia.org/T88399#1030811 (10Gilles) [13:27:18] 3Multimedia, MediaWiki-extensions-UploadWizard: Move deed-specific functions to the deeds step controller - https://phabricator.wikimedia.org/T86227#1030812 (10Gilles) 5Open>3Resolved [13:27:29] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Size of preview and real image does not match in MediaViewer - https://phabricator.wikimedia.org/T87295#1030814 (10Gilles) 5Open>3Resolved [13:27:31] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer image/screen sizing problems (tracking) - https://phabricator.wikimedia.org/T78211#1030815 (10Gilles) [13:27:39] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "VIew in browser" link in download panel overflows - https://phabricator.wikimedia.org/T87427#1030816 (10Gilles) 5Open>3Resolved [13:27:50] 3Multimedia, MediaWiki-File-management: "thumb.php" should not throw fatal MWException when missing query parameters - https://phabricator.wikimedia.org/T88508#1030817 (10Gilles) 5Open>3Resolved [13:27:59] 3Multimedia, MediaWiki-extensions-PagedTiffHandler: On top of file page is shown: bool(false) NULL - https://phabricator.wikimedia.org/T85651#1030820 (10Gilles) a:3Tgr [13:28:06] 3Multimedia, MediaWiki-extensions-PagedTiffHandler: On top of file page is shown: bool(false) NULL - https://phabricator.wikimedia.org/T85651#1030822 (10Gilles) 5Open>3Resolved [13:35:26] 3Multimedia, MediaWiki-extensions-UploadWizard: Creating upload campaigns is broken - https://phabricator.wikimedia.org/T89239#1030848 (10Gilles) 3NEW a:3Gilles [13:36:40] (03PS2) 10Gilles: Bring back needed getJsonData functionality into Campaign class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189704 (https://phabricator.wikimedia.org/T89239) [13:46:08] 3Multimedia, MediaWiki-File-management, Possible-Tech-Projects: Build an interwiki notifications framework and implement it for InstantCommons - https://phabricator.wikimedia.org/T48525#1030912 (10Qgil) Wikimedia will [[ https://phabricator.wikimedia.org/T921 | apply to Google Summer of Code and Outreachy ]] on... [13:46:26] 3Multimedia, Wikimedia-General-or-Unknown, Possible-Tech-Projects: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1030927 (10Qgil) Wikimedia will [[ https://phabricator.wikimedia.org/T921 | apply to Google Summer of Code and Outreachy ]] on Tuesday, February 17. If you... [13:46:28] 3Multimedia, Possible-Tech-Projects, MediaWiki-Uploading: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#1030926 (10Qgil) Wikimedia will [[ https://phabricator.wikimedia.org/T921 | apply to Google Summer of Code and Outreachy ]] on Tuesday, February 17. If you want this task to becom... [13:49:11] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Analytics: Collect more data in MediaViewer network performance logging - https://phabricator.wikimedia.org/T86609#1030939 (10Gilles) [13:49:19] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Analytics: Collect more data in MediaViewer network performance logging - https://phabricator.wikimedia.org/T86609#1030940 (10Gilles) a:5Gilles>3None [14:02:29] Whoa [15:16:13] 3Multimedia, MediaWiki-extensions-UploadWizard: Thumbnails in Upload Wizard do not always show - https://phabricator.wikimedia.org/T89170#1031207 (10MusikAnimal) >>! In T89170#1030742, @Gilles wrote: > When the selected batch is over a certain size, a link is displayed for each one to make the thumbnail appear,... [16:46:44] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/189995 [16:46:58] (03CR) 10jenkins-bot: [V: 04-1] Remove obvious function-level profiling [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/189995 (owner: 10Chad) [18:03:47] 3Multimedia, MediaWiki-extensions-UploadWizard: Chunked (>100MB) upload failed with "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T89197#1031833 (10Gilles) 5duplicate>3Open [18:16:28] 3Multimedia, operations: Errors when generating thumbnails should result in HTTP 400, not HTTP 500 - https://phabricator.wikimedia.org/T88412#1031914 (10Tgr) >>! In T88412#1030703, @Gilles wrote: > Should we also change the 500 happening when people request a larger (or equal) size than the original to a 400? I... [18:17:24] marktraceur: is there a bug for the P282 issue? [18:37:10] 3Multimedia, MediaWiki-extensions-UploadWizard, Quality-Assurance: UploadWizard API tests failing on beta Commons due to login problem - https://phabricator.wikimedia.org/T89272#1031965 (10Tgr) 3NEW [18:38:33] Hm, I'm looking at the media viewer, and I'm wondering, which API field is giving out the actual uploader of a photo? the fields in extmetadata (Artist or Credit) are not consistent and are taken by templates that users insert in, but the uploader must exist in some automatically-filled table... right? can anyone point me towards what iiprop to add to get that? I can't find the right info in the docs. [18:40:20] mooeypoo: there is no such field per se [18:40:38] tgr but the media viewer seems to get it right. Where are you taking that from? [18:40:54] extmetadata contains information parsed from templates [18:41:00] I'm looking at this in particular as an example -- https://commons.wikimedia.org/wiki/File:Mona_Lisa,_by_Leonardo_da_Vinci,_from_C2RMF_natural_color.jpg [18:41:09] Artist is the author [18:41:17] extmetadata gives me the Author as Leonardo da Vinci [18:41:23] who is most certainly not the uploader ;) [18:41:51] we show the last uploader [18:41:55] And yet, the media viewer notes "Uploaded by Jeff G" which is correct. [18:42:15] tgr, where are you getting that from? I'm trying toadjust VE's media edit dialog to show the uploader properly [18:42:43] you can fetch that via imageinfo, but it is somewhat crappy for images with multiple revisions, since it tends to be a person who retouched or cropped the image, and not really what you mean by "uploader" [18:42:51] it's included in imageinfo [18:43:04] it is? [18:43:28] https://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&format=json&iiprop=extmetadata&iilimit=10&titles=File:Mona_Lisa,_by_Leonardo_da_Vinci,_from_C2RMF_natural_color.jpg [18:43:29] the iiprop key for it is user [18:43:32] ^^ what am I missing? [18:43:35] oh [18:43:51] sweeeet. [18:44:09] tgr, it migth not be perfect, but it is probably better than us showing "Uploaded by Leonardo da Vinci" [18:44:12] but there is no neat way to the upoloader of the first version of the file [18:44:20] indeed :) [18:44:24] tgr, yeah [18:44:42] well, I was somewhat amused about da Vinci uploading the Mona Lisa to commons, but it seems most other people dislike that [18:46:16] https://phabricator.wikimedia.org/T59308 is the MMV bug about getting the first uploader, I don't recall if there is a more generic one but feel free to repuprose [18:46:32] * mooeypoo nods [18:46:44] I'm trying to sum up the issue in the da Vinci-related bug first [18:46:50] I'll link to that [18:52:00] tgr, thanks for the help, I've summed the "da Vinci uploading to commons" issue in our bug here, and linked to the uploader bug. https://phabricator.wikimedia.org/T88835 [18:52:21] We'll just need to figure out which labels we want to use for what field. [19:11:03] 3Multimedia, operations: Errors when generating thumbnails should result in HTTP 400, not HTTP 500 - https://phabricator.wikimedia.org/T88412#1032059 (10Gilles) 5Open>3Resolved Great! I missed that. Sounds like this is completely done, then. [19:15:12] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Clicking the image closes the download menu" browser test failing on IE - https://phabricator.wikimedia.org/T89087#1032071 (10Gilles) [19:15:14] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Improve reliability of cucumber tests - https://phabricator.wikimedia.org/T87831#1032070 (10Gilles) [19:20:41] tgr: Not sure, maybe chrismcmalunch can help us when he gets back [19:28:57] (03PS1) 10Gilles: Wait for the download menu to appear before closing it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190032 (https://phabricator.wikimedia.org/T89087) [19:32:50] well I'm sure that if Da Vinci were alive today he'd have uploaded it to commons [19:34:34] someone just stole his thunder because it's tricky to upload while dead [19:34:49] Heh, own work. [19:35:28] that too, and let's not talk about selfies https://commons.wikimedia.org/wiki/File:Leonardo_da_Vinci_-_presumed_self-portrait_-_WGA12798.jpg [19:36:47] #medievalselfiepocalypse [19:38:12] Hm, now that I look at these logs again they're actually coming from Special:UploadStash [19:38:18] Which is probably nothing to worry about really [19:56:14] 3Multimedia, operations, MediaWiki-extensions-UploadWizard: Chunked upload fails in UploadWizard with the server aborting the connection, and no errors in the server logs - https://phabricator.wikimedia.org/T89018#1032305 (10BBlack) >>! In T89018#1030174, @akosiaris wrote: > @BBlack, I have a different theory re... [20:03:29] tgr, gi11es, I assume I'm fixing up the more uploads test first, do we need to plan other tests we're all writing so we don't overlap? [20:26:51] marktraceur: gi11es: created ab etherpad to draft them [20:26:55] http://etherpad.wikimedia.org/p/uploadwizard-browser-tests [20:29:03] > key wasn't present in the database. this will happen sometimes. [20:29:10] Helpful comment is helpful [20:29:36] upload stash? [20:29:56] Yeah [20:30:21] Might be because the file was in the stash for too long? [20:30:38] No, because he got that error right after upload [20:30:48] Maybe there was some postprocessing job that hadn't finished yet [20:30:55] Ooh, maybe the chunk assembly job [20:31:05] I thought we waited for that, but maybe not everything does [20:39:01] 3Multimedia, MediaWiki-extensions-UploadWizard, Quality-Assurance: UploadWizard browser test for chunked upload - https://phabricator.wikimedia.org/T89289#1032475 (10Tgr) 3NEW a:3Tgr [20:53:51] 3Multimedia, MediaWiki-extensions-Sentry: Automated tests for Sentry error logging - https://phabricator.wikimedia.org/T88078#1032530 (10Tgr) TODO: create jenkins config so that merges actually get merged. [21:17:37] 3Multimedia, MediaWiki-Uploading: [Regression] broke Edittools for Special:Upload - https://phabricator.wikimedia.org/T33682#1032561 (10Aklapper) p:5Normal>3Volunteer? [21:23:26] Ugh, well, I'll put this on hold and play with the upload more files thing [21:30:30] I'm getting "Fatal error: Cannot use object of type LocalRepo as array in /home/marktraceur/projects/mediawiki/includes/filerepo/FileRepo.php on line 1283", is this a bug or... [21:30:42] On the describe step in Chrome [21:31:13] 3Multimedia, MediaWiki-File-management: Chunked upload offset error should specify expected offset - https://phabricator.wikimedia.org/T87535#1032643 (10Rillke) [21:31:14] 3Multimedia, MediaWiki-Uploading: Chunked upload (tracking) - https://phabricator.wikimedia.org/T61914#1032642 (10Rillke) [21:32:51] that sounds fairly buggish, yes [21:33:22] Shit it's happening on beta too [21:33:43] It's a 503 there, but what isn't [21:35:32] Prod is fine [21:35:34] So...hm [21:35:44] Here's where I start wondering what changed in core [21:38:47] 3Multimedia, MediaWiki-extensions-Sentry, Beta-Cluster, Wikimedia-Logstash: Channel PHP errors from Logstash to Sentry on the beta cluster - https://phabricator.wikimedia.org/T85239#1032685 (10greg) [21:41:48] 3Multimedia, MediaWiki-extensions-Sentry, Beta-Cluster, Wikimedia-Logstash: Channel PHP errors from Logstash to Sentry on the beta cluster - https://phabricator.wikimedia.org/T85239#1032689 (10Tgr) [21:41:49] 3Multimedia: Create basic puppet role for Sentry - https://phabricator.wikimedia.org/T84956#1032690 (10Tgr) [21:42:52] Not a damn thing that I can see...sigh [21:44:51] seems impossible [21:45:28] the status value should be an empty array, not a filerepo, it's set ten lines earlier [21:45:41] 3Multimedia, WMF-Legal: Set up and test Sentry on Labs for JS error logging - https://phabricator.wikimedia.org/T1345#1032700 (10greg) [21:45:43] 3Multimedia, MediaWiki-extensions-Sentry: Add PHP error logging to Sentry extension - https://phabricator.wikimedia.org/T85188#1032701 (10greg) [21:47:57] well, the corrent syntax should be $status->sv->value I think as core is apparently in the process of transitioning from Status to StatusValue [21:48:12] but still don't see how that error could come up [21:50:31] tgr: will you be in the office tomorrow? Can I come by and ask questions about Sentry? :) [21:51:05] Yeah, it seems unlikely [21:51:10] tgr: Can you repro with latest core? [21:51:28] greg-g: sure [21:51:41] tgr: awesome, thank you [21:52:32] marktraceur: do you have repro steps? [21:52:41] or just upload stuff and it will break? [21:53:08] 3Multimedia, MediaWiki-extensions-Sentry: Add PHP error logging to Sentry extension - https://phabricator.wikimedia.org/T85188#1032737 (10Tgr) [21:53:09] tgr: Should be that, yes [21:53:29] I used a jpg from my test uploads directory, there's a test script that will make them for you, if you need to [21:59:05] I can [21:59:13] Shit. [21:59:16] definitely sounds like an unbreak now thing [21:59:21] Well, they just branched wmf17 too [21:59:29] I wonder why the smoke test did not hit it [21:59:33] So MediaWiki.org is probably about to break in new and exciting ways [21:59:40] or maybe that only runs on prod? [21:59:48] I think it's only running on prod, but maybe beta [21:59:56] But beta is fucked anyway, 503s everywhere [22:00:10] Scap is running for wmf17 on testwiki [22:00:36] I'll file a bug [22:04:35] normal upload is borked as well [22:07:02] Bisecting now [22:07:12] Lucky we have these browser tests, it's mighty handy [22:08:05] wheeee I sure do like to hear that [22:08:15] :) [22:09:08] I015635a9bf080ef6d98b2cff49b949c4378a859f seems like the obvious culprit [22:09:32] I'll let you know in 4 steps :) [22:10:02] marktraceur: are you using hhvm? [22:11:26] Nope [22:12:24] Yeah, looks like this is it all right [22:12:36] Revert? Or... [22:13:08] 3Multimedia, Release-Engineering, MediaWiki-Uploading: Fatal error "Object does not implement ArrayAccess" in FileRepo::publishBatch() - https://phabricator.wikimedia.org/T89296#1032785 (10Tgr) 3NEW [22:13:35] 3Multimedia, Release-Engineering, MediaWiki-Uploading: Fatal error "Object does not implement ArrayAccess" in FileRepo::publishBatch() - https://phabricator.wikimedia.org/T89296#1032793 (10Tgr) [22:13:56] 3Multimedia, Release-Engineering, MediaWiki-Uploading: Fatal error "Object does not implement ArrayAccess" in FileRepo::publishBatch() - https://phabricator.wikimedia.org/T89296#1032785 (10Tgr) > Presumably related to I015635a9bf080ef6d98b2cff49b949c4378a859f. Mark verified via bisect. [22:14:04] Asking AaronS in -dev [22:15:34] At least it didn't hit commons... [22:15:47] Or is it about to... [22:16:44] only next Tuesday [22:16:53] OK good. [22:17:18] so no need to revert if someone can figure out a fix in a few days I suppose [22:17:25] Yeah [22:17:28] * marktraceur sighs [22:22:20] tgr: You want to test his patch or can I merge it? [22:25:13] ah, makes sense [22:25:25] merge it, I'll check on beta [22:25:58] Merging now [22:29:31] (03PS4) 10MarkTraceur: Add browser test for "upload more files" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/186543 (https://phabricator.wikimedia.org/T86119) [22:43:13] 3Multimedia, Release-Engineering, MediaWiki-Uploading: Fatal error "Object does not implement ArrayAccess" in FileRepo::publishBatch() - https://phabricator.wikimedia.org/T89296#1032892 (10Tgr) 5Open>3Resolved a:3Tgr Fix verified on beta. Thanks Aaron! [23:15:56] 3Multimedia, MediaWiki-Uploading: Create check hook before really uploading file with infos about description page and file - https://phabricator.wikimedia.org/T89302#1032952 (10Se4598) 3NEW [23:40:12] (03CR) 10Gergő Tisza: [C: 032] Wait for the download menu to appear before closing it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190032 (https://phabricator.wikimedia.org/T89087) (owner: 10Gilles) [23:41:02] (03Merged) 10jenkins-bot: Wait for the download menu to appear before closing it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/190032 (https://phabricator.wikimedia.org/T89087) (owner: 10Gilles)