[01:30:07] (03PS1) 10Gergő Tisza: Fix date format in pageview SQL query [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) [01:30:57] (03CR) 10Gergő Tisza: [C: 032] "Self-merge, trivial bug that prevents me from testing the limn half of the patch." [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [01:31:03] (03Merged) 10jenkins-bot: Fix date format in pageview SQL query [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [02:43:34] 3Project-Creators, Multimedia: Create sprint projects for Multimedia - https://phabricator.wikimedia.org/T86857#981100 (10Tgr) @Gilles, do you want to take that? [03:11:06] (03CR) 10Gergő Tisza: "Mostly documentation nitpicks. Note also that the correct format is" (0316 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [06:26:54] (03CR) 10Gergő Tisza: [C: 04-1] Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [08:00:57] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#981274 (10Gilles) Yes, we want to differenciate preloading requests in this case. With this @ezachte will ignore next/prev hits in his stats for now. Only the... [08:01:49] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Hackathon: track how long people are looking at a given image - https://phabricator.wikimedia.org/T77881#981275 (10Gilles) Not really blocking, at least not for the first version or per-file view stats. [08:06:47] (03CR) 10Gilles: [C: 032] Show page view / image view comparison [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [08:07:36] (03CR) 10Gilles: [V: 032] Show page view / image view comparison [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [08:08:09] (03CR) 10Gilles: "Deployed" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [08:52:28] I think that commons still has the desire to open UW flickr import to everyone, in which case that template change would become useful [08:55:33] gi11es: uploadwizard upload button throws an expection [08:55:45] can't upload anything: FF35 [08:56:02] matanya: does the exception say something about sendbeacon? [08:56:19] yes gi11es [08:56:24] and are you using adblock or similar? [08:56:36] yes, but disabling it doesn't fix it [08:56:46] i reported the original issue [08:57:00] so i suspected it in the first place [08:57:03] let me find the rish task so that you can subscribe to it [08:57:08] right [08:57:34] https://phabricator.wikimedia.org/T86680 [08:58:09] fix the bugs first..i heard it has over 9000 [08:58:39] gi11es: I reported https://phabricator.wikimedia.org/T86900 for hovercard [08:58:46] but thanks for this one :) [08:59:03] yeah, it probably affects many things [08:59:07] eventlogging is widely used [08:59:23] marktraceur should fix it ? [09:00:06] ori will, he was just trying to get confirmation from affected people that his fix would work [09:00:17] you can try it, run the command ori gave in your console [09:00:34] see his last comment on the task I've just linked to [09:01:10] it's still assigned to marktraceur because we thought it was something specific to UW when it was first filed [09:01:45] ok gi11es thanks [09:24:22] (03CR) 10Gilles: [C: 04-1] Move DeedPreview to the deed step controller (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183654 (https://phabricator.wikimedia.org/T86227) (owner: 10MarkTraceur) [09:44:39] (03CR) 10Gilles: [C: 04-1] "After a batch of successful uploads and going back to the first step via "upload more files", the UI's layout is messed up: https://www.dr" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [10:09:18] (03CR) 10Gilles: [C: 04-1] Move duplicate error handling to the wizard class (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 (owner: 10MarkTraceur) [14:34:52] Is anyone aware of UW "file name is not allowed", "this type of file is banned", and "badupload_file" issues? [14:35:00] There's several threads about this: https://commons.wikimedia.org/wiki/Commons:Village_pump#Something_wrong_with_the_UploadWizard.3F [14:35:13] https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#error_occured_while_uploading [14:35:17] https://commons.wikimedia.org/wiki/Commons:Upload_help#File_name_not_allowed_.28.E2.80.9EDieser_Dateiname_ist_nicht_erlaubt.22.29 [14:35:55] wondering if that is just another episode of https://phabricator.wikimedia.org/T86680 or not [14:37:58] Hm. [14:39:32] We allow PDFs, right? [14:39:50] Yes, we do. [14:40:05] Ooh, stash errors [14:40:07] That's a good thing [14:41:37] Wow, I can't believe we actually got a stash error [14:41:39] This is awesome [14:41:42] :D [14:41:50] well, at least one person happy here ;)) [14:42:12] * andre__ hopes he has replied to most "OMG UW all borken!!!" comments on VPs... [14:42:24] Looks like there were three from two users [14:42:57] Nothing looks terribly broken, though. Maybe those uploads just didn't finish... [14:43:24] I don't know. As usual with bugs at some point I just get this feeling wondering "Is there something bigger going on?" and then I yell on IRC :) [14:43:30] Or...more [14:43:31] Hm. [14:43:39] Let me look at a bigger graph [14:43:42] It may have been more than three [14:44:48] Gods logstash is slow. [15:21:43] ah, i see ppl are upset that their flickr auto review is gone [15:22:00] u see, the community is never satisfied :) [15:49:40] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#981981 (10Magnus) My bot is now in manual testing (no cronjob), with initial interface: https://tools.wmflabs.org/commons-delinquent/ Meanwhile, does anyone... [16:08:37] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#981989 (10Magnus) My source repo: https://bitbucket.org/magnusmanske/commons-delinquent/src [16:38:42] (03PS4) 10MarkTraceur: Move DeedPreview to the deed step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183654 (https://phabricator.wikimedia.org/T86227) [16:39:33] (03CR) 10jenkins-bot: [V: 04-1] Move DeedPreview to the deed step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183654 (https://phabricator.wikimedia.org/T86227) (owner: 10MarkTraceur) [16:39:57] (03PS5) 10MarkTraceur: Move DeedPreview to the deed step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183654 (https://phabricator.wikimedia.org/T86227) [16:56:27] marktraceur: the elasicsearch cluster behind logstash was basically dead. More log traffic from MW crushed it. Working on reviving it now [16:56:38] Ah. [16:56:48] Thanks :) [16:57:12] thedj: I was hoping you could explain why you did it, point to a discussion or something [17:28:03] (03CR) 10MarkTraceur: "I gotta figure it missed one of the uploads in the reset function. On it!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [17:59:01] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#982264 (10Kelson) 3NEW [18:09:55] 3MediaWiki-extensions-VipsScaler, Multimedia: TIFF thumbnailer fails with a few IPTC profiles - https://phabricator.wikimedia.org/T87042#982303 (10Kelson) 3NEW [18:30:38] 3MediaWiki-extensions-GWToolset, Multimedia: HTML code in GWT log entries should not be "escaped" - https://phabricator.wikimedia.org/T87044#982374 (10Kelson) [18:46:26] 3MediaWiki-extensions-VipsScaler, Multimedia: TIFF thumbnailer fails with a few IPTC profiles - https://phabricator.wikimedia.org/T87042#982508 (10Kelson) This seems to be a bug in the libTIFF. Here is the upstream ticket: http://bugzilla.maptools.org/show_bug.cgi?id=2273 [18:47:39] 3MediaWiki-extensions-VipsScaler, Multimedia: Use VipsScaler to scale TIFFs - https://phabricator.wikimedia.org/T54045#982537 (10Kelson) @TheDJ Thank you for your analysis. I have open a new ticket https://phabricator.wikimedia.org/T87042 [18:58:59] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#982587 (10Steinsplitter) >>! In T86483#981981, @Magnus wrote: > Meanwhile, does anyone know about this bot: > https://en.wikipedia.org/wiki/User:Filedelinker... [19:03:43] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#982598 (10Tgr) Using different URLs for preloading and for the actual request kind of breaks the point. You can have a different URL for a thumbnail click and... [19:04:18] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#982600 (10Steinsplitter) >>! In T86483#981981, @Magnus wrote: > My bot is now in manual testing (no cronjob), with initial interface: When your bot does the... [19:30:21] marktraceur, gi11es: anyone intending to backport https://phabricator.wikimedia.org/T86680 or should I pick that up? [19:32:01] Go ahead [19:32:10] We have at least three other issues that -commons is asking about right now [19:32:21] tgr: One is an issue with attribution in TMH with audio files [19:33:09] are they important enough for a Friday emergency deployment? [19:33:29] the pipe thing seems worth the trouble [19:33:33] Possibly [19:33:37] I haven't seen the other bugs [19:33:39] I'll definitely do the pipe thing [19:33:49] Audio attribution failure is a potential legal issue [19:33:51] just revert for now? [19:33:58] For the pipe thing? Sure. [19:34:05] I can't deploy it yet anyway [19:36:10] do we have a tesk for the pipe issue yet? [19:36:23] There should be one, yeah [19:36:28] Well, not for the new one [19:36:43] But there's a test for the sanitization in mw.UploadWizard.test.js I think [19:37:41] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#982695 (10Tgr) 5Resolved>3Open This is causing major problems on Commons since it breaks templates included in the description. [19:37:57] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#982697 (10Tgr) p:5Normal>3Unbreak! [19:39:09] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#842781 (10Tgr) E.g. https://commons.wikimedia.org/w/index.php?title=File:Scouts_of_the_Japanese_Army.jpg&diff=146765421&oldid=146761665 [19:40:02] (03PS1) 10Gergő Tisza: Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185487 (https://phabricator.wikimedia.org/T78336) [19:40:36] (03CR) 10Gergő Tisza: "Reverted for now per https://phabricator.wikimedia.org/T78336#982695" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [19:41:14] (03PS5) 10MarkTraceur: Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) [19:41:28] tgr: Were you looking at the pipe thing? Or should I? [19:41:39] Oh, you did it. [19:41:41] OK [19:41:48] I can deploy I guess [19:41:56] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [19:42:37] stfu jenkins I'll deal with you later [19:44:32] marktraceur: can you +2? I'll do the backports then [19:44:41] I'm testing it now [19:45:05] greg-g: we'll do an EventLogging deploy per https://phabricator.wikimedia.org/T86680#982160 , any objections against throwing in https://phabricator.wikimedia.org/T78336#982695 ? [19:45:30] Revert works [19:45:40] (03CR) 10MarkTraceur: [C: 032] Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185487 (https://phabricator.wikimedia.org/T78336) (owner: 10Gergő Tisza) [19:45:43] Jenkins don't fail me now. [19:45:50] any other issue that's bad or easy enough to fix and throw in? [19:46:14] I'm a bit worried about the TMH bug, but...probably not trivial to fix [19:46:20] (03Merged) 10jenkins-bot: Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185487 (https://phabricator.wikimedia.org/T78336) (owner: 10Gergő Tisza) [19:47:17] which bug is that? [19:47:33] tgr: https://commons.wikimedia.org/wiki/Commons:Wikimedia_Sverige/recent_uploads/2015_January#15_January_2015 [19:47:39] No way to get to the file page of audio files [19:47:45] Maybe just in galleries, not sure [19:50:04] https://gerrit.wikimedia.org/r/#/c/181810/ is the only recent TMH change [19:50:47] I'm not sure if it's a regression or just a bug [19:52:34] who reported it? [19:52:42] It was [19:52:49] ... [19:52:53] Josve05a [19:56:06] probably a regression, that patch does not update the resource list [19:56:16] Hm. [19:56:21] I'll write a patch [19:56:25] OK [19:56:30] Then we can push through all three [19:56:35] this is looking to be a fun Friday [19:56:40] tgr: I'll do the backport for the pipe thing [19:56:45] You do the patch for TMH [19:56:52] What was the third thing? EL? Is that set to go? [19:57:03] needs backport, I think [19:57:08] Fun, I can do that too [19:57:14] It's merged to master though, right? [19:57:19] yep, https://gerrit.wikimedia.org/r/#/c/185405/ [19:58:17] (03PS1) 10MarkTraceur: Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185493 (https://phabricator.wikimedia.org/T78336) [19:58:50] (03PS1) 10MarkTraceur: Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185494 (https://phabricator.wikimedia.org/T78336) [20:03:28] (03CR) 10MarkTraceur: [C: 032] Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185493 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [20:04:19] (03CR) 10jenkins-bot: [V: 04-1] Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185493 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [20:04:24] Ugh. [20:04:58] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] (wmf/1.25wmf15) - 10https://gerrit.wikimedia.org/r/185493 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [20:06:57] tgr: marktraceur /me nods [20:09:46] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#982836 (10Tgr) 3NEW [20:09:52] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#982844 (10Tgr) Probably a regression, but no one seems sure. Probably caused by https://gerrit.wikimedia.org/r/#/c/181810/2 (lack of message registration?) [20:10:53] what a surprise, TMH has its own way of registering messages [20:11:25] tgr: Of course! You can't expect them to take every other extension's sloppy seconds. [20:14:33] (03CR) 10MarkTraceur: [C: 032] Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185494 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [20:15:56] (03Merged) 10jenkins-bot: Revert "Sanitize | characters in descriptions" [extensions/UploadWizard] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185494 (https://phabricator.wikimedia.org/T78336) (owner: 10MarkTraceur) [20:18:13] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#982861 (10Josve05a) This only applies for when the audio file is in a gallery, see https://commons.wikimedia.org/wiki/User:Josve05a/T87056 [20:18:38] OK, we have backport patches [20:18:46] God I hate doing that so much. [20:18:49] I want it to be automatic. [20:21:42] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#982872 (10Tgr) >>! In T87056#982844, @Tgr wrote: > Probably caused by https://gerrit.wikimedia.org/r/#/c/181810/2 (lack of message registration?) It does not se... [20:22:13] not a message registration issue after all [20:22:44] which means it's not a regression, so it can wait until next week [20:23:15] is there any other urgent bug? [20:23:35] I'll glance at the GWT issue but I doubt it's something I want to touch on a Friday [20:27:49] OK [20:27:57] I don't have anything else [20:29:02] tgr: Set to go? [20:31:59] 3Security-Reviews, MediaWiki-extensions-Sentry, Multimedia: Quick/short security review of Extension:Sentry - https://phabricator.wikimedia.org/T86677#982890 (10Tgr) Super lame data flow diagram for Sentry: https://docs.google.com/a/wikimedia.org/presentation/d/1kdSdtLFev6r9rirI35n9QUrU9-3J5XgYk00vDJrqISI/edit#s... [20:34:41] marktraceur: GWT runs on Commons, right? [20:35:38] apparently so [20:35:55] no recent changes should be live yet, then [20:36:09] so the error is not something I can figure out quickly [20:36:15] So no big deal? 'cause I'm merging things as we speak [20:36:15] so set to go, yes [20:36:18] Cool [20:56:16] 3MediaWiki-extensions-CommonsMetadata, Multimedia, Wikipedia-App-Android-App: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#982921 (10Tgr) p:5Triage>3High [20:56:23] 3MediaWiki-extensions-CommonsMetadata, Multimedia, Wikipedia-App-Android-App: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#982922 (10Tgr) a:3Tgr [20:58:03] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#982924 (10Tgr) Can other GWT users confirm this or is the bug limited to that one job? [21:19:41] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#982967 (10Tgr) 3NEW [21:29:35] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#982992 (10Tgr) According to the linked discussions, error messages are `file name is not allowed`, `this type of file is banned`, `badupload_file`, `The stashed file was not found whe... [21:30:40] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983011 (10Tgr) [21:31:14] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#982967 (10Tgr) If someone could share an affected file without uploading it to Commons, that would be helpful. [21:57:56] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983105 (10Tgr) >>! In T87062#982992, @Tgr wrote: > According to the linked discussions, error messages are `file name is not allowed`, `this type of file is banned`, `badupload_file`,... [22:07:51] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983128 (10Herzi.Pinki) Sorry, I translated the message without retry. The exact message is in German //Der Dateiname ist nicht erlaubt//. In English //The filename is not allowed//. [22:12:20] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983138 (10Herzi.Pinki) {F29217} There you have a file not uploaded and failing with the same message. Name on local disk is 20150103_15-32-20_01.3.jpg. I know that the name is not l... [22:21:41] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983177 (10Herzi.Pinki) This is the relevant part of the web console: [23:20:26.883] GET https://bits.wikimedia.org/event.gif?%7B%22event%22%3A%7B%22quantity%22%3A1%2C%22event%22%3A%2... [22:37:01] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983214 (10Herzi.Pinki) The post request for the same file further downsized: Request-URL: https://commons.wikimedia.org/w/api.php Request-Methode: POST...