[00:24:02] How do i download the code for this task? http://www.google-melange.com/gci/task/view/google/gci2014/5343179045863424 [00:25:49] Hi Raheel102! [00:26:17] hi [00:26:24] I'm looking now [00:26:34] ok thank you [00:26:36] Raheel102: OK, that's the ImageMap extension. [00:26:51] Raheel102: You'll need the extension from here: https://www.mediawiki.org/wiki/Extension:ImageMap [00:27:06] Raheel102: You'll also need MediaWiki itself for testing: https://www.mediawiki.org/wiki/Download [00:27:50] Ok thank you mark! :D [00:28:00] My pleasure! [00:30:37] 3Multimedia, MediaWiki-extensions-MultimediaViewer, UI-Standardization: Misaligned icon on configuration button - https://phabricator.wikimedia.org/T85778#958592 (10Prtksxna) Change introduced in https://gerrit.wikimedia.org/r/#/c/177092/ [00:47:21] 3MediaWiki-File-management, Multimedia: SVG client side rendering - https://phabricator.wikimedia.org/T5593#958597 (10Perhelion) Maybe it is better first to enable it as beta-feature in the preferences!? [00:48:53] marktraceur: selenium itself is no big deal but the browser is running on the VM as well [00:49:03] Eugh. [00:49:04] using headless mode will speed it up a lot [00:49:12] Well jeez I should do that then [00:49:56] using zombiejs will speed it up even more but the results are not guaranteed to be the same [00:50:06] still, good for developing [00:50:25] Mm. [00:50:45] or maybe its phantomjs? [00:50:53] forgot which flavor we are using [00:51:22] phantom sounds familiar [00:51:25] phamiliar? [00:54:57] 3Multimedia, MediaWiki-extensions-MultimediaViewer, UI-Standardization: Misaligned icon on configuration button - https://phabricator.wikimedia.org/T85778#958612 (10Prtksxna) p:5Triage>3Normal a:3Prtksxna [00:55:26] 3Multimedia, MediaWiki-extensions-MultimediaViewer, UI-Standardization: Misaligned icon on configuration button - https://phabricator.wikimedia.org/T85778#954308 (10Prtksxna) [01:26:38] 3MediaWiki-Uploading, MediaWiki-extensions-UploadWizard: SVG upload should have more specific error (warning) message when blocking - https://phabricator.wikimedia.org/T85924#958643 (10Perhelion) You mean you can't made the message concrete? If you get security through left information is not a good idea. It wo... [02:15:30] 3MediaWiki-File-management, Multimedia: SVG client side rendering - https://phabricator.wikimedia.org/T5593#958698 (10McZusatz) As far as I can see this patch just adds a boolean whether to serve SVG or not. It does not take into account browser support, OS (desktop or mobile) and the size of the SVG (some SVG a... [08:23:42] 3MediaWiki-File-management, Multimedia: SVG client side rendering - https://phabricator.wikimedia.org/T5593#958909 (10Ricordisamoa) >>! In T5593#958597, @Perhelion wrote: > Maybe it is better first to enable it as beta-feature in the preferences!? While it may work fairly well on private wikis, it surely won't... [09:02:56] 3MediaWiki-File-management, Multimedia: SVG client side rendering - https://phabricator.wikimedia.org/T5593#958963 (10fbstj) @Ricordisamoa thank you for working my patch into a proper thing. I'm really glad there's some progress happening. [11:19:11] 3MediaWiki-extensions-VipsScaler, Multimedia: Use VipsScaler to scale TIFFs - https://phabricator.wikimedia.org/T54045#959148 (10Kelson) New problems detected with a few big TIFF (but not the biggest), but not sure where/what is the bug. For example here: https://commons.wikimedia.org/wiki/File:CH-NB_-_1802,_Zw... [11:56:56] 3MediaWiki-extensions-VipsScaler, Multimedia: Use VipsScaler to scale TIFFs - https://phabricator.wikimedia.org/T54045#959182 (10TheDJ) Error creating thumbnail: convert: /tmp/localcopy_7570ffa9a5d6-1.tif: wrong data type 7 for "RichTIFFIPTC"; tag ignored. `TIFFReadDirectory' @ warning/tiff.c/TIFFWarnings/706. c... [13:06:31] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer can show cached old versions of images - https://phabricator.wikimedia.org/T78745#959242 (10TheDJ) The related task is T38380 [14:26:16] 3UI-Standardization, Multimedia, MediaWiki-extensions-MultimediaViewer: Misaligned icon on configuration button - https://phabricator.wikimedia.org/T85778#959382 (10Prtksxna) 5Open>3Resolved [15:07:33] (03PS2) 10MarkTraceur: Test removing uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163529 (owner: 10Neilk) [15:09:09] So I'm thinking it might be useful to separate different tests into different feature files [15:09:37] Because right now I can't test only the newly-added browser tests [15:09:42] Oh, wait, headless mode [15:14:11] 3Multimedia, MediaWiki-extensions-UploadWizard: Flickr import -> no "next" button - https://phabricator.wikimedia.org/T86008#959472 (10Gilles) 3NEW a:3MarkTraceur [15:14:23] ^ [15:14:36] Wuuuuuuhoh [15:14:41] On it boss [15:15:20] I didn't try another URL [15:15:30] but I doubt it's related [15:15:34] Got it [15:16:25] gi11es: WFM, you're in Chrome, right? [15:16:31] firefox [15:16:32] Oh, no, Firefox [15:16:33] WTF [15:16:59] gi11es: Errors in the console? [15:17:39] it works now... wtf [15:17:49] let me check with that url again [15:18:03] That's what I said [15:18:06] Gods UW [15:18:11] At least break consistently [15:18:33] can't reproduce anymore [15:18:36] :( [15:18:42] Well [15:18:47] Bug fixed? :D [15:18:52] something like that... [15:19:06] 3Multimedia, MediaWiki-extensions-UploadWizard: Flickr import -> no "next" button - https://phabricator.wikimedia.org/T86008#959489 (10Gilles) 5Open>3Invalid Can't reproduce anymore [15:19:39] could be timing-related, who knows [15:19:45] Maybe [15:20:22] So we should add a warning that appears at 15:10 every day for flickr imports? [15:21:38] you kid but I've run into bugs like that before that only happened if the user did something on the hour [15:21:56] it took weeks to track down [15:22:21] I bet! [15:22:29] gi11es: Were you doing this exactly on the hour? [15:22:37] I don't think so :) [15:22:38] The bug report is at 15:14 so I doubt it [15:22:58] but remember that we had that weird bug that disappeared when I restarted firefox [15:23:14] I can't remember if we ever figured out what that was about or if it just went away [15:23:23] you know, where part of the UI would be greyed out? [15:25:40] (03CR) 10Gilles: [C: 032] Flickr: The community does not consider UW uploads verified [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [15:25:41] Hm, I sort of remember that [15:25:56] I definitely remember there being some issues that you had that I couldn't repro [15:26:03] I think this is the third [15:26:10] Maybe our setups are different in some subtle way [15:26:27] right, just before the holidays there was another one [15:26:33] that I couldn't reproduce on monday [15:26:47] firefox is testing me [15:28:37] Somewhere at Mozilla HQ is some guy giggling at us [15:29:28] (03CR) 10jenkins-bot: [V: 04-1] Flickr: The community does not consider UW uploads verified [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [15:30:13] Uh oh. [15:30:15] jenkins being jealous that we blame firefox for something [15:30:45] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [15:30:46] Seems bogus [15:32:04] 3Multimedia, MediaWiki-extensions-UploadWizard: State benefit(s) of chunked uploading in preference - https://phabricator.wikimedia.org/T62587#959559 (10Aklapper) [15:32:05] 3Multimedia, MediaWiki-extensions-UploadWizard: Write documentation for UploadWizard in JSDuck format - https://phabricator.wikimedia.org/T51989#959558 (10Aklapper) [15:32:44] 3Multimedia, MediaWiki-extensions-MultimediaViewer, Analytics: Make upload.wikimedia.org serve images with Timing-Allow-Origin header - https://phabricator.wikimedia.org/T76020#959586 (10Joe) 5Open>3Resolved [15:33:13] Argh [15:34:08] could be coming from core? [15:34:43] I'm asking -qa [15:37:31] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: prop=videoinfo API viprop=derivatives parameter not documented in help - https://phabricator.wikimedia.org/T57744#959621 (10Aklapper) [15:37:33] 3Multimedia, MediaWiki-extensions-GWToolset: Document design and implementation of GWToolset - https://phabricator.wikimedia.org/T58186#959622 (10Aklapper) [15:37:34] 3Multimedia, MediaWiki-extensions-UploadWizard: Complete uploadcampaign api documentation - https://phabricator.wikimedia.org/T41349#959623 (10Aklapper) [15:40:01] I'm getting an error running qunit with the latest core [15:40:18] coming form jquery.qunit.js [15:40:27] on firefox [15:40:30] I'll check chrome [15:40:38] It's phantomjs on jenkins [15:40:53] Weird that the core tests wouldn't catch it. [15:43:48] Ugh, phantomjs didn't work for my selenium testing either [15:43:50] Bastards [15:48:12] it;s the mw.fileApi: isPreviewableVideo test failing consistently for me, even on its own [15:48:25] ...orly? [15:48:40] I'll try it. [15:48:53] But only with latest core, right? [15:49:55] yeah [15:50:10] same error in chrome [15:50:23] Oh dear. [15:50:27] OK, looking into it [15:50:31] coud be caused by the qunit update that just landed [15:50:35] Might could be [15:51:04] I stubbed document.createElement in that test [15:51:14] That can definitely screw with stuff [15:51:23] But it should be replaced afterwords? [15:51:48] yep, it's the update [15:52:08] Or I shouldn't stub that [15:53:29] Trying to figure out where that first error is [15:54:02] TypeError: Argument 1 of Node.appendChild does not implement interface Node. [15:54:02] [15:54:02] assertList.appendChild( assertLi ); [15:55:01] Yes but where? [15:55:40] I'm trying to track down which line in the test it's coming from [15:56:29] assert.strictEqual( mw.fileApi.isPreviewableVideo( testFile ), true ); [15:57:04] It's because it's logging the assertion results before the test is over [15:57:32] So it needs stuff like document.createElement to exist, and not be useless, so it can create a list item saying "Yay assertion passed hooray you're brilliant" [15:57:59] I guess I can return createElement to normal between runs of isPreviewableVideoa [15:58:06] isPreviewableVideo [15:58:22] Gonna finish running my browser tests once and then I'll do that [16:14:47] Hey gi11es, want to test https://commons.wikimedia.org/wiki/File:Taluppfattning_7_Potenser_med_rationella_exponenter_och_r%C3%B6tter.webm and let me know if it plays OK for you? [16:14:56] Try on Chrome too, josve05a is saying it's borked [16:15:03] Never mind [16:15:06] He purged and it's working now [16:15:32] (03CR) 10Gilles: [C: 04-1] "Very minor indentation concern, the feature works." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (https://phabricator.wikimedia.org/T75999) (owner: 10Namit) [16:16:06] (03CR) 10MarkTraceur: [C: 031] "Working for me, I'd say merge when the children are done" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163529 (owner: 10Neilk) [16:16:22] (03CR) 10MarkTraceur: [C: 031] "Working, mergeable after the parent" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163457 (owner: 10Neilk) [16:16:34] (03PS2) 10MarkTraceur: Duplicate name test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163531 (owner: 10Neilk) [16:17:45] (03CR) 10jenkins-bot: [V: 04-1] Duplicate name test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163531 (owner: 10Neilk) [16:20:07] (03PS1) 10MarkTraceur: Fix qunit tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183260 [16:20:10] gi11es: ^^ [16:20:34] Maybe I should go buy lunch before the meeting. [16:20:42] I'll be back soon [16:22:47] (03CR) 10Gilles: [C: 032] Fix qunit tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183260 (owner: 10MarkTraceur) [16:23:26] (03Merged) 10jenkins-bot: Fix qunit tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183260 (owner: 10MarkTraceur) [16:27:40] (03CR) 10Gilles: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [16:30:03] (03CR) 10Gilles: [C: 032] Flickr: The community does not consider UW uploads verified [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [16:30:50] (03Merged) 10jenkins-bot: Flickr: The community does not consider UW uploads verified [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [16:47:28] Sorry to make you miss your event, gi11es [16:47:42] it's ok, thousands will attend it for me :) [16:54:05] 3Multimedia, MediaWiki-extensions-UploadWizard: Browser test - adding multiple files - https://phabricator.wikimedia.org/T86021#959969 (10MarkTraceur) 3NEW a:3MarkTraceur [16:55:54] 3Multimedia, MediaWiki-extensions-UploadWizard: Browser test - adding multiple files - https://phabricator.wikimedia.org/T86021#959969 (10MarkTraceur) [16:56:30] 3Multimedia, MediaWiki-extensions-UploadWizard: Browser test - remove uploads - https://phabricator.wikimedia.org/T86022#959982 (10MarkTraceur) 3NEW a:3MarkTraceur [16:56:40] 3Multimedia, MediaWiki-extensions-UploadWizard: Browser test - remove uploads - https://phabricator.wikimedia.org/T86022#959982 (10MarkTraceur) [17:07:36] (03CR) 10Gilles: [C: 032] Add tests for mw.FormDataTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 (https://phabricator.wikimedia.org/T85629) (owner: 10MarkTraceur) [17:08:20] (03Merged) 10jenkins-bot: Add tests for mw.FormDataTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 (https://phabricator.wikimedia.org/T85629) (owner: 10MarkTraceur) [17:08:53] (03CR) 10Gilles: [C: 032] Add some basic tests for IframeTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183065 (https://phabricator.wikimedia.org/T85629) (owner: 10MarkTraceur) [17:09:33] <3 [17:09:41] (03Merged) 10jenkins-bot: Add some basic tests for IframeTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183065 (https://phabricator.wikimedia.org/T85629) (owner: 10MarkTraceur) [17:09:44] are you going to do the firefogg transoprt as well? [17:09:53] Yeah, I just hadn't gotten there [17:10:00] I bet that one will be even more doubleplushard [17:10:12] ok, I'll move the card back to curent sprint then [17:11:50] Cool. [17:18:37] (03PS7) 10Namit: Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (https://phabricator.wikimedia.org/T75999) [17:20:01] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Open the download panel when the contextual menu is opened over an image - https://phabricator.wikimedia.org/T75999#960020 (10Gilles) a:3Namit [17:24:12] (03CR) 10Gilles: [C: 032] Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (https://phabricator.wikimedia.org/T75999) (owner: 10Namit) [17:27:26] 3MediaWiki-extensions-GWToolset: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#960033 (10Lokal_Profil) 3NEW [17:39:54] (03Merged) 10jenkins-bot: Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (https://phabricator.wikimedia.org/T75999) (owner: 10Namit) [17:57:35] 3MediaWiki-extensions-UploadWizard: autoCategory option to $wgUploadWizardConfig setting is getting ignored - https://phabricator.wikimedia.org/T86029#960127 (10Kghbln) 3NEW [18:14:28] 3MediaWiki-extensions-CommonsMetadata: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#960168 (10Kghbln) 3NEW [18:53:30] tgr|away: fwiw ottomata says you should ask in -operations for help with puppetization if you need it [18:53:50] 3MediaWiki-File-management, Multimedia: Allow image converter to reduce quality or color depth - https://phabricator.wikimedia.org/T62316#960362 (10dr0ptp4kt) [19:49:27] marktraceur: see the "Guidance on creating Debian packages for puppet" thread on the ops list [19:49:47] Ooh, well, you're ahead of me then. [19:50:14] in short, I'm getting lots of help on how to do it, but ops won't have time to be directly involved [19:50:21] Fair enough [19:52:39] i donwloaded git and it comes up with choose or create respitory how would i config the git? [19:53:05] raheel102: Where did you download git from? [19:53:20] https://msysgit.github.io/ [19:54:04] raheel102: Well, what project are you trying to work on? [19:54:16] this one http://www.google-melange.com/gci/task/view/google/gci2014/5343179045863424 [19:54:24] fix php notices [19:55:43] raheel102: The repository is https://git.wikimedia.org/git/mediawiki/extensions/ImageMap.git [19:56:38] ok [19:57:15] its saying not found [19:57:21] ...HM. [19:57:24] I'll try. [19:57:32] ok [19:57:54] Works for me [19:58:35] hm.. ill keep trying [20:01:25] raheel102: Wait, you tried going there in your browser? [20:01:38] yeah [20:01:44] That's...not going to work [20:01:54] raheel102: git clone https://git.wikimedia.org/git/mediawiki/extensions/ImageMap.git [20:02:10] oh ok [21:16:02] Quick question. We're doing next/previous functionality for the image viewer on the apps but it keeps showing things like the little star that shows articles are featured, and so on. [21:16:45] Is there any easy way to filter those things out? [21:18:24] Desktop MediaViewer does a pretty good job of this. [21:18:30] So I'm guessing we've missed something. [21:19:57] marktraceur, tgr ^ [21:20:22] Deskana: There's a class that we look for that blacklists those [21:20:26] I think it's maintenance. [21:22:30] .metadata and .noviewer [21:22:42] and anything with a link parameter [21:22:58] There ya go. [21:23:15] Well, "link parameter" may be inaccurate, we look at whether the href of the link matches the title of the image IIRC [21:23:24] It works out the same, but yeah [21:24:03] no, if you use [[...|link=]] MMV will not handle that file [21:24:26] Really [21:24:32] Must be a class applied to it or something? [21:24:33] we actually had a fair deal of trouble because of that, some templates used it as a lazy way of not setting a link target by default [21:26:36] Deskana: the class thing is in mmv.bootstrap.js isAllowedThumb() [21:26:58] no idea where we deal with the link params though [21:26:59] I'll take a look. Thanks! [21:28:27] 3MediaWiki-extensions-CommonsMetadata: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#960943 (10Aklapper) p:5Triage>3Low [21:33:02] Resolved in -mobel [21:33:05] -mobile even [21:33:34] He's going to work on an API query parameter to limit the images returned by action=parse&prop=images to non-maintenance ones [21:33:40] Should be fun [23:26:21] (03PS1) 10Gergő Tisza: Do not count Commons opt-ins as opt-outs [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/183392