[00:24:07] 3Multimedia, MediaWiki-File-management: More prominent display of other format available for download in image description pages - https://phabricator.wikimedia.org/T64305#956760 (10Tgr) >>! In T64305#953086, @RuchirangaW wrote: > I ran the project in debugging mode and looked line by line in execution as that p... [13:27:22] (03CR) 10Gilles: [C: 04-1] "Doesn't work in Firefox, the download menu flashes and disappears immediately. I think it might be that your code is competing with the pr" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (owner: 10Namit) [14:01:48] (03CR) 10Gilles: [C: 04-1] Add tests for mw.FormDataTransport (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 (owner: 10MarkTraceur) [14:06:08] Womp womp [14:12:37] 3Multimedia, MediaWiki-File-management: Add a wikitext keyword that controls whether animated GIFs are moving or still by default - https://phabricator.wikimedia.org/T85840#957345 (10Gilles) I think that improving video support (embedded video player instead of the current popup?) is a much worthier goal than tu... [15:11:57] (03PS3) 10MarkTraceur: Add tests for mw.FormDataTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 [15:12:02] Oops. [15:12:05] One sec. [15:12:51] (03CR) 10jenkins-bot: [V: 04-1] Add tests for mw.FormDataTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 (owner: 10MarkTraceur) [15:13:24] Actually I guess that works [15:13:28] After I fix npm of course [15:14:22] (03PS4) 10MarkTraceur: Add tests for mw.FormDataTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/182892 [15:25:58] 3MediaWiki-extensions-MultimediaViewer: Option to opt-out of media viewer won't stick. - https://phabricator.wikimedia.org/T85923#957410 (10Ikaruseijin) 3NEW [15:36:34] 3MediaWiki-extensions-MultimediaViewer: Option to opt-out of media viewer won't stick. - https://phabricator.wikimedia.org/T85923#957422 (10Gilles) I assume that you're not logged into Wikipedia when that happens, right? Just to clarify the report. [15:37:17] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Option to opt-out of media viewer won't stick. - https://phabricator.wikimedia.org/T85923#957424 (10Gilles) [15:37:20] 3Beta-Cluster, Multimedia, MediaWiki-extensions-Score: FileBackendException using tag on beta labs: No backend defined with the name 'global-multiwrite' - https://phabricator.wikimedia.org/T85049#957425 (10Gilles) [15:37:21] 3Multimedia, UI-Standardization, MediaWiki-extensions-MultimediaViewer: Misaligned icon on configuration button - https://phabricator.wikimedia.org/T85778#957428 (10Gilles) [15:37:23] 3Multimedia, MediaWiki-File-management: MW upload API file auto-extention voodoo - https://phabricator.wikimedia.org/T85708#957429 (10Gilles) [15:37:25] 3Wiki-Loves-Monuments-General, MediaWiki-extensions-UploadWizard, Multimedia: Upload Wizard for wlm campaign doesn't allow more IDs together - https://phabricator.wikimedia.org/T85520#957433 (10Gilles) [15:37:26] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: Make category suggestions case-insensitive - https://phabricator.wikimedia.org/T40785#957432 (10Gilles) [15:37:27] 3Multimedia, MediaWiki-Uploading, MediaWiki-Interface: User isn't allowed to upload, but there is no permission error - https://phabricator.wikimedia.org/T16688#957431 (10Gilles) [15:37:29] 3pywikibot-core, MediaWiki-File-management, Multimedia, MediaWiki-API: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#957434 (10Gilles) [15:37:30] 3Multimedia, MediaWiki-Uploading: No error handling for File::transform() in SpecialUpload::getDescriptionSection() - https://phabricator.wikimedia.org/T85409#957435 (10Gilles) [15:37:31] 3Multimedia, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#957436 (10Gilles) [15:37:33] 3MediaWiki-extensions-WikibaseRepository, Multimedia, Wikidata, MediaWiki-extensions-MultimediaViewer: Use MediaViewer on commonsMedia properties on Wikibase repo - https://phabricator.wikimedia.org/T71456#957437 (10Gilles) [15:37:35] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard form lacks edit tools - https://phabricator.wikimedia.org/T85111#957440 (10Gilles) [15:37:36] 3MediaWiki-extensions-UploadWizard, Multimedia: Layout of description field by UploadWizard form - https://phabricator.wikimedia.org/T85094#957439 (10Gilles) [15:37:38] 3MediaWiki-extensions-UploadWizard, Multimedia: Unspecified date entries from UploadWizard - https://phabricator.wikimedia.org/T85095#957442 (10Gilles) [15:37:39] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Viewing images in full screen removes scroll bar and sometimes disables scrolling. - https://phabricator.wikimedia.org/T85039#957443 (10Gilles) [15:37:41] 3MediaWiki-extensions-UploadWizard, Multimedia: Missing Hot-cat-like categorization support in UploadWizard - https://phabricator.wikimedia.org/T85097#957441 (10Gilles) [15:42:03] (03PS4) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [15:45:46] 3MediaWiki-Uploading: Show more concrete warning notices when blocking SVG upload - https://phabricator.wikimedia.org/T85924#957465 (10Perhelion) [15:53:22] 3MediaWiki-extensions-UploadWizard, MediaWiki-Uploading: SVG upload should have more specific error (warning) message when blocking - https://phabricator.wikimedia.org/T85924#957475 (10Perhelion) [16:21:23] (03CR) 10MarkTraceur: "Should be all good now" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 (owner: 10MarkTraceur) [16:21:30] Hm, maybe I should add tests to that. [16:36:04] 3MediaWiki-extensions-UploadWizard, MediaWiki-Uploading: SVG upload should have more specific error (warning) message when blocking - https://phabricator.wikimedia.org/T85924#957632 (10Legoktm) [16:38:13] (03PS5) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [16:38:19] (03PS6) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [17:36:53] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Option to opt-out of media viewer won't stick. - https://phabricator.wikimedia.org/T85923#957728 (10Ikaruseijin) No I am not logged in most times, I only made an account to complain about the Media Viewer, so I have no need to be. [17:39:42] * marktraceur wonders what to work on next. [17:39:48] I think we're out of marktasks for the sprint. [17:39:56] So refactoring. But *where*. [17:41:35] Oh, right, more transport tests. [17:48:13] would be nice to finish the UW browser tests that neilk had written [17:49:29] maybe your recent changes fixed the underlying issue, who knows [17:49:33] https://gerrit.wikimedia.org/r/#/c/163235/ [17:49:37] https://gerrit.wikimedia.org/r/#/c/163529/ [17:49:43] https://gerrit.wikimedia.org/r/#/c/163457/ [17:50:23] picking those 3 changesets up and making them work would be a nice win in test coverage [17:51:57] and the browser tests need further extending pretty badly. basically just pick all the regressions/bugs I found when testing your changesets by doing some manual usage of UW and turn that into a few tests [17:52:50] even just focusing on the core actions like uploading files, importing some from flickr, adding basic information would catch most of the regressions that have happened [17:54:21] there's also that as low-hanging fruit: https://gerrit.wikimedia.org/r/#/c/158887/ just needs a rebase [17:54:42] "just", considering all the refactoring you've done since :) [17:55:45] there's also that one of yours that needs some follow-up work https://gerrit.wikimedia.org/r/#/c/159625/ [17:59:04] Hm [17:59:37] I thought that was totally broken still, but I could look [18:00:16] I don't think I've done much with FlickrChecker though, the rebase should be simple(ish) [18:00:22] I'll do that and the browser tests today [18:00:32] After a quick look at IFT [18:30:12] 3MediaWiki-extensions-UploadWizard, MediaWiki-Uploading: SVG upload should have more specific error (warning) message when blocking - https://phabricator.wikimedia.org/T85924#957790 (10Aklapper) p:5Triage>3Low I guess it's also a security restriction to not run potentially malicious code. How would you reph... [18:43:26] Hrm. Messing with iframes is not going to work. [18:43:31] * marktraceur deletes last test suite [18:44:52] (03PS1) 10MarkTraceur: Add some basic tests for IframeTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183065 [18:45:29] 3Multimedia, MediaWiki-File-management: More prominent display of other format available for download in image description pages - https://phabricator.wikimedia.org/T64305#957822 (10RuchirangaW) >>! In T64305#956760, @Tgr wrote: > > Translatable strings are in the `languages/i18n` directory; you can find the in... [18:45:42] (03CR) 10jenkins-bot: [V: 04-1] Add some basic tests for IframeTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183065 (owner: 10MarkTraceur) [18:49:44] (03PS2) 10MarkTraceur: Add some basic tests for IframeTransport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183065 [18:54:42] Oh god I was wrong [19:01:42] (03PS4) 10MarkTraceur: Flickr: The community does not consider UW uploads verified [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ) [19:18:30] 3Multimedia, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#957909 (10Aklapper) p:5Triage>3Volunteer? [19:21:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user'sdecision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#957921 (10Aklapper) [19:21:31] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user'sdecision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#957410 (10Aklapper) p:5Normal>3Low [19:22:10] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user's decision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#957410 (10Aklapper) [19:30:24] 3Multimedia, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#957940 (10Reedy) a:3Reedy I think this was broken by the 14.04 upgrade. We need the freepats package installing [19:31:08] Looks like neilk had the same idea I did [19:31:18] I took out uploadToAdd and providedFile in one of the refactor commits [19:31:44] 3Multimedia, operations, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#957945 (10Reedy) p:5Volunteer?>3High [19:38:16] 3Multimedia, operations, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#957970 (10chasemp) I merged this based on my understanding of the problem and the fact that `freepats` is listed as "recommends` for timidity and our case seems to imply the need.... [19:42:22] (03PS1) 10MarkTraceur: Remove spurious uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183080 [19:42:39] Mine's better [19:42:47] Rebasing will be fun [20:08:29] (03Abandoned) 10MarkTraceur: fix spurious upload uis being created [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163235 (owner: 10Neilk) [20:10:46] I thought we stopped using Selenium [20:10:49] I guess I was wrong [20:53:56] Running the browser tests as we speak, we'll see how they do [21:00:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user's decision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#958186 (10Tgr) Thanks for taking the time to report this! > I always use https: connections, never anything else. I presume you always us... [21:08:37] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user's decision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#958200 (10MaxSem) Maybe, this stuff is just getting displaced out of LocalStorage by ResourceLoader? [21:11:49] 3Multimedia, operations, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#958202 (10Reedy) @crochet.david Can you try testing it again? :) I can't see anything obvious on https://fr.wikiversity.org/wiki/Recherche:Combinatoire_%26_pratique_instrumentale/... [21:15:01] (03PS6) 10Namit: Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 [21:22:59] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user's decision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#958232 (10Tgr) Theoretically, localStorage contents should not be displaced, the browser should just throw an exception if you are trying t... [21:27:32] 3Multimedia, operations, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#958236 (10Crochet.david) seem to be **work_for_me** [21:34:23] 3Wikimedia-Media-storage, Multimedia, MediaWiki-File-management, MediaWiki-extensions-UploadWizard: Uploadstash errors (tracking) - https://phabricator.wikimedia.org/T85568#958249 (10Tgr) [21:46:43] 3Multimedia, operations, MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#958263 (10Reedy) 5Open>3Resolved [22:15:47] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Anonymous user's decision to disable Media Viewer is forgotten after two weeks - https://phabricator.wikimedia.org/T85923#958308 (10Ikaruseijin) >>! In T85923#958186, @Tgr wrote: > Thanks for taking the time to report this! > >> I always use https: connections... [22:35:19] marktraceur: ready when you are [22:43:27] tgr: looks like your sentry role provisioned just fine. how can i verify that the mw extension is working? [23:06:12] My goodness vagrant is being laggy with selenium [23:06:33] I'm adding obscenely long timeouts to the use page. Enjoy. [23:07:57] (03PS3) 10MarkTraceur: lib for testing multiple uploads and 1 such test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163457 (owner: 10Neilk) [23:34:21] 3Multimedia, MediaWiki-File-management: Add support for thumbnails and interactive views of 3D models - https://phabricator.wikimedia.org/T54655#958518 (10Ricordisamoa)