[01:00:03] (03CR) 10Gergő Tisza: [C: 032] Add mw.mmv.viewer shortcut for current MediaViewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182151 (owner: 10Unicodesnowman) [01:01:03] (03Merged) 10jenkins-bot: Add mw.mmv.viewer shortcut for current MediaViewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182151 (owner: 10Unicodesnowman) [01:01:07] unicodesnowman: sorry, I missed the last update to that patch [01:01:51] (03PS8) 10Sn1per: Allow bold and italic text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182292 [01:01:51] just poke me on IRC / in mail if I don't respond to a patch within 3-4 hours [01:02:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Add mw.mmv.viewer to access the current MediaViewer instance - https://phabricator.wikimedia.org/T76923#950112 (10Tgr) 5Open>3Resolved a:3Tgr [01:04:30] (03CR) 10Gergő Tisza: [C: 032] Allow bold and italic text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182292 (owner: 10Sn1per) [01:05:17] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Relax formatting stripping for description - https://phabricator.wikimedia.org/T69887#950121 (10Sn1per) 5Open>3Resolved [01:05:25] (03Merged) 10jenkins-bot: Allow bold and italic text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182292 (owner: 10Sn1per) [01:15:54] 3Multimedia, MediaWiki-extensions-CommonsMetadata: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#950155 (10Sn1per) a:5Tgr>3Sn1per [01:46:44] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Measure how often users right-click the image in MediaViewer - https://phabricator.wikimedia.org/T75962#950192 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5815536596287488 [02:20:02] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Media viewer fails to give credit to all people in specific circumstances - https://phabricator.wikimedia.org/T68606#950211 (10Tgr) [02:26:36] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950218 (10Tgr) 5Open>3Resolved a:3Tgr As Umherirrender says, this is already possible. [02:27:11] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Click handler should be removed if MediaViewer fails to load - https://phabricator.wikimedia.org/T66527#950221 (10Tgr) [03:11:55] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950261 (10Jdlrobson) 5Resolved>3Open This should be preloaded. Original bug was reported because people were uploading images without this. [03:12:50] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Click handler should be removed if MediaViewer fails to load - https://phabricator.wikimedia.org/T66527#950263 (10Tgr) 5Open>3Resolved a:3Tgr Already done - the fail hanlder in `MultimediaViewerBootstrap.loadViewer()` sets the flag `MultimediaViewerBootst... [03:14:28] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950266 (10Tgr) [03:14:46] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#411389 (10Tgr) [03:21:36] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950271 (10Tgr) >>! In T38380#948860, @TheDJ wrote: > eTags on the content should also be able to handle this situation. Images use... [03:36:46] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950273 (10Tgr) 5Open>3Resolved Not sure what you mean exactly by preloaded, but `MediaWiki:Upload-default-description` will be used as the default value of the upload d... [03:58:03] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#950276 (10polybuildr) While the efficiency is a valid argument, the `UploadStashFile` class has the comment "Arguably UnregisteredLocalFile should be handling its own file repo but that class i... [04:49:26] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950283 (10MZMcBride) In my opinion, this is a situation where showing a loading icon or no image at all would be preferable to showi... [07:25:13] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#950369 (10Tgr) I think `UploadStashFile` should have the same logic as `LocalFile` (except for the memcached layer): have private properties for all [[ https://www.mediawiki.org/wiki/Manual:Upl... [07:46:15] (03CR) 10Gergő Tisza: [C: 032] Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [07:47:07] (03Merged) 10jenkins-bot: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [08:11:10] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950382 (10Tgr) Going to the file page linked from the description (I haven't visited it before) and looking up the request for the t... [08:21:49] (03PS1) 10Namit: Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 [08:22:02] (03CR) 10jenkins-bot: [V: 04-1] Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 (owner: 10Namit) [08:22:46] so when i try to uplaod a flickr image via the uploadwiz/flickr, it fives an error as "http" what does that mean marktraceur [08:27:44] (03PS2) 10Namit: Open the download panel when an image is right clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182353 [10:25:10] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950492 (10TheDJ) So either we add "Cache-control: must-revalidate" and get a lot more hits on the backend, or we need to change the... [10:27:05] 3Multimedia, MediaWiki-extensions-UploadWizard: Selecting many/multiple (>7?) files at once: Some are missing in the batch - https://phabricator.wikimedia.org/T41902#950494 (10Aklapper) p:5High>3Normal [10:55:18] 3Parsoid, MediaWiki-File-management, Multimedia: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#950509 (10Subfader) Some JS scripts in extensions rely on the image name as they grab it to pass it to the API or thumb.php. So if this comes, please make sure to provide the pro... [14:40:41] OK I'm going to try to be productive today [14:42:44] It will probably work [14:42:49] I feel less sick on average [16:27:55] 3Multimedia, MediaWiki-extensions-UploadWizard: Test step controllers - https://phabricator.wikimedia.org/T78792#950909 (10MarkTraceur) 5Open>3Resolved [17:32:35] tgr|away, meeting? Or are we skipping? [17:37:31] I'm going to go with we're skipping it. [17:45:09] * marktraceur closes window [17:52:34] :P [18:12:52] marktraceur: do you have some time to help a humble nooblet [18:13:13] GEOFBOT: I love helping nooblets! Shoot :) [18:13:29] lemme make a gerrit to show you what i'm doin [18:13:36] Cool cool. [18:14:46] marktraceur: ugh sorry, I must have misconfigured my alarm clock :( [18:14:58] tgr: No problem [18:15:12] tgr: Basically I'm going to work on refactoring the transports some more, I have no critical bugs [18:15:32] I tried to repro that flickr bug, doing so now in -tech, but no luck so far [18:15:48] (03PS1) 10Sn1per: Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [18:16:11] (03PS2) 10Sn1per: Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [18:16:48] marktraceur: I finished the sentry vagrant but apart from that mostly worked on GCI and bug organization in the last 3 days so pretty much the same tasks as last week [18:17:17] tgr: Do you need bd808 to review your vagrantization? [18:17:22] marktraceur, tgr: I tried to put in a check to see if the tempalte was alone and was on the blacklist, but it doesn't work :P [18:17:25] btw GCI goes really well but I'm running out of task ideas so if you have anything please send it [18:17:38] Eh, I'll keep it in mind, but I'm not sure I can help [18:17:57] marktraceur: yes, either him or ori [18:18:25] or dduvall [18:18:55] (03PS3) 10Sn1per: [WIP] Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [18:19:01] In *theory* releng owns mw-v now [18:19:19] GEOFBOT: unset( $group ) probably won't work, loop through the array with its keys and use unset( $data[$key] ) maybe? [18:19:34] hmmm [18:19:58] GEOFBOT: IIRC foreach ( $data as $key => $group ) { [18:19:59] marktraceur: also, I need someone from the frontend team / RL maintainers to look at https://phabricator.wikimedia.org/T85263 and https://phabricator.wikimedia.org/T85262 and tell me if I can go forward with those [18:20:10] Ooh, I pretend to be a frontend programmer [18:20:12] Er. [18:20:23] am* [18:21:16] marktraceur: these are actually backend tasks :) [18:21:29] Ah. [18:21:33] they just have to do with JS loading [18:21:43] I don't think there's actually an SoS today. [18:21:49] But maybe Roan can look at these. [18:21:57] ah, ok, didn't know that [18:22:15] it's not particularly urgent anyway [18:24:21] GEOFBOT: as marktraceur said, unsetting a reference will not unset the original, it will just make the variable cease to be a reference [18:26:14] ok [18:26:20] I made the change [18:26:24] I have a test image on vagrant [18:26:36] that has a book template [18:26:41] but the API result has no fields from it [18:27:03] so I think there is something wrong somewhere else [18:28:49] 3Multimedia, MediaWiki-extensions-UploadWizard: Make the transports mostly independent, and add tests for them - https://phabricator.wikimedia.org/T85629#951140 (10MarkTraceur) 3NEW a:3MarkTraceur [18:29:46] Oh, wow, the FDT might actually be set to be tested now. [18:29:57] Crazypants [18:31:43] AuldLangTraceur: folks are in the SoS hangout :) [18:33:16] (03CR) 10Gergő Tisza: [C: 04-1] "It's a bit confusing that a method called sortInformationGroups removes some of the groups... I'd rather see this happen in a separate met" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 (owner: 10Sn1per) [18:33:42] bd808: Yeah, but I reaally don't have much to say, go on without me [18:34:19] *nod* it's an etherpad edit session of boredom at the moment [18:36:26] Heh [19:05:03] GEOFBOT: does the same API query work for other local images? [19:05:19] I think so [19:05:36] it returns the corresponding data [19:05:36] for non-local images, it would just forward the request to the Commons API [19:06:41] by no fields you mean, no extmetadata property at all? [19:07:00] what query did you use exactly? [19:09:32] http://golf620-linux.local:8080/w/api.php?action=query&titles=File:Dna.jpg&prop=imageinfo&iiprop=extmetadata [19:09:37] it has all the fields [19:09:40] and data [19:09:47] but with my bad code [19:09:52] the book template data did not show up at all [19:14:19] sinon.js is cool [19:14:47] GEOFBOT: Can you look at the file page for dna.jpg and show us what it looks like? Maybe the format is off somehow. [19:15:46] bd808|LUNCH: I have a question about Vagrant. Whenever I try to save a JS file, vim tells me it can't open the file for writing. Usually the second attempt works fine. Is this a known issue or something weird about my setup? [19:15:53] AuldLangTraceur: http://pastebin.com/fJxLBVWt [19:16:09] GEOFBOT: I meant the HTML [19:16:12] But this is helpful too [19:16:14] oh [19:16:53] There are the relevant fileinfotpl_ id's present [19:17:16] OK, that's a good thing I suppose [19:17:29] If I take off my modifications and comment out the part about blacklists in the code, then the book fields appear [19:23:43] AuldLangTraceur, tgr I think I fixed it maybe? [19:24:35] (03PS4) 10Sn1per: [WIP] Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [19:25:43] AuldLangTraceur: I haven't seen that, but I also generally edit from the host computer side [19:25:52] Hm. [19:25:55] bd808|LUNCH: So am I [19:26:24] bd808|LUNCH: At first I thought it was a sync operation just happening to hit me when I was saving the file, but that seems unlikely [19:27:03] yeah. it sounds weird. So it's like your NFS share is locking all the files on the host side so something? [19:27:20] Something like that, I guess [19:27:48] You should try with nfs shares disabled and see if it makes any difference [19:28:48] `vagrant config nfs_shares no; vagrant reload` if you want to try that [19:31:38] Will do [19:36:46] GEOFBOT: are you familiar with using xdebug? [19:37:02] I heard of it but I haven't tried it before [19:37:03] it's a good tool for such problems [19:37:21] what editor are you using? [19:37:47] emacs [19:38:46] https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#Emacs_with_geben [19:39:59] it's worth learning, it's a huge help when debugging server-side code [19:42:12] tgr: could you check the newest patchset [19:42:14] it seems to work [19:42:19] but I don't knwo if it's just me :o [19:50:41] GEOFBOT: well, adding a unit test is a good way of checking it [19:51:43] just find a Commons page with a single book template (there is one linked in the bug report I think), grab the HTML source with action = render, add it to the test sources, then verify that the fields are there [19:52:16] the trendy thing to do these days is actually to do that before you start writing the code [19:52:38] https://en.wikipedia.org/wiki/Test-driven_development [19:53:02] Well, one trendy thing. [20:57:42] hippies [21:10:13] That's us :) [21:33:41] 3MediaWiki-extensions-MultimediaViewer, Multimedia, MediaWiki-General-or-Unknown: Port mmv.performance.js to core - https://phabricator.wikimedia.org/T67605#951276 (10matmarex) [21:40:29] 3MediaWiki-extensions-UploadWizard: UploadWizard: Make category suggestions case-insensitive - https://phabricator.wikimedia.org/T40785#951287 (10matmarex) [21:41:19] 3MediaWiki-extensions-UploadWizard: UploadWizard: Make category suggestions case-insensitive - https://phabricator.wikimedia.org/T40785#469654 (10matmarex) `getCategoriesByPrefix()` has no business caring about case sensitivity, the underlying API is case-sensitive by design. UploadWizard should use something li... [21:51:44] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Add scroll metadata open/close events to dashboards - https://phabricator.wikimedia.org/T78797#951321 (10Tgr) [21:54:39] 3MediaWiki-File-management, Multimedia: thumb.php redirection broken when there is no 404 handler - https://phabricator.wikimedia.org/T58926#951335 (10Tgr) [21:56:09] 3MediaWiki-extensions-GWToolset, Multimedia: Operational issues for very large TIFFs - https://phabricator.wikimedia.org/T67217#951352 (10Tgr)