[00:06:39] <tgr>	 bd808: can I use a hiera key in a puppet template without defining it as a parameter for the class?
[00:06:45] <tgr>	 (also, should I? :)
[00:06:59] <tgr>	 I thought scope.lookupvar is for that but it doesn't seem to work
[00:07:23] <bd808>	 Yeah. Something has to pull it from hiera into the puppet scope first
[00:08:02] <bd808>	 Generally I think it probably should be a param on the class owning the template somehow.
[00:08:41] <bd808>	 which you may realize in hiera by assigning the value of another variable is that's all that is needed
[00:09:16] <bd808>	 but in general things in hiera don't exist to puppet until something asks for a param that has not had a value provided
[00:11:35] <tgr>	 thx
[02:27:32] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: Backport MediaViewer to MediaWiki 1.23 LTS - https://phabricator.wikimedia.org/T85193#941137 (10Tgr) 3NEW
[04:50:40] <grrrit-wm1>	 (03PS2) 10Namit: MultimediaViewer usable on Special file related pages when enabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 
[13:59:55] <wikibugs>	 3MediaWiki-File-management, Multimedia: SVG thumbnail is empty when < than 800px - https://phabricator.wikimedia.org/T78820#941589 (10Perhelion)
[14:52:08] <wikibugs>	 3MediaWiki-File-management, pywikibot-core, MediaWiki-API: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#941740 (10Anomie) p:5Triage>3Low
[18:00:37] <wikibugs>	 3MediaWiki-File-management, Multimedia: During media storage failure, MW will still move image pages despite not being able to move the file causing inconsistency - https://phabricator.wikimedia.org/T71312#942032 (10jeremyb)
[18:01:20] <wikibugs>	 3Multimedia, MediaWiki-File-management: Cleanup after Swift outage - https://phabricator.wikimedia.org/T77705#942041 (10jeremyb)
[18:04:39] <wikibugs>	 3Multimedia, MediaWiki-File-management: Cleanup after Swift outage - https://phabricator.wikimedia.org/T77705#942051 (10Tgr)
[18:07:08] <grrrit-wm>	 (03PS3) 10Gergő Tisza: MultimediaViewer usable on Special file related pages when enabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 (owner: 10Namit)
[18:07:31] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Small coding convention fixes." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 (owner: 10Namit)
[18:14:38] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer should ignore generated captions on special pages - https://phabricator.wikimedia.org/T85234#942056 (10Tgr)
[18:14:56] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch, Namit!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 (owner: 10Namit)
[18:15:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: MultimediaViewer usable on Special file related pages when enabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 (owner: 10Namit)
[18:19:10] <grrrit-wm>	 (03CR) 10Namit: "Thanks for the merge, Gergő. Looking forward to contributing more to the WMF." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181441 (owner: 10Namit)
[18:39:45] <tgr>	 bd808: are you familiar with how the multiwiki apache config works in vagrant?
[18:40:04] <bd808>	 I was when I wrote it ;)
[18:40:17] <tgr>	 can you help me out with https://gerrit.wikimedia.org/r/#/c/181606/ ?
[18:41:02] <tgr>	 I'm trying to add sentry.local.wmftest.net for sentry, and it works when curling from the VM but curling sentry.local.wmftest.net:8080 from the outside just brings me to the wiki
[18:41:49] <tgr>	 I don't understand how that happens since the devwiki apache config starts with ServerAlias *.wiki.local.wmftest.net
[18:41:58] <bd808>	 hmm...
[18:42:16] <tgr>	 and the scholarship project uses the same setup
[18:43:40] <bd808>	 why would curl get different answers on the VM and off?
[18:50:40] <bd808>	 tgr: spinning up a test vm now. I'll see if I can figure out the apache weirdness
[18:51:22] <tgr>	 bd808: curl -vH 'Host: sentry.local.wmftest.net' 'http://10.11.12.32' works from outside
[18:51:38] <tgr>	 curl -v 'http://sentry.local.wmftest.net:8080' does not
[18:51:56] <tgr>	 so somehow the port forward must confuse it
[19:09:47] <bd808>	 tgr: So I added the role on a new testing vm and it seems to work. -- https://phabricator.wikimedia.org/P176
[19:10:16] <bd808>	 And going to http://sentry.local.wmftest.net:9999/ in my browser gives me the sentry login screen
[19:10:31] <bd808>	 the port number is weird because of my testing vm
[19:17:46] <tgr>	 bd808|LUNCH: thanks for checking!
[19:18:05] <tgr>	 I'll check with a clean VM, maybe something got messed up while I was developing the role
[19:18:30] <bd808|LUNCH>	 could be. puppet can leave weird crap laying around sometimes
[19:25:40] <tgr>	 eh
[19:25:49] <tgr>	 the port was stolen by another VM
[19:25:54] <tgr>	 so stupid
[20:55:05] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "This fixes the issue with the description on the file page, but the caption in the suggested wikitext on the success page still contains a" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur)
[21:07:03] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Add tests for mw.fileApi (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur)
[21:43:59] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: Add scroll metadata open/close events to dashboards - https://phabricator.wikimedia.org/T78797#942442 (10Tgr)
[21:55:32] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Fix URLs from stat1001.wikimedia.org to datasets.wikimedia.org [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/181685 
[21:56:22] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032 V: 032] "Self-merge, trivial change which should fix the dashboards which are currently broken." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/181685 (owner: 10Gergő Tisza)
[22:57:20] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Add tests for tutorial step object (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur)
[23:13:58] <wikibugs>	 3MediaWiki-Uploading, Multimedia: [REGRESSION] i18n fallback uses message from i18n file before message from db. - https://phabricator.wikimedia.org/T57473#942575 (10Tgr) a:5Tgr>3None
[23:14:56] <wikibugs>	 3MediaWiki-extensions-CommonsMetadata, Multimedia: Information template fields can contain lots of complex HTML - https://phabricator.wikimedia.org/T59383#942576 (10Tgr) a:5Tgr>3None
[23:15:18] <wikibugs>	 3MediaWiki-File-management, Multimedia: thumb.php redirection broken when there is no 404 handler - https://phabricator.wikimedia.org/T58926#942577 (10Tgr) a:5Tgr>3None
[23:17:12] <wikibugs>	 3MediaWiki-extensions-CommonsMetadata, Multimedia: No proper handling of multivalued fileds - https://phabricator.wikimedia.org/T59259#942580 (10Tgr) a:5Tgr>3None
[23:18:30] <wikibugs>	 3MediaWiki-extensions-UploadWizard, Multimedia: UW fails to load with "Unknown error: "unknown".", js error - https://phabricator.wikimedia.org/T67958#942583 (10Tgr) 5Open>3Resolved >>! In T67958#701205, @Tgr wrote: > We might want to check how this could happen in the first place; IIRC the code always passe...
[23:18:42] <wikibugs>	 3MediaWiki-extensions-CommonsMetadata, Multimedia: Multilang mode should always return a list of languages - https://phabricator.wikimedia.org/T59846#942586 (10Tgr) a:5Tgr>3None
[23:22:38] <grrrit-wm>	 (03PS7) 10Gergő Tisza: Turn mmv-next/mmv-prev into OO events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[23:22:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Turn mmv-next/mmv-prev into OO events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[23:22:49] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: Make event passing between LightboxInterface and MultimediaViewer non-global - https://phabricator.wikimedia.org/T77253#942596 (10Tgr) a:5Tgr>3None
[23:23:05] <wikibugs>	 3MediaWiki-extensions-CommonsMetadata, Multimedia: "commons-metadata" is indicated as a source for categories even when they are not from commons - https://phabricator.wikimedia.org/T59260#942599 (10Tgr) a:5Tgr>3None
[23:23:28] <wikibugs>	 3MediaWiki-extensions-CommonsMetadata, Multimedia: "commons-metadata" is indicated as a source for categories even when they are not from commons - https://phabricator.wikimedia.org/T59260#614706 (10Tgr) p:5Low>3Volunteer?
[23:27:43] <wikibugs>	 3MediaWiki-File-management, Multimedia: Extmetada is inaccessible on Commons files - https://phabricator.wikimedia.org/T58598#942601 (10Tgr) 5Open>3declined Wontfixing, extmetadata/CommonsMetadata will be superseded and this bug would only be a problem if it started using new data sources.
[23:27:44] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: License Info for Media Viewer - https://phabricator.wikimedia.org/T58143#942603 (10Tgr)
[23:30:40] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "Just a nitpick." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[23:41:41] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur)
[23:42:45] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "On second thought, not -1-worthy." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[23:42:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add unit tests for details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181075 (owner: 10MarkTraceur)
[23:42:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur)
[23:44:49] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 (owner: 10MarkTraceur)
[23:44:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 (owner: 10MarkTraceur)
[23:49:26] <wikibugs>	 3MediaWiki-extensions-UploadWizard, Multimedia: Refactor details UI code so it's less repetitive and nasty - https://phabricator.wikimedia.org/T76388#942615 (10Tgr) I assume this is not testable so it can be moved to accepted.