[00:17:04] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#846522 (10Tgr) 5Invalid>3Resolved Thanks Luis and TheDJ! (Due to the various caches involved, this might take about two days to take effect.) [00:33:02] 3MediaWiki-extensions-MultimediaViewer, Multimedia, Security-Reviews: Security review - https://phabricator.wikimedia.org/T77494#846533 (10Krenair) [06:53:20] 3MediaWiki-extensions-MultimediaViewer, Multimedia, Security-Reviews: Security (self-)review of MediaViewer - https://phabricator.wikimedia.org/T77494#846693 (10Tgr) [08:07:52] (03PS1) 10Gergő Tisza: Calculate image cache miss ratio [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/179771 [08:52:57] (03PS1) 10Gergő Tisza: Add plural support to mwe-upwiz-campaign-media-count-desc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179774 [09:11:52] (03PS2) 10Gergő Tisza: Calculate image cache miss ratio [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/179771 [10:23:00] (03PS1) 10Gergő Tisza: Calculate image cache miss ratio [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/179778 [15:48:07] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#846866 (10Lokal_Profil) This was suggested [[ https://commons.wikimedia.org/wiki/Template_talk:Cc-by-sa-layout#Wrong_short_name | before ]] but never went ahead as no confirmation could be gotten from th... [18:22:14] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#846903 (10Tgr) >>! In T78433#846866, @Lokal_Profil wrote: > This was suggested [[ https://commons.wikimedia.org/wiki/Template_talk:Cc-by-sa-layout#Wrong_short_name | before ]] but never went ahead as no... [18:28:15] (03PS1) 10Gergő Tisza: Make sure spaces in CC license shortnames are handled correctly [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/179785 [23:01:10] (03PS1) 10Gergő Tisza: Replace unneeded empty() calls [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/179860 [23:08:55] 3MediaWiki-extensions-CommonsMetadata: Don't use PHP empty() - https://phabricator.wikimedia.org/T78451#847086 (10Tgr) In most of those snippets, the code does test for a combination of the array field being unset and being the empty string. I think empty( $informationData['Artist'] ) && empty( $informationD... [23:11:16] 3MediaWiki-extensions-CommonsMetadata: Don't use PHP empty() - https://phabricator.wikimedia.org/T78451#847087 (10aaron) There are cases where empty() is fine. One example is checking boolean flags that may or may not be set. In this case, we want to check if strings are not empty. empty() doesn't work well si...