[02:48:08] 3Analytics, MediaWiki-extensions-MultimediaViewer, Multimedia: Compare file page edit counts pre- and post-MediaViewer - https://phabricator.wikimedia.org/T78364#843392 (10Tgr) 3NEW [03:38:40] (03CR) 10Krinkle: Replace Firefogg callbacks with OOJS events (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178210 (owner: 10MarkTraceur) [07:14:26] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#843643 (10Eloquence) Interestingly, the mobile lightbox doesn't exhibit this behavior - does it purge the history entries? I still see it as one of... [08:22:01] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#843799 (10Tacsipacsi) [09:35:00] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#843952 (10Gilles) It doesn't happen for every image, very odd: http://en.wikipedia.beta.wmflabs.org/wiki/MediaViewerE2ETest#mediaviewer/File:Multimedia_Team_-_W... [10:07:57] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#843997 (10Gilles) The oddness continues, in Chrome the following API request gives me a response without expected fields (thumburl, etc.): http://en.wikipedia.b... [10:10:16] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#843998 (10Gilles) p:5High>3Low Lowering the priority since this seems to only have happened on beta for that specific image. This sort of failure could happe... [11:13:12] (03CR) 10Gilles: [C: 04-1] "Using firefox pointed at beta, I get a failure at the very end:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179216 (owner: 10Cmcmahon) [11:24:11] 3MediaWiki-extensions-UploadWizard, Multimedia: Flickr import broken - https://phabricator.wikimedia.org/T78387#844074 (10Gilles) 3NEW a:3MarkTraceur [11:29:13] 3MediaWiki-extensions-UploadWizard, Multimedia: Flickr import broken - https://phabricator.wikimedia.org/T78387#844084 (10Gilles) It was caused by https://gerrit.wikimedia.org/r/#/c/171855/ [11:29:29] (03CR) 10Gilles: "Broke flickr import: https://phabricator.wikimedia.org/T78387" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/171855 (owner: 10MarkTraceur) [11:31:25] (03CR) 10Gilles: "The Flickr issue is actually happening on master... T78387 I'll revisit all the changesets you have pending review once Flickr is fixed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 (owner: 10MarkTraceur) [11:52:12] (03CR) 10Gilles: [C: 04-1] "I find the inconsistent placement of the warning a bit startling:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178141 (owner: 10Gergő Tisza) [11:57:57] (03CR) 10Gilles: Display warning for licence/attribution problems (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178141 (owner: 10Gergő Tisza) [15:21:11] *yawn* OK Flickr, prepare to be destroyed [15:30:53] (03CR) 10Cmcmahon: "I'm trying to get rid of the sleep(), but it might not be possible. For some reason the Next button on the Describe page simply doesn't wo" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179216 (owner: 10Cmcmahon) [15:56:23] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#844370 (10Cmcmahon) As of today, Chrome no longer sees any title metadata for the page at http://en.wikipedia.beta.wmflabs.org/wiki/MediaViewerE2ETest Whatever... [17:25:12] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#844444 (10Tgr) >>! In T78317#843997, @Gilles wrote: > The oddness continues, in Chrome the following API request gives me a response without expected fields (thu... [17:26:17] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Small" download option no longer works in Chrome & IE11 - https://phabricator.wikimedia.org/T78317#844448 (10Tgr) >>! In T78317#844370, @Cmcmahon wrote: > As of today, Chrome no longer sees any title metadata for the page at http://en.wikipedia.beta.wmflabs.or... [17:59:52] (03PS1) 10MarkTraceur: Fix Flickr import bug due to change in newUpload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179500 [18:00:09] gi11es: That was quite the chase. [18:01:07] (03CR) 10jenkins-bot: [V: 04-1] Fix Flickr import bug due to change in newUpload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179500 (owner: 10MarkTraceur) [18:06:51] Argh [18:07:00] Liar [18:07:23] (03PS2) 10MarkTraceur: Fix Flickr import bug due to change in newUpload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/179500 [18:47:51] gi11es: greg-g this morning beta labs was accidentally badly misconfigured. We pretty much re-started every service, and now https://phabricator.wikimedia.org/T78317 seems to be fixed afaict, after having been broken for days. [21:08:57] tgr: Hello! I was going to make the edit to {{information}} per https://commons.wikimedia.org/wiki/Template_talk:Information#Fake_machine_readable_data, then I thought: Do we want to do the same for the description field, in addition to author and source? [21:31:53] (03PS12) 10Cmcmahon: QA: WIP update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [21:45:11] (03PS13) 10Cmcmahon: QA: WIP update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [21:56:58] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#845021 (10LuisV_WMF) 3NEW [22:03:13] (03PS14) 10Cmcmahon: QA: WIP update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [22:14:13] (03PS15) 10Cmcmahon: QA: update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [22:18:22] (03PS16) 10Cmcmahon: QA: update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [22:30:02] (03CR) 10Cmcmahon: "OK, I think I finally nailed all the edge cases in this one, made it efficient, and removed the sleep(). The key was to wait for the defau" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 (owner: 10Cmcmahon) [22:38:33] Quick question, multimedia folks. [22:38:34] https://phabricator.wikimedia.org/T78433 [22:38:36] This task ^ [22:38:41] Is it easy for you guys to fix quickly? [22:38:53] And, if it is, will you do it? [22:39:01] * marktraceur looks [22:39:26] God, Luis is a fussy neckbeard. [22:39:36] If the answer is no then that's fine, I just want to know whether to tell my devs to put a quick hack in the apps to fix it on our end until it's fixed upstream :) [22:39:40] It's probably not hard. [22:39:43] I will look. [22:41:18] I think I know where it is. [22:41:29] It's probably in CMD, he's right [22:41:58] I think it's line 110 in LicenseParser.php in CommonsMetadata [22:42:01] $data['type'] = implode( '-', array_slice( $parts, 0, $i ) ); [22:42:09] I'll submit a patch right quick [22:42:22] But, I have no way to test my change, so ;) [22:42:25] Thank you :) [22:42:44] You'll have to listen to me belt out alt-country until then. [22:42:51] SHE'S MY BEST GIRL, SHE'S GOT SIX STRINGS [22:43:02] Oh, dear. [22:43:11] Hush guillom [22:43:15] :P [22:43:23] Six strings that were imploded into a single string? :) [22:44:06] Feel bad for my neighbours. [22:47:02] My gods, vagrant is slow [22:51:42] Deskana: I see where the change needs to be made, just want to test it [22:52:07] marktraceur: The default config only gives it 2 cores and 1G ram. I give my main vm 6 cores and 2G to speed it up. [22:52:26] Well...yeah [22:52:32] * marktraceur should probably fix that [23:04:12] Vagrant really hates complicated templates. [23:06:36] OK [23:06:41] I'm going to test this and see if it works [23:06:45] By having Jenkins test it. [23:07:17] (03PS1) 10MarkTraceur: Fix CC license names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/179568 [23:07:48] If it fails, it passes. [23:08:32] marktraceur: You are a gentleman and a scholar. [23:09:13] Well, Jenkins hasn't gotten back to us, wait for it. [23:09:25] It looks sane enough to me. [23:09:25] Also, I don't know if that will work very well for non-CC licenses [23:09:29] So, it will probably fail. ;) [23:09:32] GFDL, PD, etc. [23:09:49] Plus, we need an intrepid team member who isn't me to merge it [23:10:05] Details. ;) [23:10:48] Good news is, we can SWAT it in 49 minutes...oh, wait. [23:11:28] It doesn't feel so urgent to need to be SWATed to me. [23:11:37] Yeah [23:11:43] I would, if it weren't Friday [23:11:51] Just to appease Luis [23:14:58] (03CR) 10jenkins-bot: [V: 04-1] Fix CC license names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/179568 (owner: 10MarkTraceur) [23:18:11] Yay [23:18:20] Now to see *how* it broke. [23:18:30] Oh, dear. [23:18:51] See, this is why we test things [23:20:43] Deskana: which field are you using? [23:21:27] Incoming java: [23:21:30] String licenseStr = ""; [23:21:30] if (currentGalleryItem.getMetadata().containsKey("LicenseShortName")) { [23:21:30] licenseStr = currentGalleryItem.getMetadata().get("LicenseShortName"); [23:21:31] } else if (currentGalleryItem.getMetadata().containsKey("License")) { [23:21:33] licenseStr = currentGalleryItem.getMetadata().get("License"); [23:21:35] } [23:21:41] LicenseShortName. [23:21:46] But that's not what I screwed with. [23:21:57] Let me know if that's the wrong field to use. [23:22:03] LicenseShortName comes straight from the template [23:22:07] Right. [23:22:19] Deskana: I guess you should ask Commons to "fix" their template [23:22:25] ^_^ [23:22:28] I'll say so on the task and resolphe it. [23:22:39] (03Abandoned) 10MarkTraceur: Fix CC license names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/179568 (owner: 10MarkTraceur) [23:22:40] it's mostly the right field to use, but if you don't like it's value, you have to fix in Commons or at the client side [23:22:53] Yeah, fair enough. [23:23:20] Thank you, gentlemen. :) [23:23:23] License will only be set for a few recognized licenses, and it is intended to be a message key [23:23:30] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#845147 (10MarkTraceur) 5Open>3Invalid a:3MarkTraceur This text comes from the template on Commons. You'll need to request or execute a change on http://commons.wikimedia.org/wiki/Template:cc-by-sa-... [23:24:15] in MediaViewer we use License first, it matches the WikimediaMessages extension keys IIRC, and fall back to LicenseShortName [23:24:43] um, no, actually, we used to do that, but only use ShortName now [23:24:45] I think [23:24:49] let me check [23:25:25] Yeah, but we're hopeless. [23:26:18] License first, with custom message keys, then LicenseShortName [23:26:27] var message = 'multimediaviewer-license-' + ( this.internalName || '' ); [23:26:30] if ( mw.messages.exists( message ) ) { [23:26:32] return mw.message( message ).text(); [23:26:35] } else { [23:26:37] return this.shortName; [23:26:40] } [23:27:39] anyway, human-readability was not a criteria for License [23:31:04] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#845171 (10LuisV_WMF) Where does it come from in the template? Just the name, or... ? (I assume we can't have a space in the template name?) [23:31:52] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#845172 (10Tgr) The master templates to fix would be [[https://commons.wikimedia.org/wiki/Template:Cc-by-layout | Cc-by-layout ]] and [[ https://commons.wikimedia.org/wiki/Template:Cc-by-sa-layout | Cc-by... [23:34:06] 3MediaWiki-extensions-CommonsMetadata: CC-BY-SA should be CC BY-SA - https://phabricator.wikimedia.org/T78433#845185 (10Tgr) >>! In T78433#845171, @LuisV_WMF wrote: > Where does it come from in the template? Just the name, or... ? (I assume > we can't have a space in the template name?) It's the `