[08:29:00] (03PS1) 10Gergő Tisza: File page loading times are not experimental any more [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/176638 [13:50:14] gi11es: SHA-1 patch!!! [13:50:21] * marktraceur grins [13:52:33] (03CR) 10MarkTraceur: Replace hash characters in basename (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [14:09:07] tgr|away: Huh, it looks like # isn't in $wgIllegalFileChars [14:09:10] How silly [14:13:24] (03PS2) 10MarkTraceur: Replace hash characters in basename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 [14:16:28] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Re-enable Media Viewer from a file page - https://phabricator.wikimedia.org/T76033#796301 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur OK then! :) [15:18:06] (03CR) 10Gilles: [C: 04-1] Move makePreviewsFlag out of UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [15:23:09] (03CR) 10Gilles: [C: 032] Rough logging of metadata panel scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175622 (owner: 10Gergő Tisza) [15:25:11] (03CR) 10Gilles: [C: 032] Remove superfluous parseInt() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174097 (owner: 10TheDJ) [15:25:32] (03Merged) 10jenkins-bot: Remove superfluous parseInt() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174097 (owner: 10TheDJ) [15:25:40] (03CR) 10Gilles: [C: 032] File page loading times are not experimental any more [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/176638 (owner: 10Gergő Tisza) [15:31:50] (03CR) 10Gilles: "> Uses $wgIllegalFileChars which doesn't *actually* include the hash character." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [15:39:11] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Display "and X more authors" when appropriate - https://phabricator.wikimedia.org/T74082#798458 (10Gilles) [15:50:22] (03CR) 10Gilles: [C: 032] Parse {{Nuke}} templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176510 (owner: 10Gergő Tisza) [15:53:28] (03CR) 10Gilles: [C: 032] Add tests for verifyAttributionMetadata() [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176511 (owner: 10Gergő Tisza) [15:54:05] I'm going to be difficult to reach today [15:54:08] I have to deal with my car [15:54:11] It is dead. RIP. [15:54:33] Well, it's not dead, but I'm not paying $1500 to fix it. [15:58:33] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Re-enable Media Viewer from a file page - https://phabricator.wikimedia.org/T76033#798485 (10Gilles) The Mingle ticket wasn't left open accidentally, this is still waiting for the hard-to-write tests to be merged. Can be a separate task, though. [15:59:34] (03CR) 10Gilles: [C: 032] Show "and X more authors" when a file has multiple info templates [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/176226 (owner: 10Gergő Tisza) [16:05:36] (03Merged) 10jenkins-bot: Show "and X more authors" when a file has multiple info templates [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/176226 (owner: 10Gergő Tisza) [16:20:17] (03CR) 10Gilles: [C: 032] Refactor information template parsing to better support multiple templates (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176215 (owner: 10Gergő Tisza) [16:20:33] (03Merged) 10jenkins-bot: Refactor information template parsing to better support multiple templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176215 (owner: 10Gergő Tisza) [16:20:38] (03Merged) 10jenkins-bot: Parse {{Nuke}} templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176510 (owner: 10Gergő Tisza) [16:20:41] (03Merged) 10jenkins-bot: Add tests for verifyAttributionMetadata() [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176511 (owner: 10Gergő Tisza) [16:21:48] (03PS9) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [16:21:54] 3Multimedia, MediaWiki-extensions-CommonsMetadata: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#798522 (10Gilles) [16:22:11] 3Multimedia, MediaWiki-extensions-CommonsMetadata: Add fallback classes for information fields in TemplateParser - https://phabricator.wikimedia.org/T75332#798524 (10Gilles) [16:31:52] (03CR) 10Gilles: [C: 04-1] Move makePreviewsFlag out of UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [16:34:45] 3Multimedia, MediaWiki-extensions-UploadWizard: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#798534 (10Gilles) [16:37:49] gi11es: So hard to please [16:38:44] (03PS10) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [16:42:37] (03CR) 10Gilles: [C: 032] Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [16:42:58] Yayyyy [16:43:00] (03CR) 10Gilles: "Needs manual rebase, gerrit can't do it" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [16:44:03] (03Merged) 10jenkins-bot: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [16:46:25] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Set up MediaViewer sooner on page load when the URL contains #mediaviewer / an image is clicked - https://phabricator.wikimedia.org/T76300#798543 (10Gilles) p:5Triage>3Low [16:49:07] (03PS5) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [16:49:47] (03CR) 10jenkins-bot: [V: 04-1] Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [16:49:58] Curse you Jenkins [16:50:45] (03PS6) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [16:54:11] (03CR) 10Gilles: [C: 04-1] Add heading field to UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176029 (owner: 10MarkTraceur) [16:55:50] (03CR) 10jenkins-bot: [V: 04-1] Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [16:56:55] (03PS4) 10MarkTraceur: Add heading field to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176029 [16:57:41] (03PS7) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [16:58:17] (03CR) 10Gilles: [C: 032] Add heading field to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176029 (owner: 10MarkTraceur) [16:58:26] <3 [16:59:04] (03Merged) 10jenkins-bot: Add heading field to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176029 (owner: 10MarkTraceur) [17:02:57] (03CR) 10Gilles: Close panel on canvas click + fullscreen mouseleave (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 (owner: 10Gergő Tisza) [17:03:31] I guess I could start piling up more refactoring patches now. [17:03:47] Maybe try to make form management a bit easier...adding the heading field was a bit hard [17:07:39] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "You need to attribute the author" is wrong in case of CC0/Public Domain files - https://phabricator.wikimedia.org/T70687#798581 (10Gilles) Is there an easy way to test those changes that combine a CommonsMetadata and Media Viewer update on beta? It seems like... [17:07:59] yes there's a lot of redundant code there that could be made more generic [17:08:32] and it would be nice to check why the altitude one is like that. maybe there was an input for it at some point? seems like useful information to automatically pull from EXIF as well [17:10:54] There was one, yes [17:11:08] why was it removed? [17:15:57] (03CR) 10Gilles: [C: 032] Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [17:16:14] (03PS2) 10Gilles: Make fileChangedOk a little more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/171842 (owner: 10MarkTraceur) [17:16:41] (03Merged) 10jenkins-bot: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [17:18:04] 3Multimedia, MediaWiki-extensions-UploadWizard: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#798609 (10Gilles) [17:18:42] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#798610 (10Gilles) Gergo, could you provide a beta URL where this can be tested? [17:28:02] (03CR) 10Gilles: [C: 032] Make fileChangedOk a little more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/171842 (owner: 10MarkTraceur) [17:28:24] gi11es: I don't know...I'll check git blame [17:28:30] (03CR) 10Gilles: [C: 04-1] "Needs rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/171855 (owner: 10MarkTraceur) [17:28:45] (03Merged) 10jenkins-bot: Make fileChangedOk a little more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/171842 (owner: 10MarkTraceur) [17:28:52] 40651b9bccb6ce4bf9615c1ba59f95254d8e1c66 [17:28:55] thedj did it. [17:29:06] The altitude doesn't validate on rational numbers [17:29:14] Altitude is not a supported option of the commons location templates [17:29:50] I guess the question then is, why does Commons care about heading and not altitude? [17:30:13] I guess... [17:30:24] gi11es: They probably care more about where the camera is pointing than how high up it was [17:30:32] But at the same time, it might be time to suggest support. [17:30:40] And I built rational number support in too [17:30:46] thedj might know [17:30:49] At least partly. [17:32:13] http://markmail.org/message/r32setivn2wuzqyt#query:+page:1+mid:yvdhu6vivr3d6j5x+state:results [17:32:46] Aw, maplebed. [17:33:16] http://markmail.org/message/r32setivn2wuzqyt#query:+page:1+mid:wlwvfchiya6ser7n+state:results [17:33:25] So I could uncomment it and stick it in. [17:36:49] yep [17:38:35] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Analyze Media Viewer metrics following release of final improvements - https://phabricator.wikimedia.org/T76028#798642 (10Gilles) [17:40:43] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Let users collapse a description by clicking on it again, after expanding it - https://phabricator.wikimedia.org/T76029#798645 (10Gilles) https://gerrit.wikimedia.org/r/#/c/172550/ https://gerrit.wikimedia.org/r/#/c/175182/ https://gerrit.wikimedia.org/r/#/c/17... [17:58:05] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "You need to attribute the author" is wrong in case of CC0/Public Domain files - https://phabricator.wikimedia.org/T70687#798683 (10Tgr) >>! In T70687#798581, @Gilles wrote: > Is there an easy way to test those changes that combine a CommonsMetadata and Media V... [18:10:44] 3Multimedia, MediaWiki-File-management: SVG client side rendering - https://phabricator.wikimedia.org/T5593#798701 (10Tfinc) [18:42:37] (03CR) 10Gergő Tisza: Refactor information template parsing to better support multiple templates (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/176215 (owner: 10Gergő Tisza) [18:53:00] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Fix browser tests for MediaViewer options menu to work with phantomjs - https://phabricator.wikimedia.org/T76368 (10Tgr) 3NEW p:3Normal a:3Tgr [18:54:06] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Re-enable Media Viewer from a file page - https://phabricator.wikimedia.org/T76033#798869 (10Tgr) [19:05:37] 3MediaWiki-extensions-GWToolset, Multimedia: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#798899 (10JeanFred) [19:48:49] (03CR) 10Gergő Tisza: "Needed a final push." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175622 (owner: 10Gergő Tisza) [19:49:34] (03CR) 10Gergő Tisza: [C: 032 V: 032] File page loading times are not experimental any more [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/176638 (owner: 10Gergő Tisza) [19:59:59] (03CR) 10Gergő Tisza: "Stuck in CI limbo apparently." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175622 (owner: 10Gergő Tisza) [20:15:50] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#799075 (10Tgr) [20:21:14] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#799077 (10Tgr) The reason the HTML and plaintext attribution differs is that the code is slightly different: creditParams.push( this.htmlUtils.htmlToText( info.imageInfo.licens... [20:25:58] (03PS1) 10Gergő Tisza: Fix inconsistencies in attribution text * use the same text for plain and HTML format * use the same text whether or not a deed URL is set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/176731 [20:30:57] (03CR) 10jenkins-bot: [V: 04-1] Fix inconsistencies in attribution text * use the same text for plain and HTML format * use the same text whether or not a deed URL is set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/176731 (owner: 10Gergő Tisza) [21:01:40] gi11es, tgr|away, we decided a while ago not to do oojs-ui in UW, does that decision still make sense? [21:04:00] I think most of the interface code I want to refactor in UW is probably already written in OOJSUI [21:04:42] marktraceur: We even have a progress bar now. ;-) [21:05:26] James_F: Fancy dancy! [21:05:37] The thing I want to do first is the details page, though [21:05:40] Forms forms forms [21:05:49] marktraceur: cscott wanted on, so MatmaRex did it for him in a few seconds. [21:05:55] Forms should work just fine. [21:05:58] … he ays. [21:06:00] +s [21:06:01] Bah. [21:06:14] ayss [21:06:23] ftfy. [21:06:33] As in "Damn, look at that ayss" [21:06:50] * James_F sighs. [21:07:07] James_F: Sorry. [21:07:18] marktraceur: Insufficiently, clearly. [21:09:38] Well yes. [21:21:06] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Re-enable Media Viewer from a file page - https://phabricator.wikimedia.org/T76033#799207 (10Tgr) [21:23:37] (03PS2) 10Gergő Tisza: Fix inconsistencies in attribution text * use the same text for plain and HTML format * use the same text whether or not a deed URL is set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/176731 [21:27:37] 3MediaWiki-extensions-MultimediaViewer, MediaWiki-extensions-UploadWizard: Refactor details UI code so it's less repetitive and nasty - https://phabricator.wikimedia.org/T76388 (10MarkTraceur) 3NEW p:3Normal a:3MarkTraceur [21:27:51] (03PS1) 10MarkTraceur: Refactor creation of text fields a bit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176793 [21:28:27] 3MediaWiki-extensions-MultimediaViewer, MediaWiki-extensions-UploadWizard: Refactor details UI code so it's less repetitive and nasty - https://phabricator.wikimedia.org/T76388#799225 (10MarkTraceur) https://gerrit.wikimedia.org/r/176793 [21:29:50] (03CR) 10jenkins-bot: [V: 04-1] Refactor creation of text fields a bit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176793 (owner: 10MarkTraceur) [21:30:18] ...wat [21:31:23] (03PS2) 10MarkTraceur: Refactor creation of text fields a bit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176793 [21:59:43] (03PS1) 10MarkTraceur: Further refactor of location fields [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176803 [22:00:31] (03CR) 10jenkins-bot: [V: 04-1] Further refactor of location fields [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/176803 (owner: 10MarkTraceur) [22:00:35] 3MediaWiki-extensions-MultimediaViewer, MediaWiki-extensions-UploadWizard: Refactor details UI code so it's less repetitive and nasty - https://phabricator.wikimedia.org/T76388#799370 (10MarkTraceur) https://gerrit.wikimedia.org/r/176803 [22:01:12] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard refactoring - https://phabricator.wikimedia.org/T76040#799378 (10MarkTraceur) [22:17:05] marktraceur: let's talk about it during the weekly meeting [22:17:13] KK [22:17:30] the context has changed indeed now that the polyfills are in, that breaking changes are proactively being fixed for us in media viewer, etc. [22:18:17] Yeah [22:51:10] (03CR) 10Gergő Tisza: Replace hash characters in basename (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [22:55:01] (03CR) 10MarkTraceur: Replace hash characters in basename (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [23:04:13] everytime I read "polyfills", I picture the tub of http://dashboard.lepageproducts.com//upload/english/product/LePage-Poly-Filla-Big-Hole.jpg [23:21:40] (03CR) 10Gergő Tisza: "The actual list of illegal characters is everything that is either included in $wgIllegalFileChars or does not match $wgIllegalFileChars. " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [23:22:57] tgr|away: $wgLegalFileChars? Also how stupid is that. [23:32:42] (03CR) 10Gergő Tisza: Replace hash characters in basename (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/175860 (owner: 10MarkTraceur) [23:56:41] marktraceur: regarding altitude [23:57:57] it was failing on those rational numbers (which were almost always rational), and since it was in the collapsed part, ppl were not able to notice that the validator was marked failing. [23:58:34] which is annoying if you haven't actually filled something into that box yourself, but EXIF scraper filled it in FOR you [23:59:07] so auto extraction, which didn't pass the validator, which wasn't visble to the user ==== lots of frustration, quickest solution, turn it off.