[09:46:44] (03CR) 10Gilles: [C: 04-1] "When I pick 2 files with my file picker, only 1 gets added to the UI and uploaded." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [10:10:34] (03Abandoned) 10Gilles: Revert layout changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170804 (owner: 10Gilles) [10:11:31] (03PS1) 10Gilles: Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171521 [10:14:37] (03CR) 10Gilles: [C: 032] Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171521 (owner: 10Gilles) [10:15:19] (03Merged) 10jenkins-bot: Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171521 (owner: 10Gilles) [10:22:14] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata throws undefined index warnings - 10https://bugzilla.wikimedia.org/73076 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Notice: Undefined index: informationFields in /vagrant/mediawiki/extensions/CommonsMetadata/DataCollector.php on line 115... [16:09:00] (03CR) 10MarkTraceur: "...huh. Weird." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [19:32:40] Lol, I love it when I see media viewer links in the wild [19:33:05] ...huh, three files also collapse into one. wtf [19:33:05] So, apparently, do thirty. [19:33:16] Ugh wtf [19:33:22] it's a recent regression in the history of that changeset [19:33:23] Yeah, but I can't figure out why [19:33:23] I guess I'll try diffing patchsets [19:33:23] Sigh. [19:33:23] gi11es: Pretty sure it's just the movement of checkFile, but it *should* be getting called now [19:33:23] Still no luck [19:33:23] At least, the file-changed event is getting sent up from the new UWUI [19:33:34] Something very strange is happening. [19:33:34] OH [19:33:34] HERP [19:33:34] The connect() for forwarding the event only happens when the UWUI object already exists [19:33:34] So the signal gets lost because the emit() is fired during construction [19:33:34] BRILLIANT [19:33:46] (03PS1) 10Gilles: Action schema update [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/171560 [19:33:46] (03CR) 10Gilles: [C: 032] Action schema update [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/171560 (owner: 10Gilles) [19:33:46] (03Merged) 10jenkins-bot: Action schema update [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/171560 (owner: 10Gilles) [19:34:30] (03PS1) 10Pginer: Align text and icons on the grey area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171571 [20:30:56] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Accept files whose names are invalid MediaWiki titles - 10https://bugzilla.wikimedia.org/64912 (10James Forrester) 5PATC>3RESO/FIX [20:38:43] 3MediaWiki / 3Uploading: Chunked upload of SVGs triggers INVALIDXML exception, but file is valid - 10https://bugzilla.wikimedia.org/65724#c10 (10Brad Jorsch) 5PATC>3RESO/FIX The fix should be deployed to WMF wikis with 1.25wmf8, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. [20:41:56] 3MediaWiki / 3Uploading: Should not throw errors towards the JS error console if invalid title is specified - 10https://bugzilla.wikimedia.org/64922 (10James Forrester) 5PATC>3RESO/FIX [21:18:55] (03PS9) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [21:18:55] *bloody* hell I hate computers [21:29:13] marktraceur: Now, now. Computers ain’t so bad. They may be a bit dumb at times, but they’re usually more honest than humans. So I recommend following guillom ’s advice to “make the robots happy" :) [21:29:53] Oh, all too happy to do that [21:29:53] :) [21:30:00] The robots don't seem to like me too much today though [21:32:27] gi11es: Aaron says the SHA1 thing needs a rebase, will +1 once it's ready [21:37:53] (03PS10) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [21:46:18] (03PS7) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [21:46:25] (03PS7) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [21:49:26] (03PS4) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [21:49:31] (03PS3) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [22:13:41] (03CR) 10jenkins-bot: [V: 04-1] Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [22:13:50] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [22:14:54] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [22:15:18] (03CR) 10jenkins-bot: [V: 04-1] Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [22:15:27] (03CR) 10jenkins-bot: [V: 04-1] Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 (owner: 10MarkTraceur) [23:09:39] fabriceflorin: the en.wp Media Viewer RfC has been closed as no consensus to re-affirm June's RfC [23:09:43] You're getting an email [23:10:24] Keegan: Thanks for the heads-up. Let me check the email, and respond after I check it and the RfC.