[00:32:13] 3MediaWiki extensions / 3TimedMediaHandler: Support upload of audio-only WebM files (Vorbis audio track but no video) - 10https://bugzilla.wikimedia.org/72996 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Currently the WebM handling seems to assume there will be a video stream; however .webm file... [00:58:41] 3MediaWiki / 3File management: Support for Opus audio format - 10https://bugzilla.wikimedia.org/40193#c6 (10Brion Vibber) (In reply to Marco from comment #4) > Opus can now be forced into the OGG container, but the Wiki servers have > problems detecting the codec. Also playback is limited in some browsers >... [08:14:05] pginer: could you review https://gerrit.wikimedia.org/r/#/c/169785/ ? [08:55:50] tgr regarding the general behaviour, ellipsis didn’t appear when I opened an image the first time. Only when I scrolled up and down. [08:55:57] Once they appeared, behaviour was good. [08:56:49] Regarding styling I’d like to adjust for the different sizes the text size, line-height, margins and the size of the ellipsis. [08:57:14] Can I do those changes now, or is there a risk of change conflicts? [08:58:21] sure, just tell me when you are done [08:59:33] if you want a different number of sizes, you can adjust the styles option of the new mw.mmv.ui.TruncatableTextField... lines in metadataPanel.js [08:59:40] ok [09:10:29] (03CR) 10Gilles: [C: 04-1] Move showTooManyFilesWarning to the wizard object (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [09:27:45] tgr, I found font styles for sizes in two different places metadataPanel.less and truncatableTextField.less [09:27:50] which is the difference? [09:28:04] and how are they related? [09:39:40] I tried to adjust the font sizes on metadataPanel.less, but it no longer picks the right size when the text becames too big to fit in the given space [09:39:53] I need more information on how the different sizes are chosen [09:44:11] I don’t know how to adjust the size and padding of the different sizes for the title wihout it breaking (Media Viewer picking the wrong size). So I’ll add the comments on gerrit in case it helps [10:00:08] (03CR) 10Pginer: "I would keep the scroll to expand behaviour, viewing the full caption is expected to be the most common piece of information users may loo" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [10:00:51] tgr, I added my comments to the patchset [10:40:43] (03PS1) 10Gilles: [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 [10:41:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles) [10:43:12] (03PS2) 10Gilles: [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 [10:43:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles) [11:15:25] 3MediaWiki extensions / 3MultimediaViewer: Overlapping text and buttons at disable popup for long translations - 10https://bugzilla.wikimedia.org/72862#c1 (10Florian) In production, too :/ https://de.wikipedia.org/wiki/Android_%28Betriebssystem%29#mediaviewer/File:Android_Logo_%282014%29.svg [13:06:10] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c6 (10Cacycle) I have spent two days on a workaround and I am stuck. The problem seems to be related to mw.EmbedPlayer and mw.TimedText giving loading errors, s... [14:47:11] (03PS7) 10Gergő Tisza: [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [14:47:40] (03CR) 10Gergő Tisza: "fix for style issues" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [14:47:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [14:48:01] pginer: updated the styles, you can re-review if you want [14:55:26] 3MediaWiki / 3File management: Display file format of preview if different format from original file - 10https://bugzilla.wikimedia.org/56546#c7 (10Andre Klapper) Could any of you imagine being a mentor for this task in Google Code-in 2014? See https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/07... [15:04:10] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c7 (10Michael Dale) If you take a look at the loader handles the embedding of players against a video tag: https://git.wikimedia.org/blob/mediawiki%2Fextension... [15:06:26] 3MediaWiki / 3Uploading: UploadBase::checkWarnings could throw exception on null object access - 10https://bugzilla.wikimedia.org/38222#c9 (10Andre Klapper) Would anybody be willing to be a mentor for fixing the existing patch as part of Google Code-in 2014? If yes, could you add it to https://www.mediawiki... [15:30:10] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c8 (10Cacycle) Thanks Michael! Unfortunately, because of the problem described in comment 6, embedPlayer does not work, because mw.EmbedPlayer and mw.TimedText... [15:42:43] 3MediaWiki extensions / 3UploadWizard: ConfirmCloseWindow should be in core - 10https://bugzilla.wikimedia.org/59215#c5 (10Andre Klapper) mtraceur wrote that "is done but for the code review" but I don't see any link to Gerrit here? Removing "easy" etc. [15:47:59] (03PS6) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [15:48:06] Dumb mistakes are dumb [16:04:45] (03PS8) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [16:05:28] (03CR) 10jenkins-bot: [V: 04-1] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [16:08:54] (03PS9) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [16:11:24] (03CR) 10Gergő Tisza: "Ripped out most tests, I can get them to pass locally, Jenkins is probably using a different browser. With something as browser-dependent " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [16:14:16] (03PS4) 10Gergő Tisza: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 [16:16:20] tgr: marktraceur: any vacation in sight this coming sprint? [16:16:29] Not for me [16:16:36] I think tgr is off tomorrow and Friday. [16:16:58] and next Monday [16:18:22] thanks [16:18:37] what was the rationale for getting rid of the description below the fold if the caption is used up top? [16:19:06] that there is often an overlap in the contents [16:19:14] ok [16:19:37] did pginer ever answer whether he want to keep the autoexpand on scroll or not? [16:19:46] *wants [16:20:00] he said he does [16:20:13] yes, I’m adjusting the font sizes now [16:20:46] cool [16:20:54] I've put the latest changes on alpha for demoing purposes [16:21:06] I'll update that again if you get other updates in before the meeting [16:23:34] (03CR) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [16:23:52] (03CR) 10Gergő Tisza: "Could you truncate the timestamp to avoid making the file identifiable?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles) [16:28:00] we are getting the second complaint now on the MMV talk page about the disable link missing [16:28:13] Pffftahahaha [16:28:33] next time we should probably leave something in the old location for a few weeks explaining where the new location is [16:29:24] (03PS10) 10Pginer: [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [16:30:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [16:30:12] (03CR) 10Gilles: [C: 04-1] "The warning works, but I see this ugly error when it appears:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [16:30:26] done with the adjustments, it would be great to have it in alpha to try with many different images [16:31:16] I have a feeling you just undid gergo's last changes [16:31:22] since qunit failures are back into the picture [16:31:25] those are probably based on an older version, I'll merge [16:32:05] oh, gerrit [16:34:15] if this is complex to fix, you can just revert my patch and apply changes manually. I compiled my changes here: http://etherpad.wikimedia.org/p/mmv-text-size-changes [16:34:57] Uh oh. [16:35:08] no worries, I can just diff them with the old version and apply the difference [16:35:30] are you sure about the @height - (@vertical-padding/2) thing though: [16:35:34] ? [16:35:48] tgr: marktraceur: any pressing bugs to add to the meeting's agenda? [16:36:19] Nothing on my end, no [16:37:07] gi11es: no emergencies but https://bugzilla.wikimedia.org/show_bug.cgi?id=72044 has been going on for a while [16:37:23] pdf rendering failing for some people for some files [16:37:26] tgr, if I keep the bottom adding part of the 3rd line shows [16:37:29] non-WMF installs [16:38:08] My goal is to: provide some paddign around the text, keep it centered and use a big enough font. [16:38:10] gi11es: and https://bugzilla.wikimedia.org/show_bug.cgi?id=72862 is a minor style issue with a recent card [16:39:10] tgr, you can remove the height adjustment and try to look for a way to avoid part of the 3rd line to appear [16:39:16] (03PS7) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [16:39:23] I’m ok with any solution to that [16:40:04] gi11es: I'm not going to be able to make the meeting this week, I have an offline thing that just came up. Long of the short: structured data newsletter went out, minor interest/questions from that. Still waiting to see what happens with en.wp's 90th RfC, annnnddddddd that's about it. Tgr already mentioned new complaints on mw.org about MMV but I haven't had time to sit down and get to those. [16:40:22] thanks Keegan [16:40:54] in case Pau has some free time, https://www.mediawiki.org/w/index.php?title=Extension_talk%3AMedia_Viewer%2FAbout&diff=1246750&oldid=1246611 had some interesting MMV design comments [16:41:21] I’ll take a look [16:44:56] (03PS3) 10Gilles: [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 [16:45:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles) [16:51:31] (03PS11) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [16:51:53] (03PS5) 10Gergő Tisza: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 [16:52:14] (03CR) 10Gilles: [C: 04-1] "When I pick more files than allowed, I now get this weird error: https://www.dropbox.com/s/1li4k7c5yl537bm/Screenshot%202014-11-05%2017.51" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [16:54:29] pginer: so license in the middle is the conclusion of that debate? [16:54:43] the latest version doesn't have it moving anymore [16:54:46] Ugh [16:55:37] I'll fix it after the meeting. [16:55:55] I don’t know why it changed [16:55:56] gi11es: not sure that's intentional [16:56:14] actually, not sure it will stay that way after merging to master [16:56:42] I think these patches are just based on an older version of master and Pau's adjustments were done elsewhere [16:56:59] the regression happened in the last couple of commits [16:57:07] I was seeing the animation before [16:58:05] like, when I was running the version prior to your last tweak and pau's [17:02:31] tgr: waiting for you on google hangout [17:02:39] I'm there [17:20:53] tgr, can you look to my screen for a sec? [17:21:06] pginer: looking [17:21:18] some text is missing [17:21:32] if I resize window, fixes [17:22:10] I can get the image name and the screen size if it helps [17:23:12] yeah, the screen size would help [17:24:29] whole browser window was: 1263x789 [17:24:58] 3MediaWiki extensions / 3UploadWizard: Upload wizard should verify syntax of user input fields - 10https://bugzilla.wikimedia.org/73032 (10Jarek Tuszynski) 3NEW p:3Unprio s:3normal a:3None Upload wizard should verify syntax of user input fields to make sure they will not brake the template. See for e... [17:26:29] “page” size (discounting Chrome’s chrome) was: 1263x716 [17:26:58] (that is, the viewport) [17:28:25] pginer: thanks, I can reproduce [17:29:14] great [17:45:28] (03PS3) 10Gergő Tisza: Replace filename with caption/description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169719 [17:45:37] (03PS12) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [17:45:44] (03PS6) 10Gergő Tisza: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 [17:47:20] gi11es: the animation works now, but I still need to fix the bug Pau pointed out above [17:59:02] tgr: Was the animation fixed on alpha? I am not seeing the license animate to the right when I open the metadata panel on my end [18:08:12] fabriceflorin: no [18:08:17] should I update it? [18:16:47] tgr: Yes, it would be great if you could update it, if it’s easy to do. Like this, we can see the whole user experience on alpha, all in one place. What’s the bug that Pau pointed out? [18:27:05] gi11es: FYI, I just created Mingle card #979 for the Disable panel bug in German, which seems like a really high priority to me: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/979 (corresponds to Bugzilla ticket https://bugzilla.wikimedia.org/show_bug.cgi?id=72862 ) [18:32:21] fabriceflorin: done [18:34:06] Thanks, tgr . Does that include the bug that Pau pointed out? FYI, I’m now adding a few captions on alpha, so we can see how they work side-by-side with descriptions in the featured pictures gallery. [18:34:20] no [18:40:44] (03PS8) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [18:49:44] gi11es: QA asked about https://bugzilla.wikimedia.org/show_bug.cgi?id=69362 in SoS, do you know anything? Is this the Swift missing files bug? [18:50:01] tgr: OK, thanks. In this version, are we removing the description below the fold in all cases? I thought we were going to keep the description below when it is not used at the top. [18:55:18] marktraceur: no idea about those [18:55:27] K [18:57:09] some of them seem to have magically reappeared, I've seen that happen on some of those bug reports [18:57:17] Yay. [18:57:44] maybe the other ones too, if we wait long enough... ;) [18:59:42] That's the spirit [18:59:59] gi11es: It's marked as a dependency on us by QA, so we should at least be aware [19:02:13] how is it affecting them? [19:03:53] Dunno, I guess they discovered the issue [19:12:32] fabriceflorin: yes [19:12:45] that's #895 [19:14:49] tgr: It looks like #895 was changed, because when I wrote it I had recommended keeping the description below the fold if we are showing the caption. Like this, the user can get more info without having to jump to a separate page. And it makes good use of all the empty space on the left of the metadata panel. How much work would it be to still show that description below when we are not showing it above, if we [19:14:50] wanted to make that tweak? [19:17:15] fabriceflorin: we wouldn't merge this patch then [19:17:27] should I remove it from alpha? [19:19:41] tgr: I think the idea was to only remove the description if we are showing it above the fold, so we don’t duplicate it. But we would keep it when we are showing the caption of the file name. How much work would it be to do this conditional display, if we wanted to? [19:23:30] fabriceflorin: pretty sure that wasn't the original idea, the first version of this card already talks about removing the description [19:23:46] anyway, if we don't want that, we shouldn't merge the patch, that's zero work [19:25:23] tgr: OK, let’s remove the patch for now, and let me talk to Pau about this. Would it be hard to only remove the description when it duplicates the info above? [19:27:03] if you mean not using the description on two places when there is no caption, then we just need to not merge the patch for that to happen [19:27:20] if you mean recognizing that the caption and the description is the same, that would be hard [19:28:23] tgr: OK, that would be great. It sounds like this would address my concern. I am not proposing to do pattern recognition, just not to show the same field twice. [19:29:37] So it would be wonderful if you could remove the patch now on alpha, before I send this to Erik for review. I will make a note about the rationale for this in my email. [19:30:04] done on alpha [19:44:24] tgr: thanks, much appreciated! This seems like a real improvement to me. I will bring up the trade-offs in my email, which I plan to send right after lunch. [19:44:54] tgr: Thanks for ploughing through these last changes. I hope you have a great time off. :) [20:18:43] ...so much scroll back... [20:28:04] (03PS13) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [20:28:11] (03PS7) 10Gergő Tisza: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 [21:44:26] 3MediaWiki extensions / 3MultimediaViewer: Overlapping text and buttons at disable popup for long translations - 10https://bugzilla.wikimedia.org/72862#c2 (10Fabrice Florin) Hi se4598 and Florian: Thank you both for reporting this issue! We plan to address it [21:45:57] 3MediaWiki extensions / 3MultimediaViewer: Overlapping text and buttons at disable popup for long translations - 10https://bugzilla.wikimedia.org/72862#c3 (10Fabrice Florin) We plan to address this issue as a top priority in this week's spring, and are tracking it here on our development planning site on Min... [22:34:41] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c9 (10Cacycle) For this reason, the code from mw.PopUpThumbVideo.js never reaches "return false", the default click action is not suppressed, and a new player w...