[03:50:11] 3MediaWiki / 3File management: .htaccess causing problems! - 10https://bugzilla.wikimedia.org/72868#c4 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #1) > Thanks for taking the time to report this! > > https://releases.wikimedia.org/mediawiki/1.23/mediawiki-1.23.6.tar.gz does > not inclu... [06:40:26] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044 (10Andre Klapper) 5UNCO>3NEW [06:40:43] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c7 (10Andre Klapper) 5UNCO>3RESO/DUP Thanks! Marking as duplicate then - let's continue in bug 72044. *** This bug has been marked as a duplicate of bug 72044 *** [06:40:43] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c12 (10Andre Klapper) *** Bug 72349 has been marked as a duplicate of this bug. *** [08:37:26] 3MediaWiki / 3File management: Ability to give a reason when deleting old image revision - 10https://bugzilla.wikimedia.org/7535#c6 (10Andre Klapper) 5PATC>3RESO/FIX Closing again per comment 3 - comment 5 was a mistake. [10:06:55] marktraceur: I'm pretty sure that flickr import just works with the default vagrant config [10:08:07] yup, the UW role has what's needed [10:12:39] (03CR) 10Gilles: [C: 032] Cast UploadWizardErrorFlowEvent.message to string [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [10:13:19] (03Merged) 10jenkins-bot: Cast UploadWizardErrorFlowEvent.message to string [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [10:14:10] (03CR) 10Gilles: "Did you miss my inline comments from my previous review pass?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [10:52:22] (03PS1) 10Gilles: Don't generate outdated versus graph anymore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170675 [10:52:25] (03PS1) 10Gilles: Delete ancien perf queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170676 [10:52:28] (03PS1) 10Gilles: Switch duration data to ImageMetrics [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170677 [11:09:27] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c5 (10Cacycle) p:5Unprio>3Normal s:5enhanc>3normal I think that encapsulation of the PopUpMediaTransform in a load event handler is indeed the problem h... [12:52:04] (03PS1) 10Gilles: Remove old versus graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/170686 [12:52:56] (03CR) 10Gilles: "Soft-depends on https://gerrit.wikimedia.org/r/#/c/170675/" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/170686 (owner: 10Gilles) [13:24:28] gi11es: Ugh, well, I guess I have no excuse [13:59:33] (03CR) 10Gergő Tisza: [C: 032] Don't generate outdated versus graph anymore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170675 (owner: 10Gilles) [13:59:40] (03Merged) 10jenkins-bot: Don't generate outdated versus graph anymore [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170675 (owner: 10Gilles) [14:00:32] (03CR) 10Gergő Tisza: [C: 032] Delete ancien perf queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170676 (owner: 10Gilles) [14:00:38] (03Merged) 10jenkins-bot: Delete ancien perf queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170676 (owner: 10Gilles) [14:05:17] (03CR) 10Gergő Tisza: [C: 032] Switch duration data to ImageMetrics [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170677 (owner: 10Gilles) [14:05:22] (03Merged) 10jenkins-bot: Switch duration data to ImageMetrics [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/170677 (owner: 10Gilles) [14:06:58] (03CR) 10Gergő Tisza: [C: 032] Remove old versus graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/170686 (owner: 10Gilles) [14:09:18] (03CR) 10Gergő Tisza: [V: 032] Remove old versus graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/170686 (owner: 10Gilles) [14:16:52] gi11es: I deployed the changes to limn, but didn't deploy the analytics sql changes since those files are under your user account [14:17:09] I've just rebuilt the tsvs [14:17:18] those are quick to generate [14:18:00] cool, I'll move the card then [14:18:07] already did :) [14:18:23] we should see the results in 15 minutes or so [14:19:01] from what I saw when I was running the queries, they made sense (faster than the old document event) [14:19:17] but they seemed a bit bumpy, I look forward to visualizing that [14:19:31] should I revert the metadata panel changes? [14:19:45] what fabrice talked about? [14:19:46] they are deployed to Commons tomorrow noon-ish IIRC [14:19:48] yes [14:20:10] no, I think pginer made some good points that fabrice needs to answer first [14:20:26] I don't like this kind of knee-jerk reaction [14:20:34] we can always backport if it comes to that [14:20:58] yeah, he overreacted a bit [14:21:44] but let's not forget the Tuesday morning SWAT is the last chance to revert before it goes to Commons [14:21:52] sure [14:56:18] the top graph has updated, I believe: http://multimedia-metrics.wmflabs.org/dashboards/mmv#media_viewer_vs_file_page-graphs-tab [14:58:52] the file page population size is tiny [14:59:21] oh, that's only the logged-in population size [14:59:39] yes, loggedin sampling is too low [15:00:45] and the MV population has a crazy spike on Friday [15:06:04] population size on the mmv_enwiki dashboard is two magnitudes larger than on the mmv dashboard, so there must be some sort of bug in calculating that [15:33:14] (03CR) 10MarkTraceur: "Sorry about that! Incoming." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [15:33:24] (03PS11) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:23:06] marktraceur: I don't think that "empties" is used anymore, is it? [16:23:24] Uh [16:23:26] * marktraceur checks [16:23:34] Good call [16:24:18] (03PS12) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:33:03] marktraceur: acutally I've just realized now, it doesn't make sense to show the copy button if there's just one successful upload [16:33:07] you need at least 2 [16:33:10] the old code had > 1 [16:33:13] Ahhh. [16:33:18] * marktraceur can do a ternary thing [16:33:31] just could the successful uploads [16:33:36] and > 1 like before [16:33:42] count, not could [16:34:22] (03PS13) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:34:28] Oops, fail [16:34:48] (03PS14) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [16:39:20] (03CR) 10Gilles: [C: 032] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [16:39:54] (03Merged) 10jenkins-bot: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [16:40:04] (03PS15) 10Gilles: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:40:12] \o/ refactor [16:40:39] http://www.reactiongifs.com/r/2013/05/Ron-Paul_Its-Happening1.gif [16:41:24] Hahaha [16:41:34] ^ new icon for the UploadWizard refactor project in phab [16:42:43] Not that I'm using that at all. [16:46:26] marktraceur: why not have an empty definition of updateFileCounts in the base step class? [16:46:49] this way there won't be a need to add an if() at every invocation and potentially forget one [16:48:20] Sure [16:50:54] (03PS16) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:51:52] (03CR) 10Gilles: Move updateFileCounts to the upload controller (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:52:03] pretty minor stuff [16:52:05] KK [16:54:48] (03PS17) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:55:18] {{done}} gi11es. [16:55:25] Rapid-fire CR, lovin' it [16:55:33] I'm giving it a spin right now [16:55:42] testing flickr and so on [16:55:46] Coolio [16:59:42] (03CR) 10Gilles: [C: 04-1] "Uploaded 2 flickr imports + one regular file, went through the whole process, then clicked on the button to upload new files, got this:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:59:52] Ugh [17:01:11] a wild pokemon appears! [17:12:06] gi11es: Hm, I get an X-Frame-Options error with Flickr. [17:12:14] Probly my fault. [17:21:55] 3MediaWiki extensions / 3MultimediaViewer: [Javascript bug]: Some image descriptions (class mv-mmv-author) show "[object Object]" - 10https://bugzilla.wikimedia.org/66564#c7 (10Erik Moeller) This is still happening, e.g. on this file: https://en.wikipedia.org/wiki/Guglielmo_Marconi#mediaviewer/File:Guglielmo... [17:27:07] I...don't get this [17:27:29] can't reproduce the bug I've experienced? [17:27:36] I reproduced it [17:27:40] I just don't understand why [17:32:20] Probably filled-filelist [17:34:21] Hm, nope [17:37:21] Close though [17:37:30] (03PS18) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [17:37:36] gi11es: Resetting state in the UI now. [17:37:43] Or...better. [18:07:40] (03CR) 10Gilles: [C: 04-1] "More of the same:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [18:08:54] Huh. [18:28:54] Sigh, guess I have to tell the controller when uploads are removed [18:29:19] Oh, I do. [18:32:31] tgr: how far are you into fixing pau's concerns on the second commit in the chain? [18:32:35] Well...wtf. [18:33:30] if the only reason to revert is that caption above the fold isn't completed, we might as well try to finish that today [18:34:01] gi11es: didn't start yet, I'll soon write a mail about that [18:34:12] I don't think all of that is realistic [18:34:36] our current way of handling long text is to cut at a certain number of characters [18:35:05] we can tweak that, but replacing it with width-sensitive text truncation is not a small task [18:35:23] especially if it is multiline + can include HTML [18:38:06] I've done it before, but not with the ellipsis at the end of the text [18:38:56] http://hq.deviantart.com/aboutus/ -> the "more" button in spyed's section [18:39:59] worked with resizing and all [18:40:01] yeah, that looks similar to how I did it with the permission text [18:40:03] I thought the multiline+html+width-sensitive truncation was infeasible last time we looked [18:40:09] Or at least too complicated [18:40:12] that's mostly just CSS trickery [18:40:20] too complicated, yeah [18:40:54] the trick I used there was to render the content while hidden and figure out its size [18:40:58] if it's single line, we might be able to wrestle jQuery.dotdotdot into doing it, that was the only plugin to handle HTML content IIRC [18:41:35] Not autoEllipsis or whatever terrible thing we have in core? :P [18:42:08] Hrm, maybe the uploads list isn't getting cleared right [18:42:16] basically what you need to do is start adding the text character by character, check the height and stop when it becomes more than one (or two) line [18:43:00] expect, how do you add html character by character? ;) [18:43:12] that's the hard part, yes [18:43:38] not impossible, but definitely not fun [18:44:08] you need to walk the DOM tree and figure out where to truncate and which textnode is at the end [18:44:44] frankly, if we stick to the limitations of the measurement approach I used for the design, we'd be fine [18:44:55] which means not using ellipsis tacked at the end of the text [18:45:13] but a more general button to show the rest of the hidden content [18:46:04] at any rate, I don't think it's worth doing in the form recommended by pginer [18:46:18] too much effort when we are already winding down [18:46:43] I don't think he knows how much work that is compared to alternative approaches that cover the same use case [18:46:55] unless we want to write a generic text-truncate plugin that can be used by other teams as well, that might be worth the effort [18:47:01] tweak the design a little bit and you have the same feature, expect a lot easier to implement [18:47:23] indeed [18:47:30] I'll go finish the mail about that [18:48:38] I can't type except, it seems [18:49:16] tgr: I guess that if the email ping pong doesn't find a resolution quickly, we can also prepare a commit reverting the last 4-5 merged ones just in case we're going to need it [18:49:44] hm, actually dotdotdot does multiline [18:50:11] have wound down* :( [18:50:45] I can try to implement a solution based on it quickly, it will at least help me remember why we choose not to use it [18:51:22] it was for some different part of the metadata panel, so it's entirely possible that it would work well for the title [19:08:22] did a quick test with dotdotdot, it does not support HTML in the ellipsis [19:08:34] so revert it is [19:13:58] yeah [19:14:21] I've just explained the ellipsis issue to pginer and frabrice on google hangout [19:35:08] tgr , gi11es is this possible: http://i.imgur.com/D0gyJYn.png [19:35:11] ? [19:36:03] yes [19:36:35] just wrote an email which links an article doing the exact same thing [19:39:09] ok, great. I think we can go with that. [19:49:54] Damn it, the uploads array isn't passed by reference for some reason [19:49:58] Screwed that up somehow [19:56:41] Oh, right, because removeUpload replaces the array now [19:56:46] * marktraceur grumbles [20:01:07] (03PS19) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:01:09] Bloody hell. [20:01:17] gi11es: Booleans are not integers. [20:01:22] * marktraceur goes to punch a wall [20:59:43] ok, I'm gonna put together the big revert, unless someone's already doing that [21:06:10] (03PS1) 10Gilles: Revert layout changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170804 [21:09:06] tgr: marktraceur: ^ [21:09:19] we can re-revert after the branch cutoff [21:09:43] assuming the ellipsis stuff will take less than a week to be written and reviewer :) [21:09:52] *reviewed [21:20:20] gi11es: should that be merged to master or just backported? [21:20:56] I guess it doesn't matter [21:21:23] is there time to do the backport between the branch cutoff and the deploy? [21:23:24] no, but do we want to keep the old look for the next branch? [21:23:41] we should backport it to the branch that goes to Commons tomorrow [21:24:11] and the new look is good to go to the new branch on Wednesday assuming the ellipsis fix makes it, right? [21:25:20] wait, what branch goes to commons? if it's the previous one, then we're fine aren't we? [21:26:27] 1.25wmf6 [21:26:29] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 (owner: 10Anomie) [21:27:01] ah, it was already in it [21:27:10] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/169840 (owner: 10Anomie) [21:27:24] ok, so I'll make a backport commit. marktraceur will you be around for the next swat in a few hours? [21:28:16] (03CR) 10Gergő Tisza: [C: 031] Revert layout changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170804 (owner: 10Gilles) [21:30:00] (03CR) 10Gilles: "Note: This is in case we don't get the ellipsis done by Wednesday" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170804 (owner: 10Gilles) [21:30:18] (03PS1) 10Gilles: Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170809 [21:31:24] gi11es: Sure, no problemo [21:31:32] Don't forget the submodule update commit [21:31:40] yeah I'm about to make that one [21:31:55] I won't be around, I'll put your name as the commit person on the deployment calendar [21:32:00] Cool beans [21:33:51] (03CR) 10Gilles: [C: 032] Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170809 (owner: 10Gilles) [21:34:32] (03Merged) 10jenkins-bot: Revert layout changes [extensions/MultimediaViewer] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170809 (owner: 10Gilles) [23:45:07] (03CR) 10Legoktm: Add i18n for API module help (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [23:45:25] what is a NSID in context of flickr/uploadwizard: https://gerrit.wikimedia.org/r/#/c/169844/1/i18n/en.json,cm