[08:32:20] (03CR) 10Gilles: "Looks much better! Is it deliberate to not animate it when you close the panel?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169746 (owner: 10Pginer) [08:34:40] (03PS3) 10Pginer: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [08:47:03] (03CR) 10Gilles: [C: 032] Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [08:47:41] (03Merged) 10jenkins-bot: Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [08:49:05] (03CR) 10Gilles: [C: 04-1] "Why not call the function when it is one and use its return? That's what those functions passed as message parameters are normally for, ri" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [08:49:36] (03PS2) 10Gilles: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 (owner: 10Gergő Tisza) [08:54:04] (03CR) 10Pginer: "Not deliberate, but I think is all we can get with the current approach. We are basically switching text alignment and expanding the width" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169746 (owner: 10Pginer) [08:56:22] (03CR) 10Gilles: [C: 032] "I think it's a good enough effort for now :) Something I think we might want to fix that is much more visible and has been affecting MV fo" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169746 (owner: 10Pginer) [08:57:03] (03Merged) 10jenkins-bot: Layout adjustment for right data column [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169746 (owner: 10Pginer) [09:08:16] I have a feeling that what chrismcmahon has run into is the wacky issues I was having yesterday in firefox [09:08:20] it's happening to me again [09:08:28] UW randomly gets stuck with no errors, nothing [09:09:02] happening on VM, so it's hard to know if it's the VM acting up [09:09:44] 3MediaWiki extensions / 3UploadWizard: Extension detection block upload on some valid files - 10https://bugzilla.wikimedia.org/72751 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: - upload a file called test.foo.jpg - UW errors, complaining that ".foo" is unsupported. [09:12:42] 3MediaWiki extensions / 3UploadWizard: Extension detection block upload on some valid files - 10https://bugzilla.wikimedia.org/72751#c1 (10Gilles Dubuc) Slight correction: ".foo" doesn't trigger it, but ".com" does. I presume this is because .com is specifically blacklisted for being an executable extension... [09:13:41] 3MediaWiki extensions / 3UploadWizard: Extension detection block upload on some valid files - 10https://bugzilla.wikimedia.org/72751#c2 (10Gilles Dubuc) Created attachment 16954 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16954&action=edit Screenshot [09:15:44] and it's stuck again... the only thing that fixes it is restarting firefox [09:19:29] 3MediaWiki extensions / 3UploadWizard: Files that contain a pound sign in their name can't be uploaded - 10https://bugzilla.wikimedia.org/72752 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None Created attachment 16955 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16955&action=edit Screensho... [09:23:50] I think it's related to having the console open, woah [09:24:02] I'm getting close to repro steps [09:25:23] yep it has to do with the console, this is one very strange bug [09:31:59] 3MediaWiki extensions / 3UploadWizard: Opening the console in Firefox makes UW's JS stop functioning - 10https://bugzilla.wikimedia.org/72753 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: - Open Firefox - Open UW with the console closed. It should work fine - Open the console... [09:37:41] (03CR) 10Gilles: [C: 032] Remove default date population with "now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169858 (https://bugzilla.wikimedia.org/53605) (owner: 10MarkTraceur) [09:38:15] (03Merged) 10jenkins-bot: Remove default date population with "now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169858 (https://bugzilla.wikimedia.org/53605) (owner: 10MarkTraceur) [11:09:59] 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758 (10Helder) 3NEW p:3Unprio s:3normal a:3None The buttons (and the container itself) of the first example are not in the correct place: https://en.wikipedia.org/wiki... [12:01:31] (03PS4) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [12:14:56] 3MediaWiki extensions / 3UploadWizard: Opening the console in Firefox makes UW's JS stop functioning - 10https://bugzilla.wikimedia.org/72753#c1 (10Gilles Dubuc) Actually I think it's the fact that the browser cache is disabled when I have my console open which is responsible, not the console itself. I've in... [12:15:28] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753 (10Gilles Dubuc) [12:15:57] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753 (10Gilles Dubuc) p:5Unprio>3High [12:15:58] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753 (10Gilles Dubuc) a:3Gilles Dubuc [12:18:12] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753#c2 (10Gilles Dubuc) Same error also happens in jquery.ui.resizable. In both case it's the first occurrence of $.ui.plugin.add being called. [12:20:56] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753#c3 (10Gilles Dubuc) It doesn't seem to be a bug introduced by recent code. I rolled back core and UW to their state on Sep 1st and the issue is still there. [12:50:59] (03CR) 10Gergő Tisza: "Normally :) I think the function in question is the one returned by UploadWizardUpload.duplicateErrorInfo." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [13:19:26] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753#c4 (10Gilles Dubuc) I'm pretty sure now that it's a race condition caused by an undefined dependency. I've noticed that every time it gets stuck, jquery UI is the last thing to be loaded (looking at the htt... [13:48:56] (03CR) 10Pginer: "Some comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [14:17:41] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753#c5 (10Gilles Dubuc) p:5High>3Normal It's very hard to pinpoint the source, I've noticed that according to the loader registry, when the page fails to load it's usually because things are waiting on jque... [14:49:11] 3MediaWiki extensions / 3UploadWizard: Primed cache JS issues - 10https://bugzilla.wikimedia.org/72753#c6 (10Gilles Dubuc) 5NEW>3RESO/INV Isolated the issue, it has to do with the resource loader and CSS. Nothing to do with UW. I'll file a bug to core. [14:49:28] gi11es: You can just change the target of a bug [14:49:43] didn't want to leave all the investigative comments that were misled [14:50:08] Ah. [17:05:12] tgr: If you get bored, I'd love to see https://gerrit.wikimedia.org/r/#/c/141599/ and https://gerrit.wikimedia.org/r/#/c/119942/ merged :) [17:05:53] I figured since you did a lot of code review on both you might be interested in pushing the button [17:06:30] this resource loader bug in UW is turning into a nightmare [17:07:30] gi11es: :( legoktm is pretty savvy about RL if you need more eyes [17:07:33] a jQuery .data() call seemed to swallow the execution of a thread. I removed it because it was only useful for IE [17:07:43] and now $( document ).ready() never fires [17:07:52] it's a big wtf-fest [17:07:59] o.O [17:08:38] legoktm: latest core, latest UW, firefox. set firebug to disable the browser cache (only happens on a primed cache) [17:08:53] open UW, refresh it a bunch of times until you get an infinite spinner [17:09:07] I'm only good at server-side RL, not client-side :/ [17:09:09] that's what I'm trying to fix, and all the problems seem to be coming from resource loading [17:09:40] anyway, I'll keep digging, but this is a very strange bug [17:09:55] I wanted to narrow it down enough before filing it for someone else to look at, but it gets weirder and weirder as I go [17:51:33] gi11es: $.ready won't fire if some other $.ready before it throws an exception [17:51:38] maybe that helps [17:52:11] no exception in sight [17:52:22] but now I have another occurence of $.data() just killing execution [17:52:56] I'm going to look at what's happening inside of it [17:53:16] ah, jquery.migrate... [17:55:34] n/m, it has nothing to do with it (jqmigrate) [17:56:41] (03PS2) 10MarkTraceur: WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 [17:56:48] Not bloody working [17:56:48] (03CR) 10jenkins-bot: [V: 04-1] WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 (owner: 10MarkTraceur) [17:56:50] I screwed something up [17:58:27] (03PS3) 10MarkTraceur: WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 [17:58:30] (03CR) 10jenkins-bot: [V: 04-1] WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 (owner: 10MarkTraceur) [17:59:51] Ugh, this rebase may not even be worth it [18:02:08] ok, something is overriding jquery.data in my browser and it's not coming from our code... [18:02:46] jQuery.data function(elem, name, data, showInternals) [18:02:54] can't find "showInternals" anywhere [18:05:39] it was fucking firequery... [18:05:57] hours wasted! thanks, extension [18:06:14] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768 (10Brion Vibber) 3NEW p:3Unprio s:3enhanc a:3None While batch-fixing broken Ogg videos in https://commons.wikimedia.org/wiki/Category:Wikimania_2009... [18:21:07] my sanity is restored... [18:21:27] browser-level bugs are the worst, it's what you expect the least [18:30:12] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c1 (10Brion Vibber) Ideally, TimedMediaHandler should always at runtime install a small JS hook with mw.hook('wikipage.content'): https://doc.wikimedia.org/med... [18:36:14] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c2 (10Cacycle) Thanks Brion. I am already running that hook ("window.mw.hook( 'wikipage.content' ).fire( $( '#wikEdPreviewArticle' ) );") but as far as I can te... [18:48:12] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c3 (10Brion Vibber) This *might* work for now if I'm reading correctly: $( previewElement ).find('video,audio').embedPlayer(); Hopefully it won't double-app... [18:51:34] Keegan|Away: Hey Keegan, I think we can post updates about the new Media Viewer improvements on the Enwiki and Commons Village Pumps later today. Would you like me to do it, or do you prefer to do it on your end? [18:58:27] (03CR) 10Jdlrobson: [C: 04-1] Work in progress: ogv.js media player for Safari/IE (3 of 3) (035 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:02:11] (03CR) 10Brion VIBBER: "(some inline notes \o/)" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [19:15:50] Hey fabri...never mind [19:16:44] Keegan: Silly Keegan, IRC is hard [19:17:04] Sho' nuff [19:22:47] Hm...I should send pginer an email [19:23:47] DO IT [19:24:12] Just realized I'd be totally breaking the remove-upload behaviour if I did the refactor I'm imagining [19:24:17] But it would also be SUPER COOL. [19:24:39] It's all in the name of adventure and discovery [19:24:40] Or something [19:24:42] Oh, no, I could do it. Never mind. [19:25:24] marktraceur: When are you getting into Amsterdam for the hackathon, btw? [19:25:26] Ugh, it's just so nasty [19:25:30] Keegan: Letta me check [19:25:57] Keegan: 10:35 November 14th [19:26:43] Ah. heh, I *was* getting in at 10:40 on that day but I moved it back to the 13th [19:27:27] Ah [19:27:52] * marktraceur looks exasperatedly at UploadWizard [19:27:58] Why am I not rewriting this from scratch [19:28:00] This is terrible [19:39:30] $( this.ui.div ).trigger( 'removeUploadEvent' ); (elsewhere) $( upload.ui.div ).bind( 'removeUploadEvent', function ( e ) { ... } ); [19:39:42] THE UPLOAD UI DOESN'T EVEN TRIGGER THE EVENT [19:39:44] THIS IS SO STUPID [19:40:10] Take it out back. [19:40:13] You know what to do. [19:40:23] I do [19:40:25] Violently [19:42:23] Urgh [19:42:30] I forgot moveTo in an earlier patch than I thought [19:42:31] * marktraceur fixes [19:43:11] (03PS1) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [19:50:06] (03PS8) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:50:18] (03PS2) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [20:34:42] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768#c1 (10Bawolff (Brian Wolff)) I agree this would be nice. Many people using a user script currently to get around this limitation: https://commons.wikimedia... [21:23:19] (03PS9) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:23:37] (03PS3) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:24:59] (03PS7) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [21:25:04] (03PS10) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:25:09] (03PS4) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:27:54] (03PS11) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [21:27:59] (03PS5) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [21:34:01] (03PS1) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [21:35:27] I cannot believe we can just...do that now [21:35:35] I'm still a little apprehensive [21:35:41] But it seems to work fine [21:55:03] (03PS1) 10Bartosz Dziewoński: Change OO.ui.InlineMenuWidget → OO.ui.DropdownWidget for OOUI upgrade [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) [21:55:51] (03CR) 10jenkins-bot: [V: 04-1] Change OO.ui.InlineMenuWidget → OO.ui.DropdownWidget for OOUI upgrade [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński) [21:57:52] (03CR) 10Catrope: [C: 031] "Yay OO events! Suggestions for more fanciness you can optionally use inline." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [23:16:06] Keegan|Away: As discussed, I just posted Media Viewer updates on these two Village Pumps on Enwiki and Commons: [23:16:06] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Media_Viewer_Update:_New_Improvements [23:16:07] https://commons.wikimedia.org/wiki/Commons:Village_pump#Media_Viewer_Update:_New_Improvements [23:46:12] 3MediaWiki extensions / 3TimedMediaHandler: Dynamically loading TimedMediaHandler for new content (preview) - 10https://bugzilla.wikimedia.org/72675#c4 (10Cacycle) The following combination actually works, but unfortunately only for the first call. For repeated previews, the same symptoms as described in the...