[00:21:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167958 (owner: 10Gergő Tisza) [01:35:52] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c11 (10Bawolff (Brian Wolff)) Its caused by d25cb992, which changed how Ok the api request in question was -----------------------------243... [02:35:22] 3MediaWiki / 3File management: given path of the specified thumbnail is incorrect - 10https://bugzilla.wikimedia.org/72389#c1 (10Bawolff (Brian Wolff)) Appears to be accientally caused by f7be7e6a (Abbreviation threshold for files with long names was set to 140 for commons as a foreign repo, but kept at 160... [02:44:08] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c3 (10Bawolff (Brian Wolff)) I wonder if it would be a good idea to also make expected name mismatches give a redirect instead of a... [03:20:53] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c5 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX CScott deployed fix, so it should be resolved now. (Some cached pages may need to... [05:33:26] Thanks, gi11es ! Let us know what you find out about ticket #963 (Disable button only works some of the time). It would be great to take care of this before we deploy today. (We’ll also want to avoid this issue during tomorrow’s demo for the executive review. :) [07:27:25] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c13 (10Tisza Gergő) (In reply to Tisza Gergő from comment #9) > (In reply to Rainer Rillke @commons.wikimedia from comment #8) > > This has bee... [07:27:25] 3MediaWiki extensions / 3UploadWizard: UploadWizard should not use iframe transport for upload_by_url requests to the wiki-own-API (FlickrUploading) - 10https://bugzilla.wikimedia.org/65423 (10Tisza Gergő) [07:29:23] 3MediaWiki / 3File management: abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names - 10https://bugzilla.wikimedia.org/72389#c6 (10Tisza Gergő) (In reply to Bawolff (Brian Wolff) from comment #1) > Appears to be accientally caused by f7be7e6a (Abbreviation... [07:47:10] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Andre Klapper) p:5Normal>3Lowest [07:56:24] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c2 (10mrmax) (In reply to Andre Klapper from comment #1) > Have you asked on https://www.mediawiki.org/wiki/Project:Support_desk yet? > Have you checked http://www.mediawiki.org/wiki/Manual:How_to_debug ? No... [07:57:01] (03PS1) 10Gilles: Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 [07:57:48] (03CR) 10jenkins-bot: [V: 04-1] Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 (owner: 10Gilles) [08:05:34] sigh... so I imagine we set es3 for jshint for mediaviewer's own code's sake [08:05:55] but sinon needs es5 for its function called "throws" [08:06:24] and now jshint has jut gotten strict about bracket notation [08:06:38] it's a bit of a catch 22 here! [08:07:02] I guess I'm going to have to use an bypass comment for those 3 lines of code [08:10:30] (03PS2) 10Gilles: Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 [08:11:57] tgr: ^ [08:12:36] gi11es: sinon has an alternative name to avoid this issue IIRC [08:12:45] throwsException or something like that [08:13:09] not that there is anything wrong with a bypass comment [08:13:47] indeed https://gitorious.org/sinon/sinon/commit/3eddd894c0a838a3d37faf8346968984b06a82e1 [08:13:52] might as well switch to that, it's cleaner [08:14:24] we set es3 because IE8 is ES3-based and we want jshint to catch potential issues there [08:14:51] (03PS3) 10Gilles: Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 [09:39:51] (03CR) 10Gergő Tisza: [C: 04-1] Fix issue with options dialog when media viewer has been reopened (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 (owner: 10Gilles) [09:57:38] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c14 (10Rainer Rillke @commons.wikimedia) (In reply to Bawolff (Brian Wolff) from comment #11) > Note the lack of a format parameter - I guess t... [11:25:16] (03PS1) 10Pginer: Style adjustments to the disable panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168272 [12:03:08] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328#c4 (10Subfader) Check if viewport has enough width to display the 500px image. Call thumb.php?f=Foo.jpg&w=500 > Displays a 500px thumb or a smaller original How does return... [12:21:03] (03PS2) 10Krinkle: Adjust style of the Disable panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168272 (owner: 10Pginer) [12:44:47] fabriceflorin: https://commons.wikimedia.org/wiki/File:Esso_Standard_Oil_Company_commercial_1938.webm <-- where is the file :) [12:57:46] (03CR) 10Gergő Tisza: [C: 032] Adjust style of the Disable panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168272 (owner: 10Pginer) [13:29:49] (03PS4) 10Gilles: Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 [13:58:46] flickr upload via commons is continuous loading.. [14:04:52] Maybe another API change? [14:06:55] The last thing I see is the SSL-only change [14:06:58] Which we've dealt with [14:49:20] (03CR) 10Gilles: [C: 04-1] "Indeed, I think it wasn't in scope to delete all those links. Also, this link needs an event, called through trackLinkClick." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168099 (owner: 10MarkTraceur) [14:50:32] Oh, right. [14:50:39] (03CR) 10Gilles: [C: 032] Adjust style of the Disable panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168272 (owner: 10Pginer) [14:51:20] (03Merged) 10jenkins-bot: Adjust style of the Disable panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168272 (owner: 10Pginer) [14:57:58] (03CR) 10Gergő Tisza: [C: 032] Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 (owner: 10Gilles) [14:58:22] I wish Fabrice were on already so I could sort out the links... [14:58:55] (03Merged) 10jenkins-bot: Fix issue with options dialog when media viewer has been reopened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168257 (owner: 10Gilles) [14:58:58] (03CR) 10Gilles: "Doesn't help: https://www.dropbox.com/s/jrdyspdsavyy5no/Screenshot%202014-10-23%2016.55.58.png?dl=0" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza) [14:59:55] has the branch already happened? i.e. do we need to backport this? [15:01:41] git fetch gerrit wmf/1.25wmf5 [15:01:41] fatal: Couldn't find remote ref wmf/1.25wmf5 [15:02:38] marktraceur: the flickr thing is bug 72340 [15:15:34] gi11es: I think we have time before the branch. The "learn more" thing might go out next week, but I see no need for rush. [15:17:49] yeah that one's not critical, the bug was [15:20:24] Sure. But the branch hasn't happened, pretty sure. [15:39:59] (03PS1) 10Gergő Tisza: Test PhantomJS localStorage handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168305 [15:40:11] Shoot, I missed him [15:40:46] gi11es: I am trying to create a test to double-check phantomjs localstorage handling as I think the file page is the only test which relies on that [15:41:08] but ^^ fails for me completely, both with and without phantomjs [15:41:22] any tips on what I am doing wrong? [15:43:05] (gi11es: specifically, I am suspecting this issue: https://github.com/karma-runner/karma/issues/654 ) [15:43:14] I'll take a look [15:45:16] Failed to read the 'localStorage' property from 'Window': Storage is disabled inside 'data:' URLs. [15:45:23] need to load an actual page first, I guess [15:45:44] aw shoot [15:46:02] forgot that on(SomePage) doesn't automatically load that page [15:49:09] (03PS2) 10Gergő Tisza: Test PhantomJS localStorage handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168305 [15:50:04] (03Abandoned) 10Gergő Tisza: Test PhantomJS localStorage handling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168305 (owner: 10Gergő Tisza) [15:52:07] fabriceflorin: So I may have jumped the gun, I removed *all* of the links below the fold and added the "learn more" link in the options panel [15:52:26] I thought we were angling towards that anyway, and simplicity in the design appealed to me, but I'm game to put them back [15:52:59] MARKTRACEUR: I think this is premature, we should discuss this as team before making such a radical move. [15:53:39] OK, well, for now, so we can maybe get this out today, should I just put the links back? [15:53:53] Apart from the FAQ page, which moves to the panel [15:54:02] Yes, please put the links back in. Could you show this on the alpha site, for discussion purposes? But I would not roll this out on production without a team discussion. gi11es , andy thoughts? [15:54:42] I would still keep the link to the FAQ below the fold. The link in the Disable panel is primarily about disable. [15:54:42] The only change is removing a link in the panel and adding it to the options panel [15:54:49] Both gi11es and tgr expressed concerns [15:55:00] So I figured I'd ask you, and your answer seems pretty sane [15:55:02] Oh, well, OK [15:55:37] Thanks for checking with me. I think we want to move gradually on this front, first with the features we agreed on, then with any final tweaks we agree on as a team. [15:56:26] Sure sure. [15:56:50] I'll knock that out, hopefully the patch gets added to the train [15:57:07] MARKTRACEUR: were you and gi11es able to merge the bug fix for #963 (Disable button only works some of the time) in the version that is going out today? [15:57:44] I think it got merged already [15:57:47] Test on beta, maybe [16:00:34] (03PS3) 10MarkTraceur: Add about link to disable/enable dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168099 [16:00:38] (03CR) 10jenkins-bot: [V: 04-1] Add about link to disable/enable dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168099 (owner: 10MarkTraceur) [16:00:43] Oh, suck it Jenkins [16:01:54] (03PS4) 10MarkTraceur: Add about link to disable/enable dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/168099 [16:02:50] fabriceflorin: Wait, you said the link was specifically about disable...does that mean it's *not* just a link to our help page? [16:03:01] Because that's all the card says [16:03:53] Here is the link I recommend for the ‘Learn more’ inside the Disable/Enable panels: https://www.mediawiki.org/wiki/Help:Extension:Media_Viewer#How_can_I_turn_off_this_feature.3F [16:04:42] It is specifically about the Disable/Enable process. The copy would be updated on Tuesday, when we deploy to Commons, to describe the new method with the cogs icon. [16:05:29] The other Help link at the bottom of the metadata panel woud continue to go to the top of the Help page, where people can find answers on a variety of topics. [16:05:38] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c15 (10Brad Jorsch) (In reply to Gerrit Notification Bot from comment #12) > Change 168235 had a related patch set uploaded by Brian Wolff: > R... [16:06:41] marktraceur: a little deployment support - if I set up the two live wmf branches and the config repo in subdirs of mediawiki-staging, then run scap in mediawiki-staging, that will sync everything at the same time, right? [16:07:23] the MW help page has a warning about not deploying an extension that's not merged in other branches but doesn't really explain how to deploy in all branches at the same time [16:08:16] tgr: Yes, that will work [16:08:58] tgr: I *think* just being aware of what wikis are on which branches should be sufficient - i.e. if you're pushing to wmf5 today, only enable the extension on mw.org and testwikis. [16:09:04] test, test2, testwikidata [16:09:13] MARKTRACEUR : BTW, I checked beta and couldn’t find your proposed changes to remove links below the fold. Which is fine, because I think we will demo the version on beta in today’s quarterly review, to show the disable/enable functions. [16:09:23] fabriceflorin: No, because it's not merged [16:09:33] MARKTRACEUR: Good. [16:09:48] fabriceflorin: I need to print out a diagram for you about where to test things, I think. :P [16:09:50] the page seems to warn about the l10n cache builder messing up in that case, although I might misread it [16:10:00] I want to deploy to all branches anyway [16:10:08] Oh, hm. [16:10:24] tgr: It might get confused, but I can't imagine it being bad when *adding* messages. Maybe I'm wrong :) [16:11:34] MARKTRACEUR: A diagram is always appreciated. :) Though it seems like we only have 2 options for pre-release testing now: beta and sometimes alpha. Any other places I should be aware of? [16:12:08] Well, local wikis [16:12:16] I actually sort of want to do this now. [16:13:24] MARKTRACEUR: To make sure we’re on the same page, we are deploying the new disable/enable function to MediaWiki.org today, right? When do you expect that to be live? between 11am and 12pm PT? And will that include the bug fix for #963? [16:15:38] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c16 (10Tisza Gergő) As I said, there is no reason whatsoever for UploadWizard to even use a transport for Flickr upload, much less to use the i... [16:18:16] fabriceflorin: Correct, about noon your time probably [16:18:46] I think it includes #963, yes [16:19:08] MARKTRACEUR: Thanks for clarifying this, so we can give accurate info to the folks in today’s quarterly review. [16:27:38] fabriceflorin: https://www.mediawiki.org/wiki/File:Multimedia_testing_flow_chart.png just for you :) [16:28:46] Super. That is really helpful! Thanks for doing this :) [16:30:13] No problem [16:32:51] marktraceur: after updating mediawiki-staging and running sync-common on testwiki, ResourceLoader should update the JS on its own, right? [16:33:21] Yup! [16:33:37] Now, "should" is a funny word. [16:34:28] oh, it actually did, I just forgot everything is lazy-loaded [16:36:01] Heh [16:37:41] it might take up to 5 minutes for the startup module cache to clear [17:10:34] Eloquence: We cannot hear the office anymore [17:10:34] fabriceflorin: the office hangout froze [17:10:40] fabriceflorin: if y'all didn't know, you broke :( [17:10:42] CC robla [17:12:04] marktraceur: is there such a thing as a group1 dblist? [17:12:10] no [17:15:38] tgr: group 1 is "all minus wikipedia" -- https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment/Train_deploys#Promote_branch_.22Tuesday.22_deploy [17:16:20] bd808: I was just wondering how to target it in the config [17:16:31] default: true, wikipedia: false I suppose? [17:16:41] eh, probably I'll just skip that step [17:16:57] tgr: I thought you were going to group 0 wikis? [17:17:02] mw.org, tests [17:17:12] Because we're nerds, we start at 0 of course. [17:18:12] marktraceur: yes, but the group0 dblist exists, so no problem there [17:18:41] I want to do all three in the same deploy window, just give it a little time so in case it explodes it happens on group0 [17:18:47] but it's pretty low-risk [17:18:57] Ah. [17:20:35] marktraceur: so I enabled for group0 and ran 'sync-file wmf-config/InitialiseSettings.php' but it does not seem enabled on mw.org yet [17:20:40] did I miss something? [17:20:45] ...and the office is gone again [17:20:55] fabriceflorin: we lost you guys again [17:21:31] Eloquence: robla ^ [17:27:14] lol, even fae thinks the comment at https://commons.wikimedia.org/wiki/Commons:Village_pump#WMF_code_deployment_problems is unfair [17:28:01] marktraceur: any tip about the sync? [17:28:13] tgr: Oh, sorry, I missed that [17:28:24] tgr: Not sure...let me look [17:28:51] sorry for distracting you in the middle of the meeting... I did not consider how long scap would take [17:29:11] It's fine [17:29:18] tgr: How would I be able to tell it was enabled? [17:29:28] special:version [17:29:55] Pretty sure that's cached aggressively [17:30:13] oh, didn't realize that [17:30:21] tgr: Isn't there a JS object? [17:30:34] there is, let me check [17:41:09] marktraceur: "'imageMetricsLoadTime' in mw" should be true but isn't [17:41:16] Hrm [17:41:28] on file pages [17:41:35] tgr: That's pretty weird [17:43:44] tgr: I don't see it in siprop=extensions either [17:43:45] Grrr. [17:43:58] tgr: Did you also modify CommonSettings.php? Did it get synced? [17:44:14] no to both [17:44:35] ...wouldn't it need to be/ [17:44:36] ? [17:44:47] I guess if you modified the wg variable directly, no [17:45:12] marktraceur: https://gerrit.wikimedia.org/r/#/c/168326/ [17:48:16] Ahhh. [17:48:33] tgr: And CommonSettings already had something about $wmgUseImageMetrics, before. [17:48:51] marktraceur: yep, it works fine on testwiki [17:49:04] Oh, hm. [17:49:12] Maybe group0.dblist is weird [17:50:38] No, seems fine. [17:50:51] Oh, wait [17:51:20] There was something about syncing a *separate* file if you...wait, no, that was when you updated the dblists, you haven't touched those [17:55:23] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429 (10Jonatan Svensson Glad (Josve05a)) [17:56:35] Eloquence: not sure where the screenshot came from but see http://multimedia-metrics.wmflabs.org/dashboards/uw [17:56:49] there *is* a drop on the tutorial step [17:56:53] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c3 (10Jonatan Svensson Glad (Josve05a)) Thiis has been confirmed on FF and Chrome using vector, both with and without vector by multiple users on IRC. No-one has been able to see videos during the... [17:59:10] 3MediaWiki extensions / 3MultimediaViewer: Use wikis local language in "More details" button - 10https://bugzilla.wikimedia.org/72438 (10Steinsplitter) 3NEW p:3Unprio s:3enhanc a:3None The blue "More details" button in #mediaviewer/ should use the &uselang= on the local wiki. [18:00:10] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c4 (10Jonatan Svensson Glad (Josve05a)) It isn't the fact that videos is invisible, merly that the Wikimedia-video player is invisible/disapears, hiding the video from sight. [18:03:38] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429 (10Jonatan Svensson Glad (Josve05a)) [18:05:53] 3MediaWiki extensions / 3MultimediaViewer: Use wikis local language in "More details" button - 10https://bugzilla.wikimedia.org/72438#c1 (10Steinsplitter) Example: Users from dewiki should receive the german interface (&uselang=de) Users from itwiki should receive the italian interface (&uselang=it) etc. [18:18:10] (03PS1) 10Brian Wolff: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) [18:19:31] Could https://gerrit.wikimedia.org/r/168352 be reviewed rather quickly? It represents quite a bit of breakage on commons [18:20:54] (03CR) 10Brian Wolff: "Please also remember to test videos when making changes to TMH (This change broke videos)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165753 (https://bugzilla.wikimedia.org/71365) (owner: 10Phuedx) [18:21:24] bawolff: looking [18:22:12] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) (owner: 10Brian Wolff) [18:22:32] woo, thanks [18:22:49] didn't make the branch cut though [18:23:28] I think it should be swatted anyways [18:23:44] I'll prepare a SWAT in an hour or so [18:24:23] Cool. Could you also do https://gerrit.wikimedia.org/r/#/c/168235/ for swat as well? [18:24:46] sure [18:24:51] yay [18:25:16] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/168352 (https://bugzilla.wikimedia.org/72429) (owner: 10Brian Wolff) [18:30:11] marktraceur: btw, in case you haven't seen, there's a couple people complaining on COM:VP that upload wizard isn't working for them (not counting the flickr issue) - but noone has really posted anything specific enough to make the issue reproducible [18:31:00] Ughhhh [18:31:04] Things to add to my list [18:34:09] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c18 (10Rainer Rillke @commons.wikimedia) (In reply to Brad Jorsch from comment #15) > needs to be fixed to not be using format=jsonfm "accordi... [18:36:30] So, to fix the general issue, or the chunking issue...that is the question [18:36:55] bawolff: Have you been fielding questions, or were you just like "Oh, OK, I'll ask"? Because chunked uploading is known borked, and so is Firefogg [18:37:17] I just saw the post on VP [18:37:23] KK [18:37:38] I'll...ugh. I'll deal with chunked uploading for a bit and see if I can't help out otherwise later. [18:38:37] There's been a lot of "OMG!!! everything is broken posts on commons recently" (7 issues at current count) I've been trying to sort through them [18:39:12] Most of the commons specific one's are fixed now though [18:41:13] Although user indicated that file was about 100kb, which shouldn't trigger chunked uploading [18:42:28] hi neilk_! [18:43:01] neilk_: do you remember if there was a specific reason for UW to use iframe transport for upload-from-URL? [18:46:07] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c19 (10Brad Jorsch) (In reply to Rainer Rillke @commons.wikimedia from comment #18) > "according to mdale we need to do this because IE does no... [18:56:10] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c7 (10Steinsplitter) 5PATC>3RESO/FIX (Status = Merged) [18:58:09] 3MediaWiki extensions / 3MultimediaViewer: Use wikis local language in "More details" button - 10https://bugzilla.wikimedia.org/72438#c2 (10Tisza Gergő) They do: https://de.wikivoyage.org/wiki/Tiflis#mediaviewer/File:Central_part_of_Tbilisi.jpg Not sure why this doesn't work on the Wikipedias, maybe it has... [19:02:45] MARKTRACEUR tgr gi11es : Hi guys, do you know the status of today’s Media Viewer deployment? I do not see the changes up on mediawiki.org yet. Also, are there any particular issues you think I should test for when the changes are live? [19:12:09] 3MediaWiki extensions / 3UploadWizard: FlickrUpload stopped working due to API request through iframe && X-Frame-Option DENY - 10https://bugzilla.wikimedia.org/72340#c20 (10Tisza Gergő) (In reply to Brad Jorsch from comment #19) > I'm sure there are better ways than screen-scraping. Adding a JSONPI output f... [19:13:02] fabriceflorin: deploy time is 11h-13h PDT [19:25:10] (03PS1) 10Gergő Tisza: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) [19:25:34] (03PS1) 10Gergő Tisza: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) [19:27:15] tgr Thanks! I think I will go grab lunch now, since the changes are not live yet. I will be back at 13:00 PT to test the changes. [19:39:28] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:39:43] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168387 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:40:02] (03CR) 10Gergő Tisza: [C: 032] Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [19:40:14] (03Merged) 10jenkins-bot: Follow-up 9649253f6b: Unbreak videos [extensions/TimedMediaHandler] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168388 (https://bugzilla.wikimedia.org/72429) (owner: 10Gergő Tisza) [20:01:08] 3MediaWiki extensions / 3TimedMediaHandler: Videos invisible on commons - 10https://bugzilla.wikimedia.org/72429#c12 (10Jonatan Svensson Glad (Josve05a)) 5PATC>3RESO/FIX (Status = Merged) [20:10:09] Hrmmmm [20:10:17] Cannot reproduce chunked upload issue on localhost. [20:12:22] Trying on beta. [20:13:33] It seems it gets stashed but doesn't finish...why [20:13:50] And why not locally [20:14:40] Curiouser and curiouser. [20:16:57] I guess I may have messed something up with the "assembling" response at some point... [20:18:51] Which would explain why only big files are affected...if it's small enough, it doesn't need much assembling [20:18:55] [20:26:52] Fucking hell [20:27:03] It's because we didn't upgrade to promises [20:27:06] I hate programming [20:29:36] marktraceur: I prepared the files for todays SWAT but I can't stay awake til then, need to travel early tomorrow [20:29:46] can you oversee the SWAT? [20:29:51] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) [20:29:54] I can, tgr [20:29:59] thx [20:29:59] I'll probably try to push that out too... [20:30:07] tgr or gi11es, mind reviewing that? [20:30:12] (and for the help with the deploy as well) [20:31:38] 3MediaWiki extensions / 3UploadWizard: Uploading multiple files doesn't work with Firefogg and settings for multiple concurrent uploads - 10https://bugzilla.wikimedia.org/71409#c4 (10Mark Holmquist) *** Bug 65696 has been marked as a duplicate of this bug. *** [20:31:38] 3MediaWiki extensions / 3UploadWizard: Multiple selection not reliably working. [probably chunked upload exploding] - 10https://bugzilla.wikimedia.org/65696#c4 (10Mark Holmquist) 5NEW>3RESO/DUP This is almost certainly a duplicate of 71409, marking so. *** This bug has been marked as a duplicate of bug... [20:31:52] bawolff needs a medal for this, he fixed at least three different breakages today and they were all pretty tricky to track down [20:32:06] bawolff always needs a medal [20:32:08] 3MediaWiki extensions / 3UploadWizard: Multiple selection not reliably working. [probably chunked upload exploding] - 10https://bugzilla.wikimedia.org/65696#c5 (10Mark Holmquist) Sorry, chaining of duplicates. *** This bug has been marked as a duplicate of bug 69374 *** [20:34:47] hm [20:35:04] maybe mw.Api.post should have a warning for deprecated arguments? [20:35:11] Should, probably. [20:35:23] Right now I'm mostly concerned about getting 'er working again [20:35:35] I'll file a bug against Wikimedia / Krinkle [20:35:38] will be rough on gadget maintainers if they are disappeared just like that [20:35:52] True [20:37:47] and we need moar tests for UW [20:37:53] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [20:38:04] should I prepare the SWATs? [20:38:25] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168419 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [20:38:31] tgr: +1 yes please [20:39:02] tgr: If I cherry-pick the Firefogg and chunking patches to wmf4 and wmf5, will you include them in your extension update? [20:39:48] I wonder if an E2E test could have caught todays TMH breakage [20:40:10] sure, I'll do that [20:40:15] Sweet. [20:40:28] Arghhh [20:40:45] (03PS1) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) [20:40:59] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) [20:41:18] K, there you go [20:41:28] The Firefogg one is in wmf5 already [20:41:40] (03PS1) 10MarkTraceur: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) [20:43:27] neilk_: around? [20:58:02] tgr, interesting re: funnel - that makes sense. we need to explain this a bit better in the wiki page or the graph annotation; thumbs for each step + examples would be ideal [20:58:38] Eloquence: I was thinking of making a bookmarklet which shows you what's logged with mw.message [20:58:44] plus a video with it [20:59:06] huh, fancy :P [21:01:15] marktraceur: what do I need to test the FDT patch? any modern browser plus any image should do it, right? [21:02:53] tgr: Plus chunked uploading, which is not enabled by default [21:03:03] But when I ran it locally I don't think I managed to repro... [21:03:09] that means 10M+ file? [21:03:16] Then again...sec [21:03:28] tgr: 5MB+, but you'd do best with a 50MB or more [21:03:33] I don't need to repro the bug, just to make sure UW still works [21:03:48] Right [21:03:51] since this is the last SWAT before the weekend, I figured a double-check might not hurt [21:04:53] Bah, I'll be online, it's fine [21:15:27] marktraceur: still does the infinite spinner thing for me [21:15:48] ...uh oh [21:15:51] Error in the console? [21:15:57] maybe there are two bugs? [21:16:00] Might be [21:16:10] tgr: Are you using Firefox? [21:16:16] none, and the progressbar actually says "finished", but the spinner does not stop [21:16:22] no, Chrome [21:16:44] >5M files work fine [21:17:01] seems 100% reproducible, I used a 12M file with chunked ul enabled [21:18:41] Hrm [21:18:44] I'll try Chrome [21:20:15] Cannot repro here [21:20:19] tgr: Do you have latest mw? [21:20:46] tested on beta [21:21:34] with https://commons.wikimedia.org/wiki/File:Aimard_-_Ourson-t%C3%AAte-de-fer.tif [21:21:39] Trying [21:21:48] With my customary webm file [21:22:04] tgr: You turned chunking on in prefs, yeah? [21:22:08] yes [21:22:29] Ugh, yeah, I still get it too. [21:22:34] I'll merge the patches anyway, they clearly fix a bug, but maybe there is another one behind it [21:22:43] Guess so. I'll keep looking. [21:22:51] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:22:54] (03CR) 10Gergő Tisza: [C: 032] Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:23:16] Oh, wait. [21:23:22] I still get the old versions of the files on beta [21:23:26] Maybe the code update didn't take yet [21:24:11] maybe something broke in RL as well? [21:24:15] Maybe [21:24:17] it has been almost an hour [21:24:26] Oh, wow, time files [21:24:42] https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update-eqiad/ [21:24:48] Last success 2h31m ago [21:24:58] is there a cherry-pick for the firefogg patch? [21:25:02] ouch [21:25:06] Yeah, sec [21:25:11] https://bugzilla.wikimedia.org/69374 [21:25:14] Er [21:25:20] https://gerrit.wikimedia.org/r/168421 [21:25:22] Silly grrrit-wm1 [21:25:28] tgr: Only for wmf4, wmf5 has it [21:25:29] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168423 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:25:32] (03Merged) 10jenkins-bot: Upgrade FDT to use promises instead of old syntax [extensions/UploadWizard] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168422 (https://bugzilla.wikimedia.org/60821) (owner: 10MarkTraceur) [21:26:44] (03CR) 10Gergő Tisza: [C: 032] Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [21:27:17] is the mw.log.warn branch in the firefogg patch user error or bug? [21:27:19] (03Merged) 10jenkins-bot: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/168421 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [21:27:27] I mean, shouldn't we log that? [21:27:56] It's a bug, I think [21:28:03] It is logged, right? [21:28:33] I mean via EventLogging [21:28:40] Oh [21:28:52] Probably, but I see no increased urgency over other things [21:29:45] no urgency at all, I just wasn't sure [21:29:53] I'll add a card for that [21:31:08] OK [22:09:27] (03CR) 10Fomafix: "Superseded by https://gerrit.wikimedia.org/r/168419" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167410 (owner: 10Gerrit Patch Uploader) [22:13:42] tgr: marktraceur: Which mw.Api arguments? 'ok' and 'err' ? [22:13:57] yes [22:14:05] Those had deprecation warnings [22:14:09] for almost a year [22:14:18] and in several mailing list announcements and village pump announcements [22:14:32] yeah, I remember the announcements [22:14:44] Anything broken by their removal is unmaintained and the only way to reach those people is by breaking it and waking them up that javascript is no longer an append-only environment. [22:15:00] I don't recall seeing the warnings though [22:15:50] the warnings should work with all convenience functions like mw.Api.post right? [22:16:33] Yes [22:16:41] Past tense [22:16:45] They no longer exist [22:17:30] anyway, I appreciate that updating core JS modules is a lot of work as it is, but what do you think about throwing an exception in place of removed deprecated functions for a while? [22:17:51] since that's the point when people actually notice, a lot of the time [22:18:00] No. I'm not starting that. Broken code is broken. It'll fail one way or another. No need for an explicit exception. [22:18:02] and a console error would make it easier to diagnose [22:18:12] Clearly if warnings and announcement don't reach anyone, who would be handling that exception? [22:18:20] those are also on the console [22:18:45] the point is, often people only start looking when the functionality breaks [22:18:54] tgr: how did this come up in conversation? Was there an actual code or just theory? [22:19:25] yeah, UploadWizard had some old-style api calls [22:19:45] Yes I know, but that only applies to unmaintained code that people notice after it breaks. code that is actually maintained and not >6 years old, will be noticed when it gets deprecated. [22:20:00] People like edokter, thedj etc. they notice warnings, read announcements, and go through their code. [22:20:05] Just like we do for our extensions. [22:20:16] for WMF-maintained code this is not an issue, we should have known better [22:20:31] I'm not interested in spending time in non-developers and spoon-feeding it. That only encourages crap code to be kept alive longer that really should just cry out for someone to pick up maintenance. [22:21:18] For those gadgets there will be 1 point in time after it breaks, which results in a non-developer sysop filing a report and we either help them disable the gadget or they find a user that will maintain it. [22:21:27] Not for every migration, only the first. [22:21:37] This is the first ever js migration / deprecation cycle. [22:21:44] All releases before only added more js methods. [22:22:12] I mean, a gadget might be forgotten again of course, but I think that's only fair. [22:22:54] tgr: deprecation tracking is event based. People could develop a gadget that exposes the information visually without needing a console [22:23:18] e.g. an indicator on the page saying the page triggered deprecation warnings. Then interested parties could be aware of it before it breaks. [22:23:22] lots of options. [22:24:26] fair points [22:24:34] http://graphite.wikimedia.org/render/?width=900&height=400&hideLegend=false&target=mw.js.deprecate.api_cbParam.rate&from=-6months [22:24:38] thats the ok/err callback tracking [22:24:45] it emitted warnigns to the console [22:25:05] https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html [22:25:35] "Use of mediawiki.api callback params is deprecated. Use the Promise instead." [22:25:49] I did not mean to imply there wasn't enough warning [22:26:16] and in the case of UploadWizard we should have known better, certainly [22:26:35] I know it's annoying when stuff breaks, but at some point we have to stop caring. I'm probably the last person to suggest we stop caring, it was hard. But I think we've done well. [22:26:38] I was just worried about the impact on gadgets, especially on small wikis [22:26:50] tgr: Ah, this affected UploadWizard? [22:27:04] yes, but as I said, that's our fault [22:27:09] ok [22:27:44] Yeah, our integration tests shoudl run tests in a clean environment (not something like beta labs) and ensure there are no deprecation warnings [22:28:15] but on huwiki for example the standard experience is that half the staff is broken at any point in time [22:28:36] granted, most of that is unrelated to JS deprecations [22:29:18] but it really contributes to a crappy user experience for power users [22:29:46] I guess the only real fix for that would be centralization of gadgets, though [23:19:58] Curses, beta finally got the right code, and it's still not working. [23:20:08] Oh, scratch that, it just got to "finished" too quickly [23:20:10] Cool beans [23:20:16] Fixing bugs, yeah yeah [23:41:35] So...things on the radar: Progress bar weirdness