[11:04:09] (03PS1) 10Pginer: Show panel shadow on full-screen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167775 [11:56:11] pginer_: can you look at the discussion in https://gerrit.wikimedia.org/r/#/c/164529/ ? [11:56:42] yes. Looking at it.. [11:56:48] thx [12:11:39] tgr, I have a big problem with my local wiki installation. I sthe patchset live anywhere (alpha?) [12:12:00] give me a sec and I'll put it up [12:12:42] Since July, everytime I try to update core, everything breaks. So I’m stuck with an old version of core. [12:13:40] And having an old version of core produces the “Uncaught Error: Unknown dependency: mediawiki.ui.icon” error which prevents me from trying the patchset. [12:13:54] pginer: did you try using vagrant? [12:14:05] much, much less headache [12:14:38] anything breaks, just refresh the virtual machine [12:17:19] I can try Vagrant, I have it installed, but I was used to operating my local wiki [12:17:35] I think that language projects were not Vagrant-ready [12:18:27] In any case, I think I’ll need to spend some time in my patchset-testing infrastructure. [12:18:55] in any case is very frustrating that just updating core broke everything without a cue on what went wrong. [12:19:09] it sure is [12:19:15] do you get any error? [12:20:40] btw vagrant is goind to get (maybe already got?) some sort of API to remotely update the patch version, so a nice web interface to multimedia-alpha where you can just change the current version is not so far away [12:24:32] well, alpha uses old core as well so maybe we'll see :/ [12:26:34] ok, alpha should work now [13:18:32] tgr, I fixed my install, reinstalled Inkscape (Yosemite update broke it), and finally fixed the icons, but Gerrit warns that I’m submitting several commits when trying to ammend the patchset with the new icons. [13:19:24] Should I just confirm? (normally the warning is an indication that something went wrong, since I just ammended the previos commit) [13:22:42] In this case it seems the patchset has chained commits. so I’ll go ahead. [13:23:09] (03PS12) 10Pginer: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [13:23:48] (03CR) 10Pginer: "I amended the patchset with updated icons to avoid the issue mentioned." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [13:46:02] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167800 (https://bugzilla.wikimedia.org/69245) [13:47:27] (03CR) 10Zfilipin: "check experimental" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167800 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [14:26:48] pginer: yes, that's normal [14:26:59] * marktraceur looks around for gi11es [14:27:09] gerrit is stupid about handling chained changes [14:28:21] (03PS16) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [14:28:32] (03PS5) 10Gergő Tisza: Add browser tests for options menu on file page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 [14:37:26] tgr: Indeed [14:37:48] tgr: I'm starting to see the value of branch/merge workflows [14:45:00] marktraceur: the wikidata devs use github, and they complained about not being able to chain commits [14:45:24] Yeah, I see where they're coming from [14:45:36] tgr: Maybe Phabricator will be the One True CR Tool. [14:45:49] the concept of chained commits in gerrit is a good one IMO, it's just git-review having horrible UX [14:45:57] Also yes. [14:46:18] tgr: The terrible merge algorithm in Gerrit doesn't help; rebasing locally often has more success [14:46:53] for example, it should be able to detect when a commit is actually changed [14:47:08] Hyup [14:47:17] Which admittedly has gotten better, but not perfect [14:49:21] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) [15:32:19] marktraceur: I'm around now, what's up? [15:36:40] gi11es: Oh, just wondering if you'd had a chance to look at that string of commits [15:36:45] I +1'd them all yesterday [15:36:49] I shall do right now [15:37:00] So if you're good with them, we can push them on Thursday [15:37:22] anything major changed since I last touched them? did tgr address the concerns I had on his? [15:37:47] all but one where I disagreed [15:38:50] No major changes, I think. [15:39:26] ah, didn't see you were in the room, you're no longer voiced [15:40:19] (03CR) 10Gilles: [C: 032] Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [15:40:32] (03CR) 10Gilles: [C: 032] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [15:40:52] Yay, so glad to deal with these finally [15:41:47] (03Merged) 10jenkins-bot: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [15:41:49] (03Merged) 10jenkins-bot: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [16:01:58] (03CR) 10Gilles: [C: 032] Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [16:02:51] (03Merged) 10jenkins-bot: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [16:25:11] (03CR) 10Jforrester: "check experimental" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:26:26] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167800 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:28:24] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559#c12 (10Andre Klapper) So is this still a problem, fourteen weeks later? rillke? bawolff? [16:32:36] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167800 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:41:12] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:42:33] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167813 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:58:07] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559#c13 (10Bawolff (Brian Wolff)) Well the original file from comment 0 is gone from cache (i believe varnish kills things after 30 days no matter what) The issue is not occuring often e... [16:58:37] 3MediaWiki / 3File management: Images not purged from caching servers after deletion - 10https://bugzilla.wikimedia.org/67559 (10Bawolff (Brian Wolff)) p:5High>3Low [17:28:22] 3MediaWiki extensions / 3UploadWizard: Unexpected confirm dialog when clicking away from Special:UploadWizard after setting "Skip - 10https://bugzilla.wikimedia.org/72050#c1 (10Chris McMahon) 5NEW>3RESO/FIX This seems to be fixed as of 19 October [17:54:55] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324 (10Daren Welsh) 3UNCO p:3Unprio s:3normal a:3None On our wiki, we had a page that displayed several image thumbnails. After some time, one of the source im... [18:02:27] (03PS1) 10Siebrand: Allow overriding the documentation URL [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/167840 [18:27:24] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Subfader) s:5normal>3enhanc [18:27:26] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328 (10Subfader) 3NEW p:3Unprio s:3normal a:3None As title says: If a width largher than the original is called, return original image instead of error. [18:48:08] (03CR) 10Gergő Tisza: [C: 032] Allow overriding the documentation URL [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/167840 (owner: 10Siebrand) [18:48:22] (03Merged) 10jenkins-bot: Allow overriding the documentation URL [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/167840 (owner: 10Siebrand) [19:08:20] OK, since the MMV cards are all either claimed or done, I'm going to start the Firefogg investigation [19:30:37] (03CR) 10Gilles: [C: 032] Show panel shadow on full-screen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167775 (owner: 10Pginer) [19:31:14] (03PS1) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 [19:31:19] Well that was easier than I thought [19:31:27] (03Merged) 10jenkins-bot: Show panel shadow on full-screen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167775 (owner: 10Pginer) [19:33:08] 3MediaWiki extensions / 3UploadWizard: Uploading multiple files doesn't work with Firefogg and settings for multiple concurrent uploads - 10https://bugzilla.wikimedia.org/71409#c3 (10Mark Holmquist) 5NEW>3RESO/DUP This is confirmed a duplicate of 69374, because both of you were uploading multiple files a... [19:33:11] (03PS2) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) [19:34:09] Oh, thanks past Mark [19:34:15] * marktraceur contacts legal about patent issuse [19:37:10] (03CR) 10Gilles: [C: 04-1] Fix trivial error in Firefogg upload handling (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [19:37:32] Bah [19:37:51] Herp, good catch [19:39:30] (03PS3) 10MarkTraceur: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) [20:02:28] (03CR) 10Gilles: [C: 032] Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [20:03:14] (03Merged) 10jenkins-bot: Fix trivial error in Firefogg upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/167883 (https://bugzilla.wikimedia.org/69374) (owner: 10MarkTraceur) [20:04:09] Yayyyy [20:04:51] fabr [20:04:54] Ah well. [20:05:16] gi11es: I guess soon you'll be The Grand And Glorious Product, so how will that work for testing when you merge things? [20:06:08] I will have to develop a dissociative identity disorder in order to stay effective [20:06:12] Fun [20:06:27] In that case, other gi11es, Beta will have that patch in about 5 minutes, so if you could test it... [20:06:39] I just... ugh [20:07:34] Or not, whatever, I could just cut through the red tape too [20:07:48] I'll give it a spin on beta [20:07:59] one can never be too paranoid about vagrant/beta differences [20:08:38] firefogg is pretty slick, never used it before [20:08:57] mind you, I tested very small videos [20:09:23] 3MediaWiki / 3File management: thumb.php: If upscale: Return original image instead of error - 10https://bugzilla.wikimedia.org/72328#c1 (10Tisza Gergő) Why should this happen? [20:11:23] 3MediaWiki / 3File management: Allow uploading derivative works and collages (using Upload Wizard?) - 10https://bugzilla.wikimedia.org/67283#c10 (10El Grafo) (In reply to Nicolas Raoul from comment #9) > Created attachment 16770 [details] > Proposed design for integration into the Upload Wizard I'd make tha... [20:27:38] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c1 (10Tisza Gergő) Maybe you have the VipsScaler extension enabled? [20:40:23] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c2 (10Daren Welsh) We do not have that extension installed. [20:41:18] (03CR) 10Gilles: [C: 032] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:41:37] I suspect the Firefogg stuff was written before Firefox supported multiple files per input [20:42:11] (03Merged) 10jenkins-bot: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:48:08] (03CR) 10Gilles: [C: 04-1] Add browser tests for options menu on file page (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza) [20:54:23] marktraceur: I see a problem with schema versioning for the actions logging on beta [20:54:29] for the options menu [20:54:42] warnings in the console about options-open being missing [20:55:22] hmmm oddly only happened after using the back button to go back to MMV after reenabling [20:57:17] n/m, can't reproduce anymore [20:57:22] could have been a caching gremlin [20:57:40] ah! it's back [20:57:57] https://www.dropbox.com/s/mzcnwq6vyn1v8q8/Screenshot%202014-10-21%2022.57.53.png?dl=0 [20:58:37] ah, it must be the sampling [20:58:42] I only hit it when I'm in the sample [20:58:46] Right [20:58:55] so yeah, version not bumped as it should have been, or something [20:59:47] can you fix it? I'm off to bed [20:59:52] schema version definitely not updated in https://gerrit.wikimedia.org/r/#/c/148880/24/MultimediaViewer.php,unified [21:00:43] in fact it was never added to the schema either https://meta.wikimedia.org/wiki/Schema:MediaViewer [21:02:42] I'll fix it, sure. [21:03:20] also, double check that the enable/disable events are still working [21:03:41] since some of that code was moved around [21:04:20] The events didn't change, I think. [21:09:42] gi11es: have a moment ? [21:10:15] matanya: I think he was just heading to sleep [21:10:21] Anything we can help with? [21:10:37] I hope so: https://he.wikipedia.org/wiki/%D7%91%D7%A8_%D7%A8%D7%A4%D7%90%D7%9C%D7%99#mediaviewer/File:Bar_refaeli_5.jpg [21:10:37] indeed, I'll look at it in the morning if I'm the only one who can help [21:10:58] vs https://commons.wikimedia.org/wiki/File:Bar_refaeli_5.jpg#mediaviewer/File:Bar_refaeli_5.jpg [21:11:08] mediaviewer for both files [21:11:24] but different creation date [21:11:29] howcome ? [21:11:39] Same date, different format [21:11:51] means? [21:11:54] matanya: I'd guess because our date/time library is localised properly :) [21:12:06] In both cases it's 1989-12-31 [21:12:22] Just different orders [21:12:52] The only date of creation on the image is "1990" too [21:13:09] Maybe that needs to get fixed/augmented [21:13:26] doesn't explains why it ends up as 1987 in hebrew [21:13:31] -s [21:13:34] ...it does? [21:13:39] I see 189 [21:13:41] 1989* [21:13:50] is see 1987 in he [21:13:57] and 1990 in commons [21:14:07] I see the same thing as matanya [21:14:07] https://www.dropbox.com/s/rq8rb53w2ltsl0i/Screenshot%202014-10-21%2023.13.56.png?dl=0 [21:14:20] Maybe I'm using en on hewiki [21:14:26] Oh, I see it now [21:14:39] Maybe we're so bloody brilliant that we're using a totally different calendar for Hebrew [21:14:43] let's blame that date library [21:14:53] I already do [21:14:59] let's blame it more [21:15:00] moment.js, right? [21:15:03] yes [21:16:29] I'll investigate and see if we can't fix 'er upstream somehow [21:16:35] (03CR) 10Gergő Tisza: Add browser tests for options menu on file page (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza) [21:16:41] Thanks for the report, matanya [21:16:53] it appears that moment has at least attempted to handle the hebrew calendar: https://github.com/moment/moment/issues/1454 [21:16:56] probably related [21:17:07] I figure so [21:17:18] gi11es: Sleeeeeep [21:17:32] thanks for quick reply :) should i open BZ marktraceur ? [21:17:41] matanya: Wouldn't mind it [21:17:51] will do [21:21:12] matanya: probably just caching [21:21:27] did hard refresh [21:21:36] doesn't help [21:21:44] API results get cached in varnish [21:21:54] for a day, I think [21:22:02] tgr: Ssh, we're blaming moment.js still. Hard. :P [21:22:18] But also that's fine [21:22:26] tgr: No way to break the caching? [21:22:47] uhh [21:22:55] manually, you mean? [21:22:56] you mean every mediaviewer link goes throuh api?? [21:22:58] Yeah [21:23:03] matanya: Yup [21:23:06] that sounds like a waste [21:23:16] you can probably ssh to one of the prod servers and send a purge request to varnish [21:23:26] Nah, the API is just a different method to access the same stuff [21:23:34] tgr: you can invalidate the varnish cache [21:23:56] not really [21:24:07] (03CR) 10Gilles: Add browser tests for options menu on file page (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza) [21:24:17] you can make MediaWiki send purges for the cached HTTP pages [21:24:44] you can't do the same for API requests [21:25:04] i see [21:25:39] (03PS1) 10MarkTraceur: Add new version of actionlogging schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167955 [21:25:42] in general, sane cache invalidation is proprierary functionality in varnish [21:25:48] you have to buy it [21:25:50] git ervierw <-- Mark has had a long day [21:26:12] At least the v is in the right place [21:26:46] plus, the CMD API has its own cache, in memcached [21:27:00] it's really a lot easier to just wait a day :-) [21:27:31] 3MediaWiki / 3File management: Large image handling and dependency on $wgMaxImageArea and $wgMemoryLimit - 10https://bugzilla.wikimedia.org/72324#c3 (10Tisza Gergő) Can you share the test file? [21:31:24] (03CR) 10Gergő Tisza: Add browser tests for options menu on file page (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza) [21:33:39] (03PS1) 10Gergő Tisza: [WIP] Change above-the-fold layout [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167958 [21:33:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Change above-the-fold layout [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167958 (owner: 10Gergő Tisza) [21:39:36] matanya: Let me know if it persists tomorrow, K? :) [21:39:45] sure [21:41:18] (03CR) 10Gergő Tisza: [C: 032] Add new version of actionlogging schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167955 (owner: 10MarkTraceur) [21:42:59] (03Merged) 10jenkins-bot: Add new version of actionlogging schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167955 (owner: 10MarkTraceur) [21:44:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167958 (owner: 10Gergő Tisza) [22:53:46] chrismcmahon: is there a way to wait a fixed number of seconds with watir? [22:54:01] I need to make sure a certain event does *not* happen [22:54:32] but all I find in the documentation is "wait until X happens or throw an error" type of functionality [22:54:45] tgr "wait_until" waits by default for the block to return true, default 5 seconds, "wait_until(10)" for 10 seconds [22:55:25] yes, but I need to wait 5 seconds, period [22:55:36] what should I put in the block then? [23:17:18] (03PS6) 10Gergő Tisza: Add browser tests for options menu on file page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 [23:20:24] (03CR) 10Gergő Tisza: [C: 04-1] Add browser tests for options menu on file page (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (owner: 10Gergő Tisza)