[07:14:56] tgr: you there? [08:47:14] Steinsplitter: I am now [08:51:00] something was broken but works again :):):) [08:55:40] (03CR) 10Gilles: [C: 032] "+2ing based on this very positive feedback and Gergo's earlier call to +2 once QA has reviewed it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [08:56:24] (03Merged) 10jenkins-bot: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [08:57:03] (03CR) 10Gilles: [C: 04-1] "Needs test coverage. Probably more E2E than QUnit." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [09:02:11] pginer: can you review the styling of https://gerrit.wikimedia.org/r/#/c/164529/ ? it's the cog icon stuff on the file page [09:05:03] (03PS4) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [09:15:16] (03CR) 10Gilles: [C: 04-1] "There's an error when trying to (re-)enable mmv from the preferences popup:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [09:28:40] (03CR) 10Gilles: "Now that my E2E test for the download dialog have gone through with QA's seal of approval, you can easily replicate what it does for this " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [10:04:03] (03PS15) 10Gergő Tisza: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [10:04:45] (03CR) 10Gergő Tisza: "Fix reenable" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [10:28:40] (03CR) 10Pginer: "Some comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [10:29:03] thanks gi11es, I added some comments [11:28:37] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256 (10Andre Klapper) p:5Unprio>3Normal [11:30:07] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10Andre Klapper) p:5Unprio>3Low [12:05:22] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044 (10Andre Klapper) p:5Unprio>3Normal [12:45:10] (03CR) 10Gergő Tisza: [C: 04-1] "Lots of code duplication in the dialog subclass." (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [12:46:24] Argh [13:00:08] 3MediaWiki extensions / 3GlobalUsage: GlobalUsage not working with a simple one-database with multiple wikis setup (REL1.18) - 10https://bugzilla.wikimedia.org/30571#c13 (10Andre Klapper) 5NEW>3RESO/WOR Unfortunately closing this report as no further information has been provided. Gregor: Please feel fr... [13:00:24] 3MediaWiki extensions / 3UploadWizard: Cannot complete uploads following description: Unable to check file's status (mw.UploadWizardDetails.js:1362) - 10https://bugzilla.wikimedia.org/60247#c13 (10Andre Klapper) (In reply to Nemo from comment #11) > Per http://lists.wikimedia.org/pipermail/multimedia/2014-Ju... [13:02:52] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c4 (10Andre Klapper) Does the Multimedia team look at their bug reports? (In reply to Sam Reed (reedy) from comment #2) > There's actually quite a lot of these almost co... [13:07:42] (03PS5) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [13:22:22] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c5 (10Tisza Gergő) I thought this was fixed by Id1b5872d741208338cd7157f83f4ff6762ae34ee ? [13:23:07] Guh, coffee far too dark for me. [13:23:12] Must soldier on [13:23:17] Something about code duplication [13:24:18] Hrm...I thought I was disabling the buttons [13:24:29] Maybe herpderps in mwui didn't style [disabled] things. [13:25:26] No, the style is there [13:26:40] tgr: How did you get the preference request to take long enough to test whether the elements were disabled? [13:27:11] I use vagrant, that's a feature :) [13:27:39] ...ugh [13:27:41] an AJAX request takes 100-200ms [13:27:59] but I would just replace one of the deferred-returning functions [13:28:06] Right. [13:28:20] I was wondering if you had done something in particular, but OK, I'll screw with it [13:28:40] (03CR) 10Reedy: "Possibly fixed bug 69444 ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157511 (owner: 10Brian Wolff) [13:29:00] mw.mmv.Config.prototype.setMediaViewerEnabledOnClick = function () { var d = $.Deferred(); setTimeout( function () { d.resolve(); }, 500 ); return d; }; [13:29:04] something like that [13:29:36] if you don't want to replace it, you can add the delay in a .then() [13:31:02] *nod* [13:31:16] I just took out the handler in the viewingOptions file [13:31:29] But for some reason my prop( 'disabled', true ) isn't working [13:31:32] * marktraceur investigates [13:31:48] Oh, durr. prop( 'disable', true ) [13:32:18] Now it works. [13:51:32] tgr: "A nicer approach IMO is to use $.triggerHandler instead of $.trigger" ...where? [13:51:45] https://gerrit.wikimedia.org/r/#/c/148880/15/resources/mmv/mmv.js [13:53:28] use it in viewingOptions.js instead of the $( document ).trigger( 'mmv-change-preference', true ) call, and return the deferred from the handler [13:53:46] Ah. [13:54:00] that way you can handle errors in the view, without having to resort to reverse events and such [13:54:07] Sure sure. [13:58:53] 3MediaWiki extensions / 3UploadWizard: Cannot complete uploads following description: Unable to check file's status (mw.UploadWizardDetails.js:1362) - 10https://bugzilla.wikimedia.org/60247#c14 (10Tisza Gergő) You can see current numbers at http://multimedia-metrics.wmflabs.org/dashboards/uw ; drop on the de... [14:08:44] (03CR) 10Gergő Tisza: "> When accessing Media Viewer from the File page I had" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [14:11:52] 3MediaWiki extensions / 3UploadWizard: Cannot complete uploads following description: Unable to check file's status (mw.UploadWizardDetails.js:1362) - 10https://bugzilla.wikimedia.org/60247#c15 (10Tisza Gergő) p:5High>3Normal s:5major>3normal For error statistics and a rough first take on prioritizat... [14:23:04] (03CR) 10Gergő Tisza: "> When clicking on the buttons the icons disappear, they" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [14:25:33] tgr: We don't have recommendations from design about handling errors...do we? [14:26:04] I guess I can just reenable the buttons and let them try again [14:26:38] https://tools.wmflabs.org/styleguide/desktop/section-3.html has some error styles but they are not very useful [14:27:28] Sigh. [14:27:28] I would try showing an error message with a similar look than the "MV is currently disabled" header, just with a more aggressive message [14:27:39] Right. [14:27:42] but Pau probably has better advice [14:27:51] If only he were here. [14:28:07] indeed [14:28:55] I think the free WMF bouncers thing is worth revisiting [14:29:03] It's in progress [14:29:10] ^d has a thing sort of working. [14:29:13] Yuvi is involved. [14:29:20] oh, cool [14:30:34] But, him being idle might not help me much [14:30:43] At least in this case. [14:40:06] tgr marktraceur : Morning guys! Just a quick note to let hyou know that I accepted #876 (Make MediaViewer text larger in Monobook), which looks good on Beta. Thanks for doing this :) [14:40:23] Sweet. [14:40:32] marktraceur tgr : How are we coming along with the Disable and Enable tickets? [14:40:45] It's coming. [14:40:51] See above, we have a design question [14:41:12] What’s the issue? I came in late in the thread. [14:41:30] fabriceflorin: When we encounter an error in setting the preference, not sure what we should do [14:42:31] Can you ping Pau pginer by email about this, and Cc: me, so we’re all on the same page? [14:42:40] Sure. [14:42:53] What is the type of error that’s causing this issue? [14:43:31] Nothing in particular [14:43:44] We sometimes get API errors and being able to know the text helps with debugging [14:46:41] Sent to the list. [15:59:31] Goddamn it Eden Prairie [15:59:37] No cell reception at the house [15:59:50] Need to go to the coffee shop to figure out aparment stuff, brb [16:17:21] Lookie there marktraceur, you've got you a Ward Cunningham [16:30:11] I have! [16:30:39] fabr crap [16:36:15] Oh, exciting, Keegan is in my time zone now. [16:44:01] WOO HOO [16:44:23] I, however, have cell service at home [16:44:27] kind of [16:44:50] Damn you, sir [17:10:02] Ugh, duplicate code time I guess [17:17:37] 3MediaWiki extensions / 3TimedMediaHandler: Enable 1080p (aka full-hd) support in TMH - 10https://bugzilla.wikimedia.org/71705#c8 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX 1080p transcodes are now appearing on commons. *there are very few transcodes that are timing out so far, which surprised me. Maybe... [17:31:37] Ugh, apartment weirdness. [17:31:39] marktraceur: are you booked for Amsterdam? Is e'ryone staying in the hostel? [17:31:45] I may need to skip out at some point. Ugh. [17:32:00] Keegan: Yeah, I'm booked, my impression is that wmnl is doing the booking for the hostel and billing Travel. [17:32:32] Hm, k. I need to fill out the travel request and there's too many things involving numbers [17:41:10] 3MediaWiki extensions / 3MultimediaViewer: Add formatting tests to CI - 10https://bugzilla.wikimedia.org/72140 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Catching whitespace and other small formatting tests by hand is annoying. There should be an automated test catching these. [17:42:53] 3MediaWiki extensions / 3MultimediaViewer: Add formatting tests to CI - 10https://bugzilla.wikimedia.org/72140#c1 (10Tisza Gergő) a:3Tisza Gergő For reference, a similar change in UW: * JJB config: https://gerrit.wikimedia.org/r/#/c/155834 * zuul config: https://gerrit.wikimedia.org/r/#/c/155836 * UW conf... [17:45:08] I guess I'll go deal with apartments after the meeting. [18:19:10] Maybe I don't need to be in this meeting, hmmm [18:19:23] I could go and fill out an application and drive it across the city instead... [18:50:04] OK so I'm going to go sign a lease, I'll be on late tonight to make up for it [18:50:12] Get the bloody enable/disable thing finished finally, I hope [18:50:51] I still feel like everything is super hand wavey [18:51:04] * bawolff awaits something concrete [18:53:32] bawolff: I've brought up the idea of having a very rough prototype available, where people could start modelling the data for actual files, etc. [18:53:57] it'd have to come with a giant disclaimer about the fact that it's not going to be representative of expected final usability or UI [18:54:25] but it'd help with people wrapping their minds around what the data would look like in practice, I think [18:54:48] A prototype would be nice [18:56:09] 3MediaWiki extensions / 3GWToolset: GWToolset uploads files without file description pages - 10https://bugzilla.wikimedia.org/71527#c4 (10Jean-Fred) 5NEW>3UNCO The pages got deleted and I finally got around to upload them again. Everything seems fine. Changing for "Unconfirmed" but that is still fairly w... [18:56:40] basically slapping wikibase and file upload on a labs wiki, tied a minimum to each other [18:57:51] and meanwhile pginer would be focusing on UI prototypes for the real UX [18:58:07] he's going to be doing that anyway, I think he'll be ahead of the engineering work [18:58:32] that will definitely help with people picturing what it'll be like in concrete terms [19:01:37] 3MediaWiki extensions / 3GWToolset: GWToolset uploads files without file description pages - 10https://bugzilla.wikimedia.org/71527#c5 (10Bawolff (Brian Wolff)) I suspect this is not gwtoolset's fault, but MW. We've had intermitent problems before where this has happened. At the time I suspected (but could n... [19:03:41] fabriceflorin: we should probably have a chat/meeting/etc to talk about improving the upload wizard, somewhere in the coming months [19:03:52] I already try to collect feedback from users and organisers [19:18:25] TIL that loading mediawiki.ui or mediawiki.ui.button won't make button icons work, even though 90% of the icon-related styles do get loaded, but a critical one is missing [19:18:37] you need to load mediawiki.ui.icon [19:18:57] wouldn't it be super nice to have actual documentation for mediawiki.ui? [19:21:21] (03PS6) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [19:24:22] (03CR) 10Gergő Tisza: "The tooltip is a separate changeset, E2E test will also be a separate changeset (and there is not much to unit test, the change is mostly " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [20:03:22] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c6 (10Sam Reed (reedy)) (In reply to Tisza Gergő from comment #5) > I thought this was fixed by Id1b5872d741208338cd7157f83f4ff6762ae34ee ? Maybe. But the bug wasn't ref... [20:48:49] (03PS3) 10Gergő Tisza: [WIP] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [21:16:14] tgr: Documentation? You must be new here. :) [21:16:22] (but yes of course that would be nice) [21:22:50] Hi Romaine, sorry I missed your earlier message. Great minds think alike: we plan to shift our team’s focus to Upload Wizard fo our next development cycle, and would appreciate your help in prioritizing the most important tasks based on user feedback. [21:24:48] Romaine: Already prioritized: Fixing chunked uploads and Firefogg, some work on the stash API [21:25:06] I also have continued evil plans regarding building UW into a classy system. [21:25:57] no problem [21:26:40] marktraceur: that is not understable to me :p [21:28:08] Romaine: Which part, "classy system"? [21:28:11] Or all of it [21:28:17] Because all of it is pretty jargony [21:29:11] I can't say that I am a developer/technical on the level you speak, while local users on wikis consider me as very technical [21:29:22] Oh, sure. [21:29:32] Romaine: Chunked uploading is why most really big uploads fail for people. [21:29:40] ah ok [21:29:45] got it [21:29:52] Romaine: Firefogg is a Firefox extension - if people have it installed, a lot of uploads won't work even though they should [21:30:22] Romaine: And the stash API is where we stick files during the UW process before we have the description stuff, because we need a description before publishing. It's sort of like a draft namespace for files. [21:30:28] Romaine: To get a sense for what we plan to work on this cycle, check out the UW column on this Current Cycle Wall: [21:30:29] http://ur1.ca/h7w5s [21:30:31] ah ok [21:30:53] As for being classy [21:31:01] Well, UW is just a little bit of a redneck right now [21:31:07] So I'm going to refactor it to be more of a lady [21:31:17] And, you know, object-oriented. [21:33:26] I just serve as intermediate between the community and tech, between community and chapters and between community and WMF [21:34:25] and I do some stuff :p [21:34:39] You're part of the 90% of humanity that's made up of middlemen. :) [21:35:16] Sorry, 50%. [21:35:18] mmm, there are not much users who do what I do [21:35:35] "Eliminating the middleman is never as simple as it sounds. 'Bout 50% of the human race is middlemen, and they don’t take kindly to being eliminated." [21:35:48] :p [21:36:10] well, let me say I would not call myself middlemen [21:37:03] :) nor would I, true [21:37:53] being in the middle between two parties makes someone more unique, because must be able to understand both worlds [21:42:42] Romaine: I agree with you that middlemen are important — and sometimes underappreciated. So let me make it clear that I really appreciate the work you do! :) [21:43:51] :) [23:31:39] 3MediaWiki extensions / 3MultimediaViewer: (possibly spurious) "Could not load image data http" errors on beta labs - 10https://bugzilla.wikimedia.org/72162 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None It is hard to tell if this is an actual bug or an artifact of the beta labs test environment,...