[03:43:52] 3MediaWiki / 3File management: Duplicate-archive files not detected (previously deleted files when uploading identical [SHA1] files) when file extension is upper case - 10https://bugzilla.wikimedia.org/72070 (10Rainer Rillke @commons.wikimedia) [06:36:52] 3MediaWiki / 3File management: Allow uploading derivative works and collages (using Upload Wizard?) - 10https://bugzilla.wikimedia.org/67283#c9 (10Nicolas Raoul) Created attachment 16770 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16770&action=edit Proposed design for integration into the Upload W... [07:56:23] 3MediaWiki / 3Uploading: CopyUploadsFromSpecialUpload - 10https://bugzilla.wikimedia.org/72073#c1 (10Ryan Kaldari) 5NEW>3RESO/INV Oops, hit return too soon :P [08:02:44] (03CR) 10Gilles: "Hmm yes, it's possible that I had left monobook turned on after testing the monobook changeset. I'll double check." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/165788 (owner: 10MarkTraceur) [08:23:11] (03CR) 10Gilles: "Not sure if monobook had something to do with it, but sure, it sounds like a preexisting issue. That being said, now that we've freed spac" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/165788 (owner: 10MarkTraceur) [08:32:07] 3MediaWiki / 3Uploading: Investigate SVG's uploaded with external resources - 10https://bugzilla.wikimedia.org/65839 (10PRO) [08:38:36] (03CR) 10Gilles: "I can reproduce the bug with phantomjs. I hope it's just something timing-related, I've run into phantomjs limitations before and it can b" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [08:49:20] (03PS2) 10Gilles: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 [08:49:27] (03CR) 10Gilles: E2E tests for download menu (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [09:09:32] (03CR) 10Gergő Tisza: [C: 04-1] "The size select menu label checks fail intermittently. That's probably because changing the size requires an AJAX call so there is a race " (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [09:26:31] (03PS3) 10Gilles: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 [09:35:20] (03CR) 10Gilles: E2E tests for download menu (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [09:41:52] (03PS4) 10Gilles: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 [09:58:52] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c5 (10Rob Kam) Image thumbnailing is fixed now but still getting "Linker::makeImageLink: File:Lorem.pdf does not allow inline display". [10:27:44] (03CR) 10Gergő Tisza: [C: 031] "Looks good to me. I'll leave it open in case you want a review from someone in QA as well; otherwise, feel free to +2." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [10:50:22] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c6 (10Tisza Gergő) You normally get "does not allow inline display" if the media handler cannot figure out the size of the image, which probably means that callin... [11:55:37] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c7 (10Rob Kam) The problem is with the pdf, it's working fine with other pdfs. [12:08:07] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c8 (10Tisza Gergő) Can you test the pdf with the pdfinfo version you have on the server and see if it correctly extracts something like "Page size"? [12:12:22] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c9 (10Rob Kam) Created attachment 16771 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16771&action=edit Another pdf that fails to render. [12:15:38] 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c10 (10Rob Kam) pdfinfo HRM_OSC_SUB_flowchart.pdf Fontconfig error: Cannot load default config file Title: HRM_OSC_SUB_flowchart.eps Author: Rob... [12:44:52] 3MediaWiki extensions / 3PdfHandler: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71943 (10Umherirrender) 5PATC>3RESO/FIX [12:47:52] 3MediaWiki extensions / 3MultimediaViewer: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71942 (10Umherirrender) 5PATC>3RESO/FIX [12:47:52] 3MediaWiki extensions / 3CommonsMetadata: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71940 (10Umherirrender) 5PATC>3RESO/FIX [12:48:07] 3MediaWiki extensions / 3TimedMediaHandler: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71935 (10Umherirrender) 5PATC>3RESO/FIX [13:26:15] (03CR) 10Gergő Tisza: Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [13:47:02] (03PS2) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [13:47:49] (03CR) 10jenkins-bot: [V: 04-1] Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [14:33:53] (03CR) 10Gergő Tisza: Add viewing options panel (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [14:36:29] (03PS3) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [15:29:05] pginer: I am a bit unclear about the connection between https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/589 and https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/895 [15:29:15] is 895 part of 589? [15:29:59] (and having so similar card numbers also doe not help) [15:30:32] it certainly looks much nicer than the old layout, but then the current work on #833 seems a bit pointless [15:30:34] There is some duplication on those cards [15:32:03] Let me try to summarize what each card describes: [15:32:36] #833 moves license info to be grouped together with the authorship info. [15:32:59] This is needed to leave room for the caption and the rest of the cards have it grouped in that way. [15:34:54] #895 is about removing the below the fold description + design adjustments (which are needed to avoid showing a big gap on the below the fold panel). [15:36:51] #589 is about showing the caption above the fold, and includes the same design adjustments as #895. [15:37:05] what is described by each card is more or less clear, the reason I am asking is that #589 has been scheduled for this sprint but #895 has not, and it seems like a dependency to me [15:37:44] also, #895 has two mockups and Mark was working based on the first one, but the other cards just seem to assume the second one [15:38:24] um, I mean #833 has two mockups... [15:39:22] It is not a dependency. #589 does not involve removing the caption below the fold [15:39:59] Imlementing #589 will simplify #895 since the layout adjustment would be already done. [15:41:43] Regarding #833, it basically says, you’ll group license together, if the layout adjustments have been done, it will look in this way; if they are not, in this other way. [15:44:00] that seems like superfluous work if the layout adjustments will be done eventually [15:44:40] which is the part I am unsure about, #895 was not picked for the current cycle which basically means we are dropping it [15:44:49] or was that an oversight? [15:45:08] also, you said in a comment [15:45:11] "The styling for the author area (originally part of #895) was added as part of this card after a conversation with Jared." [15:45:32] so that should be done as part of #589, even if #895 is dropped, right? [15:46:08] yes [15:46:55] mm [15:47:10] probably just easier to do #895 anyway, then, the remainder is trivial [15:47:21] I'll pick it into the sprint [15:47:47] Regarding #895, we decided not to remove the below the fold description just yet [15:48:14] The reason is that people is accessing the below the fold area twice as much as the big blue “more details” button [15:49:00] That may change when we move the caption on top. But doing one change at a time will allow to see the consequences of our changes in user behaviour [15:52:03] that part can be done in a separate commit and not merged, then [15:52:17] that's the trivial part, the layout change is the harder one [15:52:20] I'll add a note [16:01:31] gi11es: Poke? [16:57:55] 3MediaWiki extensions / 3CommonsMetadata: Return the number of authors from multiple Information templates - 10https://bugzilla.wikimedia.org/72081 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None When there are multiple {{Information}}-like templates on a file page (a typical pairing is {{Artwork}}... [16:59:53] 3MediaWiki extensions / 3CommonsMetadata: Return the number of authors from multiple Information templates - 10https://bugzilla.wikimedia.org/72081 (10Tisza Gergő) [16:59:55] 3MediaWiki extensions / 3MultimediaViewer: Display "and X more authors" when appropriate - 10https://bugzilla.wikimedia.org/72082 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None When the CommonsMetadata field described in bug 72081 is set, MediaViewer should warn that there are more authors, e.g. ap... [17:06:53] 3MediaWiki extensions / 3MultimediaViewer: Display "and X more authors" when appropriate - 10https://bugzilla.wikimedia.org/72082#c1 (10Tisza Gergő) Tracked in Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/937 [17:07:22] 3MediaWiki extensions / 3CommonsMetadata: Return the number of authors from multiple Information templates - 10https://bugzilla.wikimedia.org/72081#c1 (10Tisza Gergő) Tracked in Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/937 [17:10:41] (03CR) 10Cmcmahon: [C: 04-1] "I see a consistent failure running this on beta labs:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [17:19:09] (03CR) 10Gilles: "Cmcmahon: if you're aiming the tests at beta, that's expected to happen. This changeset not only introduces the new tests but also fixes a" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [17:26:16] updating the mingle project variables... [17:32:03] pginer: any comments on https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/937 from a design standpoint? [17:32:26] I don't think it needs design, but just in case you see something problematic with it... [17:40:21] gi11es, tgr: https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/150 just for you [17:44:42] (03CR) 10Dduvall: [C: 04-1] "It's not clear to me what these scenarios are testing which, to me, indicates some convolution. As a general rule, whenever you feel compe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [17:51:34] tgr seems a good solution [17:53:14] * marktraceur looks cautiously at calendar [17:53:18] OK, no more distractions [17:54:14] (03CR) 10Gilles: "Using the "Download menu" scenario as a concrete example, are you talking about roughly having each When (and corresponding Thens) into it" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [17:54:40] 3MediaWiki extensions / 3CommonsMetadata: Prefer information templates that are about the file - 10https://bugzilla.wikimedia.org/72084 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None When an image has multiple information templates (e.g. {{Artwork}} + {{Photograph}}), prefer the one that's about th... [18:02:13] (03CR) 10Dduvall: "> Using the "Download menu" scenario as a concrete example, are you talking about roughly having each When (and corresponding Thens) into " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [18:07:01] (03PS1) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [18:07:18] Very beginnings of a test suite [18:07:19] Sigh. [18:07:25] Will fix the behaviour first [18:07:49] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [18:21:03] guillom: Hey Guillaume, did you get the email I just sent you about the Structured Data blog post? I can’t seem to access the final draft at the URL you gave us. [18:25:55] (03PS5) 10Dduvall: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [18:27:01] (03CR) 10jenkins-bot: [V: 04-1] E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [18:31:15] (03PS6) 10Dduvall: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [18:38:52] (03CR) 10Dduvall: "I've broken out the "download menu" scenario into multiple scenarios to show how it might make things clearer. Of course, feel free to rol" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles) [19:25:48] (03CR) 10MarkTraceur: "Replies inline" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [19:37:23] (03PS13) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [19:37:31] Try that on for size. [19:38:07] (03CR) 10jenkins-bot: [V: 04-1] Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [21:08:16] (03PS7) 10Gilles: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 [22:02:21] (03PS14) 10Gergő Tisza: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:03:02] (03CR) 10Gergő Tisza: "Fixed jslint issues." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:03:19] Thanks tgr [23:57:04] (03CR) 10Dduvall: [C: 031] "Your latest patch set looks fantastic! Seriously, these are exemplary feature files now, and I think we should just point everyone here an" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 (owner: 10Gilles)