[00:53:01] fabriceflorin, in case you didn't notice, the download MW UI message is also broken/missing [00:53:03] on mw.org [00:53:07] for the tooltip [00:54:17] Eloquence: Yes, there was a snafu during the SWAT, marktraceur deployed the old version, then had to re-deploy the new one again. He’s going to have to run scap again. He says he can get everything done by tomorrow, before we get to Commons. [00:55:37] thanks - just read the backscroll [00:55:38] Eloquence: You can see the working version on beta, which looks good to me: http://en.wikipedia.beta.wmflabs.org/wiki/Rapa_Nui_National_Park [00:55:41] cool [00:57:48] with the metadata panel de-cluttered, the interaction with it also feels a lot more natural .. in case we decide to keep it [00:57:58] though I'm on board with the ultimate removal plan [01:01:28] Eloquence: Yes, the product feels better as it gets simpler, IMHO. Had a good chat with Pginer this morning about all this. He plans to test a prototype with no metadata panel, to validate this will work for most users. You can already see it in the link he gave us via email. Also, we’re looking to put the help in the settings panel, as shown here: [01:01:28] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/882 [01:03:07] fabriceflorin, my vote is for having it in the settings dialog to minimize clutter :) [01:04:20] Eloquence: Yes, I think Option A feels right and the settings panel will be a natural place to look for that info. So the viewer without metadata panel might look like the mockups in this card, but maybe with a 2-line caption instead: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/892 [01:05:11] I second your comments about potentially making the font size smaller , esp for longer captions [01:07:20] Eloquence: Yes, it already becomes a smaller font if the caption is long, but we may want to stick to one smaller size, after we see all this in action. Keep in mind that all this is a couple weeks away, since Mark is just now starting on the disable/enable cards, then the captions/descriptions, then the help/settings, then the removal. With 10 days in Germany sandwiched in the middle of it all :) [01:09:52] Eloquence: You and I should probably have a quick chat about structured data this week, if you have some time on Tuesday or Wednesday. Want to aim for 15 mins. on Wed.? [01:18:01] fabriceflorin, EOD Wednesday should work [01:19:18] Eloquence: Cool. I will firm up with Praveena. You are also Cc:d on emails, but wanted to bring up a couple questions about scope and process, based on my meeting with Denny last week. [01:19:49] kk. yes, good to check in - haven't had time to follow along [03:15:33] (03CR) 10Reedy: "Needs rebasing to use en.json instead (should be trivial)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (owner: 10Nischayn22) [03:16:03] (03PS5) 10Reedy: Allow more than 50 flickr images. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://bugzilla.wikimedia.org/42979) (owner: 10Nischayn22) [03:16:07] (03CR) 10jenkins-bot: [V: 04-1] Allow more than 50 flickr images. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://bugzilla.wikimedia.org/42979) (owner: 10Nischayn22) [03:17:54] (03CR) 10Reedy: [C: 04-1] "There's also:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://bugzilla.wikimedia.org/42979) (owner: 10Nischayn22) [03:19:13] (03CR) 10Reedy: Allow more than 50 flickr images. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://bugzilla.wikimedia.org/42979) (owner: 10Nischayn22) [11:09:39] (03CR) 10Nischayn22: "No longer working on this, somebody please take this cookie." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://bugzilla.wikimedia.org/42979) (owner: 10Nischayn22) [11:40:46] (03PS1) 10Gilles: Fix repo/details check of E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163828 [11:50:27] (03PS1) 10Gilles: Lowercase tooltip wording [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163829 [11:51:42] (03CR) 10Gilles: Change tooltip wording (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163177 (owner: 10Gilles) [11:57:55] (03CR) 10Gilles: Add tracking categories for files with attribution problems (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 (owner: 10Gergő Tisza) [12:01:13] (03CR) 10Raimond Spekking: [C: 032] Lowercase tooltip wording [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163829 (owner: 10Gilles) [12:01:51] (03Merged) 10jenkins-bot: Lowercase tooltip wording [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163829 (owner: 10Gilles) [12:31:14] gi11es: me again [13:16:59] (03PS6) 10Gergő Tisza: Add tracking categories for files with attribution problems [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 [13:17:49] (03CR) 10Gergő Tisza: [C: 032] "per Gilles" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 (owner: 10Gergő Tisza) [13:18:06] (03Merged) 10jenkins-bot: Add tracking categories for files with attribution problems [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 (owner: 10Gergő Tisza) [14:25:34] (03PS1) 10Gergő Tisza: Throttle / debounce resizes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 [14:28:10] Well, the messages got successfully fixed overnight [14:28:17] So we should be set to go [14:33:02] I'm feeling a bit meh, though. I might wander into bed to rest for a bit. [14:39:58] (03PS5) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [14:42:42] (03CR) 10Gergő Tisza: Log image dimensions (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [14:44:18] (03CR) 10Gilles: [C: 04-1] Throttle / debounce resizes (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 (owner: 10Gergő Tisza) [14:54:20] (03PS2) 10Gergő Tisza: Debounce resizes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 [14:55:09] (03CR) 10Gergő Tisza: "Ew, that was lame. Thanks for catching!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 (owner: 10Gergő Tisza) [14:55:47] (03PS6) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [15:09:14] (03CR) 10Gilles: [C: 032] Debounce resizes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 (owner: 10Gergő Tisza) [15:15:08] (03CR) 10Gilles: [C: 032] Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [15:15:53] (03Merged) 10jenkins-bot: Debounce resizes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163855 (owner: 10Gergő Tisza) [15:15:55] (03Merged) 10jenkins-bot: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [15:18:20] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163#c10 (10Jackmcbarn) A few questions: Is IE's autodetection really so bad that we need to reject valid binary images because they have something that looks like HTML in them? Also, how di... [15:25:27] James_F: you mentioned once that there were plans to disable logins for old IE, for security reasons [15:25:39] is that still the case? [15:31:35] tgr: I don't know where that's ended up; it's possible that disabling all JS for IE<8 means we don't feel the need. [15:36:18] James_F: I am asking because we are still blocking the upload of valid files due to the mime sniffing misfeature in IE6-7 [15:36:45] do you maybe have a bug number or other URL at hand? [15:38:17] gi11es: how do you run e2e tests in vagrant these days? the browsertesting role seems to be gone [15:38:50] The tests and runner stuff should be there all the time now [15:39:08] you need to "bundle install" in the browser tests folder or something like that [15:39:11] then just "cucumber" [15:39:39] you might need to set up a few environment variables, I don't know if there are defaults for all the needed ones [15:43:58] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163#c11 (10Bawolff (Brian Wolff)) (In reply to Jackmcbarn from comment #10) > A few questions: Is IE's autodetection really so bad that we need to reject > valid binary images because they... [15:44:25] tgr: Looking. [15:51:52] tgr_: let me know if you have any Cucumber issues [15:53:39] (03PS2) 10Gergő Tisza: Merge two $wgExtensionFunctions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [15:55:29] James_F: I have to disconnect, if you find it, could you mail it to me? [15:55:30] sorry for the trouble [15:55:39] tgr_: Will look. [16:04:08] (03CR) 10Gilles: [C: 032] Merge two $wgExtensionFunctions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [16:04:46] (03Merged) 10jenkins-bot: Merge two $wgExtensionFunctions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [16:46:39] marktraceur: Morning! Looks like all’s well for the deployment of Media Viewer to Commons today, from my perspective: the version now on mw.org looks great. Any concerns on your end? [16:54:10] Sweet. [16:54:14] No, I'm good too [16:57:58] the new MV version is bether :) [17:02:25] marktraceur: Cool. I will prepare the two-part announcements: later today on MM and Commons mailing lists, and Friday morning on various Village Pumps. How are you coming along with the more prominent Disable/Enable feature? Any issues? [17:03:57] Steinsplitter: I’m glad you like the new Media Viewer. We based these improvements on suggestions from our community and our usability studies. I think they make a big difference and the user experience feels a lot simpler and smoother. Thanks for your support in making this happen. :) [17:06:34] fabriceflorin: I've been feeling about 80% today so I took a break, but I'm trying to recover [17:07:26] marktraceur: Sorry to hear that. Hope you feel better soon. Where are you now? in Vegas or the Twin Cities? [17:07:39] Vegas still, until Columbus Day [17:08:21] marktraceur: Oh, good. On the plus side, you have family to look out for you. :) [17:13:48] Not really :P my parents are both working and my brother has school [17:17:52] marktraceur: Maybe you could take a long nap after we deploy. I find that always helps recharge my batteries … [17:18:32] Maybe so [17:18:37] I have a few meetings today though [17:18:40] Want to at least be awake there [17:18:50] I don't think I need to be around for the deploy anyway [17:19:08] But to ansswer your question, the options thing is happening [17:19:23] I rescued the old patch and I've been reworking it to use the new dialog class instead of its own stuff [17:19:28] OK. When’s the deploy today? noonish? [17:19:37] Uhhh I think 11ish is more accurate [17:19:54] (note to self: start using UTC for things so you're used to it when you move) [17:20:27] Cool. I’ll keep an eye on it. I guess that would be 18:00 UTC? [17:20:38] Yup [17:21:15] Glad you’re making progress on the disable/enable options, which should make a lot of folks happy. Let me know if you have any product questions. [17:21:48] Sure sure [17:21:52] I think it's all fleshed out though [17:23:04] marktraceur: Yeah, Pau and Abbey have done a great job with the prototype and the testing, and it seems pretty straightforward now. [17:25:17] BTW, I’m working from home today, in case anyone is looking for me in the office (he said to nobody in particular) :) [17:27:46] fabriceflorin: Well, Timo, Erik, James, and Rob are all in here and in the office [17:27:54] But yeah, nobody on the team. :P [17:29:02] marktraceur: Yeah, it’s been a bit lonely without a team at the office … but I’m using the time productively here at home :) [17:42:47] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163#c12 (10Roxana Valentina) I started working on this bug. My current fix consists in adding a link (that redirects the user to a page that has information regarding to how to delete the... [17:46:48] (03CR) 10Krinkle: "fixme" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [17:47:22] (03CR) 10Krinkle: "(the code is not new, but I'm flagging it here for you)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [17:49:54] ...lego has a patch? [17:50:07] Ah [18:01:02] 3MediaWiki / 3Uploading: asterisk * to denote required is missing from description field on Special:UploadWizard - 10https://bugzilla.wikimedia.org/71475 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None This is a required field yet it is not noted as such. [18:01:30] 3MediaWiki / 3Uploading: asterisk * to denote required is missing from description field on Special:UploadWizard - 10https://bugzilla.wikimedia.org/71475 (10Jared Zimmerman (WMF)) p:5Unprio>3Normal s:5normal>3major [19:23:15] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163 (10Jackmcbarn) [19:35:21] marktraceur: BTW, Media Viewer looks great on Commons. I will send mailing list announcements after lunch. Nicely done! https://commons.wikimedia.org/wiki/Commons:Picture_of_the_day#mediaviewer/File:Erithacus_rubecula_with_cocked_head.jpg [19:35:48] Sweet. [19:36:13] I'll try to get some work done on the viewing options thing, I think I'm good to work now. Bloody tired is all. [20:28:14] fabriceflorin: I see there's a requirement that there be a close button, but a few of the mockups don't include that, is it better to just have the cancel button? [20:41:57] marktraceur: I recommend using a ‘Cancel’ button for the main Disable/Enable dialog, but a close ‘X’ button for the subsequent confirmation. This is based on the mockups in card #836, which match pginer ’s prototype : http://pauginer.github.io/prototypes/media-viewer/desk/workflow/index.html [21:01:24] Ah. [21:10:55] marktraceur: Also, when we get to #719 (Re-enable Media Viewer from a File Page), we should also plan to release #870 along with it (Rename Media Viewer button on File page). It says that #870 has already been accepted (though I haven’t seen it myself). From my standpoint, it would be fine to release #870 anytime, but it’s OK to wait until the other Disable/Enable features, so we can update the help page all [21:10:56] at once. [21:17:15] 3MediaWiki / 3File management: Improve user feedback in html detected upload error - 10https://bugzilla.wikimedia.org/25163#c13 (10Bawolff (Brian Wolff)) > > I was wondering if I should continue like this or change the fix with the > padding solution (even though the user can also upload non-jpeg files).... [21:17:30] 3MediaWiki / 3Uploading: Allow "html" in exif tags - 10https://bugzilla.wikimedia.org/25707 (10Bawolff (Brian Wolff)) [21:19:38] Sure. [21:56:32] 3MediaWiki / 3File management: Find a better solution for a "clickable image" on file pages - 10https://bugzilla.wikimedia.org/71485 (10Florian) 3NEW p:3Unprio s:3normal a:3None Currently, on a file page, the entire image is clickable and redirects to the image itself. I agree with Jon (refer to the... [21:57:18] 3MediaWiki / 3File management: Find a better solution for a "clickable image" on file pages - 10https://bugzilla.wikimedia.org/71485 (10Florian) [23:22:26] Keegan|Away: FYI, I just announced the first improvements for Media Viewer on the Multimedia and Commons mailing lists, as well as on our talk page: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Media_Viewer_Update:_First_Improvements [23:25:32] I posted on the Media Viewer talk page to give folks a place to respond. Hope that’s OK with you. It’s pretty low traffic, so I think it’s all right, even though we haven’t deployed on all Wikipedias yet. When I land in London on Thursday around midnight, I will post on the Village Pumps for Commons and English Wikipedia, and ping you when that’s done. To be continued … [23:34:27] All righty [23:37:31] 3MediaWiki / 3File management: Find a better solution for a "clickable image" on file pages - 10https://bugzilla.wikimedia.org/71485#c1 (10Jon) Specifically, in mobile it is very easy to accidentally tap an image and unintentionally download a large resolution photo. It's also not clear from a UX perspective... [23:38:05] Fabriceflorin: Didn't you previously plan to remove all the metadata? [23:39:58] FDMS: We are still planning to remove all the metadata, but have to do this gradually, so we don’t remove important functionality until we have found a new place for it. So this will take place last, at the end of October, as detailed here: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/892 [23:41:01] Sad, sad.