[01:05:25] (03CR) 10Eloquence: [C: 04-1] "We can test this, but let's keep the chevron (without gray area exposure) for now." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162835 (owner: 10Pginer) [01:11:23] 3MediaWiki extensions / 3TimedMediaHandler: Commons uploads: Support automatic conversion of video formats to free formats - 10https://bugzilla.wikimedia.org/43150#c16 (10Kelson [Emmanuel Engelhart]) @Sj Interesting new approach. Would be interesting to get a feedback from dev/op people about this approach. [06:54:23] (03PS1) 10Gergő Tisza: Remove copypasted code from attribution logger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163110 [07:13:37] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c13 (10Gilles Dubuc) Awesome, then I'll backport it for Commons. [07:17:24] (03PS1) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163115 (https://bugzilla.wikimedia.org/71160) [07:19:09] (03CR) 10Gilles: [C: 032] Make options of a custom campaign field parseable [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163115 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [07:19:38] (03Merged) 10jenkins-bot: Make options of a custom campaign field parseable [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163115 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [07:20:36] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c16 (10Gilles Dubuc) It'll go out to Commons during Monday's SWAT deploy [07:28:08] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c17 (10Anthere) You rock guys !!!! Thanks [10:00:41] 3MediaWiki extensions / 3UploadWizard: #shadow-root inside input element - 10https://bugzilla.wikimedia.org/71348 (10Neil Kandalgaonkar) 3NEW p:3Unprio s:3normal a:3None Created attachment 16598 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16598&action=edit screenshot of Chrome 37 inspector... [10:01:23] 3MediaWiki extensions / 3UploadWizard: #shadow-root inside input element - 10https://bugzilla.wikimedia.org/71348 (10Neil Kandalgaonkar) p:5Unprio>3Low [14:03:01] (03CR) 10Gilles: [C: 04-1] "I'm seeing this with the patch applied: https://www.dropbox.com/s/w2b0d58xg4v4bxq/Screenshot%202014-09-26%2015.59.22.png?dl=0" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 (owner: 10MarkTraceur) [14:20:25] Is it possible to make the thumb (the play-button) smaller if I want to use [[File:FlumeRide, Liseberg - last steep POV.ogv|30x21px]]? See https://sv.wikipedia.org/wiki/Wikipedia:M3%A5nadens_nyuppladdade_bilder#Tidigare_m.C3.A5nader and http://www.webpagescreenshot.info/i3/542575d480cc94-78263622 [14:29:51] (03CR) 10Gilles: [C: 032] Improve error logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163057 (owner: 10Gergő Tisza) [14:31:32] Josve05a: I don't see what's on the sceenshot on the wikipedia link you've given [14:31:57] the link is not in UTF-8 [14:32:28] https://sv.wikipedia.org/wiki/Wikipedia:M%A5nadens_nyuppladdade_bilder#Tidigare_m.C3.A5nader is [[sv:WP:MND#Tidigare månader]] [14:32:54] and http://www.webpagescreenshot.info/i3/542575d480cc94-78263622 is just a screenshot of that [14:33:09] https://sv.wikipedia.org/wiki/WP:MND#Tidigare_m.C3.A5nader then [14:33:31] still no workie [14:33:54] https://sv.wikipedia.org/wiki/WP:MNB#Tidigare_m.C3.A5nader maybe? [14:34:00] MNB* yeah [14:34:13] yes, thanks tgr [14:35:47] you should file that as a bug, the button should get the thumbnail width/height as a max-width/height attribute probably [14:36:13] anyway, I don't think you can fix that right now, short of messing with site CSS [14:36:22] TimedMediaHandler is the project to file this bug under [14:36:52] ah...bugzilla. My "best" friend...(not) [14:37:12] You could just wait a few weeks for phabricator? :) [14:38:26] (03Merged) 10jenkins-bot: Improve error logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163057 (owner: 10Gergő Tisza) [14:38:46] this page made me discover this wonderful video https://commons.wikimedia.org/wiki/File:Urilift,_G%C3%B6teborg,_Kungsportsplatsen.webm [14:39:04] or glare at us reproachfully until we file the bug ourselves [14:39:30] That's always an option, yes [14:40:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=62369 [14:41:37] Thank you! <3 [14:42:04] Or just have the bug already filed? [14:45:11] best option [14:45:33] might require a Guide Mk. II though [14:45:50] for the reverse temporal engineering [14:51:24] 3MediaWiki extensions / 3TimedMediaHandler: Video's PLAY button has a fixed size - 10https://bugzilla.wikimedia.org/62369 (10Jonatan Svensson Glad (Josve05a)) 5UNCO>3NEW [14:55:15] (03CR) 10Gilles: [C: 032] Remove copypasted code from attribution logger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163110 (owner: 10Gergő Tisza) [14:56:13] (03Merged) 10jenkins-bot: Remove copypasted code from attribution logger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163110 (owner: 10Gergő Tisza) [15:11:23] (03PS1) 10Gilles: Change tooltip wording [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163177 [15:17:12] (03PS1) 10Gilles: Revert "Show initially part of the below the fold area" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163178 [15:28:38] hmm: https://commons.wikimedia.org/wiki/Special:GloballyWantedFiles . Silly wiktionary with their case insensitivity [15:38:49] That's re-assuring... On tool labs copy of db's, their is an entry in the image table that has the empty string (or 0) for all fields... [15:39:13] ...hm. [15:39:22] That might not be the best thing, but it can't hurt...right? :D [15:40:14] More I'm worried how it got there [15:40:36] Implies something inserted something with totally bogus values, thus is didn't insert whatever it was supposed to [15:40:53] meh. for all we know, its probably been there for 10 years [15:41:02] someone used a left join to generate the table, maybe? [16:37:25] 3MediaWiki extensions / 3GlobalUsage: Special:GloballyWantedFiles reports false positives from lowercase links at wiktionary - 10https://bugzilla.wikimedia.org/71359 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Example: various lower case things on https://commons.wikimedia.org/w/api.ph... [16:49:38] 3MediaWiki extensions / 3GlobalUsage: Special:GloballyWantedFiles reports false positives from lowercase links at wiktionary - 10https://bugzilla.wikimedia.org/71359#c1 (10Bawolff (Brian Wolff)) Added warning in https://gerrit.wikimedia.org/r/163190 [17:12:25] Argh life [17:12:41] Internet went out at the house and I'm connected via my phone. [17:38:13] marktraceur: Glad you were able to connect via your phone. Is the connection good enough for you to post software updates? [17:38:21] Eh. [17:38:31] I'm thinking yes, but it might be a bit frustrating [17:40:01] The reason I ask is that we were hoping to get a few last UI fixes done today, so we can deploy them to mediawiki.org on Monday. [17:40:46] We’re only talking about a few tweaks, such as Change 'Use this file' tootip to 'Share / Embed’ [#914] [17:40:47] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/914 [17:40:49] Yes, I see ready for dev has 22 points in it now... [17:41:25] Oh, I should be able to review that  [17:41:51] fabriceflorin: Did that message change propagate like we hoped? (the more details button) [17:42:44] (03CR) 10MarkTraceur: [C: 031] "siebrand, would appreciate review on this, not sure if the slash is particularly easy to translate." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163177 (owner: 10Gilles) [17:43:39] Cool. The other one, which may be a bit trickier is removing the gray line at the bottom and restoring the old chevron behavior. We have a stub for it in this card [#912], which I can flesh out with tips from Pau in the next few minutes: [17:43:40] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/912 [17:44:19] Looks like there's a patch for that too. Are the tips from Pau significantly different from what's on the card now? [17:46:55] (03CR) 10Fabrice Florin (WMF): "The '/' slash wording was approved by Pau, who is familiar with language issues." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163177 (owner: 10Gilles) [17:47:29] If Siebrand thinks the slash is a serious problem, I think it would be fine to say instead: 'Share or Embed this file [17:47:56] Well, I'll see what he says [17:48:21] (03CR) 10MarkTraceur: "I'd still like siebrand to weigh in - he can +2 this if he thinks it's OK." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163177 (owner: 10Gilles) [17:49:10] fabriceflorin: I think the patch from gi11es fixes the grey bar issue, is there anything other than moving it that needs to happen? [17:49:58] marktraceur: Regarding #912, the tips from Pau were just guidance. He proposes that we unto the 2 previous patchsets. I just added his notes to the card. [17:50:05] OK then [17:51:40] I'll merge the first revert then submit a patch to revert the other one [17:51:49] marktraceur: For #912, the goal is to make the gray line return to the bottom of the screen, no other requirements on my end. If there is a way for me to test #912, I can let you know if the patch works as intended. [17:51:51] (03CR) 10MarkTraceur: [C: 032] Revert "Show initially part of the below the fold area" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163178 (owner: 10Gilles) [17:52:14] (03PS1) 10MarkTraceur: Revert "Layout adjustments to reduce overlap with chevron" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163207 [17:52:35] (03Merged) 10jenkins-bot: Revert "Show initially part of the below the fold area" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163178 (owner: 10Gilles) [17:53:41] gi11es: FYI the card says https://gerrit.wikimedia.org/r/163207 is also important for 912. [17:54:44] fabriceflorin: The grey bar move should be on beta soon, but the other patch needs review. [17:58:33] marktraceur: OK, then. What is the other patch link? Is it 163207? Does this revert the chevron removal? If so, do you think it could be reviewed by gi11es or tgr by Monday am, so we can backport to mw.org on Monday afternoon? [17:58:48] fabriceflorin: It might be [17:58:54] I've done all I can on that front [18:01:35] fabriceflorin: Any other big important ones? [18:02:03] marktraceur: OK, I will send an email to the team, confirming the short list of changes to push out by Monday, so we’re all on the same page. The key items seem to have already been addressed, so I think we’re in good shape. There is one last item that Pau reported, which I will look at now. [18:03:23] I am glad that ‘More details’ button now has a shorter label, thanks to the l10nupdate. Do you think we will need to run a scap for this on Commons and other sites as well? [18:03:48] Probably not [18:03:55] Cool. [18:04:02] The databases are updated now, so the change should just go to commons without incident [18:06:10] marktraceur: We also want to remove the duplicate details banner, and I think this patch has now been approved: https://gerrit.wikimedia.org/r/#/c/162765/ Is this something we can merge to beta with the other patches, if we haven’t already? [18:07:06] I think it needs fixing up still [18:07:15] * marktraceur looks [18:07:29] Yeah, there's a -1 on it for l10n issues [18:08:27] Oh thank god the internet's working again [18:09:11] (03PS2) 10MarkTraceur: Remove duplicate details link in metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 [18:09:15] Hah, I put the message in the wrong module [18:09:16] Fixed [18:09:39] (03CR) 10MarkTraceur: "I'm an idiot, I put the message in the wrong RL module. Fixed now!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 (owner: 10MarkTraceur) [18:15:26] marktraceur: Thanks for taking care of this! [18:18:14] Yup [18:18:22] 's what they pay me for [18:18:33] That and my inimitable charm [18:31:49] :) [18:33:19] marktraceur: OK, I have checked Pau’s request and confirmed that it is a real issue, which we should address for Monday’s release: [#921] Magnifier icon no longer shows up on hover https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/921 [18:43:40] AOK [18:44:33] (03PS1) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [18:45:19] (03CR) 10jenkins-bot: [V: 04-1] Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [18:46:07] (03CR) 10Gilles: [C: 032] Revert "Layout adjustments to reduce overlap with chevron" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163207 (owner: 10MarkTraceur) [18:46:09] (03PS2) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [18:46:52] (03Merged) 10jenkins-bot: Revert "Layout adjustments to reduce overlap with chevron" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163207 (owner: 10MarkTraceur) [18:49:31] (03CR) 10Gilles: Remove duplicate details link in metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 (owner: 10MarkTraceur) [18:51:32] marktraceur: ^ [18:52:33] @all, please be careful when clicking "save" on the mingle tabs, it will change the tab for everyone else, only save it if you know how your view differs from the default and you are sure it is beneficial [18:52:50] someone has a tendency of removing tasks from the current sprint view [18:54:08] I've noticed that too, I'm not the culprit :) now I have the correct view kept as an unsaved version as a workaround [18:58:20] Hi guys, I just sent an email to the team to summarize the short list of Media Viewer changes to push out by Monday. Please let us know if you have any questions, either via email or IRC. Mark and I have been discussing them here on IRC all morning, but I wanted to make sure we’re all on the same page about what we’d like to deploy on Monday and announce to the community after they have been deployed to [18:58:20] Commons on Tuesday. [19:15:38] whee, I see you fixed media viewer for firefox 3.5 :D [19:17:39] Uh [19:17:39] We did? [19:17:54] Well it sort of works now, where it didn't previously [19:17:56] Might be the oojs-ui stuff getting shimmed for es3 [19:19:29] I'm starting to develop a profound hatred for my vagrant vm [19:19:55] it just loves hanging randomly and starting to spew 503s for no reason whatsover [19:19:57] :((( it's <3's you [19:20:25] That's some hhvm bug. Possibly related to the jit cache getting full [19:20:45] what can I do? reloading it doesn't help [19:21:12] * bd808|LUNCH makes random guesses [19:21:14] gi11es: vagrant enable-role zend [19:21:20] heh [19:21:22] there is that [19:21:42] hah, that's a thing! [19:21:47] I'll buy it [19:23:17] sudo service hhvm stop; sudo service jobrunner stop; sudo rm /var/run/hhvm/hhvm.hhbc; sudo service hhvm start; sudo service jobrunner start; [19:23:39] if that's any help tracking down that bug, it happens a lot when working with uploadwizard [19:23:54] possibly job-related I would guess [19:24:51] I have a fear that running the jobrunner and fcgi out of the same cache is a problem in mw-vagrant but I don't have proof. [19:25:35] We have split config now so I guess I could change one and see what happens. I'll make a patch for you to test after I actually eat something. [19:27:59] that zend thing is like a breath of fresh air! ;) [19:31:30] (03PS1) 10Neilk: fix spurious upload uis being created [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163235 [19:36:23] gi11es: I gave up and switched to zend [19:36:31] gi11es: takes just a few minutes [19:37:13] gi11es: ah never mind I see you are way ahead of me :) [19:49:36] I've heard similar complaints about resource exhaustion from folks working on flow. I wonder if there is a correlation. [19:50:50] I will say that hhvm was basically thrown into mw-vagrant "to make people find bugs" but not a lot of careful followup has been done on problems that may be specific to that environment. [20:39:52] marktraceur: Have you seen https://commons.wikimedia.org/wiki/Commons:Village_pump#UploadWizard:_Only_first_file_uploaded [20:43:43] Oh, hm [20:43:56] gi11es: Maybe that's what rillke was on about? [21:26:30] neilk_: Thanks for all your work with our team this summer! I’m sorry that you and I didn’t get a chance to work more closely with each other, but hope there will be another opportunity down the line. All the best wishes for your next steps :) [21:29:28] I think I'm going to sign off for a bit. I'm driving down to the Inland Empire and I don't mind it being light out while I'm on the road. I'll sign on later and try to do some quick reviewing and bugfixing. [21:30:23] (03PS3) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [21:31:24] marktraceur: OK, thanks for the heads up. How far along did you get with the missing zoom icon? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/921 [21:32:01] I hadn't looked at it, I will do so when I'm at the hotel [21:32:37] OK, sounds good. This is one which would be good to fix before we backport to mw.org on Monday. Have a safe trip! [21:32:44] Sure sure [21:33:06] One good thing is, the entire engineering team will have several hours to look at the issue before the 08:00 SWAT on Monday [21:33:21] Since the G's are in Europe and I'm an early bird [21:39:13] Cool. I’ll get up early too, so I can test as soon as you backport. Have a great weekend! [21:40:04] marktraceur: I'll be working tomorrow (I cut yesterday some hours short and probably will do so on Tuesday too) so if something needs to be done before Monday, just drop me a mail [21:40:21] marktraceur: Also, feel free to ping me over the weekend if you would like me to test something on beta first … [21:42:38] (03CR) 10Nemo bis: Log image dimensions (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [21:43:47] (03PS1) 10Gergő Tisza: Only add country field when it's in the schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163284 [21:46:05] (03CR) 10jenkins-bot: [V: 04-1] Only add country field when it's in the schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163284 (owner: 10Gergő Tisza) [21:57:27] marktraceur: When you get back online, check the email from greg-g about Monday’s SWAT. He recommends we backport the changes on Monday at 4pm PT, to give us more time to test the features on Beta. Would that work for you? [22:01:06] hi fabrice - thanks, and likewise! [22:07:59] (03PS2) 10Gergő Tisza: Only add country field when it's in the schema [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163284 [22:19:10] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Make Media Viewer work on Special:Unused files if enabled - 10https://bugzilla.wikimedia.org/71372 (10Keegan Peterzell) 3NEW p:3Unprio s:3enhanc a:3None If I have Media Viewer enabled on Commons and I visit [[:commons:Special:Unused_files]] and... [22:21:22] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Make Media Viewer work on Special:Unused files if enabled - 10https://bugzilla.wikimedia.org/71372#c1 (10Keegan Peterzell) Link fix: [[:commons:Special:UnusedFiles]] [22:22:01] (03PS4) 10Gergő Tisza: Log image dimensions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 [22:22:10] (03CR) 10Gergő Tisza: Log image dimensions (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163217 (owner: 10Gergő Tisza) [22:22:53] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Make Media Viewer work on Special:UnusedFiles if enabled - 10https://bugzilla.wikimedia.org/71372 (10Keegan Peterzell) [23:07:26] 3MediaWiki extensions / 3UploadWizard: [REGRESSION]: Error message not parsed exposing plain HTML - 10https://bugzilla.wikimedia.org/70639#c6 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70617 *** [23:27:08] 3MediaWiki extensions / 3UploadWizard: #shadow-root inside input element - 10https://bugzilla.wikimedia.org/71348#c1 (10Tisza Gergő) I'm not sure I understand the bug report. Input elements tend to have shadow DOM; you see it because you have enabled it in the settings panel of the web developer toolbar (und...