[00:24:08] I see that [00:24:19] fabriceflorin: If there's an issue, stick it in the sprint as a bug [00:25:18] marktraceur: OK, I will do that. Thanks for the good advice. [04:29:00] (03PS1) 10Legoktm: Merge two $wgExtensionFunctions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 [05:23:03] (03PS1) 10Pginer: More details button color fix [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162827 [07:28:41] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 (owner: 10MarkTraceur) [07:55:55] (03PS1) 10Pginer: Remove chevron pointing down and full-screen adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162835 [07:56:56] (03CR) 10Pginer: [C: 04-1] "This is just a quick hack for discussion purposes. Discuss, review carefully and refactor before considering merging." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162835 (owner: 10Pginer) [09:06:23] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c8 (10Gilles Dubuc) If someone can verify that the fix works on beta commons, we can then backport this, due to the time-sensitiveness. [09:15:41] (03CR) 10Gilles: [C: 032] QA: Refactored performance tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162469 (owner: 10Dduvall) [09:16:25] (03Merged) 10jenkins-bot: QA: Refactored performance tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162469 (owner: 10Dduvall) [09:18:28] (03CR) 10Gilles: Merge two $wgExtensionFunctions (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162822 (owner: 10Legoktm) [09:19:35] (03CR) 10Gilles: [C: 032] More details button color fix [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162827 (owner: 10Pginer) [09:20:15] (03Merged) 10jenkins-bot: More details button color fix [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162827 (owner: 10Pginer) [09:21:57] (03CR) 10Gilles: "I find it strange that the download and share icons are still visible in fullscreen mode. They look like clutter." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162835 (owner: 10Pginer) [09:24:28] (03CR) 10Pginer: "They look misplaced. We should either reposition them or remove them." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162835 (owner: 10Pginer) [11:22:43] what is the domain of Beta Commons? [11:39:07] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c9 (10Romaine) When I try to create the campaign page (identical to regular Commons) I get an error at http://commons.wikimedia.beta.wmflabs.org/w/index... [11:40:18] am I doing something wrong here? https://bugzilla.wikimedia.org/show_bug.cgi?id=71160#c9 [11:48:38] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c10 (10Steinsplitter) same here. [12:58:10] (03CR) 10Gilles: "This actually breaks campaigns: https://bugzilla.wikimedia.org/show_bug.cgi?id=71160#c9 Maybe it was a premature change and the correspond" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161895 (owner: 10Yurik) [12:58:48] (03PS1) 10Gilles: Revert "Pass CampaignContent as a constructor param" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162875 [13:00:58] (03CR) 10Gilles: [C: 032] Revert "Pass CampaignContent as a constructor param" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162875 (owner: 10Gilles) [13:01:44] (03Merged) 10jenkins-bot: Revert "Pass CampaignContent as a constructor param" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162875 (owner: 10Gilles) [13:05:53] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c11 (10Gilles Dubuc) That error should be fixed now, please try again [13:43:29] (03CR) 10Gilles: [C: 032] Fix dialog class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162793 (owner: 10MarkTraceur) [13:44:47] (03Merged) 10jenkins-bot: Fix dialog class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162793 (owner: 10MarkTraceur) [16:57:23] The troll force is strong today [17:20:38] marktraceur: Morning, Mark. Based on the email exchange with Pau, I recommend we fix the opacity issue in the ‘More details’ button right away, as outlined in this bug ticket: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/913 [17:23:16] Sure sure [17:23:25] I thought Pau had a patch for it...sec [17:23:40] Yeah, it looks merged, if you can test on beta that'd be good [17:39:22] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256#c2 (10Bawolff (Brian Wolff)) Probably not tiff specific, just general issues with chunked upload being horrible. [17:40:25] marktraceur: Thanks! I just tested it on 3 browsers and it looks great! I have just accepted the card. :) [17:40:33] marktraceur: Also, based on Pau’s response, it would be great if we could change the 'Use this file' tootip to 'Share / Embed’, an oversight outlined in this bug ticket: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/914 [17:40:43] Right [17:40:52] fabriceflorin: Are those cards in this sprint? [17:41:47] Yeah, both cards were in this sprint as bugs, per your suggestion. But you might want to add the points they took to fix, so we can include them in the ‘accepted’ column, for the record. [18:04:41] gi11es: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/896 I don't see this issue [18:04:44] Locally anyway. [18:11:00] CC fabriceflorin. [18:26:30] marktraceur: I just tested #896 on beta. I am not seeing the issue reported there (HTM embed always using the original size even when picking something else). However, I am seeing a different issue, which is that if you select the small size in Wikitext, then click on HTML, you get a different size (either original, or whatever you selected last when in HTML mode). Ideally, once you select a size, both Wikitext and HTML [18:26:31] should display that size, when you switch back and forth between them. Want me to update #896 to reflect that issue? [18:26:57] Hrm [18:27:10] I think we should just resolve 896 as WFM and open a new card [18:27:24] marktraceur: OK, will do. [18:35:01] marktraceur: At your suggestion, I submitted a new ticket #916, to better describe the issue: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/916 [18:35:50] I still think we should take that on in this sprint, as the issue reported by the previous card is still part of that more general problem. [18:36:18] Then stick it in the sprint, it's fine [18:37:50] marktraceur: The good news is that we are correctly displaying the size you just selected in both Wikitext and HTML, based on the testing I did in several browsers. So there is no need to worry about whether or not the code is correct, we just want to make sure that the same size is used for both Wikitext and HTML. [18:38:02] KK. [18:39:48] added some clarification to #896 [18:40:29] Ohhhh [18:40:31] Herp. [18:40:38] I thought that was how we wanted it to be [18:40:51] Given the complexity and slowness of fetching the thumbnail sizes [18:41:55] if by "how we wanted it to be" you mean "we did not want to deal with thumbnail URL fetching because it's a pain in the butt" then yes [18:42:09] Heh [18:42:23] tgr: Is there a core patch looking to fix imageinfo? [18:42:24] "fix" [18:42:35] but from a reuser point of view making his visitors download a 2000px image for a 220px thumb is quite broken [18:43:00] That's true [18:43:46] see the discussion in https://bugzilla.wikimedia.org/show_bug.cgi?id=54035 - anomie wants to rewrite the whole thing [18:44:45] I can write the patch if there is consensus on the API format, it doesn't seem particularly hard [18:57:01] tgr: Thanks for clarifying #896. I had not realized that we were forcing the users to download the original file all the time. You are correct that it’s not right to download a huge file when smaller thumbnails exist that match the requested size. For some users on slow connection, that would create very long load times, which seems wrong when a better solution exists. [18:58:16] Note that the inconsistent embed size issue reported in #916 is still worth fixing, as a separate bug. [19:01:19] marktraceur: How hard would it be to move the gray artifact to the bottom of the screen, as proposed by Erik in #912? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/912 [19:01:19] If itthis is hard to do, I would punt on it, since we are going to change all this soon anyway. It’s pretty subtle and will not bother a lot of users, IMHO. [19:03:06] But if it’s easy to do, I agree with Erik that it would make the UI a bit cleaner, and is not really needed since we still have the chevron. I don’t recommend removing the chevron at this time, it can wait until we finalize our plans for the metadata panel after we’ve moved the caption up above the fold. [19:04:25] I dunno, put it in the sprint and I'll look [19:06:21] OK, it’s in the current sprint now, in the analysis column. [19:08:28] marktraceur: It seems that we deployed a different version of the ‘More details’ button on MediaWiki.org: it says ‘More details about this file’ — instead of ‘More details’, as we had agreed. Can we still do something about this, or does it require a backport? [19:08:39] https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Swallow_flying_drinking.jpg [19:09:00] Uhhh [19:09:07] I'm going to guess it's an i18n cache issue. [19:09:59] Oh, OK. Also, we still have the duplicate ‘More details about this file on Wikimedia Commons’ below the fold, which was removed on beta. Same cache issue? [19:10:05] https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Purekkari_neemel.jpg [19:10:12] Hrm [19:10:17] I thought we got that in [19:10:27] Shouldn't be a cache issue, let me check [19:11:18] mw.o doesn't have that patch [19:11:31] marktraceur : I mispoke, the ‘More details’ below the fold is still on beta, so we are consistent. Not a big deal anyway. [19:11:53] marktraceur tgr : Is there anything you would like me to test now, before I go to lunch in a couple minutes? [19:11:54] Hm, K [19:12:00] Nothing urgent, nope [19:15:40] marktraceur: OK, sounds good. I will head out now, back at 2pm. I quickly tested the new features, which seem to work reasonably well, and can test in more depth when I return. Hopefully the ‘More details about this file’ label will have been replaced by the shorter one by then … [19:45:07] Sorry about the noise and being a little distracted [19:45:15] I was worried someone had broken into my server. [19:45:20] Looks okay now [20:17:39] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c12 (10Romaine) My test appears successful. Creation of Campaign worked, selection shows correctly, selection menu does do what it should do. It can be... [20:22:25] 3MediaWiki extensions / 3TimedMediaHandler: Commons uploads: Support automatic conversion of video formats to free formats - 10https://bugzilla.wikimedia.org/43150#c15 (10SJ) Update: during Wikimania there was discussion among a couple MW devs (thanks, Brion) and Alexis @ the Internet Archive to enable auto... [20:34:08] 3MediaWiki / 3File management: Commons uploads: Support spreadsheet data format ODS - 10https://bugzilla.wikimedia.org/43151#c17 (10SJ) Bawolff: yes, upload but not display. Thanks for the next step. Maarten, can you clarify what you mean by 'not in scope'? I admit that I don't understand the current pr... [20:37:52] 3MediaWiki extensions / 3TimedMediaHandler: Commons uploads: Support automatic conversion of mp3 formats to free format - 10https://bugzilla.wikimedia.org/43149#c7 (10SJ) Thanks, Bawolff. (In reply to Bawolff (Brian Wolff) from comment #5) > To be fair, the predominant result of the rfc was not to outpu... [20:43:23] 3MediaWiki / 3File management: Commons uploads: Support spreadsheet data format ODS - 10https://bugzilla.wikimedia.org/43151#c18 (10Kunal Mehta (Legoktm)) (In reply to Dereckson from comment #1) > Moving bug to the ContentHandler system. Related: https://gerrit.wikimedia.org/r/#/c/160610/ [20:52:25] marktraceur: Did I miss anything important while I was away? I’m still seeing the the ‘More details about this file’ button on all my browsers, even after I refresh or open in incognito mode. Do you still think it’s a cache issue? Or should we plan a backport? [20:52:37] Hm [20:52:38] One sec. [20:53:47] I see it's using the right message, and that message is right in the API [20:54:11] Must be an l10n cache thing [20:57:05] marktraceur: OK. So you think we should wait a while longer for this to resolve? So if the cache issue doesn’t resolve, we could do a backport tomorrow. This would also give us a chance to test some of the new UI fixes before we deploy to Commons. [20:57:20] I asked in -operations for a scap [20:58:50] marktraceur: Cool, thanks. I am going to start updating the help FAQ page now, to reflect some of these new changes, using the wording we agreed on. [20:58:56] Sure [21:11:07] 3MediaWiki / 3File management: Commons uploads: Support spreadsheet data format ODS - 10https://bugzilla.wikimedia.org/43151#c19 (10Nemo) (In reply to SJ from comment #17) > The next step here does seem to be finding > community consensus; along with fixing the process for finding that > consensus. There is... [21:15:49] Ugh, there's no easy way to get a menu item with a specific name... [21:38:07] marktraceur: sorry to bug you about the l10n thing again. What key name and MW version are messed up? [21:40:39] (03PS1) 10MarkTraceur: Retain image size when switching embed type [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163032 [21:41:07] bd808: mw.org, multimediaviewer-repository-local [21:41:21] (03CR) 10jenkins-bot: [V: 04-1] Retain image size when switching embed type [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163032 (owner: 10MarkTraceur) [21:41:31] Used in the interface in the "More details" button which is currently showing as "More details about this file" [21:41:35] Inaccurately [21:42:38] Got it. So that key changed from php-1.24wmf22 to php-1.25wmf1 and the old version seems to be still used [21:42:47] * bd808 is looking at files on tin [21:42:51] Yup [21:42:53] Thanks :) [21:45:29] hmmm... is it a resource loader cache issue? [21:45:50] Maybe! [21:46:50] The files on tin look to have the right data in the branch [21:47:27] I'm looking at the json version we create to sync and rebuild the cdb and I see the new string [21:48:02] But I know sometimes RL caches the wrong thing before the cdbs are rebuilt [21:50:04] Isn't there a special page somewhere that lest you page through all of the messages? [21:53:03] Special:AllMessages ? [21:53:29] The API has the right value definitely [21:55:57] what about the JSON blob that RL is returning? [21:57:07] https://bits.wikimedia.org/www.mediawiki.org/load.php?modules=mmv.ui.metadataPanel&only=messages [21:57:11] is that message correct or wrong? [21:57:30] this happened a couple times and refreshMessageBlobs.php seemed to be the only thing that worked [21:58:09] it is extremely slow though [21:58:53] legoktm: That message is wrong [21:59:30] refreshMessageBlobs.php then! [21:59:53] Cool. [22:01:26] an enhancement request for refreshMessageBlobs to only clear for a given module would be reasonable. [22:02:01] fabriceflorin: A few hours from now l10nupdate will fix the issue for us, is it more urgent than that? I suspect not. [22:03:07] marktraceur: Great. We can totally wait until then, it’s only MediaWiki.org. Thanks for following up on this. :) [22:03:20] Cool. [22:04:57] marktraceur: I wonder what would happen if you created a local override, and then deleted it. [22:18:58] marktraceur: If it's just one wiki... [22:19:20] You can just run refreshMessageBlobs on one wiki [22:19:28] It'll be much quicker than every wiki [22:27:52] Eh, waiting is fine [23:09:01] (03PS1) 10Gergő Tisza: Improve error logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/163057