[01:08:41] 3MediaWiki extensions / 3UploadWizard: [Needed 1 October] Selection menu for country does not work - 10https://bugzilla.wikimedia.org/71160 (10Romaine) 3NEW p:3Unprio s:3blocke a:3None On 1 October 2014 Wiki Loves Africa starts, a large photo contest for the whole continent of Africa. A lot of langua... [01:10:08] 3MediaWiki extensions / 3UploadWizard: [Needed 1 October] Selection menu for country does not work - 10https://bugzilla.wikimedia.org/71160 (10Romaine) p:5Unprio>3Highes [01:20:39] 3MediaWiki extensions / 3UploadWizard: [Needed 1 October] Selection menu for country does not work - 10https://bugzilla.wikimedia.org/71160#c1 (10Romaine) To avoid confusion: the selection menu does work, what doesn't work is the localisation. [03:32:10] (03PS6) 10Krinkle: Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [03:33:08] (03CR) 10jenkins-bot: [V: 04-1] Use confirmCloseWindow from mediawiki-core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [06:45:40] marktraceur: you there? [07:07:50] Steinsplitter: probably not, it's around midnight here. [08:35:56] (03CR) 10Gilles: [C: 031] Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [08:37:04] (03CR) 10Gilles: [C: 031] Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [08:57:06] (03CR) 10Gilles: [C: 032] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [08:57:36] (03Merged) 10jenkins-bot: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [09:01:32] legoktm: oh, okay. thanks [09:13:11] help [09:14:43] Register [09:40:53] 3MediaWiki extensions / 3UploadWizard: [Needed 1 October] Selection menu for country does not work - 10https://bugzilla.wikimedia.org/71160#c2 (10Andre Klapper) p:5Highes>3High s:5blocke>3normal If I get the comment correctly, the selection menu for country DOES work, it's just not displayed in the l... [09:41:52] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160 (10Andre Klapper) [10:42:03] (03CR) 10Pginer: "- The "share" panel should be closed when clicking outside (even over the image). This works well for the download panel, but it does not " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [10:50:49] (03CR) 10Pginer: "- To avoid visual confusion when the metadata panel overlaps the share or download panels, we may consider supporting the following card: " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [10:59:21] (03CR) 10Pginer: "- Te share icon should be moved 2px to the right. Due to its shape (with an arrow going out at the top-right corner), a small correction i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [11:14:56] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c3 (10Erik Zachte) Just one week to go. Romaine is doing what he can in the short time after WLM to also make the WikiAfrica image upload project possib... [11:48:07] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c4 (10Anthere) As Erik said above. This is for https://meta.wikimedia.org/wiki/Wiki_Loves_Africa, photographic contest which will start on the 1st of O... [12:30:08] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160#c5 (10Romaine) (In reply to Andre Klapper from comment #2) > If I get the comment correctly, the selection menu for country DOES work, > it's just not d... [12:46:08] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160 (10Gilles Dubuc) a:3Gilles Dubuc [12:47:23] Romaine: the issue is simply that the contents of the options for a "select" custom field isn't interpreted as wikitext, right? [12:47:36] yes [12:48:18] "ao": "{{Angola|nolink=1}}", [12:48:44] between the right "" is now interpreted as wikitext [12:50:07] **not [13:08:50] (03PS1) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:24:39] (03CR) 10Gergő Tisza: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [13:24:54] (03CR) 10Gilles: [C: 032] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [13:24:57] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [13:27:43] (03CR) 10Gilles: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [13:29:53] 3MediaWiki extensions / 3CommonsMetadata: Strange `{_: "..."}` in artist/credit - 10https://bugzilla.wikimedia.org/71135#c2 (10Tisza Gergő) I think this happens when the EXIF data contains a child XML tag where an attribute would be expected. The _ key is a quirk of the MediaWiki API when it encounters data... [13:34:47] (03PS2) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:57:50] (03PS3) 10Gilles: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) [13:58:13] (03CR) 10Gilles: Make options of a custom campaign field parseable (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [14:18:06] (03PS1) 10Gilles: Rename file page button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162236 [14:58:14] (03PS5) 10Gergő Tisza: Add tracking categories for files with attribution problems [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 [15:06:23] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c22 (10Gilles Dubuc) I can finally repro and I know why it's happening: currently mediawiki doesn't do any sharpening for PNGs. It does for JPGs, and the extra sharpening passes in the chaining compensate t... [15:13:01] Ugh, more fixes. [15:13:13] pginer: Will you be up for an hour or two so I can get your final decree? [15:13:26] I'm super hopeful we can push out the latest today [15:14:19] I’ll be online the next 3 hours [15:14:43] but in 1.5h I’ll start with meetings [15:15:05] so in the next hour and a half is when I can pay more attention [15:15:36] Cool [15:16:24] Ugh, I swear I got the bloody click-outside stuff working [15:17:02] I'm going to add the shadow card to the list for next week [15:19:42] ok [15:28:28] Oh, herp, because the download dialog gets closed manually after the share dialog is opened. [15:39:19] (03PS1) 10Pginer: Add shadow when scrolling panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162281 [15:40:00] marktraceur I created a patchset for the shadow change in case it helps: https://gerrit.wikimedia.org/r/#/c/162281/ [15:41:00] The rest of the refactoring (making the cevron use the top-level class) can be still done as part of the story at a later point [15:42:30] Cool. [15:43:36] (03PS5) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [15:43:45] (03PS2) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [15:44:01] All right, pginer, I'm going to pull the latest changes to alpha [15:44:53] pginer: Give 'er a spin :) [15:47:11] The download sizes menu doesn’t look good. The tick mark overlap the option labels. [15:47:26] (I’m using Chrome) [15:48:11] Huh, thought I fixed that [15:48:20] This is how it looks to me: http://i.imgur.com/bg2Ctmd.png [15:48:23] Whoa [15:48:42] pginer: Can you try clearing your cache and hard-refreshing? [15:50:59] 3MediaWiki extensions / 3MultimediaViewer: HTML embed uses unsuitably large image size - 10https://bugzilla.wikimedia.org/67323#c7 (10Tisza Gergő) Currently we fetch thumbnail URLs when the user first selects the given file/size combination, which comes with a lot of quirks (such as the embed text appearing... [15:51:38] marktraceur it is still happening after cache cleaning, and also on Firefox which I was not using for a while [15:51:47] That's mighty strange [15:51:52] isn’t that happening to you? [15:52:09] Huh, it's happening to me on alpha, but not on my local machine [15:52:40] So I'm very confused [15:56:39] Apart from that, the rest looks good [15:57:11] Cool beans [15:57:20] I'll see if I can't figure out why things are different [15:57:32] pginer: Does alpha have any custom CSS anywhere? [15:57:57] Doesn't *look* like it. [15:58:05] Oh, I bet there's something weird with the mediawiki version we have there [15:58:09] Sec [15:58:11] I removed the ones of the prototype last week [15:59:04] Hahaha [15:59:11] We haven't even installed vector yet [15:59:13] Fantastic [16:01:22] pginer: Try that on for size [16:01:30] Latest mediawiki and vector. [16:05:24] ok. Now it is no longer broken, but test is too big compared to the embed dropdown. If possible I would like the text to be a bit smallet, and the width of the menu to be less wide (currently overlaps with the edge of the panel on the right side without keeping the same margin as it has on the left side) [16:06:17] OK [16:06:26] pginer: Say so on the patchset, I'll get that going [16:12:48] (03CR) 10Pginer: "Some more comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [17:03:22] 3MediaWiki extensions / 3UploadWizard: Selection menu for country cannot be translated (for WLA starting on Oct 01) - 10https://bugzilla.wikimedia.org/71160 (10Andre Klapper) s:5normal>3major [17:09:41] pginer: The dialogs remaining open when navigating next/prev is actually an oversight on my part - you really think we should keep it? [17:10:35] There's no handling of the interim state, I think [17:13:03] Yes, I would prefer keeping the dialogs open when exploring images. It makes the scenario of “download all pictures of the year” really quick. [17:13:06] OK [17:13:40] (03PS6) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [17:13:46] I suspect I'll get qunit failures [17:13:57] (03PS3) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [17:20:39] Well, pleasant surprise [17:21:18] pginer: Latest is on alpha again [17:33:34] Looks good [17:33:43] Just a couple of comments: [17:34:08] The “moe details” tooltip was supposed to be removed. Is that on a separate patchset? [17:34:28] Uhh [17:34:40] Probably not. Easy enough to do though [17:34:56] Also, the download panel gets closed when going next. [17:36:22] It does? [17:36:33] I didn't see that happen in my testing but I'll try it again [17:36:45] (03PS16) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [17:37:01] (03PS11) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:37:06] (03PS2) 10MarkTraceur: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 [17:37:10] (03PS7) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [17:37:15] (03PS4) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [17:38:57] (03PS17) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [17:39:04] pginer: Yeah, I don't see the download dialog close [17:39:32] (03PS12) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:39:34] (03CR) 10jenkins-bot: [V: 04-1] Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [17:39:40] (03PS3) 10MarkTraceur: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 [17:39:47] (03PS8) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [17:39:52] (03PS5) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [17:40:00] Uh oh. [17:40:13] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:40:20] (03CR) 10jenkins-bot: [V: 04-1] Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 (owner: 10MarkTraceur) [17:40:26] (03CR) 10jenkins-bot: [V: 04-1] Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [17:40:30] (03CR) 10jenkins-bot: [V: 04-1] Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [17:41:10] (03PS18) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [17:41:26] (03PS13) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:41:30] (03PS4) 10MarkTraceur: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 [17:41:34] (03PS9) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [17:41:39] (03PS6) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [17:42:00] pginer: If you could clear your cache and try the download dialog thing again that would be great [17:44:08] I tried in an incognito window, and hard refreshing. I cannot do a harder cache clean since I’m in a hangout [17:44:54] KK [17:45:04] And I guess it's Chrome, so I'll try that [17:45:42] I still don't see it [17:45:43] Weird. [17:45:54] Maybe your localStorage still has the code [17:46:21] in incognito? [17:47:24] inininincognito [17:47:29] Hm, you're right though [18:03:23] marktraceur, I have to leave soon. I can reconnect in 2-3h, would that be helpful? [18:03:39] I think greg-g is telling us we need to wait [18:03:48] But we can at least merge it all and test on beta tomorrow [18:05:26] hesitation is: MV is high stakes, generally, "last minute" changes (that aren't even yet merged to master) going out in a special window on the same day sounds risky for "just moving things around" [18:12:12] greg-g: K, no problem [18:12:20] greg-g: Tomorrow or Thursday sound OK? [18:13:52] the general rule is "merge to master, ride the next train" right? so the question is, how high need is this to warrant a train jump? [18:13:55] marktraceur: [18:14:21] greg-g: We've been waiting for these design changes to go out for quite some time [18:14:27] Other than that not much [18:14:46] Mostly just a matter of wanting to show some progress and get Media Viewer to a good-ish final state, design-wise [18:15:06] * greg-g nods [18:15:18] who's acting PM while Fabrice is out? [18:15:25] It's your call to axe it, I'm fine with that; product may not be as ppsyched [18:15:31] greg-g: Howie and Eloquence [18:15:34] No pressure. [18:15:37] heh [18:16:48] Eloquence: friendly ping re the request to push out Pau's (I assume) design changes to MediaViewer today which aren't yet merged to master. I'm questioning the urgency and why it doesn't just ride the train. [18:17:13] hf ;) [18:56:55] win 100 [18:56:57] Argh [18:57:08] 3MediaWiki extensions / 3PdfHandler: PdfHandler: Incorrect aspect ratio of the preview images. - 10https://bugzilla.wikimedia.org/22194#c23 (10Bawolff (Brian Wolff)) On wikimedia we are waiting on an update to the app servers, which im told will happen with hhvm update, which will allegedly be real soon now(... [19:32:07] * marktraceur is going to run an errand quicklyish [19:39:59] gi11es: I tested every part of the UW funnel logging and they all work, which leaves me thinking that the git clone from which the whole thing is actually running on stat1003 is not getting updated [19:40:06] could you check that? [20:14:45] tgr: any known issue ? I'm getting internal Error: bad token [20:14:55] when I upload files [20:15:23] matanya, try to log out and back in maybe? [20:15:39] not known (to me, anyway) but doesn't sound UW-specific [20:16:05] some sort of timeout maybe [20:16:10] did, i'll ask at -operations. thanks [21:19:19] (03PS1) 10Dduvall: QA: Refactored performance tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162469 [21:27:12] No word from Eloquence, eh greg-g? [21:27:20] Maybe we should have someone in the office throw things at him [21:27:55] Oh, he's in a meeting atm. [21:29:21] it is fine to throw things in the meeting [21:29:33] It would certainly get robla out on time. [21:29:38] :p [21:41:12] marktraceur: Erik (and I) have been in a 90+ minute meeting [21:41:16] Ahhh [21:41:18] Super. [21:41:24] marktraceur: I was going to tell you he's probably walking back from R37, but that doesn't help [21:41:31] Heh [21:41:41] Oh, you're out? That means meeting time for me then [21:41:46] yep [21:55:48] tgr: I don't have the uw funnel script setup in my cron tab on stat1003. isn't it running from yours pointing to your own checkout? [21:56:34] no [21:56:43] should I do that? [21:57:37] seems a bit weird, having multiple instances of the repo, each executing a part of it [21:57:49] I can it to mine, it's no problem [21:58:48] done, and ran manually for good measure [21:58:57] thanks [22:31:38] 3MediaWiki extensions / 3UploadWizard: Upload Wizard's link to 'another file' is always empty - 10https://bugzilla.wikimedia.org/59203#c2 (10Marco) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70617 *** [22:31:52] 3MediaWiki extensions / 3UploadWizard: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617#c1 (10Marco) *** Bug 59203 has been marked as a duplicate of this bug. *** [22:32:55] 3MediaWiki extensions / 3UploadWizard: [REGRESSION]: Error message not parsed exposing plain HTML - 10https://bugzilla.wikimedia.org/70639 (10Marco) [22:32:55] 3MediaWiki extensions / 3UploadWizard: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617 (10Marco) p:5Unprio>3Normal [22:32:55] 3MediaWiki extensions / 3UploadWizard: UploadWizard unable to recover from warnings - 10https://bugzilla.wikimedia.org/46741 (10Marco) [22:50:10] (03CR) 10Gergő Tisza: [C: 032] Rename file page button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162236 (owner: 10Gilles) [22:50:51] (03Merged) 10jenkins-bot: Rename file page button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162236 (owner: 10Gilles) [23:09:49] (03PS1) 10Gergő Tisza: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 [23:10:20] (03CR) 10jenkins-bot: [V: 04-1] Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [23:11:32] (03PS2) 10Gergő Tisza: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499