[02:47:47] (03PS1) 10Yurik: Pass CampaignContent as a constructor param [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161895 [06:19:52] 3MediaWiki extensions / 3MultimediaViewer: Clicking on image with Unicode filename gives MultimediaViewer errors - 10https://bugzilla.wikimedia.org/70378#c3 (10Carl Austin Bennett) It looks like this odd behaviour is caused by Greasedlightbox, a Firefox extension which pops up an image viewer which looks ver... [09:40:53] 3MediaWiki extensions / 3MultimediaViewer: Clicking on image with Unicode filename gives MultimediaViewer errors (due to Greasedlightbox add-on?) - 10https://bugzilla.wikimedia.org/70378 (10Andre Klapper) [10:52:07] 3MediaWiki / 3File management: When a local image and an image redirect on Commons have the same name, the wrong description page is linked - 10https://bugzilla.wikimedia.org/36118 (10Andre Klapper) [10:56:52] 3MediaWiki extensions / 3UploadWizard: [REGRESSION]: Error message not parsed exposing plain HTML - 10https://bugzilla.wikimedia.org/70639#c4 (10Andre Klapper) Krinkle: Any guidance (see comment 3)? [12:18:41] (03PS10) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [12:22:59] (03CR) 10Gilles: [C: 032] Log errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 (owner: 10Gergő Tisza) [12:23:33] (03Merged) 10jenkins-bot: Log errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 (owner: 10Gergő Tisza) [12:25:49] (03CR) 10Gilles: [C: 032] Pass CampaignContent as a constructor param [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161895 (owner: 10Yurik) [12:26:21] (03Merged) 10jenkins-bot: Pass CampaignContent as a constructor param [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161895 (owner: 10Yurik) [13:01:16] (03CR) 10Gilles: [C: 04-1] "The only remaining issue is the vertical jumping experienced in firefox when hovering options in "download": https://dl.dropboxusercontent" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [13:33:42] There is? [13:33:43] Weird. [13:43:23] marktraceur: can you see what I mean on the video? [13:43:28] it goes by a bit quickly [14:21:40] I didn't look yet [14:22:11] Ohhh [14:22:22] That's really tiny. :) [14:22:25] But KK [14:42:48] gi11es: Not even sure why we had a border for that [14:42:55] (03PS2) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [14:43:03] Just seems bloody silly. [14:43:40] gi11es: Once you think it's set, we can push it to alpha to make sure pginer's OK with it, and then I'll probably schedule a deployment window with greg-g so we can push out all 5 patches to Commons tomorrow. [14:43:46] Or Wednesday, not sure. [14:47:31] let me know when it is available on alpha [14:48:07] * marktraceur will do that next. [14:48:51] Cool, anomie has the SWAT, so I don't need to worry about that [14:55:21] (03CR) 10Gilles: [C: 031] Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [14:55:30] (03CR) 10Gilles: [C: 031] Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 (owner: 10MarkTraceur) [14:55:45] (03CR) 10Gilles: [C: 031] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [14:56:07] (03CR) 10Gilles: [C: 031] Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [14:57:45] Woohoo [14:59:10] pginer: alpha is the latest! [15:00:17] I have one doubt. This patchset appears as merged, but the color changes are not visible: https://gerrit.wikimedia.org/r/#/c/161242/ [15:00:21] any idea why? [15:01:07] pginer: not live where? [15:01:22] on alpha [15:01:27] Probably just not rebased the changes onto that [15:01:37] ok [15:01:52] I can rebase it if you want - is it integral to the UI changes? [15:02:28] not integral, just making sure it was not lost in Git/Gerrit limbo [15:02:53] if it's on beta, it's fine [15:03:12] Yeah, beta is for whatever has been merged recently [15:03:31] alpha is for whatever crap we feel like sticking there, on a whim [15:04:19] ok. That is on beta. [15:07:32] the download size selector seems broken [15:07:44] How? [15:08:21] It uses a strange blue underline to indicate the selected option. [15:09:06] That's the oojs-ui styling, I thought I had preserved the past behaviour [15:09:10] pginer: What *should* it be? [15:09:29] It should be maked using a “tick” as it was before, as it is with the embed sizes. [15:10:36] Ah. [15:10:45] That's what those checkmarks were. I tore them out. Crap. [15:13:07] The attribute text probably needs selection facilities (i.e., click to select the whole text). [15:14:15] Huh, thought that got carried over too [15:14:48] * marktraceur debates whether it would be worth it to do this in the download patch or if he should just add *another* child patch [15:25:32] I would like also to do some size changes to the download panel’s height and width, to better fit its content. Should I amend the patchset or write the proposed values here? [15:27:32] You could just write them on the style fixes patch [15:27:40] pginer: Put all of your comments at https://gerrit.wikimedia.org/r/161496 [15:33:09] (03CR) 10Pginer: "The download panel is a bit unbalanced. I would propose adjusting the size a bit to accommodate the contents. Proposed values:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [15:35:47] wikibase's UI is all jQuery UI based, heh [15:35:56] we're never getting rid of that thing :) [15:38:32] Oh god [16:53:05] pginer: Your proposed width makes the attribution div overflow into two lines...not a fan [16:53:45] And you didn't mention the checkmarks or text selection, I'm going to make a note of that after I push the latest style changes [16:54:09] (03PS3) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [16:54:44] (03CR) 10MarkTraceur: "The download menu needs to have checkmarks instead of the default oojs-ui highlighting." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [17:01:30] OK, last thing is text selection, I'm going to say eff it and make a new patch [17:01:34] (03PS4) 10MarkTraceur: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 [17:01:49] Rebase fatigue setting in a bit [17:42:43] gi11es: can you check why the dashboard sql is not working? the SQL commands work for me manually, but stat1003:/srv/public-datasets/all/multimedia/upload-wizard-* does not update [17:44:04] marktraceur: ping [17:44:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=70639#c4 [17:44:14] Krinkle: Pong [17:44:24] Where's the code that calls msg() for that particular error message? [17:44:41] I don't have uploads set up locally, but I can do a static check. [17:44:46] I'll run it on my brain [17:45:30] Hm [17:45:42] I was looking into this. [17:46:19] (03PS1) 10MarkTraceur: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 [17:46:26] I'll try to find it [17:47:39] Krinkle: api-error-duplicate [17:47:51] Probably called in mw.UploadWizardUpload.js or mw.UploadWizardInterface.js [17:47:54] Sorry [17:48:03] mw.UploadWizardUploadInterface.js [17:49:24] Hm.. dynamic key [17:49:27] the only one I could find is $s.msg( msgKey, args ).show(); [17:49:32] Yeah [17:49:46] Oh, right, and I asked you about the bug [17:50:01] UIP.showError [17:50:02] right [17:51:27] Because I suspected that something was wrong with jQueryMsg's code [18:19:06] marktraceur: Freshly installed locally, getting 'Use of mediawiki.api callback params is deprecated. Use the Promise instead.' from some UW code [18:19:10] want me to file a bug? [18:19:13] 1.25 is acoming :) [18:28:15] That would be super [18:28:22] I thought gi11es had already fixed them all though [18:38:08] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c26 (10Steinsplitter) 5PATC>3NEW https://commons.wikimedia.org/wiki/Commons:Upload_help#Receiving_error_at_the_end_of_uploading... [18:39:52] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c27 (10Tisza Gergő) Slightly related: https://gerrit.wikimedia.org/r/#/c/161363/ [18:42:41] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c28 (10Tisza Gergő) (In reply to Steinsplitter from comment #26) > https://commons.wikimedia.org/wiki/Commons: > Upload_help#Receiving_error_at_the_end_of_uploading... The section w... [18:42:59] (03PS1) 10Gergő Tisza: Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 [18:44:07] 3MediaWiki extensions / 3UploadWizard: Improve Error handling: api-error-unknownerror - 10https://bugzilla.wikimedia.org/66366#c29 (10Steinsplitter) 5NEW>3RESO/FIX (In reply to Tisza Gergő from comment #28) > (In reply to Steinsplitter from comment #26) > > https://commons.wikimedia.org/wiki/Commons: > >... [18:44:36] marktraceur: Found the problem, sort of [18:44:51] marktraceur: dialogFn() somehow ends up being the message parameter [18:45:25] 3MediaWiki extensions / 3UploadWizard: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617 (10Steinsplitter) s:5minor>3normal [18:45:47] Yeah, that's about what I found [18:45:57] I think even when I fixed it, it was weird though [18:46:10] marktraceur: http://i.imgur.com/24AGhIz.png [18:46:30] ...huh [18:46:38] 3MediaWiki extensions / 3UploadWizard: Displays another file instead of a link to "the existing file". - 10https://bugzilla.wikimedia.org/70617 (10Steinsplitter) [18:46:40] OK, weird, but I guess fixable [18:47:03] * marktraceur is going to go to Denny's and see if his phone will support his internets [18:47:17] If not, talk to y'all in a few hours, I'll have the latest UW refactoring done [18:48:41] I'm following it furhter down the stack [18:48:45] the function is actually a feature [18:48:51] it ends up being passed to .click(a) [18:48:53] arg [18:48:54] I believe that, yeah [18:48:56] so its fine [18:49:46] at this point innerHTML is "is another file" [18:49:48] so that's good, too [18:50:30] ... and that's where it goes wrong [18:50:33] plural calls .html() [18:50:46] which flattens it back from a tree node with node, to string [18:50:56] plural function nodes [18:50:58] if (node.jquery && node.hasClass('mediaWiki_htmlEmitter')) { [18:50:58] forms[formIndex] = forms[formIndex].html(); [18:50:59] } [18:52:02] (03CR) 10Gergő Tisza: [C: 032] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [18:53:58] marktraceur: I'll try to reproduce in a jqueryMsg test case and give it back to you? [18:55:13] (03CR) 10jenkins-bot: [V: 04-1] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [18:55:38] 3MediaWiki extensions / 3UploadWizard: After uploading files, cannot go back or cancel uploads - 10https://bugzilla.wikimedia.org/32247#c18 (10Steinsplitter) 5PATC>3NEW Open for too long, [ Please rebase your change and upload a new patchset.] [18:57:07] marktraceur: Special:JavaScriptTest/qunit?filter=jqueryMsg:%20Replace - https://gerrit.wikimedia.org/r/162013 [18:58:38] 3MediaWiki extensions / 3UploadWizard: [REGRESSION]: Error message not parsed exposing plain HTML - 10https://bugzilla.wikimedia.org/70639#c5 (10Krinkle) Found the cause, upstream mediawiki.jqueryMsg indeed Broken test case: https://gerrit.wikimedia.org/r/162013 Run with: Special:JavaScriptTest/qunit?fil... [18:59:36] (03CR) 10Gergő Tisza: [C: 032] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:00:13] (03CR) 10jenkins-bot: [V: 04-1] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:00:38] 18:55:11 Could not open input file: maintenance/install.php [19:00:40] wtf? [19:00:46] Antoine!!!!! [19:00:55] :P [19:02:26] (03CR) 10Krinkle: [C: 032] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:03:05] (03CR) 10jenkins-bot: [V: 04-1] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:08:56] (03CR) 10Krinkle: [C: 032] "Reverted recent change to Zuul-merger in QUnit jobs; Should work again now." [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:12:15] (03CR) 10jenkins-bot: [V: 04-1] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [19:14:53] OK. qunit one works again [19:15:08] It seems zuul-merger also got activated for testextensions but I don't see where that change is or how to revert it :( [19:16:07] 3MediaWiki extensions / 3PdfHandler: PdfHandler: Incorrect aspect ratio of the preview images. - 10https://bugzilla.wikimedia.org/22194#c22 (10Tilman Bayer) Another example: https://commons.wikimedia.org/wiki/File:Carta_a_SUBTEL_ref_Wikipedia_Zero.pdf (As in bug 61373, the thumbnail displays fine by itself:... [19:20:47] My bewilderment at the speed of my phone's Internet tethering continues. [19:32:46] (03PS4) 10MarkTraceur: Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 [19:32:49] (03CR) 10jenkins-bot: [V: 04-1] Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [19:35:29] (03PS5) 10MarkTraceur: Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 [19:36:24] (03CR) 10jenkins-bot: [V: 04-1] Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [20:00:30] (03PS10) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [20:15:55] 3MediaWiki extensions / 3CommonsMetadata: Strange `{_: "..."}` in artist/credit - 10https://bugzilla.wikimedia.org/71135 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None See: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=extmetadata&iilimit=10&ti... [20:19:52] 3MediaWiki extensions / 3CommonsMetadata: Strange `{_: "..."}` in artist/credit - 10https://bugzilla.wikimedia.org/71135#c1 (10Mark Holmquist) We're fairly sure that this is happening because the file has an EXIF author and source, but no information template. But I can't verify that because there are basic... [20:59:25] (03CR) 10Gergő Tisza: [C: 032 V: 032] Log errors [extensions/UploadWizard] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162010 (owner: 10Gergő Tisza) [21:21:50] (03PS12) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [21:39:39] (03PS6) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413