[04:39:14] 3MediaWiki extensions / 3UploadWizard: Upload wizard doesn't work in Konqueror: Clicking "Select media files to share" does nothing - 10https://bugzilla.wikimedia.org/23672 (10Nemo) s:5normal>3major [04:42:57] marktraceur: nope [05:21:12] I think someone added npm as voting on UW a bit prematurely... the corresponding changeset that will make it pass still breaks CSS [05:45:24] (03CR) 10Gilles: [C: 031] Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [06:00:30] (03CR) 10Gilles: [C: 032] Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [06:01:00] (03CR) 10jenkins-bot: [V: 04-1] Read description from metadata and suggest it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [07:11:23] (03PS1) 10Gilles: Improve UW funnel queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159676 [07:21:50] (03CR) 10Gilles: [C: 032] "Tested on stat1003" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159676 (owner: 10Gilles) [07:21:55] (03Merged) 10jenkins-bot: Improve UW funnel queries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159676 (owner: 10Gilles) [07:33:28] (03PS1) 10Gilles: Flatten results to make them more limn-friendly [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159677 [07:34:47] (03CR) 10Gilles: [C: 032] "Tested on stat1003" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159677 (owner: 10Gilles) [07:34:52] (03Merged) 10jenkins-bot: Flatten results to make them more limn-friendly [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/159677 (owner: 10Gilles) [08:08:00] (03PS1) 10Gilles: Improve UW funnel graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/159679 [08:08:23] (03CR) 10Gilles: [C: 032] "Tested locally against the live datasources" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/159679 (owner: 10Gilles) [08:09:23] (03CR) 10Gilles: [V: 032] Improve UW funnel graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/159679 (owner: 10Gilles) [10:06:55] hi [10:46:14] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not leave so many history entries when closed - 10https://bugzilla.wikimedia.org/62266#c28 (10Tisza Gergő) There has been considerable debate over this, so I'll try to summarize the options, and then we can pick which are good candidates for... [11:05:29] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not leave so many history entries when closed - 10https://bugzilla.wikimedia.org/62266#c29 (10Tisza Gergő) Implementation sketch: modern browsers support the history.pushState() and history.replaceState(), with the popstate event to detect ch... [11:11:29] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not leave so many history entries when closed - 10https://bugzilla.wikimedia.org/62266#c30 (10Tisza Gergő) Which versions are good candidates for a user test? I would go with C - very easy to implement, and should at least tell us whether the... [11:18:18] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [12:48:06] (03PS1) 10Gergő Tisza: Revert "Change image load check strategy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159713 [12:48:39] (03PS2) 10Gergő Tisza: Revert "Change image load check strategy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159713 [12:49:51] (03CR) 10Gergő Tisza: "The easiest way to debug this behavior is to revert temporarily and see if it goes away." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156753 (owner: 10Gilles) [13:39:32] 3MediaWiki extensions / 3GlobalUsage: GlobalUsage not working with wikis that don't use the Wikimedia database naming convention - 10https://bugzilla.wikimedia.org/70713 (10egel) 3UNCO p:3Unprio s:3normal a:3None GlobalUsage uses functions for finding the names of the wikis and the links to the pages... [13:53:00] 3MediaWiki extensions / 3GlobalUsage: GlobalUsage not working with wikis that don't use the Wikimedia database naming convention - 10https://bugzilla.wikimedia.org/70713#c1 (10egel) Created attachment 16440 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16440&action=edit A possible fix A possible fi... [16:03:18] 3MediaWiki extensions / 3UploadWizard: UploadWizard unable to recover from warnings - 10https://bugzilla.wikimedia.org/46741#c33 (10Mark Holmquist) This is WIP because the issues with the prior patches still exists. I guess we need to finish refactoring before we can have any real solution here. *weeping in... [16:25:33] (03PS9) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [16:26:05] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [16:26:11] gi11es: https://integration.wikimedia.org/ci/job/mwext-UploadWizard-testextensions-master/501/console that failure is benign, right? [16:27:02] * Steinsplitter hugs marktraceur [16:27:09] Ohai Steinsplitter [16:27:12] What's up? [16:40:10] (03PS11) 10MarkTraceur: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [16:40:16] gi11es: I fixed the CSS issue for the most part [16:40:21] It's still big, but doesn't overflow [16:41:58] The Jenkins job got deployed for some reason, so merging this is a good idea. [16:44:44] 3MediaWiki extensions / 3GlobalUsage: GlobalUsage of limited use on wikis that use an other database naming convention than Wikimedia's - 10https://bugzilla.wikimedia.org/70713 (10egel) [16:45:21] (03CR) 10Jforrester: [C: 031] Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [16:45:30] marktraceur: Thanks. [16:46:17] yw [17:03:30] 3MediaWiki extensions / 3PdfHandler: configuration problems with windows paths with blanks/spaces - 10https://bugzilla.wikimedia.org/70083#c12 (10Tisza Gergő) carchaias, can you clarify that runjobs.php --type htmlCacheUpdate gives the "C:\Program" error message? That would be an error of its own. As for... [17:05:00] (03PS4) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [17:05:18] (03CR) 10MarkTraceur: "Rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [17:05:27] (03CR) 10jenkins-bot: [V: 04-1] Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [17:06:26] Right, because npm [17:06:59] gi11es, tgr, it'd be super duper if you could review https://gerrit.wikimedia.org/r/155833 so I don't keep getting false -1s from Jenkins. [17:20:34] +marktraceur | What's up? --- i see [extensions/UploadWizard] . AWESOME. [17:20:37] who is fabrice? [17:21:49] Steinsplitter: He's not online right now, methinks [17:22:51] Aha. [17:22:56] magic :) [17:22:56] Steinsplitter: fabriceflorin just got in. [17:23:11] yes, i meesed him here. [17:23:31] Hi guys! [17:23:45] hi fabricer [17:23:48] -r [17:23:52] :) [17:24:32] gi11es marktraceur tgr: Which Media Viewer features are we releasing today? [17:25:30] Uh [17:25:36] I think just the image clicking business [17:26:02] marktraceur: Were we able to fix the Enlarge images tooltip? Or do we need a new card for that? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/831 [17:26:24] I think it still needs a card [17:26:57] marktraceur: OK, I will add a card for that. Would be great if we could take care of it in this sprint, so it doesn’t linger … [17:29:23] marktraceur: what are the i18n changes? those were existing messages which did not have a documentation in qqq? [17:30:21] tgr: Yeah [17:30:23] (03CR) 10Gergő Tisza: Set up an npm test pipeline for JS, CSS and banana i18n messages (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:31:31] (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:32:02] (03CR) 10MarkTraceur: Set up an npm test pipeline for JS, CSS and banana i18n messages (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:32:08] Argh [17:32:34] :-) [17:32:38] * James_F stops responding. [17:33:11] Quick, get the defibrillator [17:36:10] marktraceur: #886 Remove 'View original file' tooltip from 'Enlarge image’ feature: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/886 [17:36:52] it'd be nice to get that fixed today since people will be poking at what's on mediawiki.org. not critical but if it's an easy fix .. [17:37:49] Just a matter of deleting some lines [17:37:51] * marktraceur does it. [17:39:47] (03PS1) 10MarkTraceur: Remove tooltip for view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159775 [17:39:52] fabriceflorin, Eloquence ^^ [17:39:56] thanks :) [17:40:30] (03CR) 10jenkins-bot: [V: 04-1] Remove tooltip for view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159775 (owner: 10MarkTraceur) [17:40:34] Oh bollocks. [17:41:46] marktraceur: Super. Let me know if I can test this anywhere. Might it will make it in time for today’s deployment train? [17:41:52] (03PS2) 10MarkTraceur: Remove tooltip for view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159775 [17:42:06] Ask your possible reviewers [17:42:11] It's not testable because it's not merged [17:43:10] gi11es tgr : Would you mind reviewing https://gerrit.wikimedia.org/r/159775 ? It’s a very simple change, would love to have it out in today’s release, since we are widely announcing first improvements today. [17:43:40] wasn't the branch cut already? [17:43:50] it's, what, 12PM in SF? [17:44:03] It’s 10:40am in SF. [17:47:23] (03CR) 10Gergő Tisza: [C: 04-1] Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:48:11] marktraceur: ^^^ Want to take that? [17:49:39] James_F: Sure [17:51:59] marktraceur: in the MMV patch, shouldn't you remove from qqq as well? [17:52:08] I can never remember how that works [17:53:39] I think it gets cleaned up automatically by l10n bot [18:03:00] I'm getting "500 hphp_invoke" locally on all extmetadata calls [18:03:02] tgr, marktraceur: Yeah, you should only remove en.json messages. [18:03:03] fun [18:03:25] thanks, I'll try to remember it this time [18:03:53] tgr: Though I remove the qqq ones too. :-) [18:04:24] That's our James_F, always giving 200%. [18:04:38] :-) [18:05:09] Eloquence/James_F/quiddity: what do you think about enabling flow on outreachwiki in the next days/weeks? [18:08:52] Steinsplitter: The team might be a bit over-stretched at this point, but that's Danny's call. [18:10:16] ok :) (it is only a small wiki and i am sure there is no oppose) [18:11:42] Steinsplitter, not this week (there's a lot of chaos going on right now), but it's good to hear that you're still interested :) (Also, the flow team's main channel is #wikimedia-corefeatures and the product manager for Flow is dannyh :) [18:11:54] s/chaos/activity/ ! ;-) [18:14:06] :) [18:17:14] James_F: I second marktraceur’s praise about your giving 200% — thanks so much for your help with my translate issues last night. You’re a champ! [18:22:24] Steinsplitter, you're asking for a new feature to be enabled? *rubs eyes* ;-) [18:23:37] fabriceflorin: Always happy to help. :-) [18:23:47] James_F: :) [18:24:44] exactly, i love useful fetaures like transslate extension and flow [18:25:15] mmv is not so bad, have you played with the latest version? [18:26:37] nope, will look later. [18:39:13] (03CR) 10Gergő Tisza: [C: 032] Remove tooltip for view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159775 (owner: 10MarkTraceur) [18:39:18] Huzzah [18:39:27] James_F: Any luck on the npm thing? [18:39:36] marktraceur: What npm thing? [18:39:39] had to beat some sense into HipHop first [18:39:51] (03Merged) 10jenkins-bot: Remove tooltip for view-file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159775 (owner: 10MarkTraceur) [18:40:22] You asked if you wanted to take the c-1, James_F [18:40:31] I asked if you wanted to take it. [18:40:36] But I can instead, no worries. [18:40:47] Oh, sorry, misread [18:40:55] If you're busy I still can. [18:41:16] this needs backporting, then? [18:41:25] tgr: Yeah, I can SWAT it out later. [18:41:27] marktraceur: No worries. [18:41:37] cool, thanks [18:41:44] (03PS12) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [18:41:48] (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [18:45:15] 3MediaWiki / 3File management: image/vnd.microsoft.icon not recognized as MIME type for .ico (can trigger error message when trying to overwrite existing icons) - 10https://bugzilla.wikimedia.org/69437#c1 (10Alexia E. Smith) Created attachment 16442 --> https://bugzilla.wikimedia.org/attachment.cgi?id=1644... [18:53:30] tgr: Do you want to do the submodule update perchance? [18:53:52] will do [18:53:55] Sweet [18:54:12] (03PS6) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [18:54:15] (03CR) 10jenkins-bot: [V: 04-1] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [18:54:18] (03CR) 10MarkTraceur: Add model base class, description model (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [18:57:36] (03PS7) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [18:57:52] (03CR) 10MarkTraceur: "Rebase. npm tests undoubtedly still failing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [18:58:03] (03CR) 10jenkins-bot: [V: 04-1] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [18:58:07] Ta daaaaa [19:17:06] fabriceflorin: How's the grand unifying response coming? [19:18:05] marktraceur: the patch works fine for me, are there still concerns about conflicts or should I just go on and merge? [19:19:36] marktraceur : It’s coming together very nicely, on schedule. We aim to post our response to the Media Viewer consultation by 4pm PT today, along with related documents. We will then announce it on a variety of channels, such as the Media Viewer talk page, Commons + Enwiki Village Pumps and the Multimedia and Commons mailing lists. [19:20:44] 3MediaWiki / 3File management: image/vnd.microsoft.icon not recognized as MIME type for .ico (can trigger error message when trying to overwrite existing icons) - 10https://bugzilla.wikimedia.org/69437#c2 (10Andre Klapper) Hi! Thanks for your patch! You are welcome to use Developer access https://www.medi... [19:22:32] tgr: My desire to have a test for these things overrides my dislike for rebasing, go nutts [19:22:35] nuts. [19:23:19] (03CR) 10Gergő Tisza: [C: 032] Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [19:23:29] \o/ [19:23:35] Yay. [19:23:39] Peace in our time [19:23:46] Or at least code quality [19:23:47] (03Merged) 10jenkins-bot: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [19:24:19] marktraceur: Now begins the fun step of switching each of the over-rides off. [19:24:24] marktraceur: Maybe not today. :-) [19:26:15] (03PS8) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [19:26:19] Yeah probably later. [19:26:41] (03CR) 10jenkins-bot: [V: 04-1] Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur) [19:28:24] (03PS9) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 [19:31:14] 3MediaWiki extensions / 3MultimediaViewer: mediaviewer icons inconsistent and not using Wikifont assets - 10https://bugzilla.wikimedia.org/65919#c6 (10Tisza Gergő) Is there a bug tracker component for the wiki-not-font assets? I opened bug 70654 recently about icons, but it's not really a MediaViewer bug. [19:37:54] (03PS10) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [19:38:25] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [19:42:12] (03PS11) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [19:45:24] Oh! I guess the branch only just got cut [19:45:26] Or something [20:03:56] Never mind, our patch isn't on mw.org [20:10:08] (03PS5) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [20:10:11] (03PS1) 10Gergő Tisza: Remove tooltip for view-file [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/159823 [20:11:59] (03CR) 10Gergő Tisza: [C: 032] Remove tooltip for view-file [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/159823 (owner: 10Gergő Tisza) [20:12:36] (03Merged) 10jenkins-bot: Remove tooltip for view-file [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/159823 (owner: 10Gergő Tisza) [20:14:29] 3MediaWiki / 3File management: image/vnd.microsoft.icon not recognized as MIME type for .ico (can trigger error message when trying to overwrite existing icons) - 10https://bugzilla.wikimedia.org/69437#c3 (10Alexia E. Smith) Patch submitted through the uploader. https://gerrit.wikimedia.org/r/#/c/159824/ [20:29:23] marktraceur: https://gerrit.wikimedia.org/r/159829 [20:29:46] Yeah, I see it [20:29:55] I'll add it to [[Deployments]] [21:31:39] Argh, didn't realize we still wanted the project icons in the more details button, totally messed it up [21:42:14] fabriceflorin: I hate to ask, but is the project icon change something that pginer has weighed in on? [21:42:18] What's the benefit? [21:45:51] marktraceur: Yes, Pau has agreed to that change. We discussed it in several meetings this week. This is in response to community requests in the recent consultation, where users asked that we provide a visual cue to the site you are about to jump to (e.g. Commons), as well as mention the site name in the tooltip. [21:47:08] Hrm, 'kay [21:47:25] * marktraceur undoes a bunch of stuff [21:47:43] Thanks, marktraceur ! [22:09:32] (03PS3) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [22:10:00] pginer is gonna want to make us a new icon. [22:11:48] so when i try to upload an image via Upload Wizard/flickr, i get this error [22:11:58] "There is another file already on the site with the same content." [22:12:10] markup broken? [22:12:17] comets: I've seen that, I think there's a bug. Maybe a patch. Let me look! [22:15:26] comets: https://bugzilla.wikimedia.org/show_bug.cgi?id=70639 [22:15:46] I'll see if I can't fix 'er for you [22:16:55] :D [22:26:34] Looks like it's a bug in jqmsg [22:26:40] I don't see anything wrong on our side...I think [22:31:43] Yeah, not really sure what to do about this [22:33:14] I'm going to add Krinkle|detached to the report. [22:34:14] 3MediaWiki extensions / 3UploadWizard: [REGRESSION]: Error message not parsed exposing plain HTML - 10https://bugzilla.wikimedia.org/70639#c3 (10Mark Holmquist) Krinkle - I'm adding you to the CC here so you're aware of this. I think this is a bug in how $.fn.msg works, but I might be wrong. Any guidance wou... [22:34:20] Krinkle|detached: You have a shiny new CC in your inbox. https://bugzilla.wikimedia.org/show_bug.cgi?id=70639 [22:36:27] are we going to hit the SWAT window with the view orig fix or will that have to wait til next week? [22:43:14] Yup, I'm SWATting it [22:44:07] Or Roan is. [22:44:15] yay [22:46:49] * comets prefers the DUMP button for MV :| [22:47:33] comets: I think everyone's opinion on that is pretty clear in this channel. :) [22:48:00] ^_^ [23:35:13] fabriceflorin: No post yet? [23:41:46] marktraceur: I just posted our response now. Wanted to make sure to triple-check everything. Here it is: [23:41:47] https://meta.wikimedia.org/wiki/Community_Engagement_(Product)/Media_Viewer_consultation [23:42:19] Let me know if you see anything that’s an issue. I will wait to promote this until I hear back from folks this is good to go. [23:50:09] fabriceflorin: The third section is meant to be outside the closed div? [23:51:28] I don't see any reason to delay posting things [23:52:09] Good catch, thanks. I just removed the stray , so all sections share the same background. [23:53:21] OK, sounds good. I will get ready to spread the word. First on the village pumps, then on the mailing lists. Give me 30 mins or so to get the copy written and approved.