[05:50:39] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] "The change looks good, but I'll wait this one out a little bit to see if there's any objection to this change in the village pump discussi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ)
[06:18:15] <grrrit-wm>	 (03PS3) 10Gilles: Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) 
[06:21:52] <grrrit-wm>	 (03CR) 10Gilles: "I don't think that this feature has any value to anyone. We've always said that this was a poor man's placeholder that should be replaced " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158586 (owner: 10Gilles)
[06:22:56] <grrrit-wm>	 (03CR) 10Gilles: "I don't think this is useful for any wiki without a way to rank categories. Right now it's a poor experience for any wiki." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158587 (owner: 10Gilles)
[06:25:47] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Feedback: Use a proper URL for the feedback page link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158896 (owner: 10TheDJ)
[06:26:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Feedback: Use a proper URL for the feedback page link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158896 (owner: 10TheDJ)
[06:33:15] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Go to the original image on image clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158518 (owner: 10MarkTraceur)
[06:33:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Go to the original image on image clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158518 (owner: 10MarkTraceur)
[06:34:18] <grrrit-wm>	 (03CR) 10Gilles: "Is this still WIP?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[06:36:23] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] "The Mingle card states "More details" for the button caption, this uses "More details about this file"." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur)
[06:42:55] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur)
[06:43:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur)
[06:43:30] <grrrit-wm>	 (03PS7) 10Gilles: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur)
[06:49:17] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] "Needs updating to follow the recent changes to the parent, I'm getting "this.ui.moveTo is not a function"" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur)
[07:03:42] <grrrit-wm>	 (03PS4) 10Gilles: Track more clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 
[07:48:00] <grrrit-wm>	 (03CR) 10Jforrester: "I guess it is because it doesn't yet add qqq documentation for all messages (~20 left without after this), but Mark will know better." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[08:24:29] <grrrit-wm>	 (03PS5) 10Gilles: Track more clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 
[08:25:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Track more clicks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 (owner: 10Gilles)
[08:26:13] <grrrit-wm>	 (03PS6) 10Gilles: Track more metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 
[08:26:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Track more metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 (owner: 10Gilles)
[08:27:00] <grrrit-wm>	 (03PS7) 10Gilles: Track more metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 
[10:01:24] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: configuration problems with windows paths with blanks/spaces - 10https://bugzilla.wikimedia.org/70083#c4 (10Tisza Gergő) Backslashes should be doubled inside a quoted string (whether single- or double-quotes). However in this specific case I don't think it matters, PHP pr...
[10:19:40] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 - 10https://bugzilla.wikimedia.org/70553 (10Michael M.) 3NEW p:3Unprio s:3major a:3None On https://de.wikipedia.org/wiki/Wikipedia:Fragen_von_Neulingen a user reports that MediaViewer is broken in IE 8, which I can partially...
[10:21:09] <wikibugs>	 3MediaWiki extensions / 3CommonsMetadata: Rename key "Credit" to "FileSource" - 10https://bugzilla.wikimedia.org/57189#c6 (10Tisza Gergő) The reason for using the XMP naming schema is that the data extracted from the templates is merged with the XMP data from the file. That way, if the file page does not hav...
[10:24:53] <wikibugs>	 3MediaWiki extensions / 3CommonsMetadata: Rename key "Credit" to "FileSource" - 10https://bugzilla.wikimedia.org/57189#c7 (10Tisza Gergő) (In reply to Tisza Gergő from comment #6) > That way, if the file page does not have an {{Information}} template but the  > file has a Credit EXIF field, it can be display...
[10:27:54] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 - 10https://bugzilla.wikimedia.org/70553#c1 (10Michael M.) For reference: This seems to be caused by https://gerrit.wikimedia.org/r/#/c/150086/
[10:42:38] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 - 10https://bugzilla.wikimedia.org/70553#c2 (10Tisza Gergő) IE8 does not support Object.create so https://gerrit.wikimedia.org/r/#/c/150086/ should stop MediaViewer from being loaded (unless something polyfills it).
[12:24:53] <grrrit-wm>	 (03PS5) 10Siebrand: Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[12:25:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[12:29:54] <grrrit-wm>	 (03CR) 10Rillke: [C: 031] "We do not consider UW Flickr uploads as verified because they aren't. This also does not have something to do with "community", this is ju" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158887 (owner: 10TheDJ)
[12:36:23] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158586 (owner: 10Gilles)
[14:01:53] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 - 10https://bugzilla.wikimedia.org/70553#c3 (10Derk-Jan Hartman) I can confirm that on IE8 by default this test should work, but on wikipedia it fails.   That probably means that something... somewhere... is polyfilling Object.create
[14:02:23] <thedj>	 tgr: ^ tested on my IE8 VM
[14:02:58] <tgr>	 thanks!
[14:04:30] <dan-nl>	 hey csteipp, when you get a moment, i need some validation on what to do about CURLOPT_REDIR_PROTOCOLS for the vagrant environment. see https://gerrit.wikimedia.org/r/#/c/158950/
[14:21:49] <thedj>	 tgr: seems oojs.jquery is loaded and that is filling it.
[14:24:15] <thedj>	 oh no, that's just minified in front of it.
[14:24:21] <thedj>	 it's simply resources//src/polyfill-object-create.js
[14:25:18] <tgr>	 thedj: the only place where we use addEventListener is mmv.ui.canvas.js, can you verify that the error is in that file?
[14:25:30] <tgr>	 you can use debug=1 to get sane error locations
[14:25:52] <thedj>	 tgr: nope, IE8 blows up in debug mode, due to too many script files :)
[14:26:21] <thedj>	 but i should be able to distinguish from the minified mode
[14:27:46] <thedj>	 yup, on the window.addEventListener
[14:28:10] <thedj>	 of course, that is not an es5 element, so the es5 polyfill won't help there i guess
[14:29:08] <tgr>	 thanks
[14:29:16] <tgr>	 I'll fix that in a sec
[14:30:12] * thedj wonders if there is a shim specifically for IE7/8.....
[14:30:58] <tgr>	 jquery sort of does that, don't know why didn't use $.on in this case
[14:31:27] <thedj>	 true
[14:40:50] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles)
[15:06:23] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 on WMF sites - 10https://bugzilla.wikimedia.org/70553 (10Andre Klapper)
[15:25:10] <tgr>	 James_F: do you know if oojs polyfills Object.create now? or what else does?
[15:35:49] <James_F>	 tgr: Looking.
[15:36:18] <James_F>	 tgr: Yeah, we added it in wmf19: https://gerrit.wikimedia.org/r/#/c/156046/
[15:37:22] <tgr>	 James_F: thanks
[15:37:38] <James_F>	 tgr: Is it causing issues?
[15:38:34] <tgr>	 in a way
[15:39:03] <tgr>	 I made MediaViewer load or not load based on a "'create' in Object" test
[15:39:10] <tgr>	 which was a bit stupid
[15:40:00] <James_F>	 Ah.
[15:40:02] <James_F>	 Sorry
[15:41:09] <marktraceur>	 I thought that was the feature we needed, though?
[15:41:17] <tgr>	 it's my fault for writing a half-assed feature detection
[15:41:32] <tgr>	 that was the only feature OOJS needed
[15:41:42] <tgr>	 but not the only feature MediaViewer needed
[15:42:54] <marktraceur>	 Ah.
[15:43:04] <James_F>	 Right.
[15:45:17] <tgr>	 I don't get how this can cause problems on dewiki, though
[15:45:39] <tgr>	 shouldn't it only get deployed this Thursday?
[15:46:34] <tgr>	 eh, don't mind me, I can't read calendars
[15:52:09] <grrrit-wm>	 (03CR) 10MarkTraceur: "My bad." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur)
[15:53:53] <grrrit-wm>	 (03PS2) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 
[16:36:29] <marktraceur>	 robla, Keegan - are y'all still alive out there?
[16:36:55] <Keegan>	 We iz
[16:36:58] <Keegan>	 Technical delay
[16:40:15] <Keegan>	 Almost there, marktraceur, tgr, gi11es
[16:43:23] <wikibugs>	 3MediaWiki / 3Uploading: PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137 - 10https://bugzilla.wikimedia.org/53820#c10 (10Gilles Dubuc) 5ASSI>3RESO/WOR No trace of the exception in the last 30 days on logstash nor in the fluorine archives...
[17:01:58] <tgr>	 robla: the bug that might be responsible for the UW drop is https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/637 , it has been already selected for the cycle
[17:08:59] <marktraceur>	 tgr: connection issues?
[17:09:06] <tgr>	 yes
[17:35:24] <wikibugs>	 3MediaWiki extensions / 3CommonsMetadata: Rename key "Credit" to "FileSource" - 10https://bugzilla.wikimedia.org/57189#c8 (10Ryan Kaldari) >I am not sure it is worth breaking BC on an API that is going to be deprecated any minute.  I would normally be inclined to agree with you, but I would be surprised if t...
[17:49:51] <tgr>	 pginer: worth keeping in mind that first-time doesn't work well cross-wiki with anons
[17:50:37] <tgr>	 if you do stuff and then set a cookie to not do it again, that will annoy people who disable or regularly clear cookies
[17:50:56] <pginer>	 we need to keep the disabled status. If that gets forgoten, then the first time is not relevant.
[17:51:41] <tgr>	 if yet a cookie to do stuff and then remove it once you did it, setting and removing has to be on the same domain
[18:28:56] <marktraceur>	 Code review massacrrrrrrrre time
[18:29:08] <thedj>	 hehe
[18:29:31] <marktraceur>	 Bribes accepted
[18:34:40] <wikibugs>	 3MediaWiki extensions / 3GWToolset: HHVM: CURLOPT_REDIR_PROTOCOLS not defined - 10https://bugzilla.wikimedia.org/70570 (10dan) 3NEW p:3Unprio s:3normal a:3None While working with the gwtoolset role in vagrant, i noticed that gwtoolset wasn’t accepting metadata sets whose mediafile URLs contained redi...
[18:35:08] <wikibugs>	 3MediaWiki extensions / 3GWToolset: HHVM: CURLOPT_REDIR_PROTOCOLS not defined - 10https://bugzilla.wikimedia.org/70570 (10dan)
[18:44:53] <wikibugs>	 3MediaWiki extensions / 3CommonsMetadata: Rename key "Credit" to "FileSource" - 10https://bugzilla.wikimedia.org/57189#c9 (10Tisza Gergő) We intend to create a high-level API on top of the low-level data storage mechanism (which might be templates or Wikibase properties, depending on whether the file has bee...
[18:53:39] <wikibugs>	 3MediaWiki extensions / 3GWToolset: HHVM: CURLOPT_REDIR_PROTOCOLS not defined - 10https://bugzilla.wikimedia.org/70570#c2 (10dan) upstream issue: https://github.com/facebook/hhvm/issues/3702
[19:02:23] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Track more metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 (owner: 10Gilles)
[19:03:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Track more metrics [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158614 (owner: 10Gilles)
[19:12:36] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158589 (owner: 10Gilles)
[19:13:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove expensive synchronous template validation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158589 (owner: 10Gilles)
[19:18:19] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles)
[19:19:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix TitleBlacklist support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles)
[19:19:30] <marktraceur>	 gi11es: Do you see any value in fixing our handling of no stage object in the API response?
[22:29:05] <neilk_>	 Can I get anyone to pull the trigger on https://gerrit.wikimedia.org/r/#/c/158240/ ?
[22:29:13] <neilk_>	 I think it would stop some failing tests.
[22:29:23] <neilk_>	 It's been reviewed 
[22:31:57] <marktraceur>	 I will look!
[22:32:07] <marktraceur>	 2014-09-08 - 11:28:56  <+marktraceur> Code review massacrrrrrrrre time
[22:33:17] <neilk_>	 marktraceur: thanks
[22:33:40] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Blam. You can leave the whisky with my driver, Jeeves." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk)
[22:34:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: wait for ajax calls to complete [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158240 (owner: 10Neilk)
[23:12:43] <James_F>	 marktraceur: Is https://gerrit.wikimedia.org/r/#/c/155850/ good to merge?
[23:13:14] <James_F>	 marktraceur: Purely in the name to code review minimisation.
[23:16:14] <marktraceur>	 Seems fine to me James_F 
[23:16:26] * James_F fires and forgets.
[23:16:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[23:17:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add some missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur)
[23:20:15] <grrrit-wm>	 (03PS6) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 
[23:21:01] <grrrit-wm>	 (03CR) 10Jforrester: "PS6 is a rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester)
[23:21:17] <James_F>	 marktraceur: ^^^ Would appreciate your help on the remaining 18 qqq failures there.
[23:22:55] <marktraceur>	 Adding them to that patchset?
[23:23:49] <marktraceur>	 Or a new one?
[23:26:04] <grrrit-wm>	 (03CR) 10Rillke: "The way code-review is carried out here *****: https://gerrit.wikimedia.org/r/139592" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158337 (https://bugzilla.wikimedia.org/65624) (owner: 10Gilles)
[23:26:58] <James_F>	 marktraceur: That one, or a different one I can rebase onto is fine. Your call.
[23:27:08] <marktraceur>	 I'm using that commit
[23:27:19] <James_F>	 Kk.
[23:27:28] <James_F>	 Also need to get UW actually running npm too.
[23:29:01] <marktraceur>	 neilk...damn it
[23:29:14] <marktraceur>	 Oh, never mind, back to normal.
[23:30:31] <grrrit-wm>	 (03CR) 10Krinkle: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester)
[23:31:30] <grrrit-wm>	 (03CR) 10Rillke: "Will someone merge this patch if I rebase it or are parts <https://gerrit.wikimedia.org/r/158337/> of it pushed though gerrit until it is " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke)
[23:34:22] <grrrit-wm>	 (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester)
[23:35:30] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke)
[23:40:17] <grrrit-wm>	 (03PS7) 10MarkTraceur: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester)
[23:40:22] <marktraceur>	 Ta James_F
[23:49:30] <grrrit-wm>	 (03PS8) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 
[23:49:57] <grrrit-wm>	 (03CR) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester)
[23:50:23] <James_F>	 marktraceur: ^^^ OMG it now passes. :-)
[23:50:42] <James_F>	 marktraceur: Want to review and decide?
[23:55:25] <marktraceur>	 James_F: Tomorrow, I think
[23:55:47] <James_F>	 marktraceur: Sure; hope Krinkle will be around to throw the switch.
[23:55:57] <marktraceur>	 And how
[23:56:39] <Krinkle>	 Yeah, don't merge yet. Tomorrow I'll flip the switch, then rebase/recheck that commit, and merge if it passes.
[23:58:42] * James_F nods.
[23:59:00] <James_F>	 marktraceur: So, if you're happy with it +1 it before end of tomorrow?