[00:58:54] (03PS2) 10Gergő Tisza: Fix link to media viewer with proper namespace [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156163 (https://bugzilla.wikimedia.org/69956) (owner: 10MarkTraceur) [00:59:34] (03CR) 10jenkins-bot: [V: 04-1] Fix link to media viewer with proper namespace [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156163 (https://bugzilla.wikimedia.org/69956) (owner: 10MarkTraceur) [01:00:51] (03PS3) 10Gergő Tisza: Fix link to media viewer with proper namespace [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156163 (https://bugzilla.wikimedia.org/69956) (owner: 10MarkTraceur) [01:05:01] (03CR) 10Gergő Tisza: [C: 032] Fix link to media viewer with proper namespace [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156163 (https://bugzilla.wikimedia.org/69956) (owner: 10MarkTraceur) [01:05:43] (03Merged) 10jenkins-bot: Fix link to media viewer with proper namespace [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156163 (https://bugzilla.wikimedia.org/69956) (owner: 10MarkTraceur) [01:14:54] 3MediaWiki extensions / 3MultimediaViewer: via attribution link provides wrong mediaviewer link - 10https://bugzilla.wikimedia.org/69956 (10Tisza Gergő) 5PATC>3RESO/FIX [05:26:39] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display the "Credit" parameter when available - 10https://bugzilla.wikimedia.org/65445#c5 (10Erik Moeller) Hi all, The {{Credit line}} template is problematic in three important ways: 1) It repeats information in an error-prone manner. Author,... [06:42:25] 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c5 (10carchaias) This happens also on other browsers I test with IE11, IE8 and Firefox 31 . This happens also with other fileextensions like jpg and JPG. This happens also with other webse... [06:59:23] 3MediaWiki / 3File management: Previous versions of files should be collapsible - 10https://bugzilla.wikimedia.org/69053#c2 (10Florian) Is there an opinion by design or others? In my point of view there is no need to this. The thumbs in the history are fixed to max. 120 pixel. Opinions? :) [07:07:25] 3MediaWiki / 3Uploading: Uppercase picture extensions like .PNG are not allowed - 10https://bugzilla.wikimedia.org/66667#c6 (10carchaias) Removing the ! in includes/libs/IEUrlExtension.php at line 120 brings the files back in all cases mentioned in Comment 5 [07:51:47] (03CR) 10Gilles: [C: 04-1] "I'm afraid you're going to have to redo it anyway because in my review backlog there are several higher proprity refactoring changesets do" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [08:44:56] 3MediaWiki extensions / 3GWToolset: PHP Notice: Undefined index: contributors - 10https://bugzilla.wikimedia.org/70024 (10dan) 3NEW p:3Unprio s:3normal a:3None While running a GWToolset Mediafile Batch Job from the command line I noticed the following PHP Notice: Undefined index: contributors in /c... [09:19:39] 3MediaWiki extensions / 3MultimediaViewer: The link feature should provide the normal URL, not add #mediaviewer to it - 10https://bugzilla.wikimedia.org/69977#c3 (10Liam Wyatt) To reply to your points using the numbering scheme you've given them: 1) I don't mind what the embed code links to, its just that c... [09:44:09] 3MediaWiki / 3Uploading: Special uploadtext for the reupload form - 10https://bugzilla.wikimedia.org/17194#c3 (10Andre Klapper) 5UNCO>3RESO/WOR Heh, alright. Thanks for the reply :) [10:37:49] (03PS4) 10Gergő Tisza: Fix preference DB values [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156004 [10:42:03] (03CR) 10Gergő Tisza: "Added more comments. Looking more closely at how the pref system works (the $defaultOption condition in User::saveOptions() is the relevan" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/156004 (owner: 10Gergő Tisza) [11:19:24] 3MediaWiki extensions / 3MultimediaViewer: The link feature should provide the normal URL, not add #mediaviewer to it - 10https://bugzilla.wikimedia.org/69977#c4 (10Derk-Jan Hartman) I posted this to bug 69539 as well, but I was thinking, what about this: https://commons.wikimedia.org/wiki/File:Qwerty.jpg#me... [11:40:09] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display the "Credit" parameter when available - 10https://bugzilla.wikimedia.org/65445#c6 (10Derk-Jan Hartman) 1) Agreed 2) Agreed, though there are a few uses that are more esoteric and or where people request to list Multiple licenses for inst... [12:12:09] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display the "Credit" parameter when available - 10https://bugzilla.wikimedia.org/65445#c7 (10Tisza Gergő) (In reply to Derk-Jan Hartman from comment #6) > I say just parse it out, strip all html other than and show it in full > place instead... [12:16:24] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display the "Credit" parameter when available - 10https://bugzilla.wikimedia.org/65445#c8 (10Derk-Jan Hartman) We show incorrect data all the time right now, why should we be overly correct on something where people want to deviate from the stand... [12:20:09] 3MediaWiki extensions / 3MultimediaViewer: Link to file page instead of lightbox over file page in the HTML embed code - 10https://bugzilla.wikimedia.org/69539#c5 (10Toby) I agree with Lupo. Please just link directly to the Commons page. It's simpler, cleaner, provides direct access to all the file informa... [14:32:39] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display the "Credit" parameter when available - 10https://bugzilla.wikimedia.org/65445#c9 (10Jean-Fred) Regarding the extent of the usage of {{Credit line}}, I just ran I have sampled some of the biggest use... [14:34:09] (03CR) 10Gergő Tisza: [C: 04-1] "Just a tiny issue, but more importantly, shouldn't we have a separate UploadWIzardErrorEvent schema? IMO errors are important enough that " (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [15:25:51] (03CR) 10Gergő Tisza: "No concerns apart from that one." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [15:26:11] (03CR) 10Gergő Tisza: [C: 031] Move confirmCloseWindow to core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151127 (owner: 10MarkTraceur) [15:36:34] marktraceur: just glancing at the code, is start/end based on calendar dates? [15:36:45] (and not specific times) [15:36:57] I think the WLM folks like to have control of the hour as well [15:37:28] ah, strtotime, I guess it can be pretty much anything [15:38:06] I don't know how time is usually handled though (server timezone vs user's timezone) [15:39:10] i.e. since there's a timezone option in the user settings, I'd imagine that usually when people are invited to enter a time it's interpreted as their own timezone [15:39:40] and presumably strtotime will be based on the server's [15:40:45] unless there's a call upstream in php that sets the php timezone to the user's [15:43:05] gi11es: I had just used dates, but yeah, I assume it will be possible to set the hour based on server time [15:43:19] gi11es: Admins are pretty used to server time, I think - all of our log entries use it IIRC [15:50:12] (03CR) 10Jforrester: "The objective of this change was to make the repo pass quickly and then I'd rebase all outstanding patchsets, as is normal. Doing it the o" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [15:59:54] (03CR) 10Gergő Tisza: [C: 04-1] Add start/end and whileActive to the campaigns (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [16:00:06] fab [16:16:24] 3MediaWiki extensions / 3MultimediaViewer: "View license" link should be anchored to "licensing" section if standard header is used - 10https://bugzilla.wikimedia.org/56829#c4 (10Luis Villa (WMF Legal)) Given how difficult it can be for non-experts to pick out the right license information from a File: page... [16:38:32] avanyu88 [16:38:43] Never mind. [16:39:53] Welcome [17:21:32] (03PS9) 10MarkTraceur: Add some flow events for funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [17:22:06] (03CR) 10MarkTraceur: "Inline comments responded to; patch incoming." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144588 (owner: 10Gergő Tisza) [17:26:24] marktraceur: seems like our servers run on UTC, so it's not too bad [17:26:33] Yeah [17:26:46] And that's what all the diff timestamps and log times are in too [17:26:50] So people definitely know it. [17:26:58] I'm too used to the nightmare that dA's servers being set to LA time was [17:27:07] Ugh, that's awful [17:27:40] hard to change mid-flight... [17:27:53] the bad decision is probably 14 years old [17:28:35] anyway, UTC I think people can tolerate [17:28:53] re: tgr's remark, I think we just need to ask Romaine (he's not around right now via PM) [17:29:33] if it's not a feature they particularly care about, it's better to launch what you've made asap, imho [17:29:50] I mean we can even add the test parameter in later commit anyway [17:32:35] Ah, yeah [17:33:03] I hadn't seen it yet, but I agree, I don't think it's pressing right now [17:34:52] I dunno what he's on about with the if statement. [17:36:13] Oh, I see. [17:40:19] fabriceflorin, FYI my mate paroneayea has just released the latest version of GNU MediaGoblin, it may be worthwhile to spend some time writing a migration tool for MediaGoblin sites given they now have a more full API going on [17:40:23] http://mediagoblin.org/news/mediagoblin-0.7.0-time-travelers-delight.html [17:40:33] marktraceur: I think your active checks are in the wrong place [17:40:35] this->parsedConfig = $memValue['config']; [17:40:47] if it finds the parsed config in memcache, it doesn't try to re-generate it [17:40:56] Oh, hm. [17:41:04] and your isActive checks are inside the code that generates the parsed config [17:41:20] marktraceur: cool. Once upon a time I wanted to see if it was possible to write ForeignAPIRepo type things for other sites, but media goblin didn't have an api back then [17:41:22] I should prolly move it, then. [17:41:26] right :) [17:42:03] bawolff: Yeah, I was thinking of writing a pair of migration tools (one for MW, the other for GMG), but there wasn't an API and I was too new to their codebase to sort it out [17:42:17] the right place would be where the parsed config is read/used [17:42:39] my experiment lasted basically long enough for me to install a test site, and then I got bored ;) [17:43:10] bawolff: Yeah, I had a site running at media.marktraceur.info for a while, but it gave way when I stopped updating it and it got a bunch of phantom errors [17:43:19] marktraceur: https://wiki.mediagoblin.org/Special:Version :( [17:43:22] Now I have marktraceur.info/shared/images because I am nerd [17:43:56] Oh, gods [17:44:48] is this served off your laptop? [17:45:06] gi11es: No, I have a VPS at xlhost on Coren's recommendation [17:46:17] n/m I was wondering why it slowed down to a crawl, but that was my internet connection... [17:48:54] Heh [17:50:09] gi11es: It looks like getParsedConfig is used to access the config directly...not sure if it's worthwhile to add another access method or if I should just stick the munging at the end of getParsedConfig after the caching is done. [17:50:40] moving it to the end of the function works for me [17:51:07] maybe make it another function? something that's about interpreting/transforming the cached config [17:51:57] I guess, sure [17:53:28] marktraceurWMF : Thanks for letting me know about the MediaGoblin project. Do you think that this could be used to help people upload free content to Commons? Like, from Internet Archive or other sites? [17:53:33] This will be a fun rebase [17:53:43] tgr: checking if I'm following correctly. if the default is enabled by default, we store whether the person enabled it or not manually, with both states. if the default is that it's disabled by default, we only store when it's been enabled by the user? [17:53:45] fabriceflorin: IA isn't using GMG, but a few other sites are [17:53:58] I think the most notable is ViewSkew, not sure if they're still around [17:54:10] Guess not [17:54:24] fabriceflorin: https://gobblin.se/ is the biggest GMG site though [17:54:36] marktraceurWMF: Thanks. I found this list of live instances on their site: https://wiki.mediagoblin.org/Live_instances [17:54:56] gi11es: MediaWiki does not store preferences which are equal to the default state [17:55:17] tgr: so when you attempt to store "1" in the first if, it won't actually save it in db? [17:55:28] it will just delete the row? [17:55:29] if you change a setting to the same value as the default, it just deletes the row and from on default changes affect you [17:55:32] yes [17:55:36] alright, makes sense [17:55:49] (03PS2) 10Jforrester: WIP Add missing qqq messages, remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [17:55:52] (03PS3) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [17:55:54] the code is ugly and needs some help to really work that way when using the API [17:56:02] marktraceurWMF: Great. Let’s keep this in mind as we plan our next steps for improving our upload pipeline — it may have some applications for structured data as well. [17:56:13] (03CR) 10Jforrester: "PS2 is a rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [17:56:33] I see it as the first client for tgr's API, actually, if we play it right [17:56:33] (03CR) 10Jforrester: "PS3 is a rebase. Happy to sling other patches below this in the stack, of course." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 (owner: 10Jforrester) [17:57:00] And probably the impetus for implementing a similar API on the client side (which will make integrating it with UW basically like butter) [18:03:07] tgr: If I array_merge outside of that if statement and the second argument is null or undefined, won't I get fatals? [18:03:37] In https://gerrit.wikimedia.org/r/#/c/153818/1/includes/UploadWizardCampaign.php [18:04:30] Oh, wait. [18:04:40] Why don't I just merge the bloody autoAdd array into the parsedConfig [18:04:43] Durr [18:07:42] That's way shorter. [18:18:10] (03PS2) 10MarkTraceur: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) [18:18:32] (03CR) 10MarkTraceur: Add start/end and whileActive to the campaigns (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [18:24:43] (03PS3) 10MarkTraceur: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) [18:24:44] Rebased and made to work with the New Way. [18:33:25] marktraceurWMF: fabrice not here? O_O [18:33:32] 2014-08-26 - 11:26:18 -!- fabriceflorin [~fabricefl@198.73.209.3] has quit [Ping timeout: 250 seconds] [18:33:42] Steinsplitter: Everyone is shocked, by the way. [18:34:00] marktraceurWMF: sorry for my stiupd question. i haven't seen this. [18:34:05] It's okay :) [18:34:06] * Steinsplitter makes the chat window bigger [18:34:20] "There are no stupid questions, only stupid people." [18:34:21] Er... [18:34:52] :P [18:35:10] Steinsplitter: What do you need? [18:37:36] a *talk* with him :P [18:37:43] Ah. [18:40:24] marktraceurWMF: $activeModifiers doesn't contain what you expect it to. you're checking the keys for "display" for example, but it contains this: {"headerLabel":"Campaign is active"} [18:40:36] ...huh. [18:40:40] ah wait, maybe I didn't define the right keys [18:40:45] like I'm missing a level or something [18:40:46] Oh, probably not [18:40:47] Yeah [18:40:53] yes... [18:40:57] sorry about that [18:41:05] It let you save that? I thought the validation would come after you. [18:41:15] yeah it lets me save it, not caught by validation [18:41:20] Weird [18:41:39] yuvipanda: Shouldn't extraneous keys in the campaign definition get caught? [18:41:44] hmm? [18:41:48] http://pastebin.com/uMFEnstV [18:41:56] I think they might not, I might have tweaked config to let them be... [18:42:00] Ah. [18:42:07] Grmbl grmbl [18:42:10] (or not, don't remember) [18:42:11] Whatever, it'll be fine [18:43:52] we'll jus tneed to document the new options properly on https://www.mediawiki.org/wiki/Extension:UploadWizard/Campaigns [18:44:08] which contains some stale info already, I believe [18:44:41] like "just go to Special:Campaigns, choose a name for your campaign and fill the form." I've never seen the form when I tried [18:44:52] I ended up going to the Campaign namespace instead to create a new one [18:45:22] Huh [18:45:47] Special:Campaigns just lists campaigns now [18:46:15] yuvipanda: And the JSON config means we don't need any new tables, so I can remove that now, right? [18:47:48] Should be fixed. [18:47:56] I'll add the new stuff when it merges [18:50:07] marktraceurWMF: yeah, there are no forms... [18:50:20] what new stuff are you guys adding? [18:50:40] yuvipanda: Changes to the autoAdd/display arrays when the campaign is active [18:50:49] Also the concept of a campaign being active. [18:50:57] ah [18:50:59] nice [18:51:01] yuvipanda: start and end dates so that the banners/categories can change automatically right when the campaign starts and ends [18:51:19] yeah, I think there was a template based solution the last time [18:51:26] Yeah, there still is [18:51:28] * Romaine is a little bit ill at the moment [18:51:32] We're hoping to fix that in time :) [18:51:33] because the memcaching you've added lsat year was forcing Romaine and others to do a bunch of null edits at the right time for the banners [18:51:46] ah bah [18:51:47] right [18:56:33] tgr: any objection to +2ing the campaign stuff without the parameter? Romaine cares more about getting it working asap than having that simulation parameter [18:58:00] none, there is no reason for that to be in the same commit [18:58:13] Huzzah [18:58:31] I would include it in the mingle ticket, though [18:58:51] Romaine: Right, so we're apparently only giving you four days of planning for the whileActive stuff. :) [18:59:19] of course if the campaign people say they don't need it, they know it best [19:00:08] * Romaine says again, my head feels terrible, I am behind schedule, have no clear mind to judge on it [19:00:31] It's OK :) [19:00:35] marktraceurWMF: beta commons runs master for UW, right? [19:00:48] Uh, it should! [19:00:54] After about 6-12 minutes [19:01:03] cool [19:02:02] (03CR) 10Gilles: [C: 032] Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:07] (03CR) 10Gilles: [C: 032] Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:30] (03Merged) 10jenkins-bot: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [19:02:34] (03Merged) 10jenkins-bot: Add beforeActive and afterActive to campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155351 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [20:00:49] https://www.mediawiki.org/w/index.php?title=Extension%3AUploadWizard%2FCampaigns&diff=1121796&oldid=1121746 [20:00:51] ty gi11es [20:08:24] I think it should be on beta now. [23:10:28] wtf [23:10:39] The office is blacklisted at ur1.ca [23:11:30] tgr, gi11es http://bit.ly/1wz4xw1 [23:11:38] If you have some time.