[06:47:26] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c3 (10Andre Klapper) (In reply to Lupo from comment #1) > BTW, it'd be very nice if the MediaViewer would just generate the links back > to the file That i... [09:11:11] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c1 (10Tim Starling) Thanks for the report, Thiemo. It looks easy enough to fix if you don't mind losing the click tracking. If you wanted to keep the click track... [09:31:11] 3MediaWiki extensions / 3MultimediaViewer: Can not use browsers zoom to see image details - 10https://bugzilla.wikimedia.org/69473#c1 (10Tim Starling) Would a JS zoom button be an acceptable alternative, similar to Dschwen's ZoomViewer? 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c2 (10Thiemo Mättig) p:5Unprio>3High (In reply to Tim Starling from comment #1) > if you don't mind losing the click tracking. You can have the exact same c... [09:40:11] 3MediaWiki extensions / 3MultimediaViewer: Can not use browsers zoom to see image details - 10https://bugzilla.wikimedia.org/69473#c2 (10Thiemo Mättig) (In reply to Tim Starling from comment #1) > Would a JS zoom button be an acceptable alternative How? Sure, it's possible to hijack Ctrl+Plus and Ctrl+Mouse... [10:05:29] 3MediaWiki extensions / 3MultimediaViewer: Esc while in fullscreen also drops you out of MMV altogether - 10https://bugzilla.wikimedia.org/69527 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Rather similar to Bug 56059, which was at one point fixed. [11:52:41] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c4 (10Lupo) (In reply to Andre Klapper from comment #3) > That is covered in bug 62266 instead. I don't understand. Bug 62266 is about browser history, not... [12:41:11] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c3 (10Derk-Jan Hartman) We could click right click separately and then 'assume' that those would be the 'copy link' actions. Seems possible to me. I'm a fan of u... [12:54:58] 3MediaWiki extensions / 3MultimediaViewer: Metadata improvement campaign - 10https://bugzilla.wikimedia.org/69534 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None I've been thinking. Even now that we don't have reliable information just yet, we could probably make some sort of 'reliability' ass... [13:05:11] 3MediaWiki extensions / 3MultimediaViewer: Can not use browsers zoom to see image details - 10https://bugzilla.wikimedia.org/69473#c3 (10Tim Starling) I am not suggesting hijacking ctrl-plus or ctrl-mousewheel, I am suggesting making something like the popular ZoomViewer tool, which is linked from Commons de... [13:17:11] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c4 (10Tim Starling) (In reply to Thiemo Mättig from comment #2) > You can have the exact same click handler on an element. The href="..."> is for right... [13:21:57] 3MediaWiki extensions / 3MultimediaViewer: Icon to view original file should be a link so it can be middle-clicked - 10https://bugzilla.wikimedia.org/68203#c1 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69469 *** [13:21:57] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c5 (10Tisza Gergő) *** Bug 68203 has been marked as a duplicate of this bug. *** [13:28:12] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c5 (10Lupo) Does MediaViewer use the extmetadata API? If so, this bug should probably moved to the MediaWiki API component: https://commons.wikimedia.org/w... [13:46:11] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c6 (10Tisza Gergő) There is no difference in click tracking between an and a with a click handler. Either way you can choose to delay navigation (whic... [13:51:41] 3MediaWiki extensions / 3MultimediaViewer: Page scrolls to the top when using the browsers history - 10https://bugzilla.wikimedia.org/69467#c1 (10Tim Starling) Confirmed in FF 31. Setting breakpoints in Firebug in debug=true mode shows that if you click "forward" to close MMV and return to the article, MMVB.... [13:56:28] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c6 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 57458 *** [13:56:28] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c8 (10Tisza Gergő) *** Bug 69497 has been marked as a duplicate of this bug. *** [13:57:56] 3MediaWiki extensions / 3MultimediaViewer: Page scrolls to the top when using the browsers history - 10https://bugzilla.wikimedia.org/69467#c2 (10Tim Starling) That is to say, the stack trace was from step 4 of the similar sequence: 1. open MMV 2. close MMV by clicking the close button 3. back (to MMV) 4. f... [13:58:56] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c9 (10Lupo) As stated in bug 69497, these newlines are in the license template, and the code doing the HTML scraping there had better remove them. [14:01:13] 3MediaWiki extensions / 3MultimediaViewer: Link to file page instead of lightbox over file page in the HTML embed code - 10https://bugzilla.wikimedia.org/69539 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Per Lupo's comment in bug 69497 > BTW, it'd be very nice if the MediaViewer would just gener... [14:01:36] (03CR) 10Gergő Tisza: [C: 032] Remove misleading "now" from message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153788 (https://bugzilla.wikimedia.org/69282) (owner: 10Thiemo Mättig (WMDE)) [14:02:15] (03CR) 10jenkins-bot: [V: 04-1] Remove misleading "now" from message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153788 (https://bugzilla.wikimedia.org/69282) (owner: 10Thiemo Mättig (WMDE)) [14:05:04] 3MediaWiki extensions / 3MultimediaViewer: Link to file page instead of lightbox over file page in the HTML embed code - 10https://bugzilla.wikimedia.org/69539#c1 (10Lupo) - Nicer, shorter backlinks? - Less HTML to paste? (Which in turn helps keep the text wherever the user is inserting this more easily unde... [14:05:41] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c10 (10Tisza Gergő) The code to remove is in https://gerrit.wikimedia.org/r/#/c/120948/1/TemplateParser.php which at a glance seems correct to me. Also, Lokal_Profil... [14:17:44] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c7 (10Tim Starling) It would be possible to reconstruct the source URL on the client side, but please be careful of abbrvThreshold, which is used on WMF. The sou... [14:26:58] 3MediaWiki extensions / 3CommonsMetadata: licence templates on de.wikipedia are not recognized - 10https://bugzilla.wikimedia.org/69545 (10Jan Zerebecki) 3NEW p:3Unprio s:3major a:3None Licence templates on de.wikipedia are note recognized. Examples: {{Bild-CC-by-sa/3.0/de}} {{Bild-CC-by-sa/3.0}} {{B... [14:27:56] 3MediaWiki extensions / 3CommonsMetadata: licence templates on de.wikipedia are not recognized - 10https://bugzilla.wikimedia.org/69545#c1 (10Jan Zerebecki) https://de.wikipedia.org/wiki/Datei:2014_-_Olympic_Stadium_%28Athens%29.JPG#mediaviewer/Datei:2014_-_Olympic_Stadium_%28Athens%29.JPG [14:28:11] 3MediaWiki extensions / 3CommonsMetadata: HTML-based metadata (LicenseShortName etc) is missing on beta cluster for Beta Commons files - 10https://bugzilla.wikimedia.org/57248#c2 (10Tisza Gergő) 5ASSI>3RESO/WOR Beta-only issue, never figured out the exact reason but does not appear anymore. [14:34:26] 3MediaWiki extensions / 3MultimediaViewer: Esc while in fullscreen also drops you out of MMV altogether - 10https://bugzilla.wikimedia.org/69527#c1 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 62578 *** [14:34:27] 3MediaWiki extensions / 3MultimediaViewer: Lightbox closes when exiting fullscreen - 10https://bugzilla.wikimedia.org/62578#c6 (10Tisza Gergő) *** Bug 69527 has been marked as a duplicate of this bug. *** [14:36:41] 3MediaWiki extensions / 3MultimediaViewer: Lightbox closes when exiting fullscreen - 10https://bugzilla.wikimedia.org/62578#c7 (10Tisza Gergő) CC-ing Pau; any thoughts? There are a couple complaints about this on the project talk page as well. [14:41:41] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c11 (10Lupo) This code does _not_ look good. '/^\s+(.*)\s+$/' is wrong. It fails to trim if there are no leading blanks (or no trailing blanks). And watch out for th... [14:47:56] 3MediaWiki extensions / 3MultimediaViewer: Media viewer should ignore duplicate images in a sequence - 10https://bugzilla.wikimedia.org/67917#c2 (10Tisza Gergő) The main problem with this is that different instances of the image might have different captions. Is it OK to skip a caption? (In reply to Thiemo... [14:48:26] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c12 (10Lupo) (In reply to Tisza Gergő from comment #10) > Also, Lokal_Profil is right that the newline is > not always present in the HTML code. I'll test locally wi... [14:53:11] 3MediaWiki extensions / 3CommonsMetadata: licence templates on de.wikipedia are not recognized - 10https://bugzilla.wikimedia.org/69545#c2 (10Tisza Gergő) MediaViewer relies on [[commons:COM:MRD]]-style notation to parse license information and other metadata. [[mw:Multimedia/Media_Viewer/Template_compatibil... [14:55:42] 3MediaWiki extensions / 3MultimediaViewer: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496#c2 (10Tisza Gergő) MediaViewer relies on [[commons:COM:MRD]]-style notation to parse template metadata. [[mw:Multimedia/Media_Viewer/Template_compati... [15:11:41] 3MediaWiki extensions / 3MultimediaViewer: Use of SVG nominal size in MMV - 10https://bugzilla.wikimedia.org/69237#c3 (10Tisza Gergő) This would be trivial to fix (we had to add special handling just to ensure the nominal size is taken into account), but would that really be better? Icons look strange in gen... [15:16:11] 3MediaWiki extensions / 3MultimediaViewer: No indication that file shown is up for deletion and thus may actually not be free - 10https://bugzilla.wikimedia.org/69389#c1 (10Tisza Gergő) There is no machine-readable metadata which could be used to detect deletion etc. templates. Fabrice, can we commit to fixi... [15:16:41] 3MediaWiki extensions / 3MultimediaViewer: Misleading tooltip for "Disable/Enable Media Viewer" - 10https://bugzilla.wikimedia.org/69282#c2 (10Tisza Gergő) 5PATC>3RESO/FIX Fixed. Thanks for the patch, Thiemo! [15:21:11] 3MediaWiki extensions / 3MultimediaViewer: Misleading tooltip for "Disable/Enable Media Viewer" - 10https://bugzilla.wikimedia.org/69282#c3 (10Tisza Gergő) Well, partially fixed. I don't think this is worth spending a lot of time on as the final optout interface will likely look very different, somewhat alon... [15:24:11] 3MediaWiki extensions / 3MultimediaViewer: Use of SVG nominal size in MMV - 10https://bugzilla.wikimedia.org/69237#c4 (10Tim Starling) With a PNG icon, it will look pixellated when enlarged, which may well be better than having a small image on an enormous field of black. I would have thought an enlarged ico... [15:32:41] 3MediaWiki extensions / 3CommonsMetadata: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496 (10Jan Zerebecki) [15:33:28] 3MediaWiki extensions / 3CommonsMetadata: licence templates on de.wikipedia are not recognized - 10https://bugzilla.wikimedia.org/69545#c3 (10Jan Zerebecki) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69496 *** [15:33:28] 3MediaWiki extensions / 3CommonsMetadata: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496#c3 (10Jan Zerebecki) *** Bug 69545 has been marked as a duplicate of this bug. *** [15:43:11] 3MediaWiki extensions / 3MultimediaViewer: Media viewer should ignore duplicate images in a sequence - 10https://bugzilla.wikimedia.org/67917#c3 (10Thiemo Mättig) (In reply to Tisza Gergő from comment #2) > Is it OK to skip a caption? Sure, why not? The purpose of the Viewer is not to enlarge captions, righ... [15:54:24] (03PS1) 10Reedy: Remove extra intval() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154073 [15:58:11] 3MediaWiki extensions / 3MultimediaViewer: Link to file page instead of lightbox over file page in the HTML embed code - 10https://bugzilla.wikimedia.org/69539#c2 (10Tisza Gergő) (In reply to Lupo from comment #1) > - Less HTML to paste? (Which in turn helps keep the text wherever the user > is inserting thi... [16:02:21] (03CR) 10Gergő Tisza: [C: 032] "The test errors seem genuine, but cannot be possibly related to a message change... recheck." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153788 (https://bugzilla.wikimedia.org/69282) (owner: 10Thiemo Mättig (WMDE)) [16:03:00] (03CR) 10jenkins-bot: [V: 04-1] Remove misleading "now" from message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153788 (https://bugzilla.wikimedia.org/69282) (owner: 10Thiemo Mättig (WMDE)) [16:12:11] 3MediaWiki extensions / 3MultimediaViewer: Can not use browsers zoom to see image details - 10https://bugzilla.wikimedia.org/69473#c4 (10Thiemo Mättig) (In reply to Tim Starling from comment #3) > I am asking if you think this would be an acceptable alternative Having a tile-based viewer is an other request... [16:13:07] hi bawolff [16:13:13] hi [16:13:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=69453 [16:13:31] That looks familiar [16:13:37] TMH sucks [16:14:04] It ignores the mime type, so the ctype=text/x-srt probably doesn't matter [16:14:22] and the TimedText: pages are somewhat not even valid srt files [16:14:30] the other part definitely needs to be fixed [16:14:45] it's triggering the IE filter which causes a HTTP error to be thrown, meaning any non-closed transactions aren't finished [16:14:51] which ends up breaking CA :/ [16:14:56] "TMH sucks" is probably a good way to answer most questions about it. [16:17:11] hmm, the js generally should be calling the api with the parse action [16:18:45] oh, its sort of on foreign files [16:19:02] If anything is actually looking at the element, its probably broken... [16:19:16] there is no valid srt.. [16:19:48] look in the VLC media player parser, you will find a dozen exceptions, variatns etc :) [16:20:12] thedj: Ah, so maybe it works acceptably then [16:20:38] Still, but if any web browser actually looked at it, I bet there would be double subtitles with the javascript we use [16:21:19] so what's going to be the fastest way to get this fixed? can we just disable whatever is making the broken requests? [16:21:34] I'm looking into it now [16:22:09] :D [16:22:20] bawolff: prolly [16:23:42] pfft, it even works fine on instant commons, just not on ForeignDBRepos [16:28:11] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c2 (10Sam Reed (reedy)) p:5Unprio>3High There's actually quite a lot of these almost consistently... It's a shame we don't have stack traces (or in this case, a file... [16:43:33] And once again, I wonder how TMH works at all [16:54:07] Fatal error: Call to a member function getUrl() on a non-object in /var/www/w/git2/includes/Linker.php on line 916 [16:54:22] but i var_dump'd the variable in question, and it definitely has a getUrl() method [16:54:26] I hate TMH [16:55:38] oh, and i just can't read [17:35:19] * marktraceur begins to cautiously peer over the edge of UploadWizard. [17:35:52] * edge_of_uploadWi zard stares back at marktraceur [17:36:00] I've basically come to a cliff face where I either need to stop refactoring, backtrack, and find another way down [17:36:16] ...or I need to just go for it and write the 1k+ line patch [18:24:56] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer shows incomplete Permission field - 10https://bugzilla.wikimedia.org/69392#c1 (10Tisza Gergő) p:5Unprio>3Low Prioritizing down because the permission box will probably go away in the next iteration of Media Viewer. It's used way too inconsistent... [18:28:28] 3MediaWiki extensions / 3MultimediaViewer: when no license is known discourage reuse - 10https://bugzilla.wikimedia.org/69557 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3None When the MediaViewer has no license information discourage reuse in the "Use this file" popin by explaining that it needs mo... [18:35:59] 3MediaWiki extensions / 3MultimediaViewer: Respect repo zone URLs in thumbnail guessing - 10https://bugzilla.wikimedia.org/69558 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None MediaViewer can use an (imageurl, width) pair to generate an image URL with the correct width. When the input URL is a full... [18:37:26] 3MediaWiki extensions / 3MultimediaViewer: Respect repo zone URLs in thumbnail guessing - 10https://bugzilla.wikimedia.org/69558#c1 (10Tisza Gergő) p:5Unprio>3Low s:5normal>3minor Setting to low priority: this does not affect WMF servers, nor any server that uses MediaViewer with its default configur... [18:42:41] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c8 (10Tisza Gergő) The code to guess an image URL from another one is at https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources... [18:45:11] 3MediaWiki extensions / 3MultimediaViewer: Respect repo zone URLs in thumbnail guessing - 10https://bugzilla.wikimedia.org/69558#c2 (10Tisza Gergő) (In reply to Tisza Gergő from comment #1) > (specifically, with $wgUseThumbnailGuessing = false). That's $wgMediaViewerUseThumbnailGuessing of course. [18:47:56] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469#c9 (10Tisza Gergő) Proposal: * change the original file button to a proper link * change the original file button to only appear when the URL becomes available *... [18:50:26] 3MediaWiki extensions / 3MultimediaViewer: when no license is known discourage reuse - 10https://bugzilla.wikimedia.org/69557 (10Andre Klapper) s:5normal>3enhanc [18:50:41] 3MediaWiki extensions / 3MultimediaViewer: Metadata improvement campaign - 10https://bugzilla.wikimedia.org/69534#c1 (10Tisza Gergő) Currently the only thing we could easily check is whether there is an Information template present and whether there is a license template present. (And coordinates, but we can... [19:05:11] 3MediaWiki extensions / 3CommonsMetadata: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496#c4 (10Derk-Jan Hartman) Yeah it was one of my suggestions that there should be a planned campaign to stimulate the local communities to fix this befor... [19:21:56] 3MediaWiki extensions / 3CommonsMetadata: licence templates on de.wikipedia are not recognized - 10https://bugzilla.wikimedia.org/69545#c4 (10Jan Zerebecki) https://de.wikipedia.org/w/api.php?action=query&prop=imageinfo&iiprop=extmetadata&format=xml&titles=File:2014_-_Olympic_Stadium_%28Athens%29.JPG [19:35:35] I gotta say [19:35:49] Testing UW has gotten ten times easier since I added a cronjob to generate random images for me [19:39:07] (03PS2) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [19:39:13] (03PS2) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:40:17] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [19:40:20] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [19:40:27] Fuck you Jenkins [19:41:11] * marktraceur rebases all the patches [19:51:40] (03PS5) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [19:51:43] (03PS3) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:51:46] (03PS3) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [19:51:49] (03PS3) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [19:51:52] (03PS5) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [19:52:01] That was a weird order [19:53:12] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [19:53:45] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [20:03:28] (03PS4) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:03:50] (03PS4) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:04:17] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [20:05:45] (03PS5) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:26:28] 3MediaWiki extensions / 3MultimediaViewer: when no license is known discourage reuse - 10https://bugzilla.wikimedia.org/69557#c1 (10Tisza Gergő) CC Pau for design thoughts. Jan, do you have any specific phrasing in mind? [20:26:28] 3MediaWiki extensions / 3MultimediaViewer: Metadata improvement campaign - 10https://bugzilla.wikimedia.org/69534 (10Tisza Gergő) [20:41:56] 3MediaWiki extensions / 3TimedMediaHandler: TMH doesn't support ForeignDBViaLBRepo that don't render thumbnails via 404 handler - 10https://bugzilla.wikimedia.org/69570#c1 (10Bawolff (Brian Wolff)) Don't know why, but seems to have problems rendering thumbs of video files from a ForeignDBViaLBRepo when 'tran... [20:55:41] 3MediaWiki extensions / 3MultimediaViewer: Media viewer should ignore duplicate images in a sequence - 10https://bugzilla.wikimedia.org/67917#c4 (10Tisza Gergő) CC-ing Pau; this seems somewhat tricky for UX insights. What happens when someone directly clicks on the thumbnail which is left out from the sequen... [20:58:35] (03PS1) 10Brian Wolff: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) [20:59:31] \o/ [21:05:36] Huzah [21:06:56] 3MediaWiki extensions / 3TimedMediaHandler: TimedMediaHandler making bad action=raw requests - 10https://bugzilla.wikimedia.org/69453#c2 (10Bawolff (Brian Wolff)) (In reply to Gerrit Notification Bot from comment #1) > Change 154144 had a related patch set uploaded by Brian Wolff: > Fix horribly broken way T... [21:07:21] (03CR) 10MarkTraceur: [C: 031] "Looks fine, but I'm not totally comfortable merging it..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:08:14] * legoktm is fine merging anything that unbreaks this! [21:08:21] Go for it bro [21:08:55] is there an easy way to test this? [21:09:05] "easy" [21:12:45] (03CR) 10Legoktm: [C: 032] "Looks less broken" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:12:52] (03CR) 10Brian Wolff: "For reference, you could see an example of this bug at https://www.mediawiki.org/wiki/File:South_Africa_National_Anthem.ogg" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:14:19] lol it is makign requests using the Extension namespace [21:14:22] TMH is just soooo broken [21:14:33] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:14:54] why does it make a bajillion requests though? I see like 10 [21:15:13] bawolff: that should be a straightforward backport right? [21:15:30] legoktm: That's just the encoding fix, haven't fixed the namespace part yet [21:15:43] and yeah, it should be fine to backport [21:15:49] do you think you'll be able to do that before the SWAT today? [21:16:03] legoktm: I'm not sure what is actually making the requests, this is just outputting that url in html [21:17:26] (03PS1) 10Legoktm: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) [21:17:32] Guess browsers must have finally implemented element [21:17:43] (03PS1) 10Legoktm: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) [21:18:01] or maybe you just haven't upgraded in a while ;) [21:18:51] I haven't :P [21:19:52] hmm, browsers seem to support WebVTT, which is not what we do, so our subtitles probably don't work anyway [21:20:57] ok, added to todays swat [21:21:19] I don't think we need the namespace thing to un-fuck CA, but that would be nice too probably [21:21:27] ok [21:21:28] https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=123457&oldid=123452 [21:23:56] ah ok, swat is in an hour and a half [21:24:33] * bawolff re-adjusting his timezone spidy-senses [22:39:35] Ah crap. Just realized, a few hours into a refactor, that I'm trying to take the Upload creation code out of the wizard class, meaning it can no longer have a reference to the wizard [22:39:44] * marktraceur rolls up sleeves [22:41:09] Yer a wizard marktraceur. [22:41:41] that would work better if your name was Harry. [22:43:29] True [22:43:44] HarryTraceur doesn't sound as good though [22:44:43] Rrrrrgggggg why does an upload object need to know about the wizard's UI clas [22:44:43] also, [22:44:44] marktraceur: pronounce it more French. 'arryTraceur [22:44:50] you're still in the office right? [22:45:01] legoktm: Not this week, but next week and the week after yes [22:45:15] :|||||||||| [22:45:22] Wherefore? [22:45:25] So if I go into the office tomorrow, you won't be there :( [22:45:42] Well, unless you can convince me that driving home tonight is a good idea. Which actually might be possible. [22:46:14] It is a fantastic idea because I will be in the office tomorrow! [22:46:39] I...will consider it [22:51:21] OK, yeah, I'mma do that [22:51:30] :DDDD [22:51:34] where are you right now? [22:54:34] Tahoe [22:55:52] oh, maybe you shouldn't then :/ [22:56:22] legoktm: Eh, maybe, but I'm going to [22:57:42] Nothing happening here anyway [23:01:43] 3MediaWiki extensions / 3MultimediaViewer: Make the page visible in the background when the lightbox is open - 10https://bugzilla.wikimedia.org/69582 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None There have been several requests to make MediaViewer look like a popup which is on top of a page, inst... [23:02:11] 3MediaWiki extensions / 3MultimediaViewer: Make the page visible in the background when the lightbox is open - 10https://bugzilla.wikimedia.org/69582#c1 (10Tisza Gergő) Providing an uncluttered experience was one of the core goals of MediaViewer, so this is unlikely to happen unless someone can show convinci... [23:15:29] 3MediaWiki extensions / 3MultimediaViewer: Only show prev/next arrows in categories/galleries - 10https://bugzilla.wikimedia.org/69583 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Several people have requested removing the prev/next arrows (and the corresponding keyboard functionality) for thumbn... [23:20:59] 3MediaWiki extensions / 3MultimediaViewer: Only show prev/next arrows in categories/galleries - 10https://bugzilla.wikimedia.org/69583#c1 (10Tisza Gergő) I'm unsure about this one: the functionality does feel useless most of the time, but sometimes it is quite handy to compare similar or related images in an... [23:25:43] 3MediaWiki extensions / 3MultimediaViewer: Only show prev/next arrows in categories/galleries - 10https://bugzilla.wikimedia.org/69583#c2 (10Tisza Gergő) Prev/next gets used a lot; globally we have about 10M thumbnail clicks and 10M prev/next clicks a day: http://multimedia-metrics.wmflabs.org/dashboards/mmv... [23:26:27] 3MediaWiki extensions / 3MultimediaViewer: Only show prev/next arrows in categories/galleries - 10https://bugzilla.wikimedia.org/69583 (10Tisza Gergő) [23:26:28] 3MediaWiki extensions / 3MultimediaViewer: Make the page visible in the background when the lightbox is open - 10https://bugzilla.wikimedia.org/69582 (10Tisza Gergő) [23:33:11] 3MediaWiki extensions / 3MultimediaViewer: when no license and/or attribution is known discourage reuse - 10https://bugzilla.wikimedia.org/69557#c2 (10Jan Zerebecki) Replacing the content of the reuse popin with "Please investigate the license and/or attribution before reusing this image. The file page (add... [23:34:49] (03CR) 10Ori.livneh: [C: 032] Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:34:56] (03CR) 10Ori.livneh: [C: 032] Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:35:03] whee! [23:35:04] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:35:13] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:46:26] 3MediaWiki extensions / 3MultimediaViewer: when no license and/or attribution is known discourage reuse - 10https://bugzilla.wikimedia.org/69557 (10Tisza Gergő) [23:49:56] 3MediaWiki extensions / 3MultimediaViewer: Only show prev/next arrows in categories/galleries - 10https://bugzilla.wikimedia.org/69583#c3 (10Tisza Gergő) This was discussed e.g. here: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer/Archive02#Remove_the_arrows_and_view_of_other_images_in_the...