[00:06:45] marktraceur: since you're doing UW stuff, want to review https://gerrit.wikimedia.org/r/#/c/153040/ ? :) [01:32:55] 3MediaWiki extensions / 3TimedMediaHandler: TimedMediaHandler making bad action=raw requests - 10https://bugzilla.wikimedia.org/69453 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None In the CentralAuth bug 39996 debug logs we're seeing requests coming through with $_SERVER['REQUEST_URI'] set... [01:33:09] 3MediaWiki extensions / 3TimedMediaHandler: TimedMediaHandler making bad action=raw requests - 10https://bugzilla.wikimedia.org/69453 (10Kunal Mehta (Legoktm)) p:5Unprio>3Highes [07:10:53] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c1 (10Brion Vibber) Line is: $sourceAspect = intval( $sourceWidth ) / intval( $sourceHeight ); May indicate a bad file or failure to fetch metadata properly. [07:49:39] (03PS1) 10Lokal Profil: Make trim consider both parts of coordinate [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/153761 (https://bugzilla.wikimedia.org/65573) [07:51:24] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata: GPSLongitude prefixed by whitespace - 10https://bugzilla.wikimedia.org/65573 (10Lokal_Profil) a:3Lokal_Profil [07:54:38] 3MediaWiki / 3File management: Allow images in galleries to have their own borders - 10https://bugzilla.wikimedia.org/16457#c1 (10Andre Klapper) Hi denelson83! Sorry that nobody has taken a look at this report yet and given feedback. What would be the usecase for this request? [12:01:23] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c7 (10Lokal_Profil) Looking at the html source of the example above [1] there is no trace of these newline characters. Hence it might not be a cleaning/trimming issu... [13:19:25] 3MediaWiki extensions / 3MultimediaViewer: Page scrolls to the top when using the browsers history - 10https://bugzilla.wikimedia.org/69467 (10Thiemo Mättig) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Open a longer article, e.g. https://en.wikipedia.org/wiki/London 2. Click a section in... [13:32:26] 3MediaWiki extensions / 3MultimediaViewer: Link to original file is not a link and can not be used as such - 10https://bugzilla.wikimedia.org/69469 (10Thiemo Mättig) 3NEW p:3Unprio s:3major a:3None Steps to reproduce: 1. Open an image in the viewer. 2. Click the middle mouse button on "View original... [13:36:41] 3MediaWiki extensions / 3MultimediaViewer: Can not use browsers zoom to see image details - 10https://bugzilla.wikimedia.org/69473 (10Thiemo Mättig) 3NEW p:3Unprio s:3critic a:3None Steps to reproduce: 1. Open a large image in the viewer. 2. Try to zoom in (Ctrl+Plus or Ctrl+Mouse wheel). It looks l... [13:40:56] (03PS1) 10Thiemo Mättig (WMDE): Remove misleading "now" from message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153788 (https://bugzilla.wikimedia.org/69282) [13:48:23] 3MediaWiki extensions / 3MultimediaViewer: Media viewer should ignore duplicate images in a sequence - 10https://bugzilla.wikimedia.org/67917#c1 (10Thiemo Mättig) p:5Unprio>3Normal s:5enhanc>3normal I suggest to mark this as a bug, not a feature request. Main argument: It's not possible to go back to... [13:56:03] (03PS1) 10Thiemo Mättig (WMDE): Use spaces in Embed as Wikitext code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153791 (https://bugzilla.wikimedia.org/66250) [13:56:38] 3MediaWiki extensions / 3TimedMediaHandler: Use language code subpages for subtitles to allow Translate extension usage - 10https://bugzilla.wikimedia.org/42790#c15 (10Jean-Fred) (In reply to Nemo from comment #8) > (In reply to comment #7) > > (Heck, I’m so desperate about this that I considered today enabl... [14:14:14] (03CR) 10Se4598: [C: 031] "Looks good to me, but someone else must approve" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153791 (https://bugzilla.wikimedia.org/66250) (owner: 10Thiemo Mättig (WMDE)) [14:41:04] (03CR) 10MarkTraceur: [C: 032] "Thanks :) this looks fine to me." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153791 (https://bugzilla.wikimedia.org/66250) (owner: 10Thiemo Mättig (WMDE)) [14:41:43] (03Merged) 10jenkins-bot: Use spaces in Embed as Wikitext code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/153791 (https://bugzilla.wikimedia.org/66250) (owner: 10Thiemo Mättig (WMDE)) [14:42:23] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should replace underscores in embed file path - 10https://bugzilla.wikimedia.org/66250#c3 (10Mark Holmquist) 5PATC>3RESO/FIX Should be good now, thanks for the patch :) [14:56:20] Hm, not sure if I should trust Fabrice accepting the calendar invite. :3 [15:04:23] try an {{fr:agenda}} invitation [15:05:09] https://en.wiktionary.org/wiki/agenda#French [15:05:12] Cute. [15:05:25] hashar: Is the Swiss French any different? :P [15:05:53] swiss / belgium french are very similar [15:06:09] I guess it is the same difference between US west coast vs east coast or something [15:06:27] Quebec has much more differences :-) [15:06:36] the main differences are in idiomatics [15:06:53] Ah. [15:07:13] maybe relevant https://en.wikipedia.org/wiki/Swiss_French [15:07:15] hashar: The coasts in the US are basically washed of most accents now, so yeah [15:07:27] there is a few examples there [15:07:32] hashar: Video killed the accent star or something [15:07:42] like breakfast being "petit-déjeuner" in france but simply "déjeuner" in Swiss [15:07:53] (in France "déjeuner" is lunch, i.e. at noon [15:07:57] Tch, barbarians [15:08:17] > French of France [15:08:20] Awkward [15:08:38] hehe [15:08:52] Why are none of these examples ITALICIZED [15:08:54] * marktraceur rage [15:08:56] the regular french accent is the one from Paris [15:09:07] since we are heavily centralized, that is where most radios / TV broadcast from [15:09:16] there are slight regional variations [15:09:25] and of course some strong accents :-] [15:10:12] Right. [15:10:33] hashar: But not in Switzerland, apparently? Or do they not have the Parisian accent? [15:11:08] it sounds different [15:11:15] definitely not Parisian :) [15:11:18] same for Belgium [15:11:31] I am pretty sure there are accent variation among Swiss french speakers [15:12:35] Hm. [15:13:43] The fact that Swiss French needed a shorter term for "to break one's neck" is frightening. [15:13:44] learned that Swiss french descend from https://en.wikipedia.org/wiki/Franco-Provençal_language [15:14:50] | ''huitante'' || ''quatre-vingts'' || eighty [15:14:55] BLASPHEMY. [15:15:10] Don't tell me they say bloody neuvante too [15:15:16] nonante!? [15:15:20] This is insane [15:15:40] ah yeah [15:15:49] Swiss way to enumerate makes a LOT more sense [15:16:07] 60: soixante 70: septante 80: octante 90: nonante [15:16:37] versus in France: 60: soixante (same) 70: soixante-dix 80: quatre-vingt 90: quatre-vingt-dix (<---- should be refactored) [15:17:05] Someone left a TODO in the French language but then everyone got really busy [15:17:44] oh [15:17:52] there 80: might be 'huitante' [15:18:44] Yeah, it is [15:18:46] relevant https://fr.wikipedia.org/wiki/Huitante#Linguistique [15:18:55] https://en.wikipedia.org/wiki/Swiss_French#Examples_of_words_that_differ_between_Swiss_French_and_Standard_French muahaha all the italics [15:19:24] cornet || sac en plastique || plastic bag [15:19:31] in my area ,that would be "pochon" [15:19:34] similar to "poche" [15:19:47] (the part of the pant where you put your keys / money) [15:20:04] hashar: {{cn}} [15:20:11] Not that any part of the rest of the article is cited. [15:20:38] sac en plastique is used everywhere I believe [15:20:58] remember french became used only early in the 20th century [15:21:17] during 1st world war, some (lot?) soldiers did not even understand french [15:21:46] my grand-father was punished at school whenever he was speaking his native language [15:22:34] marktraceur: would you mind skipping today's meeting? It's just the two of us and I haven't gotten anything useful done today anyway [15:22:39] I'll just switch today for Saturday [15:22:46] slept until 2 PM... [15:22:55] tgr: Fabrice says he's coming, at least on Calendar [15:23:05] pginer too. [15:23:13] Not sure if that makes it worthwhile [15:24:15] it's not so much about being worthwhile, somone is organizing an Open Knowledge Hungary meetup, and no one from Wikipedia is present, so I want to go and see if anything useful comes out of it [15:24:24] and it starts in half an hour [15:24:45] I’m available for the meeting, but I’m ok if it is cancelled. [15:25:07] tgr: +1 [15:25:10] It would be great to have some help on the points I mentioned on email [15:25:17] pginer: I replied, will do [15:25:24] ok, that is great [15:25:27] thanks [15:31:27] pginer: I think it's currently set up for common.js, there's just no admins [15:31:51] I refer to the local user common.css/js [15:32:40] Oh [15:32:44] http://multimedia-alpha.wmflabs.org/wiki/User:Sometester/common.js [15:33:38] A global one could do the trick, but the user-based allow o have different versions of the site. You can ask a user to log-in with some credentials and they get a different experience [15:33:50] pginer: You should be good [15:34:19] It works! [15:34:33] Thank you marktraceur [15:34:36] Yup :) [15:36:49] * marktraceur looks around for other stuff to do. [15:39:39] marktraceur: Fabrice wrote a few days ago "I will be working for a few more hours today, then am off to Geneva to spend time with my family for a memorial service for my mother, who passed away a few months ago. After 5pm GMT+1 tonight, I will not check my work email at all until Friday at noon GMT+1." [15:39:50] Well, fair enough [15:39:54] tgr: Have a good time at the event! [15:39:59] thx [15:40:17] I'll be back online in a few hours if anything is needed [16:04:03] (03CR) 10MarkTraceur: [C: 032] "For the record, Ifcde9bcd0efcf15a3ab692dd2a0a3038559e0254 is the commit in core. I'm happy with this as is. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 (owner: 10Legoktm) [16:04:32] (03Merged) 10jenkins-bot: Convert Campaigns to extend JSONContent from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 (owner: 10Legoktm) [16:06:47] (03CR) 10MarkTraceur: "The matches that are left just construct and match classes of the form 'mwe-upwiz-status-', where is an error, or a warni" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur) [16:10:19] * marktraceur works on the WLM bug [16:15:06] YuviPanda: So the bug is to add start/end dates [16:15:29] I assume we should make the "enabled" property optional now, based on the new method for setting "enabled" [16:19:49] gi11es: Wait - https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/612 [16:20:02] Why would we want to add anything when the campaign isn't enabled? [16:20:14] Maybe I should ask Romaine [16:20:42] hi [16:20:58] Romaine: I'm working on that card for start/end dates in campaigns, and I'm wondering why you would need the headers or wikitext or fields to be available when the campaign is disabled [16:21:17] Basically I'm assuming that the start/end dates are just another method of enabling and disabling the campaign [16:21:26] if Wiki Loves Monuments/Earth is organized, a contest template is added during the time period the contest runs [16:21:57] outside that period, users can still use that upload campaign because it is linked to from various lists and automatically adds the right templates [16:22:37] enabling/disabling has an different purpose than with start/end dates [16:23:00] disabled = you cannot use this wizard [16:23:15] Right [16:23:23] OK, so that answers my question about enabled above [16:23:38] enabled during contest = you take part in contest (contest template added) + help templates added (like for IDs, etc) [16:23:56] enabled outside contest = you do not take part, but help templates are added [16:24:23] Romaine: It feels like we're adding another level of enabled. [16:24:31] Which strikes me as a weakness in the use case [16:24:50] But...whatever [16:24:55] I usually do not use disabled, unless it has malfunctions I need to fix later [16:25:56] for Wiki Loves Monuments we like to make it easier to upload and for the Wikipedians to track new uploads, and for bots to do supportive work [16:27:20] Yup [16:27:28] So I'm going to do this that way [16:27:35] It just strikes me as a really weird pattern :) [16:27:47] And we need...headers, plus wikitext. Right? [16:28:00] And categories. [16:28:51] So I'm pretty much putting autoAdd and display into a whileActive object that will replace or augment the existing objects (depending on type) [16:28:55] I don't know what you mean with "Wikitext" right now (I start tommorrow setting everything up), but headers and categories defenitely yes [16:29:28] * Romaine graps an campaign, moment [16:30:19] ah, in the autoadd section [16:30:54] Yeah [16:30:58] the problem we face lies mainly in the headerLabel section [16:31:08] So autoAdd and display are both getting added to the whileActive object [16:32:29] some teams prefer to add a "early" for before and "late" category afterwards when something is uploaded outside the timeframe of the contest to track those images [16:33:03] Hm. [16:33:19] Romaine: Should I add before/after support too? The schema already looks real big. :) [16:33:21] like https://commons.wikimedia.org/wiki/Campaign:wlm-fr [16:33:51] the only place where we really face an issue is in the headerLabel section [16:34:15] the wikitext section is substed [16:34:51] but if the start and end date is moved to the campaign page, it is probably easier to have it there, but to me not required [16:36:42] Yeah, I'm definitely moving it [17:03:10] (03PS1) 10MarkTraceur: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) [17:03:11] Romaine: ^^ :) [17:03:18] Worked like a charm for me locally [17:03:33] :) [17:04:29] should it be tested? changed? etc? [17:04:50] I mean, reviewed in general [17:05:03] If you wanted to test it that would be cool too [17:06:42] 3MediaWiki extensions / 3UploadWizard: Template used as campaign headerLabel is cached unwantedly - 10https://bugzilla.wikimedia.org/64685#c18 (10Mark Holmquist) I think this patch will just about do the trick. [17:09:24] 1. is the change already live, 2. is there a campaign ready yet? [17:26:16] Romaine: The change is nowhere near live, I just pushed it for code review [17:26:26] Romaine: I have a sample campaign I used for testing, sec [17:26:43] ok [17:26:56] Romaine: https://dpaste.de/jouK [17:39:58] is there in this format a place for the header that says the cointest isn't started and a place for the header that the contest is ended? [17:40:47] marktraceur: ^^ [17:44:03] Romaine: Not yet, no - that can be next maybe [17:44:13] beforeActive and afterActive maybe [17:44:20] yes [17:45:12] then we have a header template that shows the text in their own language saying it has not started yet or is ended + that uploads are not eligible in the contest [17:45:18] but still welcome [17:54:59] Romaine: Sure! [17:59:14] (the language is defined as many other templates and switches based on the preferences) [18:00:15] *nod* [18:00:52] I don't know if the wikitext values are always parsed...oh, they go into the page, so of course they are, never mind :) [18:01:35] :) [18:53:48] marktraceur: who is the best person to poke about https://bugzilla.wikimedia.org/show_bug.cgi?id=69453 ? [18:55:16] Maybe me! [18:55:21] I'll look at it a little later [18:56:13] ok, the logs are currently pointing at it being responsible for broken CA accounts so we need to get it fixed ASAP [19:01:09] Ahhh [19:01:16] * marktraceur looks at it a little now [19:18:14] legoktm: D you have some excerpts from those logs that I could see? [19:18:23] one sec [19:18:30] you have access to fluorine right? [19:18:30] I want to see the prior request that calls getTextTracksFromData if possible [19:18:34] Hm, yes [19:18:49] legoktm@fluorine:/a/mw-log/archive$ zgrep "Soedirmaan" centralauth-bug* [19:18:51] that's just one user [19:18:55] KK [19:19:45] we don't have any data except for what caused the account creation unless it's logged somewhere else [19:21:13] Hrm [19:21:25] Then that's probably not useful [19:29:39] // commons is called shared in production. normalize it to wikimediacommons [19:29:43] * marktraceur winces [19:31:00] legoktm: Did this just start happening recently, or did we just start noticing it recently? [19:31:20] we just started trying to figure out what has been causing it [19:31:44] it's been happening for years [19:32:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=39996 hm, was filed in 2012-09 [19:33:24] Hm [19:33:37] I ran a script a few weeks ago that un-broke around 20k accounts [19:34:34] it's likely that there have multiple culprits over the years the root cause is something not closing a transaction probably, but I think if we fix this TMH bug we can stop most of them (also it seems like a major problem in TMH too...?) [20:03:09] legoktm: This is weird, making manual API requests doesn't give me any issues [20:03:37] you don't see an error when going to https://commons.wikimedia.org/wiki/TimedText:South_Africa_National_Anthem.ogg.af.srt?action=raw&ctype=text/x-srt ? [20:04:07] No no [20:04:12] legoktm: http://commons.wikimedia.org/w/api.php?action=query&list=allpages&apnamespace=102&apprefix=South_Africa_National_Anthem.ogg&format=json [20:04:24] That's the API query that gets the title text [20:04:28] The rest of it seems perfectly fine [20:05:27] Oh, no [20:05:30] hm, so then how is it making the action=raw request? [20:05:35] It's probably getRepoPageUrl [20:09:36] I don't understand how this is supposed to work... [20:11:00] I definitely see how it gets screwed up though [20:30:15] But then, it seems like the error you're getting is not what I'm focusing on [20:36:04] the request is failing some IE check in WebRequest, and is causing a 403 / HttpError which is making mediawiki not cleanup properly [20:36:29] in MediaWiki::run [20:36:31] try { [20:36:31] $this->main(); [20:36:31] } catch ( ErrorPageError $e ) { [20:36:41] but HttpError's arent ErrorPageErrors [20:37:10] so what happens is [20:37:19] MWExceptionHandler::handle is called [20:37:32] which rolls back any changes [20:37:40] leaving the db in an inconsistent state [20:40:11] marktraceur: so if we can figure out why the request is triggering the IE security filter thing, it'll stop throwing errors and make whatever TMH feature actually work. [20:40:27] and as a byproduct, it won't break CA accounts (I hope!) [20:44:56] Yeah [20:55:39] * thedj reading tgr's suggestions on moving annotations into CommonsMetadata [21:00:37] hmmm, seems easy enough. should be a nice project for next weekend perhaps. [21:25:43] legoktm: Hm, I guess because includes/actions/RawAction.php doesn't pass a whitelist in [21:57:44] 3MediaWiki extensions / 3MultimediaViewer: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496 (10Lupo) 3NEW p:3Unprio s:3normal a:3None Reported at https://commons.wikimedia.org/w/index.php?title=Commons:Forum&oldid=131486934#Wieso_gib... [22:00:30] 3MediaWiki extensions / 3MultimediaViewer: Author and license extraction fails on the German Wikipedia for local files - 10https://bugzilla.wikimedia.org/69496#c1 (10Lupo) Just found the related bug 57248 (metadata missing in templates on beta cluster). So that's not a new or unknown issue. [22:02:07] marktraceur: should we add a hook for the whitelist? [22:02:28] I don't...think so... [22:02:28] But maybe [22:04:28] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497 (10Lupo) 3NEW p:3Unprio s:3normal a:3None https://commons.wikimedia.org/wiki/Template:Cc-by-sa-layout and possibly other license templates contain e... [22:06:56] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c1 (10Lupo) BTW, it'd be very nice if the MediaViewer would just generate the links back to the file as https://commons.wikimedia.org/wiki/File:Saint-Pierr... [22:18:41] 3MediaWiki extensions / 3MultimediaViewer: Embeddable HTML for file reuse is incorrect for files at the Commons - 10https://bugzilla.wikimedia.org/69497#c2 (10Lupo) P.S.: was originally reported at https://commons.wikimedia.org/w/index.php?title=Commons:Forum&oldid=131486934#Wieso_gibt_es_keinen_lizenzkonfor... [23:05:11] 3MediaWiki / 3File management: During media storage failure, MW will still move image pages despite not being able to move the file causing inconsistency - 10https://bugzilla.wikimedia.org/69312 (10Aaron Schulz)