[00:50:08] 3MediaWiki / 3Uploading: URL input should be enabled on click and option should be toggled to upload by url - 10https://bugzilla.wikimedia.org/68778 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Original bug title: URL input should be enabled on click and option should be togg... [00:51:23] 3MediaWiki / 3Uploading: URL input should be enabled on click and option should be toggled to upload by url - 10https://bugzilla.wikimedia.org/68778#c1 (10Rainer Rillke @commons.wikimedia) p:5Unprio>3Normal s:5normal>3enhanc This is a bit tricky to implement as disabled elements usually do not emit e... [01:25:26] (03CR) 10Neilk: "Is there a way to break out some of these changes into smaller changes? Removing UploadWizardUtil or moving its functionality around is a " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [01:40:08] 3MediaWiki / 3Uploading: URL input should be enabled on click and option should be toggled to upload by url - 10https://bugzilla.wikimedia.org/68778#c2 (10Tisza Gergő) Probably needs an invisible overlay to catch the click. [02:01:15] (03PS37) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:06:21] (03CR) 10Neilk: "There are a couple of things wrong here. If you add exactly one Flickr upload, there are *three* uploads in UploadWizardUploadList." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:52:02] (03PS38) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:54:44] (03CR) 10Neilk: "The details step was failing because the title from Flickr was never tested for validity. I'm not sure why it worked this way -- it could " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [04:49:06] 3MediaWiki extensions / 3TimedMediaHandler: TimedMediaHandler unit tests are failing with current mediawiki/core - 10https://bugzilla.wikimedia.org/61875 (10Kunal Mehta (Legoktm)) [11:41:09] 3MediaWiki / 3File management: Scaling of images should take place in a linear colour space - 10https://bugzilla.wikimedia.org/66337#c2 (10John Cupitt) Some benchmarks: $ time vipsthumbnail -a wtc.jpg --vips-leak memory: high-water mark 65.98 MB real 0m4.039s user 0m4.003s sys 0m0.038s $ time vips... [11:52:39] (03CR) 10Gilles: [C: 032] Move hide.*Buttons functions to UWI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150033 (owner: 10MarkTraceur) [11:53:08] (03Merged) 10jenkins-bot: Move hide.*Buttons functions to UWI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150033 (owner: 10MarkTraceur) [12:00:35] (03CR) 10Gilles: [C: 032] Degrade Special:OrphanedTimedText gracefully if !$wgEnableLocalTimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149788 (owner: 10Brian Wolff) [12:00:47] (03Merged) 10jenkins-bot: Degrade Special:OrphanedTimedText gracefully if !$wgEnableLocalTimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149788 (owner: 10Brian Wolff) [12:02:57] (03CR) 10Gilles: [C: 032] Feature detect OOJS compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150086 (owner: 10Gergő Tisza) [12:03:38] (03Merged) 10jenkins-bot: Feature detect OOJS compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150086 (owner: 10Gergő Tisza) [12:05:50] (03CR) 10Gilles: [C: 032] "Classic" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150039 (owner: 10MarkTraceur) [12:06:21] (03Merged) 10jenkins-bot: Remove $.notify [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150039 (owner: 10MarkTraceur) [12:42:50] (03CR) 10Gilles: "Neil, you need to configure your editor to use tabs for JS files, as per http://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScrip" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:49:33] (03PS39) 10Gilles: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:49:36] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:56:53] (03CR) 10Gilles: [C: 04-1] "Removing an ongoing flickr upload makes a mess:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:56:56] (03PS1) 10Rillke: Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 [12:58:09] (03CR) 10Gilles: [C: 032] Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 (owner: 10Rillke) [12:58:37] (03Merged) 10jenkins-bot: Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 (owner: 10Rillke) [12:59:41] (03CR) 10Rillke: "Loading the message is done in I7f55c50c6562fb1." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145420 (owner: 10Rillke) [14:39:31] marktraceur: any idea who filed https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/798 ? [14:40:50] I don't understand where this is supposed to be. we don't show the file name anywhere besides inside "use this file" [14:41:10] speaking of which, using latest master, "use this file" doesn't work locally for me... "TypeError: this.tabs[this.selectedTab] is undefined" [14:41:18] * gi11es heads to beta [14:42:14] of course beta is unusable [14:42:27] I have a feeling "Update OOjs UI to v0.1.0-pre (e9cf571db2)" is the culprit, let's check... [14:43:19] hmmm nope [14:55:23] (03PS1) 10Gilles: Add file extension to displayed title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 [14:56:07] (03CR) 10jenkins-bot: [V: 04-1] Add file extension to displayed title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [14:58:13] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [14:59:06] "use this file" only breaks in firefox for me, weird [15:01:43] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [15:33:58] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [15:35:17] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [15:36:39] Are you beating a dead horse over there, gi11es? [15:36:55] it finally worked, just gotta kick it enough times [15:36:57] gi11es: The history of that card says "Fabrice" [15:37:10] it's fine, I figured out what I was wondering about that card [15:37:15] Oh, 'kay [15:37:21] I haven't had time to investigate the firefox issue, though [15:37:26] can you check if it's happening for you? [15:37:28] >.< sure [15:37:32] On master? [15:37:34] master core and master media viewer [15:37:49] I just want to check that I'm not chasing a ghost there, because it works fine on chrome [15:37:54] KK [15:38:36] Works fine for me gi11es [15:38:41] weird [15:38:48] Clearing cache, sec. [15:39:10] Oh hm [15:39:14] That's a little funky [15:39:49] I saw a weird CSS issue, but it looks like it was a race condition. [15:41:31] hhvm just started taking a crap and serving truncated JS, rebooting vm... [15:42:46] still happens, looking into it... [15:43:14] oh... localStorage [15:43:39] I bet I have a tab saved in there that no longer exists/is called the same or something like that [15:44:31] mmv-lastUsedTab="html" [15:44:35] in my localStorage [15:44:53] not sure how that happened, but I don't see an "html" key in this.tabs [15:44:55] Huh. [15:45:12] Maybe we save the embed or attribution tab in localStorage? [15:46:27] it's something that piggybacks on OOUI's select event [15:47:01] So maybe it's bubbling [15:47:02] maybe it's getting an bubbling event from something it didn't use to, and can save that thing's name as the selected tab, when in fact it's not [15:47:11] * marktraceur hi5s gi11es [15:47:39] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807 (10Jonatan Svensson Glad (Josve05a)) [15:47:44] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807 (10Jonatan Svensson Glad (Josve05a)) 3UNCO p:3Unprio s:3normal a:3None Step 1. Ch... [15:47:49] we might be able to still blame this on the OOUI update ;) [15:48:07] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807#c1 (10Jonatan Svensson Glad (Josve05a)) And I can't read the web consol, so sorry! :( [15:49:23] James_F: does the above sound like something that could have recently changed? OOUI select events bubbling [15:49:31] James says there's no breaking changes. [15:49:38] But it seems like a simple thing to test [15:50:07] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807 (10Jonatan Svensson Glad (Josve05a)) [15:50:18] I can't reproduce it, though [15:50:25] i.e. make it save "html" in localStorage [15:50:40] could also have been that I made it happen when media viewer and core weren't master/master on my machine [15:51:01] Might have been an old bug, then. [15:51:04] Yeah. [15:51:17] I'm going to vote for that, if we see more issues down the line, we can worry about it then. [15:51:22] I'll make it recoup better when it runs into junk saved in that localStorage value [15:51:25] *nod* [15:56:39] (03PS1) 10Gilles: Make selected tab default when unknown value comes from localStorage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150241 [15:57:37] (03CR) 10jenkins-bot: [V: 04-1] Make selected tab default when unknown value comes from localStorage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150241 (owner: 10Gilles) [15:59:11] this is getting old, jenkins [15:59:22] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150241 (owner: 10Gilles) [16:59:05] Grrr [16:59:26] protip: mw.UploadWizardUpload.prototype = { // does not lend itself to inheritance [17:00:51] 3MediaWiki / 3File management: Have SvgHandler create a directory for its RSVG input files - 10https://bugzilla.wikimedia.org/67402 (10Aaron Schulz) 5PATC>3RESO/FIX [17:02:01] This patch is going to look really, really big...but I swear it's not [17:18:41] (03PS1) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:18:44] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:18:49] Ugh [17:20:06] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807#c2 (10Andre Klapper) Does the problem still happen if you start Firefox in Safe Mode? (Sa... [17:22:11] (03PS2) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:22:39] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:22:45] What. [17:23:26] (03PS3) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:23:53] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:24:44] (03PS4) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [18:04:38] Ohai YuviPanda. [18:04:53] marktraceur: ohai. [18:13:37] (03PS40) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [18:13:40] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [18:13:50] You breakin' my shit neilk_? [18:14:47] marktraceur: tabs vs spaces [18:14:51] Ah. [18:14:53] Shaaaaam. [18:14:54] e. [18:15:12] marktraceur: I configured my editor right, I just was using the same session to edit .pp files, which don't follow mediawiki conventions :( [18:15:36] Ah. [18:15:43] marktraceur: anyway I am going to continue to break your shit if this change isn't broken up [18:15:50] marktraceur: not a threat, more like an observation [18:15:51] Woohoo. [18:15:56] Yeah, it's fine. [18:16:04] Breaking things in UW is a long and time-honoured tradition. [18:16:18] marktraceur: I'm not sure I can tell the difference any more [18:16:19] Our ancestors would have an annual UW-breaking festival to celebrate a successful harvest. [18:16:45] In the middle ages, knights would have tournaments, competing for the worst UW breakage [18:16:50] marktraceur: after delving into this flickr code I officially declare that we need a total rewrite [18:16:56] Wuh oh. [18:17:03] neilk_: Of the whole thing or just the Flickr stuff? [18:17:51] (after the Industrial Revolution, brilliant minds had created steam-powered machines to break UW, and skilled workers learned new wonderful ways to break it, at breakneck speeds) [18:18:15] marktraceur: well, the Flickr stuff is sort of like a subclass, it has the outer form but every step is implemented slightly differently. UW makes many assumptions about concrete implementation. [18:18:17] (03CR) 10Gergő Tisza: [C: 04-1] "I think the Mingle ticket was ill-considered; I would prefer if we waited for Pau and discussed it again. The title can be large and cumbe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150223 (owner: 10Gilles) [18:18:31] Yeah. [18:18:41] marktraceur: so, either dropkick the flickr thing into another uploader, or rewrite from zero IMO [18:18:48] Ugh. [18:18:58] Not sure whether I like either of those options, but what choice do we have [18:19:03] marktraceur: or, or, go through a process of redesigning it so it's more abstract, and doesn't hold all its data in the DOM [18:19:09] I think moving the Flickr stuff out is probably better. [18:19:25] neilk_: I guess that's sort of what's happening anyway? [18:19:28] Slowly, but still. [18:20:08] there's a lack of overarching design here both in the code and the experience [18:20:40] Well yeah. [18:20:40] like, UW is somewhat mutable, but I see now it really should be more subclassable. [18:21:10] neilk_: Hm. Maybe I should just block out some time where I disappear into the woods and write a better uploader. [18:21:13] and all the reasons I've mentioned why there are some misdesigns in the code. [18:21:40] marktraceur: tbh I don't think it would be hard to write a 90%-case uploader. However, we don't seem to know what the 90% case is. [18:22:02] Because data are hard. [18:22:07] at wikimedia anyway [18:22:42] perhaps we could do a survey or just start a wiki page asking people. Anecdotal but better than nothing. [18:24:50] * marktraceur winces at "survey [18:24:50] " [18:32:26] 3MediaWiki extensions / 3TimedMediaHandler: Play button is over top of controls since z-index change - 10https://bugzilla.wikimedia.org/68479#c6 (10Bawolff (Brian Wolff)) So apparently all z-index issues can be solved by just not messing with z-index in the first place (z-index: auto). [18:32:47] marktraceur: I've broken UW only once, no? [18:32:53] marktraceur: and that too not for long [18:33:07] Only once? [18:33:13] That's a problem. Let's increment that number. [18:33:24] YuviPanda: But that sounds right to me, yeah. [18:33:33] marktraceur: :P I rewrote one big component and broke it only once, need to repent! [18:34:13] hey, everyone, I am having difficulty dealing with multiple patches per change. [18:34:33] I've googled the ways to see what the last patch changed, but they are still very difficult to deal with [18:34:42] is there some easy thing everyone else is doing? [18:35:02] neilk_: in gerrit, when looking at a diff, you can select the 'base' to compare against in the top left [18:35:18] neilk_: by default it is set to 'base', which is 'previous merged patch', but you can change it to a particular patchset [18:35:58] YuviPanda: right, I did that. But, in massive changes like c68835 that still gives me an interface where I'm "paging" through all the changes, some of which have been merged in like translation stuff. [18:36:21] neilk_: Roughly, people should never make changes during a rebase, so you just shouldn't look at rebases. [18:36:22] neilk_: hm, give me a link to it? I can check [18:36:22] YuviPanda: so I'm marching through 20 unchanged files to get to the 3 that were changed [18:36:32] yeah, + what marktraceur said [18:36:34] In practice people are sometimes dumb. [18:36:40] But with me you can generally trust it [18:36:44] YuviPanda: https://gerrit.wikimedia.org/r/#/c/68835/ [18:37:14] neilk_: that's the standard gerrit experience, you'll get used to it :/ [18:37:21] marktraceur: I don't understand what you mean - some patches require a rebase, like the ones that we are dealing with now in UW. [18:37:26] All hail phabricator [18:37:38] or you can do a diff in your console instead [18:38:05] neilk_: I mean, rebase patchsets. If the only thing that changed in PS39 is that we rebased the patch, then don't review that patchset, just look at the difference between PS39 and PS40. [18:38:14] tgr: I tried the git review diff stuff, it was still hard to understand. [18:38:39] neilk_: I never tried that, but you can just do a regular diff [18:38:56] marktraceur: oooohkay so your point is that we should never mix rebasing stuff from master, and new stuff, in the same patch? [18:39:03] you can see the commit hashes next to the patch section headers in gerrit [18:39:15] Yeah neilk_. [18:40:06] neilk_: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change "It's best to make rebase updates a separate patch, so that your code reviewers have an easy time seeing what changes you've made." [18:40:11] tgr: so I'm supposed to do git diff .. by copying and pasting? That seems... suboptimal [18:40:42] (03CR) 10Eloquence: "Can we line this up for deployment to all wikis this week? We shouldn't wait for the train to fix older browser breakage. Thanks :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150086 (owner: 10Gergő Tisza) [18:41:07] I have another dumb question - when I submit a new patchset, it's supposed to be without comment? [18:41:23] I seem to remember modifying the commit message the first time I tried this but I don't see anyone else doing that [18:41:54] neilk_: We have a rough policy against using the commit message to talk about patchset changes; you can submit a comment in the web UI if you want to talk about what changed [18:41:57] that is, when I amend, I seem to have no opportunity to explain what I did, other than making another comment in the web UI. [18:42:04] Yeah that's about right. [18:43:13] neilk_: Welcome to gerrit [18:43:14] ok well this works for small changes with a few corrective patches but not for big ones. [18:43:36] True [18:43:53] After a couple months you'll have Stockholm syndrome, and you'll learn to love gerrit design choices [18:44:49] bawolff: it may be setting in early... I found the whole amending paradigm to be weird, but it is growing on me. [18:44:50] neilk_: For viewing diffs between patch sets, generally I use the gerrit ui to do that. There's a button [18:45:13] bawolff: yeah I know, but it's not great for a particularly massive changeset we have [18:45:25] yeah, it shouldn't have been that massive [18:45:31] should've been a bunch of dependent patches [18:45:35] i think the conclusion here is not to have massive changesets [18:45:40] YuviPanda: I couldn't see a good way to do that, sadly [18:45:48] I wish there was a way I could to tell git-review to automatically add a comment on the patchset as a message for what I changed [18:45:52] Too much spaghetti everywhere [18:45:54] marktraceur: I was thinking about that [18:45:59] marktraceur: dependent patches man. but yeah. [18:46:19] marktraceur: the big campaigns patch was like PS65 or something, but that was only because I was using GitHub [18:46:25] Right. [18:46:30] marktraceur: if we allowed branching-in-code it could have been easier. i.e. you create a lot of parallel scaffolding that doesn't do anything. [18:46:38] marktraceur: and then slowly starts taking over. [18:46:41] Hah, I remember that. SuchABot. [18:47:00] marktraceur: but I do sympathize this was not a simple change [18:47:02] marktraceur: indeed, need to bring it back. [18:47:09] YuviPanda: Pretty sure not [18:47:20] marktraceur: that said I still think you're conflating code cleanups (like abolishing the Util class) and conceptual changes [18:47:28] Probably [18:47:35] neilk_: The Util thing got merged, though, didn't it? [18:47:35] marktraceur: at least 4 people have asked for it [18:47:37] marktraceur: sorry if that's harsh [18:47:50] https://gerrit.wikimedia.org/r/146140 [18:47:51] marktraceur: you're cleaning up mistakes I made, mostly :( [18:48:00] It's fine [18:48:11] YuviPanda: That's that "network effect" thing I've been hearing about [18:48:24] marktraceur: heh :D [18:48:44] neilk_: UWUtil got deleted in a different patch, so... [18:49:23] marktraceur: ok clearly I'm confused then. [18:49:37] Maybe so:) [18:49:55] neilk_: You might have looked at the patchset where we rebased onto the UWUtil class, and it stuck in your head [18:50:14] marktraceur: I think that's what happened [18:50:27] I kept wondering what you were on about :) [18:50:27] well, that's another thing. The patches that are just rebases aren't marked as such [18:50:35] Yeah, I'm usually better about that [18:50:51] it's no one's fault, the tool is imperfect at best here. [18:51:11] don't worry, we'll new to a Newer Glorious Tool Soon [18:51:30] "imperfect at best" is a Dashboard Confessional song, right [18:51:39] Anyway. [18:52:02] marktraceur: see, this is why you need SuchABot [18:52:03] neilk_: I can revisit it if you'd like and try to split it up, but apart from the Flickr bugs I don't know if it needs to be split up [18:52:06] marktraceur: so instead of amending you'd just push a commit :) [18:52:40] YuviPanda: I don't see any reason to care about the difference :P [18:52:51] * marktraceur is going to go get noms quickly, don't y'all go nowhere [18:52:55] marktraceur: :P [18:55:08] <_neilk_> I promise I'll get really good at Gerrit just before we switch to something else [19:37:30] gi11es: Is the "% of opted out in..." graph actually in percent, or is out of 1? Because damn, 1% and change for very active users is super great. [19:38:13] actual percents, as far as I remember [19:38:47] Wow cool. [19:39:08] At first I was like "Wait, 120% doesn't make any sense", but then realized what was happening. :) [19:39:40] 3MediaWiki extensions / 3OggHandler: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Florian) [19:39:42] 10-11% on enwiki, though [19:39:46] http://multimedia-metrics.wmflabs.org/dashboards/mmv_enwiki#opt_in_opt_out-graphs-tab [19:39:52] 3MediaWiki extensions / 3OggHandler: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Florian) [19:39:59] I believe it. [19:40:21] Whiny crybabies. :P [19:40:25] and 18% in dewiki [19:40:35] wtf, why should OggHandler pass jshint [19:40:37] and... 25% on commons [19:40:40] Wowwww [19:40:53] bawolff: EVERYTHING should pass jshint!!! [19:41:08] marktraceur: Extensions that haven't been used since 2008 :P [19:41:10] * marktraceur runs jshint on the linux kernel [20:13:42] (03PS1) 10Gergő Tisza: Feature detect OOJS compatibility [extensions/MultimediaViewer] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150374 [20:14:23] (03CR) 10Gergő Tisza: [C: 032] Feature detect OOJS compatibility [extensions/MultimediaViewer] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150374 (owner: 10Gergő Tisza) [20:15:06] (03CR) 10jenkins-bot: [V: 04-1] Feature detect OOJS compatibility [extensions/MultimediaViewer] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150374 (owner: 10Gergő Tisza) [20:15:57] (03CR) 10Gergő Tisza: [C: 032] "recheck" [extensions/MultimediaViewer] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150374 (owner: 10Gergő Tisza) [20:16:37] (03Merged) 10jenkins-bot: Feature detect OOJS compatibility [extensions/MultimediaViewer] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150374 (owner: 10Gergő Tisza) [20:35:34] idle question: what privileges does it take to delete a file on Commons? I guessed at "importer" and "file mover" but I seem to be wrong. [20:36:52] 'admin' :P [20:37:13] chrismcmahon: You could just request it? [20:37:19] Why are you deleting the file? [20:38:04] in general, you can check such things at https://commons.wikimedia.org/wiki/Special:ListGroupRights [20:38:06] marktraceur: actually beta commons, our GSoC person is uploading VE screenshots in different languages [20:38:18] Uh...huh [20:38:29] chrismcmahon: Yeah, probably just admin [20:38:37] You should probably have admin on beta anyway :) [20:39:09] marktraceur: yes, I have superpowers on beta, but I want to keep the GSoC powers to minimum [20:40:45] admin is actually a pretty low levels of power, especially on a beta wiki [20:41:44] 's like 5 watts. Maybe 10. [20:41:47] thanks, Vikas the GSoC guy now has admin on beta labs, but I'm holding off on giving the bot that power I think. [20:42:06] You could just give him admin on betacommons? [20:42:43] marktraceur: that makes sense. But first to solve the immediate problem, we need some files deleted... [20:44:33] chrismcmahon: Just for comparison sake, on testwiki, which is arguably more of a real wiki than beta wiki, admin rights are handed out like candy to anyone who is a "developer" very loosely defined [20:45:20] bawolff: thanks, noted [20:56:36] 3MediaWiki / 3File management: Have SvgHandler create a directory for its RSVG input files - 10https://bugzilla.wikimedia.org/67402 (10Aaron Schulz) 5PATC>3RESO/FIX [21:45:50] (03CR) 10Neilk: "I can't figure out this rebase. According to Gerrit docs I'm supposed to rebase from master, but I think some recent changes are incompati" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [21:48:57] neilk_: Heh, you're not *in* a branch :) [21:49:14] The first test Jenkins runs is "can this be merged with master?" [21:49:44] marktraceur: ok but why was that fine before, and not so now? The sections it complains about are where you modified makeTransitioner. [21:49:57] or rather that's what's left after a rebase [21:50:09] but, whatever the rebase did, made UW not work (no continue button) [21:50:23] Were there merge conflicts? [21:50:38] only in mw.UploadWizard.js and only in the promise / makeTransitioner section. [21:51:16] I'm assuming the rebase is somehow not smart enough. In any case I'm already spending a lot of time on c68835 [21:51:32] You could maybe move on and I can rebase it? [21:51:35] yeah [21:52:04] rebasing can break things without any conflict [21:52:28] say you rename function A to function B and someone adds a call to A to a new place [21:52:45] there is no way for got to detect those two changes are incompatible [21:52:54] tgr: I assume this is what is happening (particularly since the buttons were moved in master, & now they are missing in the change) [21:55:34] (03CR) 10Gergő Tisza: [C: 032] Make selected tab default when unknown value comes from localStorage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150241 (owner: 10Gilles) [21:56:15] (03Merged) 10jenkins-bot: Make selected tab default when unknown value comes from localStorage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150241 (owner: 10Gilles) [22:14:10] ok, I guess I'm getting all my stupid questions in today, but about UploadWizard tests - one of the things RobLa and Erik said I'd be doing was to flesh out browser and unit tests, making them more like MMV's. I'm looking now and they're already pretty good. Are there spots where you feel coverage is missing? [22:14:26] re: tests for UW ^^ [22:15:32] UW has unit tests? [22:15:52] Ehhh sort of. [22:16:05] UW has unit tests? [22:16:10] neilk_: We have what, 2-3 files in tests/qunit? [22:16:16] marktraceur: 5 [22:16:20] Wow. [22:16:27] But there are at least 20 files in resources/ [22:16:28] marktraceur: ok so the issue is to have more unit tests [22:16:31] Not counting subdirs [22:16:44] And most of the existing tests don't cover even close to a whole class [22:16:50] Just a few methods. [22:16:59] So yeah, coverage is what we're after mostly :) [22:17:39] marktraceur: understood. Okay I'll try to go deeper [22:17:56] I changed a few things half a year ago and added tests for what I changed specifically [22:18:14] that's near-zero coverage, even for the files which are there [22:18:42] I was more surprised that there were decent scenario tests. Not sure how testable UploadWizard is with qunit, but I'll see what can be done. [22:18:50] like, mw.UploadWizard.test.js consists of running "new UploadWizard()" and checking whether we get an object [22:18:56] tgr: yeah, I saw [23:00:09] (03CR) 10Rillke: "You are pushing to master:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:01:29] (03CR) 10Neilk: "Thanks Rillke. They also straightened me out on IRC." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:02:37] ooops should have had a look here [23:02:55] :) [23:28:45] neilk_: re: browser tests, I can surely help flesh those out if needed, but history says that UW rarely fails in the UI, it fails uploading weird kinds of files and stuff. [23:29:15] chrismcmahon: I think I've got a handle on it. I did see you wrote a lot of these [23:29:35] chrismcmahon: I'm making a list now of what behavior is even testable :) [23:29:45] neilk_: we've had good scenario tests for UW for two years. UW was our first serious proof-of-concept that we could actually provide valuable UI automation [23:30:49] chrismcmahon: we're doing more refactoring so some more UI tests are probably in order [23:31:14] chrismcmahon: that said we're probably also swapping out components that are just plain better, like a category picker, so... :/ [23:31:42] neilk_: sounds good, I'll be watching master branch. are y'all using vagrant for a dev env? [23:32:14] chrismcmahon: I am [23:33:29] chrismcmahon: does that matter? [23:33:30] neilk_: you should speak to Dan Duvall (marxarelli on IRC), he is hacking all our vagrant roles to support browser tests easily, and UW would be righteous. He did VisualEditor already and is working on MobileFrontend, and UW should be better than it is. [23:33:52] chrismcmahon: oh, excellent. I was just trying to figure out if one should run these in vagrant or not. I assumed not. [23:34:17] neilk_: one should, but one probably would have a hard time right now. please give Dan more work, he's new :-) [23:36:34] chrismcmahon: ok offhand, if I have a component like a jquery extension that modifies DOM, is that unit testable? I assume not since fragments don't have proper dimensions or visibility or such things. [23:38:21] 3MediaWiki extensions / 3UploadWizard: Unexpected freezing of browser after hightlighting from the description field and/or pulling scroll on the bottom right to extend the field - 10https://bugzilla.wikimedia.org/68807#c3 (10Jonatan Svensson Glad (Josve05a)) In safe mode: When the desciption was "short", it... [23:38:40] neilk_: I don't think we have any tools in regular use that could do that. I have a bias thinking that such an operation might have different effects in different browsers, too, so a UI test would be appropriate. [23:46:52] chrismcmahon: truth [23:53:10] neilk_: usually, you use qunit, apply the changes to #qunit-fixture and verify [23:53:17] MMV has lots of examples [23:53:56] tgr: Ok. I was looking at MMV for examples but I missed that [23:54:21] just make sure not to modify #qunit-fixture itself, qunit does not clean that up [23:54:37] the thing is, is qunit fixture itself offscreen or something? [23:54:54] if I'm testing something that manages visibility, dimensions, etc, that might not work [23:55:11] tgr: well I'll figure it out, nm [23:55:42] it's just some element at the bottom of the page [23:55:58] but I am pretty sure offscreen elements get dimensions as well [23:56:33] tgr: in sane browsers, yes :) [23:57:16] I recall gi11es mentioning he had troubles using the :visible filter in tests, but I don't remember the details [23:57:35] but core tests do that a lot, seems to work reliably enough