[00:08:24] (03CR) 10Gergő Tisza: Track loading time for MediaViewer and the file page (031 comment) [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148021 (owner: 10Gergő Tisza) [00:44:26] (03PS1) 10Gergő Tisza: More duration time clarification text [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/149204 [00:44:45] (03CR) 10Gergő Tisza: [C: 032 V: 032] "Self-merge more text changes." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/149204 (owner: 10Gergő Tisza) [00:49:50] marktraceur: is there a services team mailing list? [01:16:46] (03CR) 10MaxSem: [C: 032] Fix use of undefined const NS_TIMEDTEXT [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149046 (owner: 10Ori.livneh) [01:16:57] (03Merged) 10jenkins-bot: Fix use of undefined const NS_TIMEDTEXT [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149046 (owner: 10Ori.livneh) [01:45:16] (03PS1) 10Gergő Tisza: Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 [01:45:47] Eloquence: ^^ [08:48:14] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c2 (10dan) is this the mediawiki template you’re mapping to? http://commons.wikimedia.beta.wmflabs.org/wiki/Template:MH_IDF-Ingestion [09:12:42] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c3 (10Jean-Fred) (In reply to dan from comment #2) > is this the mediawiki template you’re mapping to? > http://commons.wikimedia.beta.wmflabs.org/wiki/Template:MH_IDF-Ingestion... [10:34:57] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506#c1 (10Nemo) p:5Unprio>3High s:5normal>3major Liam said: > Well that's particularly unfortunate timing as I understand that the GWT is > going to be a feature item in the n... [10:35:51] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285 (10Nemo) [10:35:51] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506 (10Nemo) [11:03:42] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c4 (10dan) local test ---------- * created a subset of the attached XML file containing the first 6 records * imported and used this mapping: http://commons.wikimedia.beta.wmflab... [12:08:13] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c5 (10Fæ) This might be a slight tangent, but chipping in my category experience... I have been adding multiple categories to several batch upload projects now by flexibly addin... [14:18:41] (03CR) 10Gilles: Track loading time for MediaViewer and the file page (031 comment) [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/148021 (owner: 10Gergő Tisza) [14:23:19] (03PS1) 10Gilles: Switch back to domComplete [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/149314 [14:23:32] (03CR) 10Gilles: [C: 032 V: 032] Switch back to domComplete [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/149314 (owner: 10Gilles) [14:24:47] Argh why aren't we using the fucking team list [14:24:51] * marktraceur rages [14:26:17] I guess more people than the team are involved in that discussion [14:26:53] they could be on that ML for the duration of their involvement, though [14:27:24] or the people could be added on top of the list [14:27:52] anyway, I haven't started such a private email thread myself in eons. I pretty much always write to the public ML [14:28:50] marktraceur: have you watched some of the user tests? I saw that you were in the google doc earlier when I was [14:33:00] any of u guys know why my firefox browser won't load pages after i upgraded to firefox 32beta? [14:34:38] no idea, I don't use beta browsers [14:34:45] it's hard enough supporting various stable ones [14:35:21] sounds like a bug report for firefox beta [14:36:32] especially if it's on a mediawiki-hosted wiki, they'd pay attention to their beta version breaking high-traffic sites [14:39:14] suddenly with domComplete, the new versus graph tells a totally different story... http://multimedia-metrics.wmflabs.org/dashboards/mmv_enwiki#media_viewer_vs_file_page-graphs-tab [14:40:18] we just have to confirm that the slowdown on loggedout file page views is due to those file pages being slow non-image ones [14:57:52] gi11es: I watched one [14:59:08] gi11es, the image file name for firefox.exe is redirecting to "C:\Program Files\Mozilla Firefox 4.0 Beta 9\updated\firefox.exe" which doesn;'t exist [14:59:25] comets: Bro, this is not a firefox support channel. [14:59:37] do u know how to make it redirect to the real location? (C:\Program Files\Mozilla Firefox 4.0 Beta 9\firefox.exe) [14:59:57] sorry marktraceur tried their channel and server, the dummies don't know :( [15:00:14] Maybe you should install a not-beta version. [15:00:22] Also, Firefox 4 has been out of beta for years. [15:02:19] nah its jsut hte folder it gets "auto-updated" too... its FF32beta [15:03:19] Yeah, well [15:03:27] Still not a Firefox support channel [15:04:23] sorry, figured i ask the nerds i know....not the nerds who don't know.. [15:04:55] comets: You said irc.mozilla.org was unhelpful? [15:04:58] And you filed a bug? [15:05:32] nah no bugs, the las t bug i filed got no response in 5 years.. [15:06:00] That's not a good reason to stop filing bugs, it's a reason to file more :) [15:07:49] :P the false redirection means i can't load pages in my firefox, ..i'm browserless now :( [15:47:29] 3MediaWiki extensions / 3GWToolset: GWToolset should not fail in case of duplicated file - 10https://bugzilla.wikimedia.org/68577 (10Jean-Fred) 3NEW p:3Unprio s:3normal a:3None According to bug 68285, “if there are duplicates, GWToolset would unfortunately fail silently at the moment.” What would fa... [15:47:43] 3MediaWiki extensions / 3GWToolset: GWToolset should not fail in case of duplicated file - 10https://bugzilla.wikimedia.org/68577 (10Jean-Fred) p:5Unprio>3High [16:06:12] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c6 (10Jean-Fred) (In reply to dan from comment #4) > when i first ran the upload i ran into a duplicate file issue. this error is > only visible in the runJobs log or in my case,... [16:08:58] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c7 (10Jean-Fred) (In reply to Fæ from comment #5) > This might be a slight tangent, but chipping in my category experience... > > I have been adding multiple categories to sever... [16:31:25] gi11es: You're still waiting on Fae to get some images to test GWT with, right? [16:32:02] I'm not sure. Is that what we're waiting for, tgr? [16:32:37] Oh, wrong team member -.- sorry [16:32:52] gi11es: yes, no one wants to mass-upload TIFF images at the moment [16:32:56] OK. [16:33:03] It sounds like we might get our wish [16:33:07] https://commons.wikimedia.org/wiki/Commons:Village_pump#Funding_for_expenses_needed.2C_estimated_.2430_for_100.2C000_high_quality_files_to_be_released_on_Commons [16:33:55] Oh, wait, that's...I skimmed it. [16:34:09] We'd be directly putting them on our hard drives, I see now [16:34:38] also, we are in no hurry - waiting means more improvements out there (such as ops increasing Swift bandwidth) which makes it less likely we need to test again [16:34:57] K. [16:35:45] files being uploaded by some other means than GWToolset is not necessarily the problem, the outage was likely not related to GWToolset at all [16:36:19] Ah. [16:36:25] but if they are e.g. PNG images, that doesn't really create similar circumstances [16:36:25] It was special:newfiles [16:37:39] gi11es: I am doing random tests in my browser, and seems like you were right about images generally loading at/before domInteractive [16:37:52] although depends a lot on the image size [16:38:20] I think on slow bandwidth domInteractive would happen a lot sooner [16:38:25] have you tried constraining your bandwidth? [16:38:49] PNGs with the right dimensions can be pretty large; enwiki OTOH has a lot of very small fair use images and those load much sooner than domInteractive even [16:38:56] no, I haven't tried that [16:39:37] I'll set up proper measurements over the weekend, with ResourceTiming it should be simple [16:39:52] measuring the image directly you mean> [16:39:53] ? [16:40:00] yes [16:40:13] although there is no way to measure the change around deployment and that's the interesting part [16:47:41] (03CR) 10Gilles: [C: 032] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:48:24] (03CR) 10jenkins-bot: [V: 04-1] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:48:45] tgr: marktraceur: not sure which one of you filed https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/809 I left some comments there, I can't reproduce it [16:49:39] (03CR) 10Gilles: [V: 032] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:49:52] (03CR) 10Gilles: [C: 032] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:50:10] that was me [16:50:30] (03CR) 10jenkins-bot: [V: 04-1] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:50:41] I'll need the large screen to recheck, it doesn't happen on the laptop, but I did try waiting for a while [16:51:21] anyway, not a huge issue, especially if we are moving away from MMV, maybe we should just backlog it [16:51:29] (03CR) 10Gilles: [C: 032] Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [16:51:49] yep, looked like backlog material to me [16:52:06] (03Merged) 10jenkins-bot: Do not treat category captions as gallery captions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/149213 (owner: 10Gergő Tisza) [17:45:27] 3MediaWiki extensions / 3GWToolset: GWToolset should not fail in case of duplicated file - 10https://bugzilla.wikimedia.org/68577#c1 (10dan) 3/ just the file the "failure", is really a skip over the upload of that specific file. the output to the runJobs log indicates the title of the file that already exis... [17:46:01] fabriceflorin: Hey, have you seen https://bugzilla.wikimedia.org/68468 yet? I worry that people are rushing around thinking about making yet another change to the rats' nest of image options without thinking it through. [17:49:47] James_F: Thanks for the heads-up about this. I am concerned that we are moving too quickly with this typography refresh, and it’s going to introduce a lot of confusion, right when we’re all at Wikimania. And this particular initiative is also jumping the gun, IMHO. We need more time to think through the issues carefully, rather than jump to premature conclusions. I will respond on Bugzilla, as well as on the [17:49:48] email thread about removing the ‘Expand’ icon, which may still be needed in some cases. [17:51:08] fabriceflorin: Glad to be of service. [18:03:28] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c8 (10Fæ) > > Problems are avoided by ensuring that a record with the maximum > > number of categories appears at the top of the file, so is used as an > > exemplar for mapping.... [18:04:42] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506#c2 (10Aaron Schulz) The runJobs logs show lots of successful jobs by Fae, with some gwtoolsetUploadMediafileJob jobs failing with "An identical media file already exists under the... [18:05:33] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506#c3 (10Aaron Schulz) Aside from the failed "claimed" jobs, the queue is empty atm. [18:06:28] 3MediaWiki extensions / 3GWToolset: GWToolset fails to upload files and throws no warning - 10https://bugzilla.wikimedia.org/68285#c9 (10dan) (In reply to Jean-Fred from comment #6)> > Hmmm, I used that for nearly 3000 files without any problem though. yes, it does work, but GWToolset doesn’t parse the sin... [18:11:37] fabriceflorin: "and store an opt-in event for metrics purposes" why? We're using preference change events now, surely that's sufficient? [18:12:41] And...the close options panel event...is that necessary too? [18:14:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [18:16:58] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506#c4 (10Fæ) (In reply to Aaron Schulz from comment #3) > Aside from the failed "claimed" jobs, the queue is empty atm. In which case I don't understand how "ghost jobs" can be arisi... [18:55:36] 3MediaWiki extensions / 3GWToolset: GWT freezing up - queues appear to be getting stuck - 10https://bugzilla.wikimedia.org/68506#c5 (10Fæ) I have created another job, "HABS 24 July 2014 (2301:2600)" (should have been 25th, it's a typo). This re-kicked the other jobs, as can be seen as further sets of 20 ima... [18:55:46] marktraceur: regarding "storing an opt-in event for metrics purposes”, we want to make sure that each opt-in/out action is stored as a separate event in [18:56:07] We get that with the preference change events, already. [18:57:21] marktraceur: regarding "storing an opt-in event for metrics purposes”, we want to make sure that each opt-in/out action is stored as a separate event in EventLogging, so it will appear on the opt-in/out dashboard. We’re not just logging logged-in user preferences, but also logged-out user choices, which I belive are now stored with ‘local storage’. tgr may be able to offer some useful suggestions in that [18:57:22] regard. [18:57:37] Ugh, sigh [18:57:38] OK [18:57:55] aren't we logging that already? [18:57:59] fabriceflorin: What about the event on closing the user options panel? [18:58:08] tgr: Basically, but I need to copy the code over to the new handler [18:58:45] marktraceur: I suppose we could punt on the close options panel event for now, though it is useful data to find out if people find the viewing panel unhelpful. [18:59:18] * marktraceur punts. [18:59:44] tgr marktraceur : My understanding is that whatever event logging we do on ‘Disable Media Viewer’ should also be present for Viewing Options Panel, which is due to take its place. [19:00:11] Sure. [19:00:37] that will be a bit painful with clicks that make the user leave the site [19:00:39] Cool. Then I think we’re set on both points for now. Let me know if you have any other questions. [19:01:05] although for logged-in users it will be painful anyway as they have to wait for the pref setting ajax request [19:01:27] tgr: Yeah...I guess we'll use the same delay thing that we use in other places [19:01:50] btw, I left a note in https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/799 [19:02:15] if the pereference changing is implemented that way, we might avoid dealing with cross-site crap [19:03:13] makes routing a bit more complicated because it involves a new URL parameter though [19:07:32] tgr : I like your idea to redirect users from the Commons file page to MediaViewer ‘on xwiki’ to change the preference, if you think this will work well technically. Which parts of Pau’s design would be lost with this approach? Can we still show them the Viewing Options Panel after they land on the Commons file page? [19:09:39] Won't we need to deal with cross-site crap *anyway*? [19:09:54] I mean, not us, right now, but maybe us or someone else, later [19:10:05] It might be good to talk to services about it anyway [19:10:42] marktraceur: I guess so [19:11:13] but given all the tension about how much time to spend on MMV and how, I would rather deal with it some other time [19:11:28] Oh sure, our implementation probably wouldn't happen right away [19:11:29] btw, is there a services mailing list? [19:11:37] or just cc gwicke? [19:11:54] The latter would be my guess, but ask him if he has a preference maybe [19:11:59] Or brave wikitech-l :) [19:12:43] wikitech-l was the original plan, I wrote the mail already [19:12:58] then right before sending I realized we might not actually need this [19:13:57] fabriceflorin: the difference would be that this way preference changing *has* to happen together with switching between the views [19:14:23] tgr: The problem I see is that we'd wind up losing context really fast [19:14:30] so you can't do stuff like having a save button, switch between views, but only save the preference when the user clicks save [19:14:44] Like if someone turned off the viewer on enwiki, then wanted to turn it back on after coming from enwikibooks or something [19:15:34] tgr: Got it. Reading your comment on #799 more closely, it seems that the "preview" and "save as default" behavior could not be separated with this approach. I defer to Pau on whether or not that's problematic from a design perspective. But it’s not such a big issue for me, as long as the panel is still open, so they can change their preference if they want. [19:15:38] * marktraceur posts WIP patch [19:15:43] marktraceur: that is generally a problem with the optout panel thing, not specific to how we implement preference setting [19:15:52] (03PS2) 10MarkTraceur: WIP Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [19:15:57] tgr: True. [19:16:59] tgr: I noted in the user tests that some people didn’t think to click on the green ‘Save as default’ button. They seemed to expect that just clicking the radio button might be enough. So if that’s true, that would support your approach, methinks. [19:20:07] marktraceur: You are correct that we don’t have an easy way to re-enable Media Viewer on your source wiki from another wiki like Commons after the fact. But I don’t know if that’s a serious issue yet. Or an issue we can solve right away. If tgr’s proposal works technically and Pau is OK with it, it may be a sufficient solution for now. [19:20:40] Sure. [19:31:39] (03CR) 10Hashar: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [19:32:14] (03CR) 10Hashar: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [19:34:12] (03CR) 10Hashar: "Bah it is stalled in Zuul queue. Next patchset or +2 will trigger tests." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:49:43] 3MediaWiki extensions / 3GWToolset: GWToolset should report that it skipped a file because it was a duplicate - 10https://bugzilla.wikimedia.org/68577#c2 (10Jean-Fred) p:5High>3Normal s:5normal>3enhanc That’s good to hear, thanks. I’ll repurpose this bug for the warning then. (then the duplicated fi...