[00:47:09] <grrrit-wm>	 (03CR) 10Gergő Tisza: "I don't disagree about in-your-face-ness :)" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza)
[00:48:09] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 
[00:48:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 (owner: 10Gergő Tisza)
[00:49:44] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Reveal full text when metadata panel is opened [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146992 
[02:18:19] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: WebVideoJobRunner silently fails to pick up transcode jobs under HHVM - 10https://bugzilla.wikimedia.org/67973#c1 (10Ori Livneh) p:5Normal>3Lowest As of I0f8b36d47, we provision a jobrunner service that processes jobs of all types in the background, so the need...
[04:25:26] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Optionally use avconv/ffmpeg for .ogv transcodes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) 
[04:25:29] <grrrit-wm>	 (03PS7) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) 
[06:30:40] <grrrit-wm>	 (03PS8) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) 
[06:40:29] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Latest patch sets add support for iOS Safari (audio init fix) and IE 9 (via Flash build of the codec libs)." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER)
[06:47:05] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Support ogv.js in player - 10https://bugzilla.wikimedia.org/61823#c8 (10Brion Vibber) Added support for iOS Safari and IE 9 in latest patch set. (IE 9 uses the Flash build of the decoder.)  Note TMH's JS doesn't load in MobileFrontend yet -- currently iOS playback...
[08:07:22] <grrrit-wm>	 (03PS9) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) 
[08:08:24] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Use image title in history [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) 
[08:09:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use image title in history [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) (owner: 10Gergő Tisza)
[08:11:16] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Use image title in history [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) 
[08:11:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use image title in history [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) (owner: 10Gergő Tisza)
[08:14:01] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Use image title in history [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) 
[08:52:47] <grrrit-wm>	 (03PS10) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) 
[11:40:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. See inline for discussion item." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER)
[12:46:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Adding messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145420 (owner: 10Rillke)
[12:46:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145420 (owner: 10Rillke)
[12:51:04] <wikibugs>	 3MediaWiki extensions / 3ImageMap: The links on imagemap should contain information about "missing article" and "external link". - 10https://bugzilla.wikimedia.org/36175#c9 (10Andre Klapper) kipod: Could you upload the patch as a file? See http://tools.wmflabs.org/gerrit-patch-uploader/ - no need to set up a...
[12:52:05] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: Missing message <mwe-upwiz-undefined> - 10https://bugzilla.wikimedia.org/54524#c10 (10Andre Klapper) 5NEW>3RESO/FIX No reply to comment 9 - assuming this is fixed by the merged patch.
[15:18:12] <grrrit-wm>	 (03PS11) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) 
[15:20:31] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Cleaned up player menu entries to say "JavaScript Ogg Player" and "Flash Ogg Player", and fixed the duplicate source menu entries when nat" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER)
[15:24:52] <grrrit-wm>	 (03CR) 10Gilles: Use image title in history (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/147392 (https://bugzilla.wikimedia.org/67008) (owner: 10Gergő Tisza)
[15:30:03] <marktraceur>	 inb4 preference-oid
[15:41:58] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] "If you remove all uploads while they're ongoing, you end up with this broken state:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur)
[15:42:58] <marktraceur>	 "Doctor, it hurts when I do this"
[15:43:02] <gi11es>	 this is what happens when design is rushed
[15:43:02] <marktraceur>	 *slams head into wall*
[15:43:15] <marktraceur>	 gi11es: What's that?
[15:43:23] <gi11es>	 the crosswiki issue
[15:43:32] <marktraceur>	 Ah, yeah
[15:50:12] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] ""x of y files uploaded" message no longer works:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur)
[15:50:36] <marktraceur>	 Ugh, so negative today
[15:50:38] <marktraceur>	 :)
[15:50:38] <gi11es>	 sorry to make this drag even longer
[15:50:41] <marktraceur>	 No, it's OK
[15:50:49] <marktraceur>	 It needs to happen
[15:51:00] <marktraceur>	 I kept forgetting about the counter issue
[16:19:41] <grrrit-wm>	 (03PS29) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) 
[16:21:03] <marktraceur>	 gi11es: That was a very dumb bug
[16:21:23] <grrrit-wm>	 (03PS7) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 
[16:21:30] <grrrit-wm>	 (03PS7) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 
[16:22:05] <gi11es>	 marktraceur: I still don't get the "don't leave this page" prompt
[16:22:53] <marktraceur>	 It's supposed to stop people from losing their data accidentally
[16:23:00] <marktraceur>	 The edit page does it too
[16:23:15] <gi11es>	 I mean that it's not there
[16:23:20] <gi11es>	 when your changeset is applied
[16:23:23] <marktraceur>	 ...wait, it's not?
[16:23:26] * marktraceur tries
[16:23:35] <gi11es>	 at the upload stage
[16:23:38] <marktraceur>	 Huh.
[16:23:41] <marktraceur>	 Super weird
[16:23:43] <gi11es>	 upload 2 files, try to refresh: your version doesn't stop me
[16:23:50] <marktraceur>	 I'll look into that
[16:30:15] <grrrit-wm>	 (03PS30) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) 
[16:32:11] <marktraceur>	 gi11es: That one was pretty dumb too :)
[16:35:30] <grrrit-wm>	 (03PS31) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) 
[16:35:41] <grrrit-wm>	 (03PS8) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 
[16:35:48] <grrrit-wm>	 (03PS8) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 
[17:07:59] <marktraceur>	 Something tells me the removeItem replacement isn't working because of equality problems.
[17:08:16] <marktraceur>	 I honestly don't know why removeItem ever worked at all
[17:12:27] <marktraceur>	 ...I don't know what I want to do about it either
[17:14:02] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] "Spotted another bug:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur)
[17:16:23] <marktraceur>	 Oof
[17:16:27] <marktraceur>	 Sad times.
[17:21:03] <marktraceur>	 Maybe I'll just leave UploadWizardUtil alive for now
[17:21:42] <marktraceur>	 Work on making the upload model sane first
[17:21:48] <marktraceur>	 Well, saner.
[17:38:32] <marktraceur>	 Yeah, I think after the Massive Refactor I'll make the upload objects have an isEmpty() method, then call that, and add a check for whether they're removed...until then there are too many nasty spaghetti strings to untangle to do this sanely
[17:59:58] <marktraceur>	 Argh, heisenbug.
[18:16:50] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: "Download as PDF" doesn't show references inside template - 10https://bugzilla.wikimedia.org/44552 (10Nihiltres)
[18:37:18] <neilk_>	 marktraceur: I'd like to have a more serious look at the Promise refactor, but can that wait until Monday?
[18:38:00] <marktraceur>	 Yeah, neilk_ 
[18:38:08] <marktraceur>	 It's been waiting a long time, what's one more weekend :)
[18:38:25] <marktraceur>	 I have to figure out why it's broken anyway
[18:38:26] <neilk_>	 marktraceur: I just browsed the whole history. One year!
[18:38:42] <neilk_>	 marktraceur: well, let's make that a "we" rather than just you
[18:38:50] <marktraceur>	 Oh, if you'd like
[18:38:57] <marktraceur>	 I'm looking at it now, though
[18:39:16] <neilk_>	 marktraceur: I'm only on WM stuff part-time & have another client thing today
[18:39:26] <marktraceur>	 *nod*
[18:39:41] <marktraceur>	 I'll probably fix this bug in it, and you can review it on Monday
[18:39:47] <neilk_>	 marktraceur: nod
[18:40:49] <marktraceur>	 Assuming I can figure it out
[18:41:03] <neilk_>	 we should really be writing new tests for all the stuff discovered here
[18:41:08] <neilk_>	 i.e. the x of y bug
[18:41:12] <marktraceur>	 *nod*
[18:41:13] <neilk_>	 but I guess that's my new job
[18:41:20] <marktraceur>	 Eh, it's everyone's job
[18:41:35] <neilk_>	 Only you can prevent forest fires
[18:42:06] <marktraceur>	 ...started by frustrated UW programmers
[20:22:19] <wikibugs>	 3MediaWiki extensions / 3VipsScaler: Apply jpgcrush (mozjpeg) over all thumbnails - 10https://bugzilla.wikimedia.org/68145#c6 (10Bawolff (Brian Wolff)) Just to clarify, Vips is an image scaling program, just like image magick. The main differences between vips and image magick is that image magick has more o...
[20:34:52] <grrrit-wm>	 (03CR) 10Mattflaschen: "Removing myself" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 (owner: 10Paladox)
[20:53:02] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "Some code comments are out of whack. Otherwise this is good." (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) (owner: 10Brion VIBBER)
[21:43:45] <Pao>	  
[21:44:03] <marktraceur>	 Bam! Pao! Kathwack!
[22:00:21] <marktraceur>	 Hurr durr
[22:00:28] <marktraceur>	 The promise doesn't resolve for a stupid reason
[22:09:10] <grrrit-wm>	 (03CR) 10Mattflaschen: "Removing myself" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox)
[22:10:02] <grrrit-wm>	 (03CR) 10MarkTraceur: "Given that nobody else is now on the review here, could you please respond to my comment?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox)
[22:25:07] <grrrit-wm>	 (03CR) 10Rillke: "Just wondering how this message will be loaded..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145420 (owner: 10Rillke)
[22:33:50] <grrrit-wm>	 (03CR) 10Paladox: "I just thought that it needed upgraded and I have not independaly tested the patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox)
[22:36:43] <grrrit-wm>	 (03CR) 10MarkTraceur: "Your opinion, while valid, is not sufficient reason for this patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox)
[22:41:07] <marktraceur>	 I totally see that there's a promise not resolving, I just don't see why it would only do it with more than one upload...
[22:54:08] <marktraceur>	 ...ugh, there's a race condition, I know there is
[23:02:37] <marktraceur>	 K, I can beat my head against this at home
[23:02:49] <marktraceur>	 Got in super early today.
[23:40:20] <wikibugs>	 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c5 (10Tisza Gergő) Doesn't seem to be working on beta.  Steps taken to verify:  1. open http://upload.beta.wmflabs.org/wikipedia/en/thumb/4/4d/Snowman.JPG/1000px-Snowman.JPG in browser 2. ssh (via the labs...