[01:06:04] 3MediaWiki extensions / 3UploadWizard: UploadWizard hangs if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082 (10Neil Kandalgaonkar) 3UNCO p:3Unprio s:3normal a:3None To replicate: - Upload two or more photos. - At the licensing step, ask to provi... [01:08:02] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082 (10Neil Kandalgaonkar) [01:09:46] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082#c1 (10Neil Kandalgaonkar) However, the upload itself isn't stalled - the user can fix the problem and then proceed. Presumably the... [01:12:44] (03CR) 10Neilk: [C: 031] "It's a pretty wide-ranging change, but it looks good to me and I tested as many paths through these events as I could find." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [01:16:53] (03CR) 10Neilk: "One unrelated change, you altered $( '') and similar to $( '' ). I remember doing that everywhere as it didn't work on some brow" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [07:56:33] 3MediaWiki / 3File management: Dutch mediawiki does not format images correctly using [[Bestand:...]] - 10https://bugzilla.wikimedia.org/68091 (10Rein van 't Veer) 3UNCO p:3Unprio s:3normal a:3None When using [[Bestand:somefile.jpg]] to render an uploaded image file on a page, the file frame does not... [10:24:46] 3MediaWiki / 3File management: Dutch mediawiki ignores formatting options when using [[Bestand:...]] instead of [[File:...]] - 10https://bugzilla.wikimedia.org/68091#c1 (10Andre Klapper) Which exact MediaWiki version are you running? [10:25:01] 3MediaWiki / 3File management: Dutch mediawiki ignores formatting options when using [[Bestand:...]] instead of [[File:...]] - 10https://bugzilla.wikimedia.org/68091#c2 (10Andre Klapper) Oh, and any public example test case for this? [12:00:47] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082#c2 (10Steinsplitter) 5UNCO>3ASSI Which browser do you use? [12:01:04] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082 (10Steinsplitter) 5ASSI>3NEW [12:26:52] (03CR) 10Gilles: "Do you want to keep this one?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 (owner: 10Gergő Tisza) [13:01:25] (03CR) 10Gilles: "Relevant doc section on the page you've linked to:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [13:12:04] (03CR) 10Gilles: [C: 032] Refactor createInterface into a new class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [13:12:32] (03Merged) 10jenkins-bot: Refactor createInterface into a new class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146229 (owner: 10MarkTraceur) [13:35:16] (03CR) 10Gilles: "The breadcrumb-like divider on the left still being there after expanding gives it a broken look. On the mockups, it's removed in expanded" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [14:14:19] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104 (10th3gov) 3UNCO p:3Unprio s:3blocke a:3None Created attachment 15951 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15951&action=edit Uncaught TypeError: Cann... [14:43:30] (03PS1) 10Gilles: Move repo icon back to the right-hand side [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 [14:44:08] (03CR) 10jenkins-bot: [V: 04-1] Move repo icon back to the right-hand side [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [14:45:18] (03PS2) 10Gilles: Move repo icon back to the right-hand side [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 [15:26:41] (03PS1) 10Gilles: Remove all survey-related code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 [15:52:36] gi11es: Do you know if we did the testing on reference thumbnails? [15:54:18] marktraceur: no, it should be a task I think. to give it a proper spin on beta sites [16:01:22] 'kay [16:01:33] It's "in testing" right now [16:01:36] I guess. [16:01:39] So that works [16:06:46] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - 10https://bugzilla.wikimedia.org/68082#c3 (10Neil Kandalgaonkar) (In reply to Steinsplitter from comment #2) > Which browser do you use? I'm seeing it in Chrome 35 and F... [16:54:14] tgr: https://gerrit.wikimedia.org/r/#/c/145990/ [17:04:11] marktraceur: about oo.js. Just wondering is that really the right way to bring in an EventEmitter? There are more minimal EventEmitters for use client-side [17:04:40] neilk_: I was planning on using oojs for class hierarchy later anyway [17:05:12] marktraceur: I see [17:08:11] (03PS1) 10Chad: Properly register a few missing classes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/146815 [17:08:42] neilk_: Also, we don't have any other EventEmitter libraries already merged, do we? [17:08:50] marktraceur: nope [17:08:59] I mean, apart from pubsub which I'm deleting soon :) [17:09:08] Which doesn't count. [17:09:30] marktraceur: unless you count jquery events but they are more UI-focused. [17:11:29] marktraceur: if the team is using oojs and likes it, well, great - I guess it's hard for me to see, on the outside, what it does that's obviously superior [17:12:26] marktraceur: no docs other than that it does inheritance, which can (a) can be accomplished in a zillion ways already (b) I'm personally a skeptic of, but I realize that's a minority opinion. [17:12:53] neilk_: I dunno, it seems to make things relatively easy for us, and we're sort of already going down the inheritance road [17:13:26] neilk_: The EventEmitter is a nice bonus; anyway, I picked up on this being a new MediaWiki thing in general, and went with it [17:14:06] * marktraceur would be in favor of a neilk_ / Trevor discussion about comparisons to other libraries, FWIW [17:14:18] But I don't think I'm going to be of much use [17:16:36] well here's the thing, inheritance in a language like JS is inherently inefficient [17:17:07] Sure [17:18:01] anyway this would get into a longer discussion. FWIW you're organizing this much better anyway [17:18:26] if I understood events properly this code would have been better organized for sure [17:20:33] :) [17:20:39] neilk_: We'll get there, don't worry [17:21:18] (03CR) 10MarkTraceur: [C: 032] Properly register a few missing classes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/146815 (owner: 10Chad) [17:21:25] (03Merged) 10jenkins-bot: Properly register a few missing classes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/146815 (owner: 10Chad) [17:24:52] neilk_: It's definitely worth saving, at least, so I'd say you did a good job [17:26:17] marktraceur: there's a lot of code, some of it okay. I think it is solving the wrong problems though. Not much I could have done to fix that though. [17:27:06] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer stay on black screen after close - 10https://bugzilla.wikimedia.org/68104#c1 (10Tisza Gergő) Could you reproduce this on a page with a ?debug=1 URL parameter added? Javascript error locations are pretty useless in non-debug mode. [17:28:44] marktraceur: it's currently jumping through hoops to make batch uploads sort of work in a sort of user-friendly way, but it's pretty clear that is a minority use case IMO. Also, it's trying to square the circle of making licensing correct and highly flexible, in a system where the format is blobs of text, and the convention is that you must get licensing right on your very first upload. [17:29:22] marktraceur: IOW I feel like I probably lost many months of my life solving problems nobody had, and ignoring the ones they did [17:29:27] :( [17:29:38] neilk_: I've definitely uploaded multiple images at once a bunch of times [17:30:14] marktraceur: sure it happens, but the cost-benefit to get that right in IE6 and a modern Chrome is ludicrous [17:30:37] Right [17:31:14] marktraceur: anyway I have an even more depressing thing I wrote the other day. Not because i want you all to be sad, but to understand what's worth throwing away and what's worth keeping [17:31:21] ttyl [17:32:05] (03CR) 10Gergő Tisza: [C: 04-1] "One small thing left out." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [17:40:06] (03PS2) 10Gilles: Remove all survey-related code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 [17:40:08] gi11es: FYI ottomata says mark was waiting on a follow-up, I think - let me know if you want me to bother people more [17:40:30] marktraceur: follow-up on what? [17:40:55] On the pre-rendering thumbnails stuff [17:40:59] Re: Capacity [17:41:05] (03CR) 10Gilles: Remove all survey-related code (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [17:42:41] I don't understand, who's waiting for what? :) [17:42:59] I'm a little fuzzy on that myself. [17:43:05] is the blocking some discussion between ops? [17:43:09] I think so [17:43:26] Ugh, I should clarify with ottomata [17:44:51] Sorry [17:44:58] gi11es: mark is going to email *you*. [17:45:00] My bad. [17:45:07] cool [17:48:58] (03CR) 10jenkins-bot: [V: 04-1] Remove all survey-related code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [17:50:46] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [18:35:47] Crap, I lost track of which thumbnail I'm fetching [18:35:58] /opt/vagrant/bin/vagrant: line 107: 10934 Segmentation fault (core dumped) [18:36:02] that's a new one [18:36:39] another day, another weird vagrant issue [19:54:04] (03CR) 10Gergő Tisza: [C: 04-1] "If I understand it correctly, the plan is to roll this back (i.e. roll out the repo-link-to-the-left change) in a few weeks, so anything t" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [20:02:56] (03CR) 10Gilles: "I didn't follow the part where this is supposed to be undone later. Last I heard Erik was very much against the icon on the left altogethe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [20:03:43] fabriceflorin: can you comment on https://gerrit.wikimedia.org/r/146783 ? [20:04:10] tgr: OK, will do. [20:10:34] fabriceflorin: How'd your meeting with halfak go? [20:13:26] marktraceur: The meeting with Aaron went well. He proposed a smaller controlled experiment with 1% of people who click on a thumbnail. They would be divided into two groups, one with Media Viewer enabled, one with it disabled. I am meeting with Lila at 2:30 to discuss his proposal, and will brief you on her recommendations afterwards. [20:14:44] fabriceflorin: Did you see the response on list about major interface changes? [20:14:57] (or did halfak?) [20:15:06] marktraceur: Note that if we go with this plan, there would be community discussion period before we develop anything, so development would not start until early next week at the earliest. [20:15:15] Yeah, I figured [20:16:23] marktraceur: Which list are you talking about? The analytics list? Or another list? [20:17:34] Analytics [20:19:00] Also, fabriceflorin, are we doing this for new logged-in users, or logged-out users? [20:19:14] (side note, argh uploadwizard) [20:19:50] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c2 (10Rainer Rillke @commons.wikimedia) ... and before anyone is going to implement anything, we should agree where it sh... [20:19:52] marktraceur: The proposal is to do this for both. But let’s wait and see what Lila says. She may steer us towards more socialization of the feature, rather than collecting metrics. [20:20:59] Hmm. K [20:21:49] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c3 (10Rainer Rillke @commons.wikimedia) 4) I believe messages should go to WikimediaMessages and config into operations-m... [20:23:39] (03CR) 10Fabrice Florin (WMF): "Yes, Erik does not support the icon-to-the-left implementation, so I don't expect we will want to re-introduce it later. The arguments aga" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [20:25:56] (03PS1) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [20:26:00] (03CR) 10jenkins-bot: [V: 04-1] Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 (owner: 10MarkTraceur) [20:26:03] Noooooooo [20:26:13] Bastard [20:26:20] Jenkins: Do my biddinggggg [20:30:49] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c4 (10Jarek Tuszynski) (In reply to Yann Forget from comment #1) >Options 1 and 2 above seem the same, but yes, more opti... [20:32:05] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c5 (10Jarek Tuszynski) (In reply to Rainer Rillke @commons.wikimedia from comment #2) > ... and before anyone is going to... [20:39:01] (03PS2) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [20:39:04] (03PS27) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [20:39:08] (03PS4) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [20:39:08] What uuuuuup [20:39:35] (03PS3) 10MarkTraceur: Use promises for fetching thumbnail info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [20:41:09] (03CR) 10jenkins-bot: [V: 04-1] Use promises for fetching thumbnail info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 (owner: 10MarkTraceur) [20:41:17] Boo [20:59:17] (03PS4) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [20:59:27] Oops, it's going to complain again. [20:59:41] (03CR) 10jenkins-bot: [V: 04-1] Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 (owner: 10MarkTraceur) [21:02:06] (03PS5) 10MarkTraceur: Use promises for fetching image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146903 [21:21:43] (03CR) 10Gergő Tisza: [C: 032] Move repo icon back to the right-hand side [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [21:22:37] (03Merged) 10jenkins-bot: Move repo icon back to the right-hand side [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146783 (owner: 10Gilles) [21:22:46] (03Abandoned) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 (owner: 10Gergő Tisza) [21:23:05] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c6 (10Rainer Rillke @commons.wikimedia) (In reply to Jarek Tuszynski from comment #5) > Where do they go right now? Ther... [21:23:37] 3MediaWiki extensions / 3MultimediaViewer: Without CSS, clicks on thumbnails getting silently swallowed - 10https://bugzilla.wikimedia.org/68123 (10christian) 3NEW p:3Unprio s:3normal a:3None For users that have CSS disabled (but JavaScript enabled), clicking on a thumbnail does not cause any action.... [21:29:09] (03PS3) 10Gergő Tisza: Remove all survey-related code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [21:29:50] (03CR) 10Gergő Tisza: "PS3: removed mock localStorage and clock from the test" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [21:30:48] (03CR) 10Gergő Tisza: [C: 032] "Whew! I feel lighter already. Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [21:31:22] (03Merged) 10jenkins-bot: Remove all survey-related code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146789 (owner: 10Gilles) [21:34:29] (03PS19) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [21:35:05] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [21:35:12] (03CR) 10Gergő Tisza: "Rebased." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [21:35:55] (03PS20) 10Gergő Tisza: Reveal full text when user clicks on title or credit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [21:42:31] (03CR) 10Gergő Tisza: "So apparently the animation test bug still exists somewhere, it's just very sproadic..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [21:46:38] neilk_: Finally burned pubsub to the ground [21:46:44] After a whole lot of untangling [22:21:16] (03PS3) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [22:21:39] (03CR) 10jenkins-bot: [V: 04-1] Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [22:22:40] (03PS4) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [22:22:47] Let's try that again... [22:27:09] 3MediaWiki extensions / 3MultimediaViewer: Without CSS, clicks on thumbnails getting silently swallowed - 10https://bugzilla.wikimedia.org/68123#c1 (10Tisza Gergő) (In reply to christian from comment #0) > For users that have CSS disabled (but JavaScript enabled) o_O ...that's a thing? This is caused by th... [22:33:05] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327#c7 (10Tisza Gergő) (In reply to Rainer Rillke @commons.wikimedia from comment #2) > ... and before anyone is going to imp... [23:59:49] 3MediaWiki extensions / 3MultimediaViewer: Without CSS, clicks on thumbnails getting silently swallowed - 10https://bugzilla.wikimedia.org/68123#c2 (10Erik Moeller) Middle-clicking (loading in a new tab) should work as a workaround, FYI.