[07:37:16] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c6 (10Andre Klapper) 5NEW>3UNCO (In reply to Steinsplitter from comment #4) > Opening a file via filedescriptionpage or thumb.php it loads quick. But > opening a file in MV it takes some seconds... [07:45:01] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c7 (10Steinsplitter) 5UNCO>3RESO/WON You like that volonteers are searching the error for you payed staffer? ... No comment, Closing this as WONTFIX and dropping a not onwiki that the WMF don't... [10:34:47] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c9 (10Tisza Gergő) We run automated tests to measure loading time via MediaViewer and the file page, and MediaViewer is quite a bit faster: http://multimedia-metrics.wmflabs.org/dashboards/mmv#media... [10:55:20] 3MediaWiki extensions / 3TimedMediaHandler: ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 - 10https://bugzilla.wikimedia.org/67953 (10Ori Livneh) [11:15:47] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewers not crediting Photographer of {{Object photo}} - 10https://bugzilla.wikimedia.org/67860#c3 (10Pierre-Selim) I'm not sure that dealing partially with authorship is an option we should accept. [12:18:01] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c10 (10Andre Klapper) I don't think it's helpful for this bug in order to get fixed to turn it into a high-level "WMF vs community" issue out of frustration that somebody cannot reproduce the proble... [12:40:31] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c11 (10Quim Gil) 5RESO/WON>3REOP Reopening because we still haven't agreed on the problem that must be fixed/wontfixed. [12:42:18] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c12 (10Quim Gil) 5REOP>3UNCO Steinsplitter, all what Andre and Gergő are asking for is a description of how to reproduce the problem, step by step, so others can reproduce the bug: https://www.... [13:09:47] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c8 (10Steinsplitter) Oft habe ich den Eindruck die unbezahlten Volonteers sollen die Arbeit für Staffer machen. thumb.php & Standard Ansicht liefert eine schnellere Ausgabe wie MV. Bei mv dauert es... [13:10:18] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not display hidden categories, or give them lesser priority - 10https://bugzilla.wikimedia.org/62277#c2 (10Derk-Jan Hartman) This is partly caused by the implementation of getForeignCategories, added in git commit 4893d1f of Bug 56598. I se... [13:53:47] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c13 (10Steinsplitter) (In reply to Quim Gil from comment #12) > Steinsplitter, all what Andre and Gergő are asking for is a description of > how to reproduce the problem, step by step, so others can... [13:54:31] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c14 (10Steinsplitter) To make it clear, i have NO PROBLEM wit the WMF. Andres comment "WMF vs community" is complety nonsense. I stop commenting here and will notify the communety abut your collabo... [14:16:46] 3MediaWiki extensions / 3MultimediaViewer: Thumb generation very slow - 10https://bugzilla.wikimedia.org/67848#c15 (10Quim Gil) Summary of this report: (In reply to Steinsplitter from comment #0) > MV is slower then thumb.php... > > It takes too long to load this should be improved. MediaViewer is faster... [15:10:46] 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428 (10Gilles Dubuc) 5PATC>3RESO/FIX [15:26:23] fab of course [15:26:54] gi11es: Sanity check, do I need to be involved in the wikidata thing? It seems like y'all are sorting it out fine without me [16:45:05] marktraceur: not at this stage, probably when we'll start dealing with actual UI [16:45:12] Yeah, that's what I figured [16:45:19] I'll keep my eyes peeled for specs [16:45:30] And make sure we implement them in UW and CMD on time [17:10:32] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer: Remove uses of jQuery.browser - 10https://bugzilla.wikimedia.org/66098#c3 (10Gilles Dubuc) 5NEW>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/145406/ [17:19:40] fabr crap. [18:06:02] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not display hidden categories, or give them lesser priority - 10https://bugzilla.wikimedia.org/62277#c3 (10Tisza Gergő) The return value from getForeignCategories() is analogous to getCategories() except that get it returns Title objects whil... [18:48:12] neilk_: How are you doing? [18:48:51] (/me reviews neilk_'s patch for UW) [18:50:48] (03CR) 10MarkTraceur: [C: 032] "Thanks, neilk! :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145728 (https://bugzilla.wikimedia.org/66214) (owner: 10Neilk) [18:52:29] (03Merged) 10jenkins-bot: pointer cursor for thumbs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145728 (https://bugzilla.wikimedia.org/66214) (owner: 10Neilk) [18:53:01] 3MediaWiki extensions / 3UploadWizard: Should have cursor: pointer on UploadWizard thumbnails in details step - 10https://bugzilla.wikimedia.org/66214#c6 (10Mark Holmquist) 5PATC>3RESO/FIX Thanks again, Neil. [18:59:34] marktraceur: hey, ya'll using fab.wmflabs for uploadwizardry? [18:59:39] er, planning [18:59:54] * greg-g just saw http://fab.wmflabs.org/project/board/51/ [19:00:19] greg-g: Just for refactor planning [19:00:37] thoughts? [19:01:09] greg-g: It's pretty awesome. :) [19:01:16] cool [19:14:11] neilk_: I'm wondering after the status of the "massive refactor" code review; if you're not up for +2ing it I might shop around for someone [19:14:34] I'm also eyeing whether I could kill pubsub in the same fell swoop... [19:20:58] Or maybe in a dependent patch [19:21:01] * marktraceur does that instead [19:28:11] marktraceur: this UWIP idea seems good to me. No new functionality so it seems the only thing to test is whether OO.EventEmitter misses any subtleties of how the interface interacted? [19:28:26] Hm, I guess [19:28:33] neilk_: I tested a bit locally, it seemed OK [19:28:53] marktraceur: yeah, I've been looking back and forth at the patches. The code is more or less just copied to events [19:28:59] Pretty much! [19:29:06] The interface-creation stuff stays in UWI [19:29:14] marktraceur: nod [19:29:18] The "controller" stuff stays in UW [19:29:29] Magically we have a slightly nicer codebase. Well, slightly. [19:29:39] marktraceur: refactors are hard, this is a great first step [19:29:47] marktraceur: plus then you can swap out UI [19:30:00] *nod* true, though this patch stops short of making it easy [19:30:07] marktraceur: baby steps! :) [19:30:43] marktraceur: just a general question, I'm supposed to be writing tests for UW... do we have a standard frontend test framework, simulating clicks etc? Selenium? [19:31:23] marktraceur: it seems to me that if we're rewriting everything those tests might end up being useless so they'd be more like a listing of functionality, with tests for the old thing, and then people changing stuff can write tests for the new code? [19:31:44] qunit basically [19:31:47] Oh wait [19:32:02] neilk_: We...are using Cucumber and Watir, last I checked. Hey chrismcmahon! [19:32:15] This is neilk_, he's the bomb, you should help him with testing. [19:32:16] Yeah I heard something about Cuke. Watir is new to me [19:32:25] chrismcmahon, marktraceur: :) [19:32:52] Oh, wait, Jasmine is the one I destroyed [19:32:58] Selenium might be right after all [19:33:09] meh, I liked Jasmine but apparently I'm the only one. [19:33:11] Heh [19:33:15] hi neilk_ (you actually interviewed me 2.5 years ago) [19:33:24] neilk_: I realized they weren't ever run, so I gave up and rm -rf'd it [19:33:32] Especially since they were out of date [19:33:38] well, Krinkle came along and changed everything to qUnit, with the justification that he is a maintainer, so that's good for us I guess. [19:33:58] chrismcmahon: hi! this is an Obi-Wan / Darth Vader moment then. [19:34:36] neilk_: we use Selenium-WebDriver in Ruby, and there is a wrapper called watir-webdriver that gives us a much richer API than raw Selenium [19:34:51] chrismcmahon: is there an exemplar project that uses it? [19:35:32] chrismcmahon: ideally, an extension [19:35:46] neilk_: MobileFrontend and VisualEditor are probably our two biggest examples [19:35:53] chrismcmahon: great, thanks [19:36:06] neilk_: but we have tests in quite a lot of repos, one sec [19:37:23] (03PS25) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [19:37:23] neilk_: README: https://github.com/wikimedia/mediawiki-selenium [19:37:57] chrismcmahon: oh, duh, there's already tests in UploadWizard. [19:38:09] neilk_: framework docs: https://github.com/cheezy/page-object [19:38:09] Heh [19:38:23] * marktraceur hands neilk_ a participation ribbon [19:38:46] basically I just pester people with questions before ls -la [19:38:48] neilk_: yeah, UW was our first reasonably sophisticated test suite [19:39:59] neilk_: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/ [19:40:11] chrismcmahon: I'll figure it out eventually but what tests are substantially missing then? [19:41:40] neilk_: current UW Cuke: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/tests/browser/features/upload_wizard.feature should be pretty self-explanatory [19:41:43] chrismcmahon: it seems that a lot of these things just test for existence of expected elements [19:42:03] yes, but it does upload a file at the end [19:42:30] chrismcmahon: ok I guess I need to learn more [19:43:04] chrismcmahonafk, marktraceur: thanks [19:44:42] No problem [21:02:28] (03PS1) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [21:04:04] (03CR) 10Krinkle: Use promises for getting image info (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (owner: 10MarkTraceur) [21:04:23] (03CR) 10jenkins-bot: [V: 04-1] Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (owner: 10MarkTraceur) [21:04:25] Wat. [21:06:18] (03PS2) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [21:06:29] Krinkle: Thanks :) [21:06:54] (03CR) 10Krinkle: "Looks nice. Don't know the extension well enough to test it. Might want to remove a few of the @method tags." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [21:07:13] <3 Krinkle [21:11:19] (03PS26) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [21:11:34] (03PS3) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 [21:12:02] marktraceur: remember that +2ing those https://gerrit.wikimedia.org/r/#/c/143872/ isn't enough to deploy them [21:12:52] Ugh [21:13:06] gi11es: Want me to, or have you gone to do it? [21:13:11] I [21:13:12] m gonna [21:13:16] 'kay [21:30:03] (03CR) 10Gilles: [C: 032] Remove unused messages from TimedText module. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 (owner: 10Brian Wolff) [21:30:12] (03Merged) 10jenkins-bot: Remove unused messages from TimedText module. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 (owner: 10Brian Wolff) [21:31:56] (03CR) 10Gilles: [C: 032] Transclude expand button text in help message instead of copying it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 (owner: 10Gergő Tisza) [21:32:32] (03CR) 10jenkins-bot: [V: 04-1] Transclude expand button text in help message instead of copying it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 (owner: 10Gergő Tisza) [21:36:17] (03CR) 10Gilles: [C: 032] Testing UtilitiesTime and removing unused methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146139 (owner: 10MarkTraceur) [21:36:41] (03Merged) 10jenkins-bot: Testing UtilitiesTime and removing unused methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146139 (owner: 10MarkTraceur) [21:38:15] (03CR) 10Krinkle: Use promises for getting image info (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (owner: 10MarkTraceur) [21:40:25] (03CR) 10Gilles: [C: 04-1] Test UploadWizardUtil and move single-use things to other classes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [21:43:31] (03CR) 10Gilles: [C: 032] Fix a few issues in unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146294 (owner: 10MarkTraceur) [21:45:04] (03CR) 10jenkins-bot: [V: 04-1] Fix a few issues in unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146294 (owner: 10MarkTraceur) [21:45:58] "TypeError: 'undefined' is not a function (evaluating 'this.embedSizeSwitchHtml.getMenu().hide()')" [21:46:18] I guess it's another OOUI breaking change [21:46:56] Gah, did they affect you? We thought they wouldn't. [21:47:14] Sorry. [21:47:34] was getMenu() replaced by something else? [21:49:19] gi11es: No, but hide() and show() were. [21:49:28] gi11es: Instead use toggle( false ). [21:49:32] gi11es: Sorry. [21:49:33] thanks [21:50:26] (03PS13) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [21:50:32] you might as well add Media Viewer's tests that cover our OOUI widgets to your jenkins run, at this point :) [21:50:46] That would probably help. :-) [21:50:53] (03CR) 10Gergő Tisza: "PS13: hide stripe button texts in untruncated mode" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [21:50:57] Right now we're still trying to get the cross-browser testing working for OOUI. [21:51:03] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [21:51:05] It's… been slow progress. :-( [21:51:57] Despite Krinkle doing huge amounts of work, we've still not got it done. [21:52:12] James_F: Maybe a mailing list! [21:52:16] Just for shits and giggles [21:52:34] I feel like I've said this after approximately four breaking changes affected us [21:53:29] marktraceur: Sure, though it feels a bit premature right now. [22:02:14] (03PS1) 10Gilles: Fix JS error caused by change in OOUI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146618 [22:02:32] ^ tgr, marktraceur [22:04:54] Checking [22:06:26] Hrm, cache or something [22:07:14] There we go. [22:07:22] (03CR) 10MarkTraceur: [C: 032] Fix JS error caused by change in OOUI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146618 (owner: 10Gilles) [22:07:44] (03PS14) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [22:08:06] (03Merged) 10jenkins-bot: Fix JS error caused by change in OOUI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146618 (owner: 10Gilles) [22:08:42] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [22:09:57] (03PS15) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [22:11:11] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [22:11:45] tgr: rebase it if you want qunit to pass [22:12:01] I just did [22:12:27] this is a different error which also seems unrelated to MMV :/ [22:12:30] new errors :) [22:12:47] (03PS3) 10Gilles: Transclude expand button text in help message instead of copying it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146013 (owner: 10Gergő Tisza) [22:13:53] hm, I recall Krinkle mentioning something about the sinon.js update breaking fake timers [22:14:04] seems to be related to your change specifically, though [22:14:07] at a glance, the errors seem animation-related [22:14:19] that other changeset I've just rebased works fine [22:14:28] Sinon.JS was very briefly updated. I reported it upstream and fixed there and on our side the same day. [22:14:34] very briefly broken( [22:15:05] (03PS2) 10Gilles: Fix a few issues in unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146294 (owner: 10MarkTraceur) [22:15:05] I get a bunch of "Teardown failed on xxx(): Unfinished animations: 1" [22:15:37] maybe I broke an animation in MMV, and there is some new global check? [22:15:49] I don't recall seeing this error message before [22:17:01] anyway, probably just another animation that's not mocked out and conflicts with the fake timers [22:23:20] Aaaaarghhhhhh [22:38:04] (03PS16) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [22:38:08] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [22:45:26] (03PS17) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [22:46:02] (03CR) 10jenkins-bot: [V: 04-1] Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 (owner: 10Gergő Tisza) [22:47:55] (03PS18) 10Gergő Tisza: Reveal full text when user clicks on title etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/144086 [23:13:53] (03PS1) 10Gergő Tisza: Test commit for unit test breakage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146644 [23:16:41] (03CR) 10jenkins-bot: [V: 04-1] Test commit for unit test breakage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146644 (owner: 10Gergő Tisza) [23:17:09] well that's that then. [23:18:16] (03Abandoned) 10Gergő Tisza: Test commit for unit test breakage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146644 (owner: 10Gergő Tisza) [23:20:23] (03PS1) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:23:13] (03PS2) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:27:18] (03PS3) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:29:03] (03PS4) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:31:11] (03PS5) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:36:04] (03PS6) 10Gergő Tisza: Test commit to find out which MMV test conflicts with the core tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146648 [23:41:37] (03CR) 10Gergő Tisza: "No idea what this was but it went away on its own (or is very intermittent) - could not reproduce it in https://gerrit.wikimedia.org/r/#/c" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/146644 (owner: 10Gergő Tisza)