[00:55:47] 3MediaWiki / 3File management: False positives for MEDIATYPE_VIDEO due to looking for string theora in (audio) ogg files - 10https://bugzilla.wikimedia.org/63584#c7 (10Bawolff (Brian Wolff)) 5PATC>3NEW Resetting to new - the above patch helps the situation, but isn't a "proper" fix. [11:34:28] (03CR) 10Pginer: [C: 04-1] "A couple of comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [12:01:39] OK what did I miss [12:35:02] [[Special:UploadWizard/Flickr]] broken on commons [12:37:05] (03PS1) 10Pginer: Adjustments for invite animation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143019 [12:37:16] comets: Arright, what's the issue? [12:37:55] the "get from flickr" button won't work .. [12:38:09] comets: Do you see any errors in your browser console, or anything? [12:39:35] nope.. [12:40:00] works on testwiki, not on commons [12:40:23] some sort of javascripting problem maybe ? [12:44:14] Seems likely [12:44:30] comets: Can you turn on the JS console on page load, and *then* try clicking the button? [12:48:10] just one link [12:48:13] GET http://api.flickr.com/services/rest/ [12:48:34] followed by [HTTP/1.1 403 Forbidden 1704ms] [12:52:15] ....403, weird [12:53:59] comets: Can you copy the link to me in a PM? [12:54:19] same for any image [12:54:28] what link? :p [12:55:30] The GET to flickr [12:55:50] Also, any image? I thought choosing an image happened after clicking the button. [12:56:19] OK, I think this is just us failing to use the right API URL [12:56:56] thank god, thot flickr was broke again :P [12:58:06] Maybe they changed their API requirements or something [12:59:10] it works ok on test.wikipedia [13:01:09] http://pastebin.com/BnriQEFH raw log on test wiki [13:01:43] TypeError: Property 'handleEvent' is not callable. [13:02:04] I don't see a 403 in that trace. [13:03:14] yeah its for test wiki, for commons its jsut ONE line .. [13:03:20] Oh right. [13:03:30] See, it's weird that testwiki's API call works. [13:03:46] But then, it's using https. [13:03:56] comets: Are you accessing Commons via HTTPS? [13:04:05] nope http. [13:04:11] Can you try switching? [13:04:21] It might be that we brain-deadedly use the same protocol. [13:04:45] lol, ok, lemme change, i hate https, too slow for me :P [13:07:23] urgh yeah, works on https :\ [13:08:10] Sigh [13:08:13] OK I'll open a bug. [13:08:42] http://pastebin.com/dNE3aRat [13:09:32] generally ppl with low Internet speed (3.4 of the world) use the http version ;) [13:09:32] 3/4* [13:22:06] comets: https://bugzilla.wikimedia.org/show_bug.cgi?id=67298 [13:22:21] 3MediaWiki extensions / 3UploadWizard: Flickr API method=flickr.photos.licenses.getInfo requires SSL, we don't use it - 10https://bugzilla.wikimedia.org/67298 (10Mark Holmquist) 3NEW p:3Unprio s:3normal a:3None It seems like our Flickr API calls match the protocol that was used to access the UploadWi... [13:57:50] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer breaks Cite extension parser tests - 10https://bugzilla.wikimedia.org/67302 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None Created attachment 15782 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15782&action=edit Failing... [14:06:04] marktraceur: that is what i filled https://bugzilla.wikimedia.org/67302 [14:06:16] marktraceur: i.e. Cite parser tests get broken because MutlimediaViewer enhance the output [14:06:23] marktraceur: not sure how to have that fixed though :D [14:08:47] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer breaks Cite extension parser tests - 10https://bugzilla.wikimedia.org/67302#c1 (10Antoine "hashar" Musso) p:5Unprio>3High We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward... [14:11:03] I see that yeah [14:11:20] I guess you could do a sanitization of the DOM before comparing, but eh [14:11:32] You could also just check the parts of the DOM that are important to Cite [14:11:41] Instead of checking the entire thing [14:15:00] (03CR) 10MarkTraceur: "What do you mean about not believing you?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [14:25:06] gi11es: You're around, right? [14:33:35] (03PS7) 10MarkTraceur: Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 [14:34:47] (03CR) 10jenkins-bot: [V: 04-1] Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [14:34:53] wtf [14:36:10] (03PS8) 10MarkTraceur: Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 [14:36:50] (03CR) 10jenkins-bot: [V: 04-1] Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [14:38:18] (03PS9) 10MarkTraceur: Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 [14:44:34] (03PS2) 10MarkTraceur: Remove next/prev tooltips [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 [14:44:41] * marktraceur stops being a moron [15:31:02] 3MediaWiki / 3File management: Allowed memory size exhausted when using API - 10https://bugzilla.wikimedia.org/30751#c10 (10Svick) 5NEW>3RESO/WOR I can't reproduce the original issue, so I guess I'll close this bug. [15:52:00] marktraceur: any clue who is in charge of BetaFeatures extension nowadays ? [15:52:25] hashar: Me. [15:52:47] James_F: could use someone to test / review a patch I have made https://gerrit.wikimedia.org/r/#/c/143042/ :-D [15:52:48] hashar: But it's in maintenance-only, and there's certainly no HHVM-experts familiar with it. [15:52:58] hashar: Yes, I could use someone. Who do you suggest? [15:53:06] James_F: that fix some bad interaction with other extensions using the GetPreferences hooks. [15:53:11] oh [15:53:14] that is plain PHP :-] [15:53:17] not hhmv related at all [15:53:47] Ah. I thought there was an HHVM issue too? [15:54:35] hashar: Do we actually use OATHAuth? [15:54:47] James_F: I hvae no clue [15:54:48] Oh, wikitechwiki? [15:54:52] but it is definitely in the wmf branches [15:55:02] so I will need the tests to pass when both extensions are installed [15:55:02] hashar: We don't run OATHAuth and BetaFeatures on the same wikis, I believe. [15:55:17] yeah but the tests will run with a stock configuration (i.e. a default LocalSettings ) [15:55:28] * James_F nods. [15:55:30] so there is no magic configuration variance ala mediawiki-config [15:55:50] How will we cope when we have two extensions that actually conflict? [15:55:58] fix tests ! :-D [15:56:12] No, I mean, can't reasonably both be installed on the same wiki. [15:56:12] once we have all extensions passing tests together, I get the job voting [15:56:18] * James_F nods. [15:56:22] and Jenkins will prevent further tests brokage [15:56:29] that is really rough [15:56:52] eventually I will start injecting mediawiki-config configuration parameters with different wiki settings (ex: enwiki) [15:56:57] but that is a long way [15:57:20] Yeah. [15:57:27] for BetaFeatures, the maintenance should belong to Platform > mediawiki/core? (reedy, tim, anomie, me ...) [15:58:00] I am not sure how extensions responsibilities are moved from a group to another one though (Features -> Platform) [15:58:22] hashar: Generally, they aren't. :-( [15:58:28] :-D [15:58:40] will raise the point later tonight. We have our weekly meeting [15:58:40] hashar: I'll ask marktraceur to review it but it looks sane. [16:02:39] added the point to my team agenda. Might keep you updated or Rob will come see you / Terry :] [17:34:07] (03PS1) 10Reedy: Drop execute bit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143060 [17:38:00] (03CR) 10Gergő Tisza: [C: 032] Drop execute bit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143060 (owner: 10Reedy) [17:38:34] (03Merged) 10jenkins-bot: Drop execute bit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143060 (owner: 10Reedy) [17:43:34] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer breaks Cite extension parser tests - 10https://bugzilla.wikimedia.org/67302#c2 (10Tisza Gergő) Sounds like those tests are too rigid. Maybe they could use some sort of DOM parsing and then check only for the elements which are actually used by the C... [17:55:29] pginer: Hey, re https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396 - what should I do if there are links in the text? There's still no design notes if I see correctly [17:55:49] I would cc fflorin if he were around [17:56:35] (03CR) 10Gergő Tisza: "> What do you mean about not believing you?" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [17:56:52] (03CR) 10MarkTraceur: "Yeah, thanks :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [17:57:00] since the added ellipsis will not be a link, you always have the opportunity to click on it [17:57:05] 3MediaWiki extensions / 3MultimediaViewer: "Use this file" popup content appears offscreen on iPad (desktop view) when details drawer is open - 10https://bugzilla.wikimedia.org/67319 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Created attachment 15789 --> https://bugzilla.wikimedia.org/attach... [17:57:33] pginer: So handle clicks on links in the truncated bits as a separate event, and don't propagate them? [17:57:39] pginer: maybe interesting for you: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Media_Viewer&diff=0&oldid=614831515 [17:59:02] if we want to be cautious, we can do both, open the link in a window and propagate to expand. But I was mainly thinking on the issue of not being able to expand if all you have in the visible area is a link [18:00:43] I don't want to be cautious, I want to be consistent - I think clicking on a link should probably not have side effects [18:02:35] 3MediaWiki extensions / 3MultimediaViewer: Tooltips for next/prev don't disappear, float with wrong layer on iPad (desktop) - 10https://bugzilla.wikimedia.org/67320 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Created attachment 15790 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15790&... [18:03:34] marktraceur that makes sense [18:03:39] AOK [18:06:22] tgr: I think the “X” works in the context (users that want to get rid of the extra info know hot to do so), but I can look for alternative icons since it is true that may not fulfill all expectations (not getting completelly rid of them but “minimizing them). [18:08:50] 3MediaWiki extensions / 3MultimediaViewer: HTML embed uses unsuitably large image size - 10https://bugzilla.wikimedia.org/67323 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Created attachment 15791 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15791&action=edit screenshot showing 3000x2... [18:15:33] 3MediaWiki extensions / 3MultimediaViewer: Tooltips for next/prev don't disappear, float with wrong layer on iPad (desktop) - 10https://bugzilla.wikimedia.org/67320#c1 (10Tisza Gergő) > The tooltips for the next/previous buttons show up when tapping them on iPad > (in desktop view), but don't get hidden. S... [18:19:33] 3MediaWiki extensions / 3TimedMediaHandler: last edited note incorrect on timedText namespace page - 10https://bugzilla.wikimedia.org/66384#c4 (10Jon) *** Bug 67096 has been marked as a duplicate of this bug. *** [18:19:48] (03CR) 10Gergő Tisza: [C: 04-1] "The messages should be removed from MultimediaViewer.php as well." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 (owner: 10MarkTraceur) [18:20:02] Argh ffs [18:20:47] (03PS3) 10MarkTraceur: Remove next/prev tooltips [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 [18:20:59] Surprised the tests didn't catch that. [18:28:47] (03CR) 10Gergő Tisza: [C: 032] "Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 (owner: 10MarkTraceur) [18:29:23] (03Merged) 10jenkins-bot: Remove next/prev tooltips [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 (owner: 10MarkTraceur) [18:32:48] 3MediaWiki extensions / 3MultimediaViewer: HTML embed uses unsuitably large image size - 10https://bugzilla.wikimedia.org/67323#c1 (10Tisza Gergő) Well, you have selected "Original size"... I guess it should not be the default for embedding, though. [18:35:32] (03CR) 10Gergő Tisza: [C: 032] Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [18:36:07] (03Merged) 10jenkins-bot: Add section for attribution of downloads [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [18:43:51] 3MediaWiki extensions / 3MultimediaViewer: "Use this file" popup content appears offscreen on iPad (desktop view) when details drawer is open - 10https://bugzilla.wikimedia.org/67319#c1 (10Tisza Gergő) This sounds like a "don't do that then" issue to me - you can just pull back the drawer a bit to access the... [18:48:57] (03CR) 10Gergő Tisza: [C: 032] "Neat!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143019 (owner: 10Pginer) [18:49:34] (03Merged) 10jenkins-bot: Adjustments for invite animation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143019 (owner: 10Pginer) [18:49:51] 3MediaWiki extensions / 3MultimediaViewer: HTML embed uses unsuitably large image size - 10https://bugzilla.wikimedia.org/67323#c2 (10Brion Vibber) Yes, it's the default... which seems unwise for multi-megapixel images. :) [18:50:33] (03CR) 10Gergő Tisza: "> When the tooltip is shown, scrolling makes it move which should not happen." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [19:13:56] 3MediaWiki extensions / 3MultimediaViewer: Tooltips for next/prev don't disappear, float with wrong layer on iPad (desktop) - 10https://bugzilla.wikimedia.org/67320#c2 (10Tisza Gergő) (In reply to Tisza Gergő from comment #1) > Adding position:fixed to the tooltips seems to fix it. Unfortunately not really;... [20:22:38] 3MediaWiki extensions / 3UploadWizard: Upload wizard should be more specific in case of "The copyright has definitely expired in the USA" licenses - 10https://bugzilla.wikimedia.org/67327 (10Jarek Tuszynski) 3NEW p:3Unprio s:3normal a:3None At the moment one of the license options in Upload Wizard is... [20:25:51] 3MediaWiki extensions / 3MultimediaViewer: Tooltips for next/prev don't disappear, float with wrong layer on iPad (desktop) - 10https://bugzilla.wikimedia.org/67320#c3 (10Tisza Gergő) (In reply to Tisza Gergő from comment #2) > tipsy does not take positioning in account when placing the tooltips, > so they d... [20:31:18] (03PS1) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [20:40:43] (03CR) 10jenkins-bot: [V: 04-1] Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [20:43:29] (03CR) 10Gergő Tisza: "> That's a generic issue (bug 67320). I'll address it in a separate patchset." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [21:08:30] (03PS4) 10Gergő Tisza: Show help tooltip for "view original file" button on image click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 [21:08:33] (03CR) 10jenkins-bot: [V: 04-1] Show help tooltip for "view original file" button on image click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [21:09:13] (03CR) 10Gergő Tisza: "Implemented the other comment." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 (owner: 10Gergő Tisza) [21:12:38] (03PS5) 10Gergő Tisza: Show help tooltip for "view original file" button on image click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142180 [21:18:19] (03PS2) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [21:19:06] (03CR) 10jenkins-bot: [V: 04-1] Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [21:39:47] (03PS3) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [21:40:24] (03CR) 10jenkins-bot: [V: 04-1] Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [21:41:40] (03PS4) 10Gergő Tisza: Move button setup from lightboxinterface to canvasButton [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 [22:28:05] (03PS1) 10Gergő Tisza: Use 4 spaces to indent, per Python coding standards [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/143180 [22:44:17] Hey marktraceur tgr : Thanks for developing #598 (Show attribution credits in download tool). A couple minor nitpicks: 1) could we use the same text font and hilite style as for Embed and Share? (the current font is too large and the light gray highlight is hard to read on my browser); 2) in the plain text version of the attribution credit, could you remove the period after the URL, so users don’t end up including it accidentally? or [22:44:18] add a space between the period and the end of the URL? I’m accepting the other tooltips cards. Thanks! https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/598 [22:47:45] gi11es: Not sure if you're subscribed to the list, have you seen http://lists.wikimedia.org/pipermail/glamtools/2014-June/000208.html probably should get some sort of response, but I'm not sure who would actually know what the answer is (perhaps you do) [22:49:32] bawolff: Thanks for the heads-up. I don’t know the answer either, but I guess we’ll probably find out as we start switching our attention to Upload Wizard. [22:50:40] bawolff: Also note gi11es is on vacation until tomorrow morning, FYI. [22:52:16] Ok. I assume he'll check his irc client sometime tommorow anyways [22:58:19] bawolff: I replied some time ago in the bug which is mentioned towards the end of that thread [22:58:53] ah, nevermind, I thought you meant the other thread [23:00:38] tgr: I think Fae is just looking for some arbitrary line so he knows how he can most effectively do his mass upload work without negatively affecting the servers [23:02:39] 3MediaWiki / 3Uploading: Unable to upload OGV, Wikipedia thinks it is OGX - 10https://bugzilla.wikimedia.org/67335 (10supervegetauk2001) 3UNCO p:3Unprio s:3normal a:3None I have an OGV file, I've checked the extension and it is .ogv but Wikipedia is blocking me from uploading it saying that it is an... [23:02:42] which from a user prespective isn't unreasonable. But from our prespective I think is a big ? mark [23:04:26] (03CR) 10Gergő Tisza: "Config patch was merged." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142475 (https://bugzilla.wikimedia.org/64554) (owner: 10Gergő Tisza) [23:05:20] bawolff: not sure upload speed has any effect [23:05:51] 3MediaWiki / 3Uploading: Unable to upload OGV, Wikipedia thinks it is OGX - 10https://bugzilla.wikimedia.org/67335#c1 (10Bawolff (Brian Wolff)) Umm, all those extensions should be considered equivalent as far as mediawiki is concerned. What is the precise error you are getting? What method are you using to u... [23:06:06] Well if we're sure about that, we should tell Fae to upload things as fast as he wants [23:06:07] the bug was triggered by lots of simultaneous requests to the scalers, probably from looking at special:newfiles, or a category, or something like that [23:06:51] The thing is, there's still a lot of unknowns about what precisely triggered it (e.g. What people were actually looking at) [23:07:21] if you upload very fast, saturation at new files page will be higher, but if the files are small enough and the scalers can handle that, the uploads itself should not be problematic [23:08:00] Although in the original outage, it didn't correspond with high upload rates (The high upload rates were earlier in the day. The outage happened in a lull) [23:08:18] And the outages continued after gwtoolset was stopped [23:08:52] he says 3000x15MB images a day, that's about .5 Mbps [23:09:19] even a hundred times that much should not be too problematic, as far as bandwidth goes [23:10:43] anyway, IIRC the current speed limits are set up in such a way that running more threads would just mean they will run slower [23:11:33] I'll doublecheck that and reply to him