[00:58:59] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Add MS prefixed version of .unselectable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141876 
[02:16:46] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Remmeber last reuse tab selection [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 
[02:17:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remmeber last reuse tab selection [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 (owner: 10Gergő Tisza)
[02:18:44] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Remmeber last reuse tab selection [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 
[02:19:50] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Remember last reuse tab selection [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 
[06:38:16] <wikibugs>	 3MediaWiki / 3File management: InstantCommons broken for some images: Error creating thumbnail: Invalid thumbnail parameters - 10https://bugzilla.wikimedia.org/32387#c25 (10D Hugh Redelmeier) I just hit this "problem".  Or perhaps a variant of it.  - local JPEG file from a modest camera takes pictures with m...
[06:43:17] <wikibugs>	 3MediaWiki / 3File management: InstantCommons broken for some images: Error creating thumbnail: Invalid thumbnail parameters - 10https://bugzilla.wikimedia.org/32387#c26 (10Nemo) (In reply to D Hugh Redelmeier from comment #25) > The absolutely simple fix is to print a useful diagnostic.  Perhaps >    Error...
[08:33:57] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141871 (owner: 10Reedy)
[08:35:30] <grrrit-wm>	 (03PS1) 10Pginer: Angle separator image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141903 
[08:37:40] <pginer>	 I got a JS error in my local installation of Media viewer: “Cannot read property 'msie' of undefined”
[08:37:48] <pginer>	 It prevents the Media Viewer from opening
[10:27:14] <grrrit-wm>	 (03PS1) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) 
[10:27:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[10:29:41] <grrrit-wm>	 (03PS2) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) 
[10:29:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[10:52:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/138183 (owner: 10Raimond Spekking)
[13:09:10] <grrrit-wm>	 (03PS3) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) 
[14:09:47] <wikibugs>	 3MediaWiki / 3Uploading: MimeMagic: ZIP types not properly detected - 10https://bugzilla.wikimedia.org/66428#c17 (10Andre Klapper) Updating the flag from ? to + now that this has been backported.
[14:47:56] <grrrit-wm>	 (03PS1) 10MarkTraceur: Remove next/prev tooltips [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 
[14:48:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove next/prev tooltips [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 (owner: 10MarkTraceur)
[14:55:12] <marktraceur>	 baw<tab><tab> cuuuuurse youuuuuu bawolffffff
[15:13:46] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data,  could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c16 (10Laurence 'GreenReaper' Parry) I can confirm, the default $wgMediaViewerUseThumbnailGuessing = true doesn't always work ri...
[15:22:02] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer fails with “Impossible to load thumbnail data,  could not load image from etc.” - 10https://bugzilla.wikimedia.org/64554#c17 (10Laurence 'GreenReaper' Parry) Also, Firefox is showing your two requests for the same image coming immediately in success...
[15:37:34] <grrrit-wm>	 (03CR) 10MarkTraceur: "tgr, you have a qunit failure." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza)
[15:55:56] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "This is pretty neat stuff. Thanks, tgr!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 (owner: 10Gergő Tisza)
[15:56:25] <grrrit-wm>	 (03PS1) 10Inchikutty: Adds leaflet scripts to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141979 (https://bugzilla.wikimedia.org/56612) 
[15:56:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remember last reuse tab selection [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141883 (owner: 10Gergő Tisza)
[16:02:34] <grrrit-wm>	 (03PS1) 10Inchikutty: Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) 
[16:02:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[16:25:18] <wikibugs>	 3MediaWiki / 3Uploading: Upload by URL fails without giving any error - 10https://bugzilla.wikimedia.org/39507 (10Rohan Rawat) a:3Rohan Rawat
[17:00:34] <grrrit-wm>	 (03PS2) 10Inchikutty: Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) 
[17:00:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:11:33] <tgr>	 marktraceur: anything for the scrum of scrums, apart from the MediaViewer issues?
[17:13:08] <marktraceur>	 Uh
[17:13:19] <marktraceur>	 The security bug and the...poolcounter thing
[17:13:22] <marktraceur>	 That's all I know of
[17:20:31] <tgr>	 marktraceur: we have a blocker about oojs, the bug it refers to is fixed though
[17:20:38] <tgr>	 is that still a thing?
[17:21:04] <tgr>	 should it be rephrased about old IE support for oojs UI?
[17:21:20] <tgr>	 as I understand, oojs supports pretty much anything now
[17:22:33] <marktraceur>	 It's...not really a thing
[17:22:44] <marktraceur>	 I think they merged the patch that supports IE8 at least, maybe 6, not sure
[17:22:51] <marktraceur>	 I vote close the ticket
[17:26:06] <tgr>	 IE6-8, yes
[17:28:16] <James_F>	 marktraceur, tgr: OOjs itself now does IE6-8 parsing; with the new patch (not yet landed) it also /works/ in IE6–8 in MW, but that's not yet merged.
[17:28:33] <marktraceur>	 *nod*
[17:48:57] <grrrit-wm>	 (03PS3) 10Inchikutty: Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) 
[18:26:04] <grrrit-wm>	 (03PS2) 10Brian Wolff: Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 
[18:26:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 (owner: 10Brian Wolff)
[18:37:36] <grrrit-wm>	 (03CR) 10Brian Wolff: "I tested on orca (A free software screen reader for gnome). Prior to this change it read out the play button as "link", after this change " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/110310 (owner: 10Brian Wolff)
[18:55:17] <grrrit-wm>	 (03PS3) 10Brian Wolff: Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 
[18:55:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 (owner: 10Brian Wolff)
[19:02:12] <grrrit-wm>	 (03PS4) 10Brian Wolff: Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 
[19:02:32] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c6 (10Tisza Gergő) 5PATC>3NEW This seems to have made things worse, the blog posts are completely unreadable now.
[19:27:46] <fabriceflorin>	 bawolff : Thanks for working on Bugzilla ticket #66143 to make the embedded videos play again. The videos plays fine now, but as reported by tgr, we can’t see the blog posts on pages like these: https://blog.wikimedia.org/2013/11/08/open-letter-free-access-wikipedia-south-africa/
[19:29:09] <bawolff>	 fabriceflorin: yes. I just saw that
[19:29:52] <bawolff>	 There's a patch in gerrit that might help which isn't deployed yet.
[19:29:58] * bawolff needs to test to figure out what's going on
[19:32:05] <fabriceflorin>	 bawolff: Cool. What’s the new gerrit patch? Keep us posted on your progress. Happy to test the next version of the code. For now, I have moved ticket #729 back in the development column on our Current Cycle Wall: http://ur1.ca/h7w5s
[19:36:37] <bawolff>	 Sorry, got a phone call
[19:36:56] <bawolff>	 Next gerrit patch is already merged, its just not deployed
[19:39:28] <fabriceflorin>	 bawolff: OK, thanks. If you would like us to test it before we deploy, and if this is a practical idea, you could put it on this beta site, where we have been testing new features for Media Viewer:  http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo
[19:39:44] <bawolff>	 Its already on the beta site
[19:40:35] <fabriceflorin>	 bawolff: Great. Is there any particular page on that site where we could try playing an embedded video? Or would you like to create one for that purpose?
[19:41:05] <bawolff>	 So hmm, the issue doesn't happen on my local wiki (Which makes me feel mildly better, as that would be quite a collosal failure in terms of my testing my own patches if it exploded on my local wiki)
[19:41:19] <bawolff>	 but which still leaves the problem of why is it happening on production
[19:42:15] <fabriceflorin>	 bawolff: Glad it’s working on your local wiki. Let me know if it’s practical for me to test as well on beta. Happy to do it :)
[19:42:17] <bawolff>	 fabriceflorin: So this feature is for embedding in external sites, so it can't really test on beta itself, as you can't embed an iframe on beta. But the other patch should be on beta, so we could test by using beta as the source of the video
[19:42:49] <fabriceflorin>	 bawolff: Got it. Let me know if there’s anything I can do to help :)
[19:42:56] <bawolff>	 fabriceflorin: I mean, the version before the fix that's in gerrit but not production works on my wiki, which is kind of :s since that means its unclear why bad things happen on real wikis
[19:43:17] <marktraceur>	 "real"
[19:44:28] <bawolff>	 oh ugh, it explodes on chrome for me to. I just thought it didn't because I had js disabled testing something else and forgot
[19:50:43] <bawolff>	 hmm, how does an iframe loading from an external domain even redirect the page to somewhere else. I thought that was a violation of same-origin policy or something
[19:58:26] <bawolff>	 Well I can confirm the version on beta works fine. I don't know if that's because beta and commons is different, or because of the patch
[19:59:47] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c7 (10Bawolff (Brian Wolff)) (In reply to Tisza Gergő from comment #6) > This seems to have made things worse, the blog posts are completely > unreadable now.  Oh wow. That's not good....
[20:22:17] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c8 (10Bawolff (Brian Wolff)) Ok, what's happening is that $wgBreakFrames = true is on production. My last change that used MW's default loader, caused this code to become active for emb...
[20:34:57] <grrrit-wm>	 (03PS1) 10Brian Wolff: Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142085 (https://bugzilla.wikimedia.org/66143) 
[20:46:02] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c10 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #8) > Ok, what's happening is that $wgBreakFrames = true is on production. My last > change that used MW's...
[20:46:58] <bawolff>	 marktraceur / tgr : Maybe if we could get gerrit 142085 reviewed quickly, it could be swatted out today.
[20:47:14] <tgr>	 looking at it
[20:47:25] <bawolff>	 thanks :)
[20:49:20] <robla>	 tgr: you don't happen to see Dan Duvall at his desk, do you?
[20:49:28] <tgr>	 no
[20:49:50] <robla>	 thanks anyway
[20:50:39] <tgr>	 $wgBreakFrames overrides allowClickJacking()? wow thats messy
[20:52:11] <tgr>	 robla: he just came back
[20:53:18] <bawolff>	 tgr: Well ->allowClickJacking() would be the default for a normal article view anyways, I think that hook just happens before that method is called
[20:54:24] <bawolff>	 The alternative would be making our own version of $wgOut->getHeadScripts();, which would be a lot messier
[20:54:25] <robla>	 thanks
[20:54:37] <tgr>	 it's just weird to have two parallel mechanisms for the same thing
[20:55:11] <tgr>	 or rather one mechanism but two places to configure it
[20:56:06] <bawolff>	 Ah. I think one is for people who don't want people framing their site with adverts, and the other is the always-on don't let people get around csrf tokens using frames
[20:56:20] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142085 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff)
[20:57:05] <bawolff>	 Whee!
[20:57:58] <tgr>	 should I set up the SWAT?
[20:58:23] <bawolff>	 Sure. Or is that something I can do? (I've never been involved with SWAT stuff before)
[20:58:42] <tgr>	 will do
[20:59:11] <tgr>	 anyone can, in theory, although being in wmf-deployment helps
[20:59:23] <bawolff>	 Ideally I think https://gerrit.wikimedia.org/r/#/c/140833/ should go out with this change
[20:59:36] <tgr>	 I'm not in that group either, so we'll just nag marktraceur for that part
[21:00:12] <tgr>	 this is only relevant for Commons, right?
[21:00:15] <marktraceur>	 Oh dear.
[21:00:15] <tgr>	 so wmf10
[21:00:23] * marktraceur will look at it in a bit
[21:00:46] <tgr>	 marktraceur: just need a +2 for some backports
[21:00:53] <tgr>	 which, um, are not backported yet
[21:01:31] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Avoid double processing <video> tags in iframes [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142131 
[21:02:33] <bawolff>	 yep, only relavent for commons (You can embed from other wikis, but I don't think anyone actually does that. Not that I have any numbers to back that up)
[21:03:21] <bawolff>	 and wikipedia will be on wmf10 tommorow anyways
[21:03:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142085 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff)
[21:04:10] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142132 (https://bugzilla.wikimedia.org/66143) 
[21:07:28] <tgr>	 does Jenkins not run on deployment branches, or is it just horribly slow?
[21:07:43] <bawolff>	 its just horribly slow
[21:08:42] <bawolff>	 https://integration.wikimedia.org/zuul/ has a bit of a backlog from the looks of it
[21:09:04] <tgr>	 marktraceur: can you cast a glance on https://gerrit.wikimedia.org/r/141871 ? it's based on grepping PHP sources, and I couldn't decide whether it would break things
[21:10:34] <tgr>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/142131/ https://gerrit.wikimedia.org/r/#/c/142132/ could you +2 these backports?
[21:25:34] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "Should get rid of the messages, too." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/141965 (owner: 10MarkTraceur)
[21:40:41] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Uh... Krinkle broke it!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza)
[21:41:05] <grrrit-wm>	 (03PS6) 10Gergő Tisza: Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) 
[21:43:30] <grrrit-wm>	 (03PS2) 10Cmcmahon: Add Safari to browser tags [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139811 (owner: 10Gilles)
[21:43:37] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Add Safari to browser tags [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139811 (owner: 10Gilles)
[21:45:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Safari to browser tags [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139811 (owner: 10Gilles)
[21:48:37] <grrrit-wm>	 (03CR) 10Krinkle: "Yeah, these tests shouldn't be referencing random files from mediawiki-core internals. Individual skins' files are not an API." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza)
[21:48:52] <grrrit-wm>	 (03CR) 10Krinkle: "As for blame, MatmaRex renamed it :P" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza)
[22:13:56] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Fix image download test to not rely on assets outside the codebase [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142143 
[22:14:24] <grrrit-wm>	 (03CR) 10Gergő Tisza: "See comments in https://gerrit.wikimedia.org/r/#/c/138999/ for background." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/142143 (owner: 10Gergő Tisza)
[22:15:03] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Fixed (well, somewhat) in https://gerrit.wikimedia.org/r/#/c/142143/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza)
[22:15:53] <tgr>	 marktraceur: ping, could you look at the backports?
[22:16:20] <tgr>	 they don't really need review, just someone with +2
[22:20:21] <bawolff>	 tgr: Not really familar with the swat process, but do those patches need to be listed at https://wikitech.wikimedia.org/wiki/Deployments ?
[22:21:00] <tgr>	 bawolff: only if you want SWATters to hate you
[22:21:12] <tgr>	 it's one way to do it, but more work for them
[22:21:25] <bawolff>	 Ah. Well we don't want them to hate us :)
[22:21:53] <tgr>	 ideally, we would merge into wmf10, create a patch in mediawiki/core updating the submodule and list that
[22:22:26] <tgr>	 except you have to be in wmf-deployment to do the merge
[22:23:08] <tgr>	 or you have to mess up the gerrit configuration for UploadWizard, which I am considering doing...
[22:23:50] <tgr>	 not sure not allowing extension owners to +2 inf wmf/* makes sense
[22:25:47] <bawolff>	 Keegan: Heads up if you haven't already seen: https://commons.wikimedia.org/wiki/Commons:VP#Media_Viewer_software_feature
[22:26:03] * Keegan sighs
[22:27:00] <Keegan>	 ...and to think I was gonna guess who...
[22:27:47] <Keegan>	 Thanks, relatively speaking :)
[22:29:04] <bawolff>	 yeah, I'm sure thats exactly the post you wanted to see
[22:29:37] <marktraceur>	 tgr: Sorry, yeah
[22:29:49] <Keegan>	 I'm not at all surprised he took it over there, unfortunately. I'd have bet money on it.
[22:30:03] <tgr>	 well, we are on the fence about enabling it on Commons anyway, and that discussion has to happen at some point
[22:30:35] <tgr>	 I just hope it will be a bit more sophisticated than the yes/no thing on enwiki
[22:30:42] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Avoid double processing <video> tags in iframes [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142131 (owner: 10Gergő Tisza)
[22:30:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid double processing <video> tags in iframes [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142131 (owner: 10Gergő Tisza)
[22:31:05] <bawolff>	 Well so far just one person trying to take it over from wikipedia -> commons. There's a real possibility everyone at commons will just be meh, and not really care
[22:31:06] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142132 (https://bugzilla.wikimedia.org/66143) (owner: 10Gergő Tisza)
[22:31:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not break iframes in the iframe output of TMH [extensions/TimedMediaHandler] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142132 (https://bugzilla.wikimedia.org/66143) (owner: 10Gergő Tisza)
[22:31:25] <tgr>	 marktraceur: thx
[22:31:38] <marktraceur>	 tgr: The UW patch...not so sure about it
[22:31:53] <marktraceur>	 I suspect you're right they don't exist
[22:32:00] <marktraceur>	 But not totally sure
[22:32:03] <marktraceur>	 Yuvi would know, sec
[22:32:27] <tgr>	 marktraceur: I only looked at it in passing, it looked like those could be created from a page content JSON blob in some magical way
[22:32:45] <Keegan>	 bawolff: Yeah
[22:32:56] <marktraceur>	 tgr: Probly, hence asking
[22:33:01] * marktraceur looks at Commons
[22:33:04] <Keegan>	 My life will get back to normal one of these months
[22:33:24] <marktraceur>	 Keegan: You keep telling yourself that
[22:33:41] <Keegan>	 marktraceur: I will. It helps the pain.
[22:34:00] <marktraceur>	 <3
[22:35:17] <fabriceflorin>	 Keegan: Sorry to see this proposal for an RfC to disable Media Viewer on Commons. It appears that Pete Forsythe has strong opinions against this feature. Coincidentally, he has also aggressively started to delete photos I have uploaded in the past, as you can see on my Commons talk page: https://commons.wikimedia.org/wiki/User_talk:Fabrice_Florin_(WMF)
[22:35:52] <Keegan>	 Meh. People.
[22:37:10] <bawolff>	 Out community, being opinionated! who'd a thunk
[22:37:14] <Keegan>	 "This file is a copyright violation for the following reason: Contents projected on screen are not attributed; no license information provided."
[22:37:43] <Keegan>	 I believe the words Charlie Brown is looking for are "Good grief."
[22:37:49] <bawolff>	 Hmm, using the same template like 20 times is a bit impolite
[22:38:45] * bawolff goes fixes the copyright descriptions on your image
[22:38:57] <bawolff>	 His complaint is basically you don't have a source link to your slideshow
[22:39:28] <fabriceflorin>	 Keegan: yeah, I think his point is that if an image is included in a presenter slide, it needs to be fully attributed, even if it takes up a very small area of my entire photo. But that is not practical for me to do as the photographer, as I don’t know where the presenter got that image, and it seems to be an excessive requirement when an image is so small that it represents less than 5% of the entire photo. 
[22:39:30] <fabriceflorin>	 Also, is speedy deletion appropriate in this case, since I have shown good faith in the past in trying to provide attribution when requested?
[22:40:07] <Keegan>	 I'm not up on Commons deletion policies.
[22:40:50] <fabriceflorin>	 Keegan: I asked Daniel Schwen for guidance, since he is a bureaucrat on Commons. 
[22:40:54] * bawolff personally would not use speedy in this case
[22:40:58] <marktraceur>	 Surely there's something about coincidental use
[22:41:08] <bawolff>	 fabriceflorin: If its less then 5% then it may be de-minis
[22:41:16] <bawolff>	 less than 5% should definitely go to normal dr
[22:41:36] <Keegan>	 I'm pretty sure he's trying to make a point to fabriceflorin ;)
[22:41:52] * Keegan isn't suggesting it's appropriate
[22:41:52] <marktraceur>	 Ask in -commons maybe?
[22:42:12] <fabriceflorin>	 bawolff: Can you clarify what you mean by linking source to slide show? I usually try to include a link to the metrics meeting page where these slides are located.
[22:43:25] <bawolff>	 oh wait, i didn't read the deletion notice
[22:43:34] <fabriceflorin>	 Keegan: Yes, I think he may be upset about the Media Viewer roll out and is trying to get my attention. He has it now, but it doesn’t seem like a very productive way to engage people towards a civil conflict resolution. 
[22:44:14] <Keegan>	 fabriceflorin: Heh. Not exactly. I'll take it to PM
[22:44:21] <bawolff>	 He's saying, in the source you claimed you took the photo, you're in the photo so that can't be true, therefor someone else took the photo
[22:45:37] <fabriceflorin>	 bawolff: Oh, yeah, I think I gave my camera to the person sitting next to me, and asked them to take a few shots of our presentation as well, so we would be included in this photo document. Now I have to remember who took them. 
[22:45:37] <bawolff>	 Which he's not entirely wrong about. From a commons prespective, if someone else took the photo, then we need their permission to release it, not yours
[22:45:45] <marktraceur>	 Maybe it's fabriceflorin's EVIL TWIN in the photo!!!
[22:47:02] <fabriceflorin>	 This is the second time that Pete has come after me and try to delete my images. What’s sad about this is that taking photos of our meetings is not part of my job: I do this as my personal contribution to the movement. But Pete’s hostile behavior is making me reconsider posting any more photos on Commons, it’s just not worth the aggravation.
[22:47:22] <bawolff>	 fabriceflorin: I actually don't think this is some sort of passive-aggresive scheme to get back at you for media viewer, probably more of a really believing that we need the photographers release, and using automated scripts instead of just a nice personal message of "Please include who actually shot the photo"
[22:47:53] <tgr>	 fabriceflorin: maybe he just wants to help you experience the average new-uploader experience on Commons :)
[22:48:05] <tgr>	 in which case it is fairly accurate, sadly
[22:48:21] <bawolff>	 lol
[22:49:55] <fabriceflorin>	 bawolff: You could be right. But the impact on the recipient of these messages is quite disheartening. Today, I have a number of work assignments to complete before I can address this lower priority issue. So by the time I get home tonight, they will probably have been deleted. This leaves me kinda ”downtrodden and resigned", to quote Richard Stallman.
[22:50:20] <bawolff>	 Some of them already are deleted - https://commons.wikimedia.org/w/index.php?title=File:Wikimedia_December_Metrics_Meeting_-_Photo_06.jpg&action=edit&redlink=1
[22:50:44] <bawolff>	 But yes, if you can confirm permission from the original photographer, its pretty trivial to get them undeleted
[22:51:33] <fabriceflorin>	 bawolff: I just remembered who the photographer was: none other than our own tgr :)
[22:51:51] <Eloquence>	 sigh, screenshot copyright claims for wmf slides? what a waste of time
[22:52:30] <bawolff>	 tgr: So, do you give permission to release those photos that you took of the metrics meeting under cc-by-sa 3.0 ?
[22:52:39] <fabriceflorin>	 So I will include your name, Gergo, if that’s alll right with you. But I really can’t spend a lot of time on this, I have a lot of more pressing assignments to complete. I guess I will just let him delete them for now. Sad :(
[22:53:23] <Eloquence>	 next he's going to go after whether the words on the signs in https://commons.wikimedia.org/wiki/File:How_to_Make_Wikipedia_Better_-_Wikimania_2013_-_01.jpg are CC-BY-SA
[22:53:24] <fabriceflorin>	 bawolff: Yes, all WMF presentations are usually released under CC-BY-SA-3.0.
[22:53:50] <Eloquence>	 bawolff, the question is not about the photos but about the slides displayed on the screen
[22:53:59] <Eloquence>	 it's stupid nonsense waste of time copyright lawyering
[22:54:10] <bawolff>	 Eloquence: Some of them were about the photo, some of them were about the slides
[22:54:17] <bawolff>	 I don't disagree that this is a bit silly
[22:54:53] <Eloquence>	 don't we have a standard "work by WMF" permission template somewhere we can slap on these?
[22:56:13] <fabriceflorin>	 Anyway, I don’t want to detract from the more important issue, which is what to do about the RfC proposal. Keegan, let us know if you think we should chime in or just let the community respond to Pete directly. Also, would you like me to participate more on the MediaWiki discussion page? 
[22:56:45] <bawolff>	 {{WMF-staff-upload|<your name>}}
[22:57:14] <fabriceflorin>	 Eloquence: Thanks for suggesting a standard “work by WMF” template. Should we ask Philippe for guidance on this? Or someone else?
[22:59:42] <Keegan>	 fabriceflorin: No, no need to chime in. Community processes, all that. Sure, participate more on the MW.org page if you'd like. As for the staff template, see what bawolff just wrote
[23:00:17] <tgr>	 I can fix the images
[23:01:02] <fabriceflorin>	 keegan bawolff : Thanks for the guidance. Should I just add the {{WMF-staff-upload|<your name>}} at the top of the edit script and remove the speedy deletion notice? Then add a comment in the talk page to explain what I just did?
[23:02:02] <bawolff>	 Replace the <your-name> part with your actual name. The template should probably go in the permissions section of the image to be proper (doesn't matter much)
[23:02:27] <Eloquence>	 bawolff, I think Pete will still insist that slide authors be attributed, even if that template is added.
[23:02:28] <Eloquence>	 meh.
[23:02:43] <fabriceflorin>	 bawolff: Thanks. Is that an acceptable sustitute for the attribution credit?
[23:02:53] <bawolff>	 Eloquence: Arguably, its work for hire right?
[23:03:10] <Eloquence>	 this is an infinite regress. next he'll ask for attribution of the images that are used in the screenshot of the wikipedia mobile app in the slides by kenan.
[23:03:26] <fabriceflorin>	 bawolff: Yes, I was taking the picture during my work hours, even though it’s not technically part of my job.
[23:04:10] <bawolff>	 I mean for the presentation slides
[23:04:13] <Keegan>	 What Eloquence said. It's turtles all the way down
[23:04:13] <fabriceflorin>	 Eloquence: I have asked Daniel Schwen for guidance, since he is a bureaucrat on Commons. 
[23:05:00] <Eloquence>	 fabriceflorin, the "correct" thing to do would be to add the authorship of each slide displayed in photographs, and/or to trace down the specific authorship of each photograph not taken by you, and identify them as the authors, and identify the permission as CC-BY-SA due to work-for-hire by WMF.
[23:05:14] <Eloquence>	 Fun way to spend your evening :P
[23:06:39] <fabriceflorin>	 Eloquence: Yeah, I don’t think I can invest that kind of time. So I guess I will just let them be deleted. The pictures are all on Flickr, so we will still have them as reference. What saddens me most about this process is the amount of time that it’s taking to deal with this. We have so much more important work to do.
[23:06:43] <bawolff>	 fabriceflorin: Just for future reference, [[Category:Multimedia]] [[Category:Software]] shouldn't be added for these types of images
[23:08:42] <fabriceflorin>	 bawolff: Thanks, I stopped using these categories a few months ago, but the older photos still have them. Categories are sooo confusing to newcomers like me. We’re all used to tags on other multimedia sites, the current category system is very obscure and impenetrable to casual users.
[23:09:57] * Keegan once uploaded a picture of the sky and included Category:Air and as a result got a chastising on improper categorization and disrespecting Commons
[23:10:15] <Keegan>	 fabriceflorin: so it's not just newcomers :)
[23:10:15] <Keegan>	 Anywho
[23:10:19] <Keegan>	 Moving on
[23:11:26] <bawolff>	 fabriceflorin: Well 31 seconds ago Pete just thanked me for removing his speedy deletion template
[23:11:27] <fabriceflorin>	 Keegan: Yes, moving on. I now have to respond to important comments about multimedia metrics on the Engineering roadmap, then I will go chime in a bit on MW.org. Onward! 
[23:13:09] <fabriceflorin>	 bawolff: Go figure. Maybe all he wanted was attention. It all seems very passive-aggressive to me. But I really need to move on, or I won’t get anything else done today. Thanks so much for your kind advice today :).
[23:20:53] <bawolff>	 This all really brings to my attention the horrible amount of compression artifacts our pdf rendering has
[23:21:04] * bawolff wishes they were png thumbs
[23:30:02] <tgr>	 bawolff: can you test the embeds?
[23:30:32] <tgr>	 I looked at https://blog.wikimedia.org/2013/11/08/open-letter-free-access-wikipedia-south-africa/ and the first video still doesn't seem to work, the other ones look OK
[23:32:48] <bawolff>	 tgr: Hmm, the first one is literally the output of TMH for the normal site copy and pasted minus the javascript
[23:33:18] <bawolff>	 So its not surprising it doesn't work
[23:35:00] <tgr>	 bawolff: bug fixed, then?
[23:35:12] <bawolff>	 Looks fixed to me
[23:35:18] <bawolff>	 Of course I thought that last week
[23:35:56] <bawolff>	 Thanks for taking care of getting that swatted
[23:38:32] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: ?embedplayer=yes videos broken (again) - 10https://bugzilla.wikimedia.org/66143#c16 (10Tisza Gergő) 5PATC>3RESO/FIX Fix deployed to Commons, seems to work now. Thanks, Bawolff!  (The first video in https://blog.wikimedia.org/2013/11/08/open-letter-free-access-w...
[23:39:23] <fabriceflorin>	 bawolff: Looks good to me too on Mac Chrome and Firefox for all three links in the Bugzilla ticket, including this one: https://blog.wikimedia.org/2013/10/21/scientific-multimedia-files-get-a-second-life-on-wikipedia/ They don’t work on Safari, but that was to be expected, right? (We really should show some error messages to users of unsupported platforms, to let them know why the videos are not playing.)
[23:39:53] <bawolff>	 fabriceflorin: Hmm, we should be showing an error message. You don't see one?
[23:40:08] <bawolff>	 yes, not working on safari is to be expected
[23:40:16] <bawolff>	 Unless you have a severely out of date version of java
[23:41:36] * bawolff will have to test that next time I'm with a friend who has a mac
[23:42:37] <bawolff>	 fabriceflorin: Speaking of not working on safari, did you see http://lists.wikimedia.org/pipermail/multimedia/2014-June/000664.html
[23:42:47] <fabriceflorin>	 bawolff: If I click on the blog link above in Mac Safari, I get a blank black screen, with no error messages at all. If I click on this direct Commons link in Safari, I also get a black screen with no message: https://commons.wikimedia.org/wiki/File%3ACienciaaberta_gt2013_abertura.webm?embedplayer=yes (when I tried it earlier, it tried unsuccessfully to download the WebM file).  
[23:43:20] <bawolff>	 Umm, hmm. We are definitely supposed to have an error message
[23:44:53] <bawolff>	 fabriceflorin: Just to check, do you have java enabled? (To check, just go to https://tools.wmflabs.org/bawolff/video_test.htm and see what the Java on, and java mime available lines of the table say)
[23:45:56] <fabriceflorin>	 bawolff: yeah, I saw that message and liked the idea, but we’re so slammed with Media Viewer and preparing for Upload Wizard and Structured Data that I have no cycles left for video right now. So I haven’t had time to research the Cortado option, but in general I am in favor of enabling video for the 150 million users who can’t play videos on our site.
[23:47:22] <bawolff>	 fabriceflorin: so the tl;dr version of that email is - for $180, we can mark the cortado applet which we already use as signed, and then it will work in very roughly 80% of people who use safari or IE on the desktop
[23:49:12] <fabriceflorin>	 bawolff: Sounds like a good idea to me. I will respond now, with the caveat that I have not done due diligence to make sure Cortado is a viable long-term platform. But if the investment is only $180, seems like we should do it. I will respond to Faidon now. Thanks for summarizing this for me.
[23:50:18] <bawolff>	 I actually don't think we should use it long term. In the long term we should use ogv.js. But in the short term we already have cortado up and running, it basically just needs the "signed" flag to work in modern browsers
[23:59:53] <fabriceflorin>	 bawolff: OK, I just responded to Faidon. Thanks again for briefing me on this. :)