[00:03:43] (03PS4) 10Gergő Tisza: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 [00:04:31] (03CR) 10jenkins-bot: [V: 04-1] Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [01:03:54] (03PS5) 10Gergő Tisza: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 [01:09:22] (03CR) 10Gergő Tisza: "Not sure about all the test errors. They were in completely unrelated tests, I could reproduce them locally, but only on every second run " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [01:22:50] (03PS1) 10Gergő Tisza: Log clicks on the original file link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140627 [01:28:13] (03PS1) 10Gergő Tisza: Add original file clicks to the TSV data generation [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140629 [01:31:26] (03PS1) 10Gergő Tisza: Show original file view count on graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140630 [02:27:33] 3MediaWiki / 3File management: Enable the adding of rel="license" ; property="cc:attributionName" on File pages - 10https://bugzilla.wikimedia.org/27334#c2 (10Bawolff (Brian Wolff)) This is something we should perhaps look into doing. https://commons.wikimedia.org/wiki/Commons:Machine-readable_data is pretty... [04:03:18] (03PS1) 10Brian Wolff: Handle double tags properly (fix php warning about trim()) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140641 (https://bugzilla.wikimedia.org/66448) [04:10:22] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509 - 10https://bugzilla.wikimedia.org/66801#c1 (10Bawolff (Brian Wolff)) Any information on what page this warning was triggered from? [04:44:19] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509 - 10https://bugzilla.wikimedia.org/66801#c2 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #1) > Any information on what page this warning was triggered from? Nevermind... [05:00:42] (03PS1) 10Brian Wolff: Fix issue where getCommonMetaArray returned false instead of array() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140643 (https://bugzilla.wikimedia.org/66801) [05:01:39] (03PS2) 10Brian Wolff: Fix issue where getCommonMetaArray returned false instead of array() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140643 (https://bugzilla.wikimedia.org/66801) [05:21:55] (03PS1) 10Brian Wolff: Fix warning in case no streams are decodable. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140645 [05:46:55] (03PS6) 10Gergő Tisza: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 [06:00:00] (03CR) 10Gergő Tisza: "Turns out the errors went away because I accidentally commented out a tipsy call, so mystery solved." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [06:22:53] (03CR) 10Gergő Tisza: "There are a bunch of whitespace errors in the test; I am fixing them in the next changeset, because keeping a changeset which has multiple" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [06:32:43] (03PS1) 10Gergő Tisza: Display opt-out/opt-in events [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140657 [06:32:53] (03PS1) 10Gergő Tisza: Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 [06:37:16] (03PS1) 10Gergő Tisza: Collect data for opt-in/opt-out events [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140659 [07:15:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [07:17:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140645 (owner: 10Brian Wolff) [08:17:21] (03CR) 10Gilles: [C: 032] Change "learn more" to "more details about this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138303 (owner: 10Gergő Tisza) [08:17:55] (03Merged) 10jenkins-bot: Change "learn more" to "more details about this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138303 (owner: 10Gergő Tisza) [08:27:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/139295 (owner: 10MarkTraceur) [08:27:51] (03CR) 10Gilles: [C: 032] Log clicks on the original file link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140627 (owner: 10Gergő Tisza) [08:28:24] (03Merged) 10jenkins-bot: Log clicks on the original file link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140627 (owner: 10Gergő Tisza) [08:33:54] (03PS7) 10Gilles: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:37:50] (03PS8) 10Gilles: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:38:12] (03CR) 10Gilles: Make optout link more AJAXy (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:38:27] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Thanks for the fixes. 1 issue remaining." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:38:54] (03CR) 10Siebrand: Make optout link more AJAXy (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:39:33] (03CR) 10Gilles: "Which i18n issue remains?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:40:41] (03CR) 10Gilles: "Nevermind, you posted the inline comment just when I asked what was wrong." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:42:09] (03PS9) 10Gilles: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [08:46:36] (03PS2) 10Pginer: Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [08:46:39] (03CR) 10jenkins-bot: [V: 04-1] Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [08:53:46] (03CR) 10Pginer: "I updated the position of the chevron which was misaligned." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [08:56:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [09:01:20] (03CR) 10Gilles: [C: 032] Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [09:01:56] (03Merged) 10jenkins-bot: Make optout link more AJAXy [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140259 (owner: 10Gergő Tisza) [09:04:26] (03CR) 10Pginer: "For consistency I think it is better to keep the metadata panel actions on fullscreen. To properly support that, the needed change would b" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [09:05:59] (03PS1) 10Gilles: Fix typo in i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140670 [09:06:19] (03CR) 10Gilles: [C: 032] Fix typo in i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140670 (owner: 10Gilles) [09:06:54] (03Merged) 10jenkins-bot: Fix typo in i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140670 (owner: 10Gilles) [09:16:18] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer: Usage of non-standard date format parsing with Moment.js is deprecated - 10https://bugzilla.wikimedia.org/66635#c2 (10Mormegil) (In reply to Tisza Gergő from comment #1) > As for the warning itself, > there doesn't seem to be a way to suppress it w... [09:20:40] (03PS2) 10Gilles: Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 (owner: 10Gergő Tisza) [09:21:13] (03CR) 10jenkins-bot: [V: 04-1] Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 (owner: 10Gergő Tisza) [09:23:07] (03PS3) 10Gilles: Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 (owner: 10Gergő Tisza) [09:24:45] (03CR) 10Gilles: [C: 032] Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 (owner: 10Gergő Tisza) [09:26:29] (03Merged) 10jenkins-bot: Track optin/optout events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140658 (owner: 10Gergő Tisza) [10:04:08] (03CR) 10Gilles: [C: 032] Add above-fold filepage link to stats fields [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140263 (owner: 10Gergő Tisza) [10:04:12] (03CR) 10Gilles: [C: 032] Add original file clicks to the TSV data generation [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140629 (owner: 10Gergő Tisza) [10:04:15] (03Merged) 10jenkins-bot: Add above-fold filepage link to stats fields [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140263 (owner: 10Gergő Tisza) [10:04:18] (03CR) 10Gilles: [C: 032] Collect data for opt-in/opt-out events [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140659 (owner: 10Gergő Tisza) [10:04:21] (03Merged) 10jenkins-bot: Add original file clicks to the TSV data generation [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140629 (owner: 10Gergő Tisza) [10:04:24] (03Merged) 10jenkins-bot: Collect data for opt-in/opt-out events [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/140659 (owner: 10Gergő Tisza) [11:40:22] (03CR) 10Gilles: [C: 032] Add click tracking for the above-the-fold file page link [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140264 (owner: 10Gergő Tisza) [11:42:04] (03CR) 10Gilles: [C: 032] Show original file view count on graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140630 (owner: 10Gergő Tisza) [11:42:33] (03CR) 10Gilles: [V: 032] Add click tracking for the above-the-fold file page link [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140264 (owner: 10Gergő Tisza) [11:43:07] (03CR) 10Gilles: [V: 032] Show original file view count on graph [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140630 (owner: 10Gergő Tisza) [11:43:45] (03CR) 10Gilles: [C: 032 V: 032] Display opt-out/opt-in events [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140657 (owner: 10Gergő Tisza) [12:04:18] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in FormatMetadata.php on line 104 - 10https://bugzilla.wikimedia.org/66802 (10Andre Klapper) p:5Unprio>3Normal [12:04:33] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509 - 10https://bugzilla.wikimedia.org/66801 (10Andre Klapper) p:5Unprio>3Normal [13:05:37] (03PS2) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [13:05:57] (03CR) 10Rillke: Create title in file NS and validate as such (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [13:50:38] (03PS1) 10Gilles: Add the new metrics to the graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140710 [14:08:39] (03CR) 10Gilles: [C: 032 V: 032] Add the new metrics to the graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/140710 (owner: 10Gilles) [14:15:13] (03CR) 10Gilles: "Pau, you should try each action when in fullscreen mode. Some can be a bit strange, for example "download" will exit fullscreen mode (I be" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [14:17:06] (03CR) 10Gilles: "I think the issue Pau is that for that particular icon, visually the square part of it is what we expect to be aligned. It's not the case " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [14:51:38] (03PS2) 10Gilles: Fix jquery.client dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137907 [15:00:06] (03PS3) 10Gilles: Fix jquery.client dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137907 [15:01:15] (03PS5) 10Gilles: Fix ?embedplayer=yes mode, which is currently totally broken [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [15:02:51] (03CR) 10Gilles: [C: 032] Fix ?embedplayer=yes mode, which is currently totally broken [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [15:13:22] * marktraceur waves from Seattle [15:13:34] I'll be joining the meeting from J-Mo's house then going to The Hub [15:16:03] (03PS2) 10Gilles: Handle double tags properly (fix php warning about trim()) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140641 (https://bugzilla.wikimedia.org/66448) (owner: 10Brian Wolff) [15:16:36] (03CR) 10Gilles: [C: 032] Handle double tags properly (fix php warning about trim()) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140641 (https://bugzilla.wikimedia.org/66448) (owner: 10Brian Wolff) [15:16:44] (03Merged) 10jenkins-bot: Handle double tags properly (fix php warning about trim()) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140641 (https://bugzilla.wikimedia.org/66448) (owner: 10Brian Wolff) [15:18:06] (03PS3) 10Gilles: Fix issue where getCommonMetaArray returned false instead of array() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140643 (https://bugzilla.wikimedia.org/66801) (owner: 10Brian Wolff) [15:18:25] (03CR) 10Gilles: [C: 032] Fix issue where getCommonMetaArray returned false instead of array() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140643 (https://bugzilla.wikimedia.org/66801) (owner: 10Brian Wolff) [15:18:31] (03Merged) 10jenkins-bot: Fix issue where getCommonMetaArray returned false instead of array() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140643 (https://bugzilla.wikimedia.org/66801) (owner: 10Brian Wolff) [15:20:34] (03CR) 10Gilles: [C: 032] Fix warning in case no streams are decodable. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140645 (owner: 10Brian Wolff) [15:20:42] (03Merged) 10jenkins-bot: Fix warning in case no streams are decodable. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140645 (owner: 10Brian Wolff) [16:21:33] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in FormatMetadata.php on line 104 - 10https://bugzilla.wikimedia.org/66802 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [16:21:48] 3MediaWiki / 3File management: Warning: Invalid argument supplied for foreach() in MediaHandler.php on line 509 - 10https://bugzilla.wikimedia.org/66801 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [16:22:18] marktraceur: https://www.surveymonkey.com/results/SM-6N66NXL8/data-trends/ [16:22:46] the dropoff is sharper for en/de IIRC [16:25:57] (03PS1) 10Cmcmahon: QA: update Ruby gems [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/140729 [16:26:39] OK thanks tgr [16:28:45] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/140729 (owner: 10Cmcmahon) [16:29:08] (03Merged) 10jenkins-bot: QA: update Ruby gems [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/140729 (owner: 10Cmcmahon) [16:58:20] 3MediaWiki extensions / 3TimedMediaHandler: Distorted thumbnail for audio files - 10https://bugzilla.wikimedia.org/66852 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None When querying the API for audio thumbnails (yeah, appears to be stupid ...) it returns a height and width in a... [17:03:23] (03CR) 10Brian Wolff: [C: 032] Fix jquery.client dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137907 (owner: 10Gilles) [17:03:32] (03Merged) 10jenkins-bot: Fix jquery.client dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137907 (owner: 10Gilles) [17:03:37] (03Merged) 10jenkins-bot: Fix ?embedplayer=yes mode, which is currently totally broken [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [17:06:33] marktraceur: Do you have a better sense of when and how the deployment to all wikis will take place today? What needs to be done on your end? [17:06:56] fabriceflorin: It's scheduled as part of the train, I'm asking if we need to do it separately [17:07:45] marktraceur: Thanks, please keep us posted, so we know when to test and announce the deploy. Keegan in particular will be interested in these answers, as well as yours truly. [17:09:33] 3MediaWiki extensions / 3TimedMediaHandler: Distorted thumbnail for audio files - 10https://bugzilla.wikimedia.org/66852#c1 (10Bawolff (Brian Wolff)) I guess its returning the width/height of the JS player, but then outputting the url for file icon which really isn't used. Maybe it should be outputting http... [17:10:00] * Keegan is just riding the Ferris Wheel [17:10:22] Keegan: Bueller [17:10:53] marktraceur: That's Fabrice up on the float, not I! [17:11:14] Heh. [17:15:19] 3MediaWiki extensions / 3TimedMediaHandler: sign cortado applet so that it works for people with outdated java - 10https://bugzilla.wikimedia.org/60287#c2 (10Bawolff (Brian Wolff)) >There's a signed version at http://theora.org/cortado.jar In some security settings, the permissions attribute is also require... [17:16:54] I actually like Ferris wheels. My standard user profile photo was taken from atop a Ferris wheel above the Marin wetlands: https://twitter.com/fabriceflorin [17:31:18] (03PS4) 10Gergő Tisza: Fullscreen improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 [17:35:36] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Exiting full screen using Firefox on a Mac exits the browser from full screen - 10https://bugzilla.wikimedia.org/66854 (10Keegan Peterzell) 3NEW p:3Unprio s:3normal a:3None This bug occurs using Firefox and Mac OS X. I am using Firefox 30.0/OS... [17:37:00] Feel free to retitle that bug [17:42:43] Keegan: Wait - full screen like F11 full screen? [17:42:48] Or like "Full screen mode" [17:43:50] f11 [17:44:03] The bad boy takes up e'rything mode [17:45:43] * marktraceur tests [17:45:55] Whoa cool [17:45:59] Repro'd on gnu/linux [17:46:19] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer: Usage of non-standard date format parsing with Moment.js is deprecated - 10https://bugzilla.wikimedia.org/66635#c3 (10Tisza Gergő) (In reply to Mormegil from comment #2) > The current functionality allowing to do moment('4 3 2000') and expecting a... [17:49:03] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Exiting full screen using Firefox on a Mac exits the browser from full screen - 10https://bugzilla.wikimedia.org/66854#c1 (10Mark Holmquist) Interesting. Reproduced on GNU/Linux Firefox, not sure about other browsers right now. [17:52:34] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Exiting full screen using Firefox on a Mac exits the browser from full screen - 10https://bugzilla.wikimedia.org/66854#c2 (10Keegan Peterzell) (In reply to Mark Holmquist from comment #1) > Interesting. Reproduced on GNU/Linux Firefox, not sure about o... [17:55:18] Hey marktraceur : Any updates on when Media Viewer will be deployed on all wikis? Anything we can do on our end to support you? [17:56:43] I'm...um [17:56:55] fabriceflorin: greg-g says separation is good, but also is fine with it going out on the train [17:57:01] So probably in the next hour. [17:57:05] I'll ping you when I see it go. [17:57:16] marktraceur: Cool, thanks. [18:08:07] marktraceur: will you be around for code review in an hour or two? I need to backport stuff today, our chevron just disappeared [18:08:28] tgr: Yeah; I'll be at lunch about 12:00-13:00 but will be back then [18:08:34] It can definitely get merged before SWAT [18:08:52] Where did the chevron go? :/ [18:09:40] cool [18:09:57] I'm going to start on CR now; looks like we have a big ol' backlog [18:10:03] it's white now if you are a new user, which doesn't exactly jump out [18:10:21] we deployed some patches in the wrong order or wrong grouping or something [18:11:03] Weird. [18:11:03] (03PS1) 10MarkTraceur: WIP stripebuttons addition hook [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140760 [18:11:04] (it will be nice to have icon fonts) [18:11:23] (03CR) 10jenkins-bot: [V: 04-1] WIP stripebuttons addition hook [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140760 (owner: 10MarkTraceur) [18:11:26] marktraceur: Is there anything we can do to troubleshoot issues about the release to all wikis while you’re away at lunch? [18:11:28] (03PS5) 10MarkTraceur: Fullscreen improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [18:11:40] (03CR) 10MarkTraceur: "Needs a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [18:12:00] fabriceflorin: Just check that things work on all the different projects [18:12:16] Wikitravel, Wikibooks, and...maybe Wikiversity. [18:12:28] Ooh, wikiquote and wiktionary may be trouble too. [18:12:41] You could probably just check the english ones if you're pressed for time. [18:14:37] (03CR) 10Gergő Tisza: "I removed the hiding of the right-side buttons. I think the rest of the functional changes should be pretty uncontroversial:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [18:15:42] ITT REEDY GETS NETSPLIT DURING THE DEPLOY [18:16:15] * marktraceur sips coffee [18:19:05] marktraceur: Thanks, can you clarify the note about ITT REEDY GETS NETSPLIT? [18:19:34] fabriceflorin: Freenode is behaving weird and Reedy got disconnected during the deploy [18:19:37] Fun times. [18:19:47] * Keegan rides the netsplit [18:20:04] Also, marktraceur, deploy Media Viewer to WikiTravel. I DARE YOU :P [18:20:15] Keegan: You gon' get suuuuued [18:20:31] marktraceur: Ooh, sorry to hear that. Should we be going to a different IRC chat room to communicate with Reedy? How do we do that? [18:20:42] I'm communicating with him just fine [18:20:43] Such as it is [18:21:14] Don't worry about it too much, he's back now [18:22:00] marktraceur: Cool. Just to make sure I understand, are we essentially removing Media Viewer from Beta Features, making it available everywhere? Or is there another special technical step involved in this deployment we should know about? [18:22:19] No, that's about it [18:23:11] fabriceflorin: Freenode works on a distributed server system. Sometimes some of the servers split off sharing communications, a "netsplit." It takes a moment for the servers to get back together. It's a common IRC problem [18:23:42] marktraceur: Got it. Also, what types of issues should we prepare for on Wikitravel, Wikibooks, Wikiquote and Wiktionary? [18:23:49] It's like IRC splits into two separate Schrodinger-like universes [18:23:58] My god you guys [18:24:00] Wikivoyage [18:24:24] Keegan: Thanks for the clarification. Will you be available to help test all these sites when they deploy? How should we divvy up the work? [18:24:42] fabriceflorin: I don't know what kinds of issues, those are just the ones I thought of that might be trouble [18:24:51] Ideally you'd hit at least one of every kind of wiki [18:25:04] I mean, ideally you'd hit every wiki, but I want you to have time this month to sleep, eat, etc. [18:25:10] Keegan: Also, should we plan to make a few announcements on the largest wikis that haven’t been enabled yet, so they know where to go to leave feedback? Or just let the built-in tools in Media Viewer direct them to us? [18:25:21] marktraceur: we've been on English Wikivoyage for a couple of months, all has been well [18:25:36] Rschen would have informed me otherwise. With a polite slap. [18:25:38] Oh, right, I forgot [18:25:55] Books should be okay, so should 'versity [18:26:08] Wiktionary might get weird [18:26:58] fabriceflorin: uuuhhhhh I can whip together a mass message target list of some of the biggers, if you'd like [18:27:02] After I make lunch [18:27:16] fabriceflorin: you just write a couple simple English paragraphs [18:27:23] I'll send it out and sign your name [18:27:27] Or we can not do that. [18:27:37] Keegan: Sounds good. I will send you a paragraph shortly. [18:28:00] marktraceur: What’s the latest ETA for deployment? [18:28:01] Yeah, one paragraph is good. [18:28:29] fabriceflorin: Reedy hasn't acknowledged my ping, but that's not necessarily cause for concern [18:28:35] Probably 12:00-12:15 [18:29:15] fabriceflorin: Watch for logmsgbot messages that say something like "Finished scap" and then check if enwikibooks has the media viewer. [18:29:23] Clear your cache etc [18:30:48] marktraceur: Thanks. tgr , can you keep an eye on the launch with Keegan and I around 12:00-12:15, so we have an engineering perspective on all this, while Mark is at lunch? [18:31:47] marktraceur: will the logmsgbot messages be here on the multimedia channel? or in operations? or some other place? [18:33:26] In -operations [18:34:43] marktraceur: Thanks! I’ll keep the ops window open then. [18:35:08] (03CR) 10Gergő Tisza: "It's a CSS issue (not related to the patchset), I'll fix." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [18:53:31] tgr: What does & { do in less? [18:53:50] & is replaced by the parent selector [18:53:53] Ah. [18:54:02] That's handy stuff [18:54:40] can be used without the space as well, like &:hover [18:54:52] very cool feature [18:55:11] Yeah, I knew about &:hover, I didn't know it would replace it anywhere [18:55:27] I guess it makes more sense than trying to make sense of the selector lexically [18:55:50] they do it to some extent [18:56:13] .foo, .bar { body.no-js & {} } [18:56:32] this will end up as .foo, .bar { body.no-js .foo, body.no-js .bar {} } [18:56:53] (03CR) 10MarkTraceur: [C: 032] Fullscreen improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [18:57:10] tgr: Right [18:57:29] (03Merged) 10jenkins-bot: Fullscreen improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [19:01:35] fabriceflorin: we'll be messaging these wikis, then: https://meta.wikimedia.org/wiki/User:Keegan_(WMF)/MassMessage/Multimedia/Media_Viewer [19:02:21] Thanks, that’s great. I am almost done with my message, will send it to you shortly. [19:05:08] Odd. I can't find a Western browser that supports Dhivehi script. Lame. [19:05:11] OK, we have an ACK from Reedy that he's dealing with the deploy. [19:05:16] No one ever thinks of the Maldives. [19:05:24] I suspect he'll do it after the second scap for wmf9. [19:05:45] Er, the scap for wmf9, which is the third today, but the second effectual one today. [19:06:04] While he's doing that, I will be finding noms. [19:26:55] fabriceflorin: Message looks good. I'm going to add links to take the survey in French and Spanish as well [19:30:04] Keegan: Good idea, thanks. [19:33:12] Keegan: I did some major updates to the Help FAQ yesterday, but have not yet added icons yet. I was hoping to do before asking folks to translate it. Do you think we can wait another hour or so to do that work, or should we ask for translations right away with the current text? [19:33:33] It can wait [19:33:44] Translators are not instant coffee :) [19:35:15] Keegan: Thought so, but wanted to make sure we’re not holding things up. I like your apt analogy :) [19:36:26] Plus there's the fun fact that by the time most delopys finish in SF, 2/3 of the world is afk for the night/morning [19:41:50] Good point. Still, I’m getting started now, so we can wrap this up in the next hour or two. [19:47:11] (03PS3) 10Gergő Tisza: Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 [19:51:23] Keegan: Are we also posting on the ‘Village Pumps’ of the large Wikipedias? I’m thinking of zh, hi, ar, ms, id, for example. I couldn’t easily find their links on your mass message list. [19:51:36] http://stats.wikimedia.org/EN/Sitemap.htm [19:52:27] Yes. They are alphabetical by language code in my list [19:52:48] ويكيبيديا:سفارة [at] ar.wikipedia.org [19:52:57] For example :) [19:54:27] Keegan: OK, thanks. I was searching for zh.wikipedia and couldn’t find it. Just wanted to confirm. I will be testing on these large sites first, before going to the sister projects. [19:56:47] (03CR) 10Gergő Tisza: [C: 04-1] "metadata panel is too wide in fullscreen." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 (owner: 10Gergő Tisza) [19:57:48] Project:互助客栈/消息 [at] zh.wikipedia.org :D [19:59:04] fabriceflorin: FYI the ops/platform folk are recovering from a cluster outage, I would not push them [20:00:22] (also I'm back) [20:00:26] tgr: Get lunch! [20:01:15] (03CR) 10Gergő Tisza: "> To properly support that, the needed change would be to avoid the metadata panel to fade out if the share panel is open." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140240 (owner: 10Gergő Tisza) [20:03:25] thx, marktraceur, off to lunch [20:03:39] tada! [20:14:28] marktraceur keegan : we’re back …. with chinese takeout from around the corner :) Did we miss anything exciting? [20:14:33] Nice [20:14:48] Nothing changed in the past ten minutes, -ops is trying to sort it all out before moving [20:15:46] ok, no rush, it’s great to have our hands free to consume the food :) [20:16:29] *nod* [20:16:35] I'm doing the frantic channel [20:16:38] -watching for you [20:26:24] marktraceur: Thanks. Did you have a nice drive to Seattle? How’s the weather? [20:26:38] 14 hours is a long ass time [20:26:41] But yeah, it was OK [20:26:51] The weather is fine here, we had a nice outdoor lunch just now [20:27:32] Cool. Yeah, America is a LARGE country. Driving 14 hours will soon become second nature :) [20:28:22] I've done 2 13 hour days in a row before, that's not a problem [20:28:31] I'm just not as young as I was then, I guess [20:28:52] Turns out 2-ish years of sitting on your ass and programming takes a physical toll, who knew [20:29:15] I know people looked at me funny when I told them I was hitchhiking across the country to California. But that worked out fine, did it in 3 days. [20:29:34] Hitchhiking is a whole different bag of crazy [20:30:15] Well, that was 38 years ago … when it was still part of the culture. [20:30:24] *nod* [20:30:35] We saw some kids hitchhiking just outside of Portland actually [20:30:46] But it's definitely not a thing you do these days, for a variety of reasons [20:31:46] Yeah, times change … OK, back to the FAQ. It’s nice to have that breathing room, actually. [20:31:53] robla: I foresee us postponing our 1:1 [20:32:38] marktraceur: yeah, does tomorrow work for you? [20:33:20] I can still do it today, but I'm assuming you're going to want the time today too [20:33:32] robla: I'll be on the road, but if you want to do it by phone (while I'm in a car with others) we can do that [20:34:30] robla: Or later today [20:53:41] robla: Actually if you're able to do it now, I can [20:53:47] I'll just keep half an eye on -ops [20:53:58] Or at 14:00 or whatever. [21:05:51] marktraceur: how does 3:30pm sound? [21:06:56] Sure [21:15:29] (03PS4) 10Gergő Tisza: Make the metadata panel opening affordance more obvious [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140247 [21:17:48] marktraceur: ^^ large-ish patch, if you could review it before the SWAT that would be cool [21:18:16] otherwise I can just revert the chevron icon change in that branch, so not super critical [21:18:40] I was just going to merge the globalusage change... [21:18:50] tgr: Do we want Krinkle|detached to finish reviewing IwTitle? [21:18:57] It looks like thedj is kind of assenting [21:19:36] Krinkle did not seem happy with the concept [21:20:01] Which means...we should merge it now before he has a chance to -2? :P [21:20:05] I can rework it, but making it into something very simple that does not match the signature of Title does not make sense to me [21:20:07] OK I'll let him have his say [21:20:11] And block the card for now [21:20:35] (03CR) 10MarkTraceur: [C: 031] Fix URL handling for global usage list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/138999 (https://bugzilla.wikimedia.org/63908) (owner: 10Gergő Tisza) [21:21:58] fabriceflorin: We should be out now [21:22:08] Fingers crossed the cluster doesn't crash again [21:23:15] marktraceur: Cool, I’m on it. Keegan, I’ll start with the big wikis first (zh, ar, hi, id, etc), then move on to the sister wikis next. [21:25:11] You're just random sampling the small wikis, right? [21:25:29] I don't desire to manually check 900+ wikis [21:25:31] Or the time [21:26:19] Keegan: if it's about discussions, you should ask the tech ambassadors for help [21:26:55] Keegan: Yeah, just random samples. [21:27:29] Cool. [21:27:46] tgr: I will email the techambassadors after Keegan makes the mass announcement. That will happen in about 30 mins., after we’ve confirmed that we didn’t break anything major :) [21:27:47] tgr: <3 tech ambassadors [21:28:42] doesn't seem to be working yet, though [21:29:19] fabriceflorin: I altered some of the language that promoted the survey results, since that line of point hasn't been working so well. It's now "The tool has been tested extensively across all Wikimedia wikis over the past six months as a Beta Feature and has been released to the largest Wikipedias, all language Wikisources, and the English Wikivoyage already." [21:30:28] marktraceur Keegan : Is it just me, or is the Indonesian Wikipedia not showing Media Viewer for you too? https://id.wikipedia.org/wiki/Halaman_Utama [21:30:54] Works for me - https://id.wikipedia.org/wiki/Somme [21:31:06] They probably cock up the main page images somehow, we've seen that before [21:31:46] marktraceur: Yeah, that image worked for me. Must be a main page issue, as you point out. Works well on Hindi Wikipedia too. [21:32:09] We've never had any issue with wikipedias [21:32:20] Apart from community-solvable ones anyway [21:32:20] marktraceur, fabriceflorin Yeah if the Main Page image is cascaded transclusion protected, it doesn't show up with Media Viewer [21:32:51] I noticed that with en.wiki a couple of weeks ago and mentally triaged it to minor at the time [21:32:56] Keegan: The language change is fine. I trust your instincts. [21:33:40] Keegan: Looks good on all the large wikis I just tested (zh, ar, hi, in). Moving on to the sister projects now. [21:33:48] 3MediaWiki extensions / 3MultimediaViewer: Mediaviewer scrolling issue while using the Monobook skin. - 10https://bugzilla.wikimedia.org/66810#c2 (10Excirial) 5NEW>3RESO/FIX Seems fixed - after the little hiccup on the deployment of 1.24wmf10 i cannot seem to reproduce this issue anymore on any browser w... [21:34:49] marktraceur: Did you notice that the Chinese Wikipedia seems to be displaying a very elegant font for the info below the image: https://zh.wikipedia.org/wiki/Wikipedia:%E9%A6%96%E9%A1%B5#mediaviewer/File:TD_Ten_21_sept_2007_1650Z.jpg [21:35:13] fabriceflorin: Some wikis have different fonts, yeah [21:36:12] marktraceur : Also, it seems like the Commons icons are still miniscule on zh, ar and other sites. I thought we had fixed that. :( [21:36:25] I really like http://en.brickimedia.org/wiki/10242_MINI_Cooper_MK_VII#mediaviewer/File:10242%20box.jpg too [21:36:31] They have some neat fonts [21:36:41] Ugh, I thought we had too. [21:36:49] Maybe it's a wmf10 fix [21:38:28] Or maybe our logic didn't do the trick. Sec [21:39:37] WTF I thought we fixed this [21:39:54] Why do I feel dirty after spending only a few minutes in WikiTravel? Could it be that all the ads on that site are overwhelming? In any case, I can’t seem to get Media Viewer to work there: http://wikitravel.org/en/Hong_Kong/Eastern_Hong_Kong_Island [21:40:19] fabriceflorin: That's because we don't run Wikitravel [21:40:22] Wikivoyage. [21:40:55] Oh, I thought you guys had said to check Wikitravel. Maybe you were just kidding … [21:41:34] Yeah, that was super much a joke [21:42:50] fabriceflorin: to be fair, at least now you see why the community jumped ship ;) [21:43:17] (03PS1) 10Brian Wolff: Avoid double processing