[00:12:04] (03CR) 10MarkTraceur: "Patch incoming" (037 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [00:12:36] (03PS20) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [00:23:12] tgr: Do you think that #636 will make it for tomorrow’s release? Can I help test it today? [00:26:05] It's still in CR [00:26:09] So probably unlikely [00:41:49] fabriceflorin: I will probably have time to review it in the evening [00:41:57] if not, gi11es probably will [00:42:05] I doubt it needs much testing [00:43:24] tgr: Thanks. Let me know if I can do anything. What about #665? Can that one get reviewed too? [00:44:21] oh, I mixed up the two [00:44:50] so #665 will get review, it's a very simple patch [00:45:16] not so sure about #636, I'll try to fix it tonight though [00:46:28] tgr: Yeah, I was talking about #636 Fix bug where license details from different licenses get mixed up. The Germans are particularly concerned about that one, as well as #567 Handle multiple licenses — I told them #567 didn’t make it, but #636 may make it in time for their release. [00:54:41] 3MediaWiki extensions / 3MultimediaViewer: MultimediaViewer should not display hidden categories, or give them lesser priority - 10https://bugzilla.wikimedia.org/62277#c1 (10Arnold Reinhold) More to the point, I and other s believe all visible Commons categories should be displayed in the viewer. There have... [06:49:58] hey tgr, when you have a moment, do you know who is reviewing gwtoolset code this week? [07:40:50] marktraceur: I'm usually very careful about trailing commas, I've be burned by those before. where was the offending one in mmv? [07:41:21] I thought jshint caught those, maybe we shoudl configure it to do so if it's an option that needs to be turned on [07:41:40] ah, nvm, saw that you found the option [07:43:36] (03CR) 10Gilles: [C: 032] Make JSHint enforce ES3 compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135955 (owner: 10Gergő Tisza) [07:44:30] (03Merged) 10jenkins-bot: Make JSHint enforce ES3 compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135955 (owner: 10Gergő Tisza) [08:43:31] (03CR) 10Gilles: [C: 032] Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 (owner: 10MarkTraceur) [08:43:33] (03CR) 10jenkins-bot: [V: 04-1] Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 (owner: 10MarkTraceur) [08:45:26] 3MediaWiki extensions / 3PagedTiffHandler: Need error message and/or better design for thumbnails broken due to megapixel limit - 10https://bugzilla.wikimedia.org/62306#c5 (10Bawolff (Brian Wolff)) 5PAT>3RES/FIX Calling this fixed as there now actually is an error (look for it on commons on tuesday). For... [08:46:59] (03PS2) 10Gilles: Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 (owner: 10MarkTraceur) [08:48:49] (03CR) 10Gilles: [C: 032] Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 (owner: 10MarkTraceur) [08:49:21] (03Merged) 10jenkins-bot: Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 (owner: 10MarkTraceur) [10:36:43] (03CR) 10Gilles: [C: 04-1] "The QUnit tests are failing quite badly, is it caused by that change? Any objection to making qunit voting?" (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [14:40:05] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [15:22:55] (03CR) 10Krinkle: [C: 04-1] "-1 for binding deferred methods." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [16:10:42] (03CR) 10Krinkle: Massive refactor (037 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [16:11:27] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [16:11:36] Krinkle: Thanks for being super helpful on the review for that big ol' patchset. [16:11:48] yw :) [18:10:59] WPs going to wmf6 soon [18:11:07] Reedy just merged the change. [18:43:43] marktraceur: who is the person for upload wizard ? [18:46:14] "the person"? I guess that's me. Wow, how did that happen [18:46:21] matanya: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you? [18:48:21] well, i know it is best, but wasn't sure it is the right place to ask. to the point. I have a suggestion: [18:49:26] when uploading large files UW waits with publishing until all encoding and scaling is done before notifying you it is done [18:50:02] i have tested this with unexperienced user today, and they were all sure the uploading died [18:50:46] and gave up / refreshed. They didn't think of going to the file page and looking if it was in fact uploaded [18:51:34] I think it would be best to continue to the publishing phase once the original was uploaded if that is technically possible [18:51:56] and continue scaling in backround [18:52:15] marktraceur: does this make any sense to you ? [18:54:50] * marktraceur reads [18:55:13] matanya: Maybe [18:55:37] matanya: I haven't dealt a lot with the chunked upload backend bits; not sure if it's technically feasible to start the last part of the process before the upload is done [18:56:04] should i file a bug ? [18:57:11] Hm, it sounds like that might be useful [18:58:04] thanks marktraceur [19:19:03] matanya: Thanks for sharing this recommendation to improve upload wizard. It is very timely, as we are just now planning next year’s work, which will focus on upload wizard and structured data. We won’t have any immediate solutions for you, but I will make sure to add this request to our wishlist, as product manager for multimedia. Can you please share the bug number with us when you file it? Thanks again, and be well :) [19:20:06] thank you very much for your response fabriceflorin i havn't filed it yet, will update shortly [19:23:37] Sounds great. Thanks for finding us and pointing us towards this issue. I suspect this will require a number of improvements, but it is our goal to make this whole upload pipeline smoother through a variety of ways. We aim to fix some chunked uploads bugs this summer, and tackle metadata-related issues in the fall (for letting you enter descriptions while the file uploads). So we may be able to address your specific request around [19:23:37] that time, if feasible. [19:24:27] fabriceflorin: https://bugzilla.wikimedia.org/show_bug.cgi?id=65909 [19:24:32] 3MediaWiki extensions / 3UploadWizard: Scale images/ video in the backround and publish immediately - 10https://bugzilla.wikimedia.org/65909 (10matanya) 3NEW p:3Unprio s:3normal a:3None when uploading files UW waits with publishing until all encoding and scaling is done before notifying the user the... [19:25:30] 3MediaWiki extensions / 3UploadWizard: Scale images/ video in the backround and publish immediately - 10https://bugzilla.wikimedia.org/65909 (10Fabrice Florin) p:5Unprio>3High [19:27:43] Thanks, matanya ! We’re now reviewing all of last year’s upload wizard feedback, and are logging many similar concerns here: http://ur1.ca/heohg But it’s helpful to add your bug to the list, to help us prioritize which issues to take on first. Much appreciated :) [19:39:16] 3MediaWiki / 3File management: Multilanguage SVG images should be rendered in the wiki's content language - 10https://bugzilla.wikimedia.org/61649#c4 (10C. Scott Ananian) Bug 58920 points out that the browser implementation of the "lang" option is inconsistent. In theory, embedding an SVG in a page with the... [19:45:46] 3MediaWiki extensions / 3UploadWizard: Scale images/video in the background and publish immediately - 10https://bugzilla.wikimedia.org/65909 (10Andre Klapper) [19:53:30] 3MediaWiki extensions / 3MultimediaViewer: media viewer doesn't preserve thumbnail options like svg language - 10https://bugzilla.wikimedia.org/58663#c7 (10C. Scott Ananian) See also bug 58920, which quibbles with the desired semantics of 'systemLanguage'. [19:57:45] 3MediaWiki / 3File management: SVG images with a specified width should not get rendered into PNG thumbnails that are bigger - 10https://bugzilla.wikimedia.org/63914#c3 (10C. Scott Ananian) I think this is a WONTFIX. The Parser clearly allows SVGs to be rendered above their native resolution, and that is ex... [20:00:01] 3MediaWiki / 3File management: Serve thumbnails even for the original size of a jpeg or png - 10https://bugzilla.wikimedia.org/65383#c5 (10C. Scott Ananian) I think the opposite happens as well: the thumbnailer currently screws up some image types (I've seen transparent images and animated images mentioned i... [20:01:11] ...FUCK. [20:01:24] gi11es: If you're around you need to remove your -2 on the wikisource patchset [20:01:37] I cannot submit it (I don't think jenkins-bot can either) otherwise [20:01:45] 3MediaWiki / 3File management: SVG client side rendering - 10https://bugzilla.wikimedia.org/3593#c37 (10C. Scott Ananian) Note that the 'lang' option won't work for client-side SVG rendering; see bug 58920. [20:02:46] 3MediaWiki / 3File management: Can't make images in frames any larger than they already are - 10https://bugzilla.wikimedia.org/9124#c1 (10C. Scott Ananian) By design, no bitmap image will be displayed larger than its native size. You can use CSS to scale the image up, if you really want that. [20:08:46] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:08:46] 3MediaWiki / 3File management: Preview/"other resolutions" links should be hidden for when image exceeds megapixel limit - 10https://bugzilla.wikimedia.org/62307 (10Dominic) [20:09:01] 3MediaWiki extensions / 3UploadWizard: No error message in UploadWizard for files exceeding MP limit - 10https://bugzilla.wikimedia.org/65552 (10Dominic) [20:09:01] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:09:31] 3MediaWiki / 3File management: enable caption for "border" and "frameless" mode - 10https://bugzilla.wikimedia.org/10587#c1 (10C. Scott Ananian) Can't this be solved with: [[Image:example.jpeg|thumb|class=mycoolclass|some useful text]] and some appropriate CSS for .mycoolclass? [20:09:46] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:09:46] 3MediaWiki / 3File management: TIFF images that are too big to thumbnail don't display errors on image page - 10https://bugzilla.wikimedia.org/25647 (10Dominic) [20:13:31] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:13:31] 3MediaWiki / 3File management: Display file format of preview if different format from original file - 10https://bugzilla.wikimedia.org/56546 (10Dominic) [20:18:01] marktraceur: Did you get gilles to remove his -2 on the Wikisource patchset? Or did you find a workaround? [20:18:38] No, I'm just submitting a new one [20:19:27] you can just delete reviews if you are sure about what you are doing [20:19:38] there is a little X next to them [20:19:39] You can [20:19:41] * marktraceur tries [20:19:45] 3MediaWiki / 3File management: Support linking to the image description page of a specific "page" of an image, using wiki internal link syntax - 10https://bugzilla.wikimedia.org/14788#c5 (10C. Scott Ananian) For reference, the desired *output* url is something like: https://en.wikipedia.org/w/index.php?titl... [20:20:02] 3MediaWiki / 3File management: Support linking to the image description page of a specific "page" of an image, using wiki internal link syntax - 10https://bugzilla.wikimedia.org/14788 (10C. Scott Ananian) a:3C. Scott Ananian [20:20:03] Oh. [20:20:08] * marktraceur hates gerrit [20:22:02] 3MediaWiki / 3File management: Support for multilingual SVGs - 10https://bugzilla.wikimedia.org/16052 (10C. Scott Ananian) [20:23:46] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:23:46] 3MediaWiki extensions / 3PagedTiffHandler: Need error message and/or better design for thumbnails broken due to megapixel limit - 10https://bugzilla.wikimedia.org/62306 (10Dominic) [20:25:16] 3MediaWiki / 3File management: TIFF handling (tracking) - 10https://bugzilla.wikimedia.org/62466 (10Dominic) [20:25:16] 3MediaWiki / 3File management: Display file format of preview if different format from original file - 10https://bugzilla.wikimedia.org/56546 (10Dominic) [20:26:45] 3MediaWiki / 3File management: Add title= option for images - 10https://bugzilla.wikimedia.org/24586#c5 (10C. Scott Ananian) Retitled bug to reflect comment 4, since as comment 3 states, the existing alt/title defaults are historical. But sure, we should be able to arbitrarily override alt and title if desi... [20:27:45] 3MediaWiki extensions / 3PagedTiffHandler: Need error message and/or better design for thumbnails broken due to megapixel limit - 10https://bugzilla.wikimedia.org/62306#c6 (10Dominic) (In reply to Bawolff (Brian Wolff) from comment #5) > Calling this fixed as there now actually is an error (look for it on co... [20:30:30] fabriceflorin: http://en.wikisource.org/wiki/Main_Page?debug=true#mediaviewer/File:Cambridge_Natural_History_Mammalia_Fig_159.jpg [20:31:50] * marktraceur is doing self.review() [20:32:13] If someone wants to chime in at https://en.wikipedia.org/wiki/Template_talk:Portal-inline#metadata_class_for_the_logo [20:32:17] I think I did that right [20:32:20] But I could be wrong [20:36:01] marktraceur: Thanks for the update. I think your post is helpful, to remind folks on how to remove an image from Media Viewer. [20:36:45] 3MediaWiki / 3Uploading: Support PhantomJS as an SVG rasterizer/renderer option - 10https://bugzilla.wikimedia.org/54030#c7 (10C. Scott Ananian) Re i18n, see also bug 58920. We have to manually hack the browser's preferred language preference to match the 'lang' option specified. But phantomjs doesn't impl... [20:38:33] marktraceur: I think I will add this to our help FAQ, adjusted to reflect the comments from our community: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#How_to_disable_MediaViewer_for_some_images [20:38:44] 'kay [20:39:44] At some point, we should revisit the ‘noviewer’ special class idea, as several community members still think it’s needed, as an alternative to the metadata and link solutions. [20:47:45] 3MediaWiki / 3File management: image's real dimensions could differ from dimension specified in html if height-based scaling is used - 10https://bugzilla.wikimedia.org/34974#c8 (10C. Scott Ananian) Yes, the stored filename and all indexing for the thumbnail are width based. This means that we can't distingu... [20:48:08] maybe [20:48:29] fabriceflorin: If they're still vocal about it you could just point them here and tell them to ask for help with the codebase [20:50:46] 3MediaWiki / 3File management: Parameter for square thumbs that cut off edge of image - 10https://bugzilla.wikimedia.org/35756#c9 (10C. Scott Ananian) I propose: [[File::Filename.jpg|crop|100x200px]] which would return an image *exactly* 100x200px, cropped as necessary. As an elaboration, you might allow... [20:55:10] marktraceur: For now, I have added this entry to the FAQ, to document the ‘metadata’ solution, with the caveats recommended by TheDJ. Based on his comments, I would not recommend using the ‘=link’ option to disable Media Viewer for images. https://www.mediawiki.org/wiki/Help:Multimedia/Media_Viewer#How_can_I_disable_Media_Viewer_for_unrelated_images.3F [20:56:05] fabriceflorin: You could comment on the talk page I linked to and say "Don't do link=" [20:56:18] I think link={{the portal page}} is a good idea, but that's just me [20:56:52] Yeah, I will do that, as well as ping TheDJ, Nemo and Jay8g to finalize the consensus about implementing the ‘noviewer’ class at some point. [21:02:00] 3MediaWiki extensions / 3UploadWizard: Scale images/video in the background and publish immediately - 10https://bugzilla.wikimedia.org/65909#c1 (10Tisza Gergő) Is this specifically about video? I'm not sure this would be an accurate description of how image uploading works. [21:02:34] fabriceflorin: Also, we're live on wikisource, presumably the announcements went out and everything [21:02:42] keeg [21:03:49] marktraceur: Yeah, the pre-announcements went out last Friday. I’m not sure we need another announcement today, though happy to make one in Keegan’s absence, if you think that would help. [21:03:53] Cool [21:03:59] I don't think we need it [21:04:16] Cool. Plenty of other work on my plate :) [21:04:22] Yeah :) [21:09:55] marktraceur: icons linking to their description pages is generally a horrible usability fail, but people will insist to keep it that way for licensing concerns [21:10:15] (rightfully) [21:10:32] Yeah. [21:11:05] maybe we could create some sort of credits special page which links to all images of a given article to free up link= [21:11:37] Hm. [21:11:57] I wonder what our legals would say about that [21:13:06] we'll never know unless we ask [21:14:30] IIRC there is an optional credit link in MediaWiki [21:14:38] do we have sites which have that enabled? [21:22:07] * marktraceur doesn't know [21:22:43] I am probably confusing things, all I can find is $wgMaxCredits [21:40:31] 3MediaWiki extensions / 3UploadWizard: Scale images/video in the background and publish immediately - 10https://bugzilla.wikimedia.org/65909#c2 (10matanya) It is commons for video, as it is usually bigger in size, but if you upload an image stream from flickr it also takes a long time. there is image scaling... [22:02:18] tgr: I guess "what links here" might have the images too? [22:02:53] does it? [22:03:00] No. But we could add it to action=info maybe [22:03:15] I think that's probably our best option [22:03:47] adding it to an API does not help with legal issues about attribution [22:03:57] ah, nevermind [22:04:08] that's a oage view mode, right? [22:04:19] Yeah [22:04:30] "Page info" or something, in the toolbox [22:04:50] might be the right place, yes [22:09:31] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata should retrieve custom Credit Line through licensetpl_attr - 10https://bugzilla.wikimedia.org/57460#c3 (10Jean-Fred) Huh, well, not sure what I was supposed to do but whatever. Attribution specified through {{Credit line}} is now wrapped in a class="l... [22:16:00] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata should retrieve custom Credit Line through licensetpl_attr - 10https://bugzilla.wikimedia.org/57460#c4 (10Tisza Gergő) The current implementation of CommonsMetadata ignores licensetpl_* fields not wrapped in a licensetpl class, so this won't have any... [22:21:01] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata should retrieve custom Credit Line through licensetpl_attr - 10https://bugzilla.wikimedia.org/57460#c5 (10Jean-Fred) (In reply to Tisza Gergő from comment #4) > The current implementation of CommonsMetadata ignores licensetpl_* fields > not wrapped in... [22:25:01] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata should retrieve custom Credit Line through licensetpl_attr - 10https://bugzilla.wikimedia.org/57460#c6 (10Jean-Fred) (In reply to Jean-Fred from comment #5) > (In reply to Tisza Gergő from comment #4) > > The current implementation of CommonsMetadata... [22:25:33] 3MediaWiki extensions / 3MultimediaViewer: close, fullscreen, back, and forward icons are inconsistent and not using Wikifont assets - 10https://bugzilla.wikimedia.org/65919 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None these assets should be integrated into wikifont if missing or use wi... [22:39:50] (03PS4) 10Gergő Tisza: Handle multiple templates in TemplateParser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/135194 (https://bugzilla.wikimedia.org/57259) [22:45:00] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata should retrieve custom Credit Line through licensetpl_attr - 10https://bugzilla.wikimedia.org/57460#c7 (10Tisza Gergő) Again, how about adding id="fileinfotpl_credit" (to the first column, not the second) instead of class="fileinfotpl_credit"? That wo... [23:13:47] (03CR) 10MarkTraceur: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:45:00] 3MediaWiki extensions / 3UploadWizard: Scale images/video in the background and publish immediately - 10https://bugzilla.wikimedia.org/65909#c3 (10Bawolff (Brian Wolff)) Thats not an accurate description of the upload process for either type of file. The delay in "publishing" probably has to do with the roun... [23:49:45] 3MediaWiki / 3File management: Parameter for square thumbs that cut off edge of image - 10https://bugzilla.wikimedia.org/35756#c10 (10Bawolff (Brian Wolff)) I feel like the people in wmf projects would not use this feature (thats unsubstiatiated though). I would be opposed to making core thumbnailing more co...