[06:22:11] 3MediaWiki / 3File management: Resized raster image does not succeed metadata of the original file - 10https://bugzilla.wikimedia.org/65475#c5 (10Thomash Lee) There is already the discussion 17503 about generating metadata by checking licensing/author info or information template from the media description p... [07:00:26] marktraceur: yes I saw his comment, I thought you'd be on it since you wrote the changeset [07:01:01] tgr: GWToolset hasn't been disabled and Fae hasn't got back to me on the ML about scheduling his next attempt [07:38:49] (03CR) 10Gilles: [C: 04-1] Handle multiple templates in TemplateParser (036 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/135194 (https://bugzilla.wikimedia.org/57259) (owner: 10Gergő Tisza) [07:49:46] (03CR) 10Gilles: [C: 04-1] Add unit tests for HookHandler (032 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/135503 (owner: 10Gergő Tisza) [07:50:23] (03CR) 10Gilles: [C: 032] Remove old template parser [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/135607 (owner: 10Gergő Tisza) [11:19:26] 3MediaWiki / 3Uploading: Chunked upload of large SVGs (~70mb) triggers INVALIDXML exception, but file is valid - 10https://bugzilla.wikimedia.org/65724#c6 (10Derk-Jan Hartman) http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076691.html [13:58:56] 3MediaWiki / 3Uploading: Special:Upload should remove whitespace before file extension - 10https://bugzilla.wikimedia.org/65811 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [15:12:56] 3MediaWiki / 3Uploading: Special:Upload should remove whitespace before file extension - 10https://bugzilla.wikimedia.org/65811#c1 (10Rainer Rillke @commons.wikimedia) For the client side: Will be addressed with https://bugzilla.wikimedia.org/show_bug.cgi?id=64922 specifically https://gerrit.wikimedia.org/... [15:19:01] hey gi11es, is anyone assigned to gwtoolset gerrit commits this week? [15:24:46] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/GWToolset,n,z [19:22:57] * bawolff excited for wikiconference usa [20:20:13] (03PS16) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [20:20:14] WHEW [20:20:21] It better pass jslint [20:25:16] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:28:23] (03CR) 10Hashar: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:35:19] Urgh. [20:35:53] hashar: It's probably actual failures; the rebase may have actually been bad [20:57:28] might be [20:57:57] I take it back, it's wrong [20:58:11] It has to be [20:58:43] Oh, no [20:58:50] jshint was stupidly checking node_modules [20:58:55] Excuse me while I kill it [21:10:23] :-D [21:49:43] (03PS17) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [21:49:53] OK jenkins let's talk [21:57:25] marktraceur: Jenkins treated me bad earlier today, got your flamethrower? [21:57:56] * marktraceur cocks nerf gun [21:57:56] chrismcmahon: Where is the bastard [22:06:55] marktraceur tgr: I now think that #665 (Put "Download" as the first tab of the "use" panel) may be more effective to address community concerns than #660 (Put "Download" as the first tab of the "use" panel), because it takes one less click to find the link to the original file. Would you be willing to swap them for this sprint, if they take the same amount of time? Or do them both and postpone the tooltips in #546 by a week? [22:06:55] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/665 [22:07:38] Sorry, #660 is “Remember the last selection of the reuse menu”. [22:07:52] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/660 [22:09:04] Hm [22:09:20] I think #665 is not that hard [22:11:28] (03CR) 10MarkTraceur: [C: 04-1] "I have a big list of worrisome things I saw in the rebase that I still want to address, hold on." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [22:11:57] (03CR) 10MarkTraceur: "Actually...let's not make this any bigger. Ready for review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [22:12:59] marktraceur: Glad to hear #665 is not that hard. How many points would it take, in your view? I forgot to mark it as a ‘must-have’, so I didn’t see it in our current cycle when it came time to make a decision. But I think it is higher priority than #660, to address our users requests of quick access to original files. [22:13:40] Probably 1, but not sure [22:13:43] I can look [22:14:12] marktraceur: Thanks, would you take a look and let us know what you think? [22:14:39] Yeah sec [22:15:40] I think it might be a one-line change [22:15:42] Let me test [22:17:43] gi11es, tgr, heads-up that trailing commas in JS objects break old browsers and are against code conventions besides. I caught an instance of them in MMV just now which is not a big deal but in UW it might be worse [22:18:59] OK not one line but five minutes [22:19:29] (03PS1) 10MarkTraceur: Prioritize download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135949 [22:20:36] marktraceur: That’s great to hear. Do you think we could add it to the current sprint? If necessary, we could remove the tooltips to make up for it. Or we can keep them both, if it’s only a 5-min. fix. [22:21:01] I just did and submitted the patch [22:21:14] I won't sneeze at a five minute task [22:21:33] WOW! Thank you so much … Ask and thou shall receive :) [22:21:34] Besides who could pass up this opportunity: "Story Points: 0.01" [22:22:53] Cool. Really appreciate it. [22:42:37] fabriceflorin: I don't see the big win #665, it is trading off on the convenience of different user groups [22:43:07] new users for example probably want the sample wikitext most, which is in the share tab [22:43:18] umm embed tab [22:44:52] you might set up defaults in a way that makes it convenient for experienced users, and that might result in fewer complaints, but it does not actually make MediaViewer more usable, it just moves the problem to less represented user groups [22:46:22] marktraceur: http://jslinterrors.com/extra-comma [22:46:32] maybe we misconfigured JSHint? [22:46:47] ah [22:46:49] Probably [22:46:50] "Since version 2.0.0 JSHint will only raise this warning if the es3 option is set to true." [22:47:01] that's kind of stupid [22:47:13] but easy to fix! [22:48:57] (03PS1) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135955 [22:49:29] (03CR) 10jenkins-bot: [V: 04-1] Make JSHint enforce ES3 compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135955 (owner: 10Gergő Tisza) [22:50:02] woah, we had quite a few of those [22:50:38] Bah. [22:50:47] I wonder if I should try to do that with UW [22:54:13] is there a way to supress warnings for a whole directory? [22:54:35] Probably [22:54:41] Not sure what it is though [22:54:43] because sinon.js has a function called throws() which makes the tests using it non-es3-compliant [22:55:13] Ugh. [22:55:38] tgr: You could probably set es3=false in those files [22:55:50] We want other files to get checked probably [22:56:30] oh, they actually wrote sinon in an ES3-compliant way, nice [22:56:39] we can just fix it in the tests then [22:57:02] Oh, cool. [23:04:17] (03PS2) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/135955 [23:14:39] (03PS1) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135961 [23:14:50] (03PS1) 10MarkTraceur: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 [23:15:11] first! [23:16:04] and it actually works out of the box, wow [23:16:45] (03Abandoned) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135961 (owner: 10Gergő Tisza) [23:16:50] (03PS2) 10Gergő Tisza: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:17:02] Balls [23:17:26] (03CR) 10Gergő Tisza: [C: 032] Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:17:41] Well it all worked out in the end. [23:17:51] (03Merged) 10jenkins-bot: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:17:57] Hi tgr : thanks for your observations about #665. I think you are correct that it is helping experienced users more that casual users. I view this as a temporary measure, to make adoption easier when we deploy to enwiki and dewiki next week, and all other wikis later this month. In the future, once we have more research, we may want to switch back to having Share first, but by then the experienced users will have become comfortable [23:17:57] with the tool. [23:19:31] tgr: Pau was comfortable with this solution as a placeholder, for reasons stated above. So if you are OK with it too, it would be great if you could review the code, so we might possibly release it tomorrow. [23:23:51] (03CR) 10MarkTraceur: [C: 04-1] "Error on upload completion; "upload more files" is apparently broken now (was it before?)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:24:03] (03PS18) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [23:24:48] (03PS19) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [23:37:32] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:40:00] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:40:13] Whoa deja vu [23:52:17] (03CR) 10Krinkle: Massive refactor (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:58:05] Krinkle|detached: Are you tired of telling me "bar, not slash" yet? :)