[08:40:23] (03CR) 10TheDJ: "Mark asked me if I remembered what the problem was here. This related to: https://bugzilla.wikimedia.org/show_bug.cgi?id=39852" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65318 (https://bugzilla.wikimedia.org/40921) (owner: 10TheDJ) [13:44:16] (03CR) 10Gilles: [C: 032] jQuery 1.9 fixes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [13:44:25] (03Merged) 10jenkins-bot: jQuery 1.9 fixes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [14:00:50] (03CR) 10Krinkle: "FIXME: You're missing one or two dependency declarations on jquery.client. In one case it is missing entirely (EmbedPlayer.loader.js), and" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [16:40:48] 3MediaWiki / 3File management: Resized raster image does not succeed metadata of the original file - 10https://bugzilla.wikimedia.org/65475#c3 (10Bawolff (Brian Wolff)) I dont think thats the expected result. Lots of useless crap in the metadata. However there are some fields which would be nice to copy ove... [17:05:33] 3MediaWiki / 3File management: internal_api_error_DBQueryError when moving files - 10https://bugzilla.wikimedia.org/37519#c11 (10Bawolff (Brian Wolff)) *** Bug 53768 has been marked as a duplicate of this bug. *** [17:06:18] 3MediaWiki / 3File management: internal_api_error_DBQueryError when moving files - 10https://bugzilla.wikimedia.org/37519#c12 (10Bawolff (Brian Wolff)) See also bug 40927 comment 6. I'm unsure if this bug should be marked a dupe of that one. [17:10:34] 3MediaWiki / 3File management: Resized raster image does not succeed metadata of the original file - 10https://bugzilla.wikimedia.org/65475#c4 (10Bawolff (Brian Wolff)) > > After the change of Wikimedia that the file description page no longer > provides original size preview if the width of the original r... [18:27:26] ugh, the unit tests on PagedTiffHandler are scary [18:29:31] (03CR) 10MarkTraceur: "OK, so I'm going to fix up the "massive refactor" patch, which removes the stupid ID methodology, and then also re-enable the archive warn" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65318 (https://bugzilla.wikimedia.org/40921) (owner: 10TheDJ) [18:53:20] screw it, I'll just upload to gerrit and let it test the tests [18:55:26] That's the spirit [18:56:31] Someone should add some tests for our test suite [18:57:02] Oh, gerrit doesn't even run these tests [18:57:42] so what are the 5 tests that gerrit does run... [18:59:47] bawolff: core tests that get run for extensions prolly [19:00:42] * bawolff would write so many more tests if our test suite wasn't such a pita [19:01:35] *nod* [19:02:12] Did I mention about how 2 days ago, our test suite decided to delete my entire user table on my test wiki [21:39:38] Whoo, finally got paged tiff handler tests to work [21:43:37] And of course they fail on jenkins [23:41:11] bawolff, to be able to solve https://bugzilla.wikimedia.org/show_bug.cgi?id=65757, I am in need of help ... http://pastebin.de/126191 is a stored proc I intend to use for updating MSSQL server's constraints to be finally able to modify them for changing major mime [23:42:10] a single update to a table would then be reduced to http://pastebin.de/126192 [23:42:11] We even have working support for MSSQL! [23:42:32] Yes, it really works! [23:42:53] Spent my whole day setting with it :( [23:45:24] Most developers consider it sufficient to add support for mysql, sqlite and postgress, and call it a day at that, leaving the more obscure dbs for those who maintain them [23:45:49] Now the issue is that DatabaseMssql::doQuery() which is invoked by the maintenance script sets a cursor ... 'Scrollable' => SQLSRV_CURSOR_STATIC ... and when this server is set, MSSQL server fails with "Cursor type changed." "Executing SQL directly; no cursor." [23:47:07] otherwise it would work .... [23:48:53] As I understand it, a cursor is only required for iterating over result data [23:50:00] Since not all SQL queries need result data, I wonder whether augmenting DatabaseBase with a method to just execute something is appropriate.... [23:52:09] I don't really understand much about mssql, but it seems like adding an option to DatabaseMssql would be appropriate [23:52:49] In theory, the ->query method is supposed to just execute it [23:53:15] Skizzerz: is the main maintainer of mssql support, and he's currently in #mediawiki, maybe he has some suggestions [23:53:43] * rillke is going mediawiki [23:53:58] I mean, it seems more appropriate to be something in DatabaseMssql rather than DatabaseBase, since it seems very mssql specific [23:55:07] yeah but in this case we can't use includes/installer/MssqlUpdater.php [23:55:22] which has such a nice stucture [23:58:04] Well MSSQLUpdater extends DatabaseUpdater so its possible to just override a method from DatabaseUpdater if it needs to set a special flag