[00:10:57] (03PS8) 10Gergő Tisza: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [00:17:06] tgr: Should I schedule them, or are you? [00:17:19] I am doing it [00:17:26] 'kay! [00:30:21] (03CR) 10Krinkle: Record sampling factor in EventLogging calls (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [00:52:02] marktraceur: scheduled, but I don't see errors in logstash anymore [00:52:15] maybe someone did something about this already? [00:55:12] (03CR) 10Gergő Tisza: "Mostly nitpicks, and a few documentation issues, but the head-loading issue is worrysome." (039 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [00:55:20] (03CR) 10Gergő Tisza: [C: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [08:19:07] hello! [08:28:50] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata: GPSLongitude prefixed by whitespace - 10https://bugzilla.wikimedia.org/65573 (10Lokal_Profil) 3NEW p:3Unprio s:3normal a:3None The extracted metadata seems to always prefix the GPSLongitude value with whitespace. Example: https://commons.wik... [08:30:22] (03PS3) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [08:30:25] (03CR) 10jenkins-bot: [V: 04-1] jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [08:32:00] (03CR) 10Gilles: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [08:33:42] (03PS4) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [08:38:14] gi11es: I found the issue :-] [08:42:11] (03PS7) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [08:43:15] (03PS8) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [08:43:57] (03CR) 10Gergő Tisza: "Thanks! It was an uppercase/lowercase issue for me as well." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [08:47:06] gi11es: fixed! [08:52:19] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458#c6 (10Lokal_Profil) 5RES/FIX>3REO This issue is occurring again. See e.g. https://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&format=json&iiprop=... [08:53:52] 3MediaWiki extensions / 3CommonsMetadata: CommonsMetadata: GPSLongitude prefixed by whitespace - 10https://bugzilla.wikimedia.org/65573 (10Lokal_Profil) [08:53:52] 3MediaWiki extensions / 3CommonsMetadata: '\n' are added to various elements in CommonsMetadata output - 10https://bugzilla.wikimedia.org/57458 (10Lokal_Profil) [09:02:33] (03PS9) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [09:12:30] (03PS10) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [09:22:20] (03CR) 10Gergő Tisza: "QUnit is still failing but I cannot reproduce it locally anymore." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [09:29:50] 3MediaWiki extensions / 3MultimediaViewer: MMV downloads PNG when user tries to download an SVG original - 10https://bugzilla.wikimedia.org/65576 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None As can be seen in the URL. Go to "Use this file" -> Download Choose "original size" This gives you... [09:45:50] (03PS9) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [09:46:02] (03CR) 10Gilles: Record sampling factor in EventLogging calls (039 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [09:46:09] (03CR) 10Gilles: Record sampling factor in EventLogging calls (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [09:46:53] (03CR) 10jenkins-bot: [V: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [09:57:05] (03CR) 10Gilles: "Either by another cosmic coincidence I'm running into an issue with exactly the same test, or the failure is unrelated to our changes: htt" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [09:59:50] (03CR) 10Gilles: "Nevermind, I thought I saw an error in the same test but I must have dreamt it, your last error seems specific to this changeset's code, a" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [10:00:15] (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [10:48:33] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Accept files whose names are invalid MediaWiki titles - 10https://bugzilla.wikimedia.org/64912#c4 (10Rainer Rillke @commons.wikimedia) * You are unable to upload this file unless you rename it. You have to rename it locally. It's not uploaded at all. [14:19:15] uhm bug 65406 now has a bug ... [14:19:53] http://i.imgur.com/MQKe2Ci.png (Upload from flickr broken) [14:30:04] warpath: That looks like something we can handle within 1-2 days. Thanks :) [14:30:31] \o/ [14:30:40] * marktraceur re-posts https://bugzilla.wikimedia.org/show_bug.cgi?id=65406 in the channel for the record [14:30:52] warpath: It might be fixed but not deployed? [14:31:25] meh, will wait for the next deployment then :( [14:43:39] (03CR) 10Krinkle: [C: 031] jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [15:09:35] hmmm UploadWizard isn't installed on mediawiki.org, surprising [15:21:39] test it on commons :) [15:28:46] yeah, I'm just surprised that's all [15:36:53] it used to have another problem as well, once u upload a image (to the serer, not commons), and make the necessary changes, if you try to make changes to the descritoon section (provided there is already a long descrption carreid on from flickr, then it would freeze your browser and force you to shut it down.. :( [15:43:24] gi11es: UW is literally useless on every wiki but Commons [16:13:40] (03CR) 10MarkTraceur: "You should just remove the jasmine test; we've not used it for a long time and I honestly thought we had already deleted it all." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [17:46:24] gi11es: Would you mind taking a look at the sha1 storage patch? I failed to finish it off but I'd love to see it go [17:59:10] fabriceflorin: I don't know if you got that Engineering email, but https://meta.wikimedia.org/wiki/Research:Data/Dashboards is lonely without us [18:00:24] marktraceur: Cool. Happy to update that dashboard page, later today. Thanks for the nudge. [18:03:36] Can anyone tell why this edit didn’t work? https://commons.wikimedia.org/w/index.php?title=File:Vietnam_and_World_Opinion,_p._97_of_118_-_NARA_-_304226.jpg&diff=prev&oldid=124479306 [18:04:00] interferes with “subst”ing, or something? [18:04:26] Hm, it shouldn't [18:04:33] greg-g : FYI, we want to push back tomorrow’s Media Viewer deploys to English and German Wikipedia to June 3, so we don’t release right before Memorial Day Weekend, and have a community liaison on call for these crucial release. We still want to deploy to Italian and Russian Wikipedias tomorrow and will update the Gerrit ticket accordingly. I have updated the Media Viewer release plan with our new deploy dates, and am now updating [18:04:34] the Deployment calendar, then will send an email to our mailing lists. https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Release_Plan#Timeline [18:05:01] I can still do the deploy during our window, though [18:06:08] Dmcdevit: Must be, I see the same issue locally [18:07:03] fabriceflorin: sounds like a good idea, thanks [18:07:47] marktraceur: I wonder if it’s a known bug? It doesn’t seem like it’s a crazy idea I’d be the first to try. ;-) [18:08:25] * marktraceur looks [18:08:44] https://bugzilla.wikimedia.org/show_bug.cgi?id=2700 maybe [18:08:46] It’s kind of annoying if I have to account for a potential gallery tag when I’m doing a mass replacement with a subst in it. [18:08:51] greg-g marktraceur: Glad that works for you. Thank robla for this brilliant idea. I have updated the development calendar now, will file a ticket to update the Gerrit patch: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_May_19th [18:10:00] Dmcdevit: Bug 2700 is a long tale of misery and woe [18:10:07] Yeah. :/ [18:10:21] * marktraceur is going to bother gwicke [18:20:26] marktraceur tgr : FYI, I have created this new ticket #633 for the local config changes to Media Viewer new release dates. Could one of you take care of this today? Thanks :) [18:20:27] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/633 [18:22:17] "local"? Anyway, I'll make the config patch tomorrow during the deploy window. [18:24:04] (03PS1) 10MarkTraceur: Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 [18:24:08] Krinkle: ^^ [18:24:12] :D [18:24:20] But I need an IE person to test, womp womp [18:25:16] (03CR) 10jenkins-bot: [V: 04-1] Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 (owner: 10MarkTraceur) [18:26:53] (03PS2) 10MarkTraceur: Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 [18:27:28] (03CR) 10jenkins-bot: [V: 04-1] Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 (owner: 10MarkTraceur) [18:28:52] Oh come on [18:29:23] Oh, wrong file :3 [18:29:50] lol [18:29:51] (03PS3) 10MarkTraceur: Feature detection, magical stuff [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134655 [18:29:55] yolo, remove jQuery [18:29:56] * marktraceur drinks more coffee [18:30:03] what could go wrong [18:30:52] jslint told me to remove $, so I deleted it from me dependencies, I don't know what else I could have done [18:31:01] my* [18:51:53] marktraceur, fabriceflorin: I'm not sure what the outcome was, did we pick https://bugzilla.wikimedia.org/show_bug.cgi?id=46741 for this week? [18:52:12] I don't think so? [18:52:18] It's a complex one [18:52:56] tgr: Wait, this one is "fixed" to an extent by rillke's work [18:53:03] I don’t think so. We selected #615 Different images uploaded under the same title [18:53:19] Wait, that’s the wrong one, sorry. [18:53:45] marktraceur: aren't you thinking of the other one that fabriceflorin just mentioned? [18:53:59] Hmmmayyybe? [18:54:10] Take that back, we did select #615, according to our notes. [18:54:34] fabriceflorin: we unselected #615 since rillke mostly fixed it already [18:54:51] this other bug has no ticket yet [18:54:58] Oh, I thought there was still some follow up work to be done on that front. [18:55:20] there is, it's just not particularly urgent [18:56:17] Oh, OK. Didn’t we also say we would start making Upload Wizard data accessible for a funnel analysis? [18:56:43] not sure what that means, exactly [18:56:57] the tickets to collect the data should be finalized today [18:57:15] I had a card for the funnel analysis, not sure what happened to it. [18:57:28] But we do have this one, which could do the trick: #587 Upload Wizard Metrics - Dashboards [18:57:52] we have maybe four tickets for it, but it's not very clear what they are about [18:58:19] Here, I found the funnel metrics ticket: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/541 [18:58:22] there are multiple levels of detail in the data collection that could be added [18:58:55] I think it would be useful to start surfacing the data you are collecting now right away, then add more data soon after. [18:59:26] So my recommendation in the meeting was intended to suport #541 above. [19:00:26] If that #541 matches your understanding of our next steps, then I recommend we add it to the list. [19:02:25] tgr : I now understand why #541 fell off the current sprint wall: It was still ‘In analysis’, which doesn’t show up on our current cycle wall. It was already marked for that sprint but not visible. I moved it to ‘Ready for development’, so we can see it on that wall. [19:03:28] tgr: Another ticket that fell through the cracks was #628 Per-file view stats — I added an ‘In analysis’ column to the current cycle, so we don’t lose cards like that. [19:03:58] fabriceflorin: thanks! [19:04:17] I did run into the same issue with epics ocassionally, by the way [19:04:41] maybe we should have a fourth column in the current sprint for things that don't have a release epic [19:04:52] because right now they are invisible [19:32:04] (03PS11) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [19:36:42] (03CR) 10Gergő Tisza: "Yeah, this is an issue with the test I wrote, I just can't get it to happen locally. Whatever, I'll just discard the texts. It is probably" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [19:36:54] (03PS12) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [19:56:12] fyi, the "Share" panel doesn't actually appear to work (text not selectable in chromev34) [19:56:16] (mmv) [19:57:53] oh, wow [20:10:06] still works on Wikipedia, must be something recent [20:18:03] its a side-effect of the jQuery update [20:27:26] tgr: Shouldn't everything be covered by jQuery.migrate still? [20:27:44] not at all [20:28:06] that plugin makes sure the deprecated functions still exist [20:28:21] it doesn't magically undo all the behavior changes [20:28:40] *nod* [20:28:52] jQuery 1.9 has a major change in how focus events are handled, I am suspecting that [20:29:15] it even broke half our tests, but we didn't think to check if it broke something else [20:29:20] that was stupid [20:29:57] I wonder if ti is possible to write an E2E test for the actual text selection behavior [20:30:20] Probably maybe [20:30:34] fabriceflorin: ^^ https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/638 [20:31:04] maybe not a great time to start a conversation about reuse panel vs zoom hack vs original file button after all :) [20:31:27] Heh [20:32:18] and we don't even have the E2E tests which would check whether the reuse panel opens at all... sad [21:10:13] fabriceflorin: https://gerrit.wikimedia.org/r/134080 wanted to run that by you [21:14:16] marktraceur tgr : Thanks for pointing out the reuse panel issue in #638. That’s a really serious problem, as it makes ‘Use this file’ largely unusable (except for Download and preview). Is this a hard thing to fix? I would recommend that we take this on in this cycle, if possible. How many points does it represent? If necessary, I would put it ahead of #636, though that one is important too. [21:14:44] experiance is so much more buzzword compliant though [21:24:57] marktraceur tgr : For now, I added #638 in the current sprint, in the ‘ready for development’ column. Let me know if you disagree. :) [21:27:46] fabriceflorin: What about the string change from "new media viewing experience" to "MediaViewer"? [21:29:41] marktraceur: That would be nice if we could make that change, but is probably less important than #638 or #636, which are broken. But I can add a card for that string change, so we can track it. How many points? [21:30:39] It's literally sitting in code review [21:30:47] I just wanted to make sure you were OK with it [21:30:56] But you weren't on IRC when I was looking at it [21:31:22] marktraceur: You’re right, I did make a card for it. Yes, that’s a definite improvement, suggested by Patrick 87. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/622 [21:31:48] I think we should go with it. It will help in our discussions on Commons, where the idea came up. [21:31:48] fabriceflorin: The difference is the lack of space, I think [21:31:56] The proposed change says "Enable MediaViewer" [21:32:35] We have been using a space between these two words, which would help for consistency’s sake, for translations. [21:32:59] I suspect odder was confused because of "MultimediaViewer"; I'll fix it and merge 'er [21:33:45] (03PS3) 10MarkTraceur: Change preference name for enabling MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder) [21:33:51] Yeah, the public, customer-facing name is “Media Viewer” and we should stick with it. “MultimediaViewer” is the name of the extension, which is more relevant to developers, but not the general public. [21:33:53] Thanks! [21:34:41] just fyi, I've been hearing some grumbling on commons about people not wanting media viewer to be triggered from the images in category listings. [21:35:06] bawolff: On VP? [21:35:18] mostly yes [21:35:33] Hm [21:35:53] I've heard apathy and I've heard not wanting it at all, this is a nice middle ground [21:35:54] not sure there is any aspect of MediaViewer people on commons have not grumbled about yet [21:36:00] ^ [21:36:25] Well yeah, there's that too [21:37:26] I do ultimately think that people reading wikipedia articles are much more inline with your ideal use case then power users at commons [21:38:15] God the localisation cache is such a massive pain [21:38:39] bu then, articles on Wikipedia send people to Commons galeries and categories [21:38:55] yeah :s [21:40:33] Oh my god external links on special:preferences are so ugly [21:40:49] I don't even know what to say to this [21:41:06] say ? [21:41:13] :P [21:42:11] Yeah [21:42:16] In a friggin' message [21:42:23] IN A MESSAGE BAWOLFF. This is terrible. [21:42:34] (03PS4) 10MarkTraceur: Change preference name for enabling MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134080 (owner: 10Odder) [21:42:42] But at least it works and doesn't make my eyes bleed [21:43:01] Quick, merge before siebrand sees [21:43:38] Heh [21:44:13] He's asleep...wonder if I could rustle up a different i18n person to review [21:44:43] Actually I should let him review it. [21:44:58] If it's more egregious than I realize, it would be good for him to axe it and tell me to do it right [21:46:32] bawolff, the idea of not triggering it from categories because categories are used for maintenance and not useful to readers is insane logic [21:46:48] why the hell categorize anything if categories aren't useful for readers? [21:47:24] Eloquence: Logic. On a wiki. pfft [21:47:31] we should focus on making categories/tags more useful, not treat them as some kind of circle jerk [21:47:35] [21:48:10] if mmv had basic editing capabilities it would actually be awesomely useful on large collections [21:48:37] Eloquence: Added https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/629 yesterday based on russavia's comments in -commons :) [21:49:33] yeah, something like that would be neat. I wouldn't want to spend too much effort in that direction until we start working in earnest on burning down the category system and replacing it with wikidata tags [21:50:08] categories are monolingual and therefore inherently a poor choice for a multilingual project [21:50:29] wait, I closed the tag already. ;) [21:50:38] * bawolff will wait for it to actually happen... [21:50:38] Yeah man, illegal dom fragments [21:50:52] (03PS1) 10Gergő Tisza: Fix text selection behavior in reuse panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134738 [21:51:09] The difference between a category and a tag is mostly in how people use it. If commons really wanted tags, they could probably already have them [21:51:14] marktraceur: ^^ [21:51:18] bawolff, lots of things people have said would never happen actually started happening recently .. like .. wikidata itself :) [21:51:24] Rockin, thanks tgr [21:51:24] (03CR) 10jenkins-bot: [V: 04-1] Fix text selection behavior in reuse panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134738 (owner: 10Gergő Tisza) [21:51:27] true enough [21:51:28] Aw, womp womp [21:52:08] wikidata Q numbers probably make better tags because you get the multilingual labels and disambiguation for free. [21:52:12] That looks eerily familiar [21:52:45] knowing commons, I'm half surprised that they haven't done something horrible in javascript to magically translate category names [21:52:54] haha [21:53:07] don't give people ideas :) [21:53:30] tgr: Further jQuery issues? [22:02:48] marktraceur: no, I forgot to unattach the fixed event handlers and the tests caught it [22:02:51] yay tests [22:03:12] (03PS2) 10Gergő Tisza: Fix text selection behavior in reuse panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134738 [22:03:20] Yay tests indeed [22:03:54] the sad thing is, these are the same tests that got broken as soon as the jQuery upgrade happened [22:04:00] Yes. [22:04:05] so they sort of caught the whole select issue [22:04:14] So it's a bit of a boy-who-cried-wolf thing [22:04:15] I just did not realize it at the time [22:04:35] no, it was just me not trusting the tests [22:05:15] I should have tested the feature manually then, but I thought I understood why they are broken so did not even check [22:05:47] well, I did understand why they are broken, I just did not understand that that issue does affect the code as well [22:06:48] I'll schedule a SWAT [22:07:11] unless you have any idea how to fix the jumping thing [22:07:38] Jumping thing...? [22:07:53] if you select the embed html, the panel jumps [22:08:02] but only for that textfield [22:08:39] Huh. [22:08:48] probably related to how text/html is handled by two divs, one of which is hidden and probably positioned below the other and slightly outside the screen [22:09:09] and then on focus the screen gets scrolled to contain it or something [22:09:35] anyway, I don't think I'll solve that in the hour that remains until SWAT time, so... [22:10:24] Yeah [22:11:39] tgr: I don't see that bug; are you testing in Chrome? [22:15:14] yes [22:17:51] marktraceur: I can reproduce on Firefox, though [22:21:33] Hm [22:21:38] With or without your patch? Or both? [22:21:48] on mediawiki.org [22:23:09] Oh, [22:23:34] I don't see that either [22:24:19] I'm looking at it in FF 29 [22:24:30] I think I'm in 28 [22:24:42] Can't be that much difference [22:24:55] maybe you still have old jQuery? [22:25:23] fwiw I can verify that the fix works in FF29 [22:27:53] Hrm [22:30:04] I'm not seeing it at all but OK if the fix works let's do it [22:30:16] And that's the text selection behaviour patch, right? [22:30:43] yes [22:36:43] o.O we lost gi11es for a second and now he's decloaked [22:37:20] that's normal if you don't use SASL [22:44:16] marktraceur: any concern with the patch? I would like to get it deployed in 15 minutes [22:44:44] Oh, no, just going through it [22:45:33] (03CR) 10MarkTraceur: [C: 032] Fix text selection behavior in reuse panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134738 (owner: 10Gergő Tisza) [22:45:34] bd [22:46:01] thanks! [22:46:26] (03Merged) 10jenkins-bot: Fix text selection behavior in reuse panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134738 (owner: 10Gergő Tisza) [22:50:22] (03PS1) 10Gergő Tisza: Fix text selection behavior in reuse panel [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 [22:51:47] (03CR) 10jenkins-bot: [V: 04-1] Fix text selection behavior in reuse panel [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 (owner: 10Gergő Tisza) [22:52:31] Aw. [22:55:35] (03PS2) 10Gergő Tisza: Fix text selection behavior in reuse panel. [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 [22:56:28] (03CR) 10jenkins-bot: [V: 04-1] Fix text selection behavior in reuse panel. [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 (owner: 10Gergő Tisza) [22:56:52] (03CR) 10Gergő Tisza: "Ignore the tests, they conflicted and I messed up the merge." [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 (owner: 10Gergő Tisza) [23:00:40] this is my third time ignoring these specific test failures [23:00:58] third time is bound to work, right? [23:02:03] Sure [23:02:09] I hear it's the charm [23:13:29] (03CR) 10MaxSem: [C: 032 V: 032] "Next time please merge yourself before the deployment." [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134750 (owner: 10Gergő Tisza) [23:21:58] (03CR) 10Brian Wolff: "I'm more concerned about the case where the job doesn't go in the queue at all. I'm not really sure how this would happen, but it appears " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:26:03] (03CR) 10Aaron Schulz: "If the insert failed you should get an exception. Wouldn't that rollback the transcode table updates (or are those separated out?)." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:33:53] (03CR) 10Gergő Tisza: "I left a few remarks, but they are just ideas, I don't have concerns with the patch (well, apart from the tests not passing). I didn't hav" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [23:36:47] (03CR) 10Brian Wolff: "There is no use of transactions in TMH whatsoever (which is just great), also that code block is not in a try/catch, so the implicit trans" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:38:14] (03CR) 10Brian Wolff: "I also have not heard any complaints from users of "Error of type MWException"" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff)