[00:02:24] http://i60.tinypic.com/de1bfo.png [00:05:18] Or...screenshot it [00:06:10] rillke: I want to know that the code you're adding for title verification is running, so just stick an alert() there and try the next button [00:06:26] http://i59.tinypic.com/2nlhf9y.png [00:07:24] Argh this is the most annoying site [00:07:38] Which one do you recommend? [00:07:50] imgur.com is probably better [00:08:04] But also just doing it and saying yeah there was an alert there would work [00:08:14] Hm [00:08:21] OK so...maybe it's not firing for me. Sec [00:09:06] set a breakpoint into "detailsValid: function (cb, cberr) {" [00:09:17] e.g. at "upload.details.setDuplicateTitleError();" [00:10:43] Or an alert [00:11:02] $('.mwe-upwiz-button-next').last().parents('form') [00:11:11] OK now it works [00:11:12] Weird [00:11:17] returns nothing so which form should be submitted ? [00:11:28] * marktraceur merges [00:11:47] (03CR) 10MarkTraceur: [C: 032] "OK works for me now. Ghosts in the code etc." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:11:50] (03CR) 10jenkins-bot: [V: 04-1] UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:11:56] ...hrm [00:12:00] Conflict? [00:12:15] Rebase time [00:12:24] Can MergeYes ... why doesn't it tell the truth? [00:13:06] * rillke is rebasing [00:13:56] (03CR) 10MarkTraceur: "Test modules in error state - can you make sure it's not your changes causing that?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [00:14:11] Because Gerrit is Dumb [00:16:08] is there a way to add a note like "rebased" while uploading my patchset? [00:16:09] modules in error state is when ResourceLoader cannot load the tests? [00:16:16] *new patch [00:16:36] rillke: no, but there is a rebase button, that works sometimes [00:16:43] when there is no actual conflict [00:16:47] tgr: Probably because the schema is a dependency [00:16:58] Maybe stub it somehow... [00:17:00] (03PS11) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) [00:18:32] (03CR) 10Rillke: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:18:51] rillke: You don't need to recheck... [00:19:18] (03PS1) 10Gergő Tisza: [WIP] move funnel logging into its own component [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/134283 [00:19:44] (03CR) 10MarkTraceur: "weird." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:19:49] (03CR) 10MarkTraceur: [C: 032] UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:19:56] I hate Jenkins [00:20:14] (03Merged) 10jenkins-bot: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [00:21:10] Thank you, mark, one of the annoying bugs squashed. [00:21:33] :) [00:21:38] My pleasure [00:23:24] marktraceur: locally I only get two core failures, and those look jQuery upgrade related [00:23:35] (03CR) 10MarkTraceur: "Note: Errors in module state because the dependency (schema:whatever) is not fillable on the test server, maybe?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [00:23:36] nothing like the module loading error [00:23:49] Oh? [00:23:56] tgr: Well, because you have EL installed [00:24:01] I don't see failures locally either [00:24:11] oh, right [00:24:22] lemme try without that [00:24:46] Maybe just don't run that test if we don't has EL [01:48:01] (03CR) 10Gergő Tisza: "Runs fine for me with EventLogging disabled. Besides, I am only adding the dependency if EventLogging is not installed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [01:48:19] (03PS6) 10Gergő Tisza: Basic funnel data logging for UploadWizard. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [02:01:52] (03CR) 10Gergő Tisza: "It only happens when not in debug mode. Fun!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [02:18:26] (03CR) 10Gergő Tisza: "Fails with EventLogging enabled, too." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [02:26:27] 3MediaWiki extensions / 3GWToolset: GWToolset processes just three files and then nothing - 10https://bugzilla.wikimedia.org/63864#c22 (10dan) it should be part of today's deploy, so it should be available on the production server tomorrow. == concern == one concern though is that the image scalers are havi... [05:55:20] (03CR) 10Gilles: [C: 032] Code hygiene: pass flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134128 (owner: 10Hashar) [05:55:51] (03CR) 10Gilles: [V: 032] Code hygiene: pass flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134128 (owner: 10Hashar) [05:56:24] (03CR) 10Gilles: [C: 032 V: 032] Tox environement to run flake8 python linter [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134144 (owner: 10Hashar) [06:53:00] (03PS2) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [06:53:21] (03CR) 10Gilles: jQuery 1.9 compatibility fixes (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [07:03:11] 3MediaWiki extensions / 3Score: Rendered score image overlaps scan image on Wikisource - 10https://bugzilla.wikimedia.org/65252 (10dacuetu) [07:03:38] (03CR) 10Gilles: [C: 032] jshint fixes for mw.UploadWizardDeed.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [07:04:01] (03Merged) 10jenkins-bot: jshint fixes for mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [07:36:01] gi11es: good morning :-} [07:36:21] not sure whether flake8 for analytics/multimedia.git is a good idea but I thought it would [07:36:26] happy to see you merged my change [07:36:39] ou en français [07:43:03] Alors, pas de francais, c'est un canal anglais! [07:43:28] * marktraceur not sure if canal means channel or man-made body of water through a narrow land mass but whatev [07:53:25] marktraceur: it means both [07:53:32] that is the concept of funneling something [07:53:37] i.e. water or conversations [07:53:54] I am going to add the flake8 tox job to analytics/multimedia.git [07:55:34] in short your french was correct :D [07:56:39] But for the lack of accents [07:56:56] * marktraceur blames, in order, lack of compose buttons and lack of UTF-8 support on his server [07:58:07] I don't bother using accents anymore [07:58:36] for casual conversations like on IRC, you can happily skip them [08:00:51] flake8 enabled! [08:01:08] (03CR) 10Hashar: "recheck" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134065 (owner: 10Gilles) [08:07:51] hashar: I hear there are some guys with swords who take issue with that. [08:08:05] yeah speak to them in english :] [08:14:38] Heh [08:56:15] (03PS3) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [08:56:54] (03CR) 10jenkins-bot: [V: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [09:31:52] hey gi11es, i've been thinking about the image scaler issue … if we place the media files in a stash before they are made available to the Special:NewFiles and run the image scaling on them while they're in the stash, will that really solve the issue? won't the image scalers still be overloaded because the media files will still line-up in the queue ... [09:32:44] the difference is that when you do that you can be a good citizen and wait for each thumbnail processing to be done before requesting a new one [09:34:00] when someone or a bot visits the NewFiles page, dozens of thumbnails can be requested at once [09:35:15] there's no escaping the fact that very large files take a long time to generate thumbnails for, but the bursts of having to generate thumbnails for many images like that at once can be avoided [09:58:48] gi11es, are there hooks for MIME-type detection? Or do I have to commit this to core? [09:59:11] (to the MimeMagic.php)? [09:59:36] rillke: I have no idea [10:05:04] gi11es: have a possible idea, but how do you envision those thumbnail requests waiting for each other to finish before kicking off another? [10:05:32] dan-nl: the http requests hang until the thumb is generated [10:05:36] when you hit the scalers [10:05:52] I think a HEAD is even sufficient to do that (and hangs as well) [10:05:56] no need for a GET [10:07:38] so the job would hang until that http reuest finishes … l [10:08:12] thus that job runner would need to wait before pickng up another [10:08:41] so potentially 16 jobs might run at once because of the 16 job runners … would that be okay [10:19:35] we might have to do some resource pooling if it's too much [10:20:19] isn't the amount of job runners configurable anyway? [10:21:16] don't know … aaron would know [10:21:47] it at least gives me an idea to work on … just don't know when i can work on it … current manager has me working on a few projects atm [10:22:15] should be able to start on monday .. will try to get to it sooner [10:34:54] 3MediaWiki extensions / 3TimedMediaHandler: Fatal error: Call to a member function doTransform() on a non-object in TimedMediaThumbnail.php on line 201 - 10https://bugzilla.wikimedia.org/64152#c8 (10Andre Klapper) 5PAT>3RES/FIX Assuming this bug is FIXED as all patches are committed to all branches. If t... [10:35:24] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c8 (10Andre Klapper) Patch was merged yesterday - is there more work left to do here (if yes: please reset the bug report status t... [10:37:56] 3MediaWiki extensions / 3TimedMediaHandler: TMH player defaults to very small .ogv even when it has native webm playback - 10https://bugzilla.wikimedia.org/61760#c11 (10Andre Klapper) https://gerrit.wikimedia.org/r/#/c/114918/ still waiting for review. [10:41:25] 3MediaWiki extensions / 3CommonsMetadata: Value of "Artist" should have a full URL - 10https://bugzilla.wikimedia.org/57187#c6 (10Andre Klapper) 5PAT>3RES/FIX Assuming this bug is FIXED as all patches were merged. If that is not the case: Please reopen and elaborate what is left to do here to get this re... [10:41:39] 3MediaWiki extensions / 3Score: Rendered score image overlaps scan image on Wikisource - 10https://bugzilla.wikimedia.org/65252#c3 (10Bawolff (Brian Wolff)) (In reply to dacuetu from comment #2) > Even simpler: close the browser. Problem fixed! :D Live off the grid! [10:42:53] 3MediaWiki extensions / 3TimedMediaHandler: Appends link to Kaltura - 10https://bugzilla.wikimedia.org/23965#c13 (10Andre Klapper) (In reply to Fabrice Florin from comment #12) > Thanks, RobLa. We plan to revisit this issue shortly when we get ready to > integrate Kaltura's new player with Media Viewer in co... [10:43:41] 3MediaWiki extensions / 3UploadWizard: After uploading files, cannot go back or cancel uploads - 10https://bugzilla.wikimedia.org/32247#c17 (10Andre Klapper) https://gerrit.wikimedia.org/r/9549 Patch has been awaiting review for eleven months... [10:48:39] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c9 (10Rainer Rillke @commons.wikimedia) 5PAT>3RES/FIX (In reply to Andre Klapper from comment #8) Is there a reason we have no... [10:50:09] 3MediaWiki extensions / 3UploadWizard: UploadWizard should not allowing upload two different files with same name at same time - 10https://bugzilla.wikimedia.org/54750 (10Rainer Rillke @commons.wikimedia) 5PAT>3RES/FIX [11:26:03] gi11es: do you know if timedmediahandler or something else is already implementing the background thumbnail creation so i might be able to copy their implementation? [11:34:14] (03PS4) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [11:34:44] (03CR) 10jenkins-bot: [V: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [11:42:21] (03PS5) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [11:42:48] (03CR) 10jenkins-bot: [V: 04-1] Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [11:50:13] dan-nl: UploadWizard uses the upload stash [11:51:39] thanks … will look into how it's creating thumbnails then … do you happen to know how long the upload stash is valid on production? [11:54:05] I don't know, have you found that there's an expiry defined in code? [11:54:17] if it's a php option, I can look up the production value [12:01:37] gi11es: i just remember aaron mentioning something about it being cleared out regularly … maybe every hour [12:01:58] i'll ask him or look through the production config a bit later … thanks [12:03:24] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c10 (10Cometstyles) 5RES/FIX>3REO I still get this (http://i.imgur.com/yNgeWbE.png) and get redirected to this page (http://co... [12:07:10] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c11 (10Rainer Rillke @commons.wikimedia) 5REO>3RES/FIX (In reply to Cometstyles from comment #10) Of course you get because it... [12:13:03] When is UploadWizard usually synchonized? [12:13:43] is there some default schedule for WMF-deployment of extensions ? [12:28:42] rillke: it follows the same deployment schedule as core [12:29:15] oh, thanks [12:34:23] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c12 (10Rainer Rillke @commons.wikimedia) According to [[:mw:MediaWiki_1.24/Roadmap]], the new version will be deployed today to Co... [12:36:36] (03CR) 10Gilles: "I'm running into a very similar problem: https://gerrit.wikimedia.org/r/#/c/134343/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [12:43:43] (03CR) 10Gilles: "Wrong link, I meant: https://gerrit.wikimedia.org/r/#/c/134064/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [13:24:24] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails badly with jshint - 10https://bugzilla.wikimedia.org/47161#c70 (10Antoine "hashar" Musso) So apparently UploadWizard pass the Jenkins job jslint which runs JSHint. Should we consider this bug fixed and make the job voting? :-) [13:34:23] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c13 (10Andre Klapper) FIXED means fixed in the code base. FIXED does not mean deployed on the servers. https://www.mediawiki.org/w... [14:34:59] (03PS1) 10Krinkle: Use example.{com,net,org} instead of proprietary domains [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134360 [14:44:10] (03CR) 10Florianschmidtwelzow: [C: 031] Use example.{com,net,org} instead of proprietary domains [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134360 (owner: 10Krinkle) [15:03:40] 3MediaWiki extensions / 3OggHandler: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Antoine "hashar" Musso) 5PAT>3RES/FIX [15:09:14] (03CR) 10Krinkle: "Some info," (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [15:09:53] gi11es: Timo replied to your qunit / ResourceLoader issue :-) [15:10:27] bd808, do you know which type of MIME type detection MediaWiki uses in prod.? [15:10:42] *in WMF prod. [15:10:59] Hmm... no, but I think I know where to look. Hang on. [15:13:48] and do you agree that MW should have a hook allowing extension to validate files with a given file extensions entirely their own? [15:19:02] rillke: $wgMimeDetectorCommand is NOT set in operations/mediawiki-config.git and the fileinfo module is loaded, so MimeMagic::detectMimeType() should use that in prod cluster. [15:19:38] how did you find out whether the fileinfo module is loaded? [15:19:48] (03CR) 10Krinkle: Record sampling factor in EventLogging calls (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [15:20:28] By shelling into a prod node (terbium) and running `php --rf finfo_open` and `php -m|grep -i file` [15:21:14] I probably could have dug through operation/puppet.git as well, but shell access makes some things faster :) [15:21:25] oh, thank you ... terbium [15:22:49] Terbium is a misc host that mostly gets used for running maintenance scripts against production. https://wikitech.wikimedia.org/wiki/Terbium [15:24:26] rillke: "validate files with a given file extensions entirely their own" -- can you expand on this for me. Is there something you know you need to by-pass? [15:25:19] I have to check first whether my installation has the fileinfo module loaded; it reported the wrong MIME type for CTL files [15:25:33] (03CR) 10MarkTraceur: [C: 032] ":(" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134360 (owner: 10Krinkle) [15:26:50] (03Merged) 10jenkins-bot: Use example.{com,net,org} instead of proprietary domains [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134360 (owner: 10Krinkle) [15:27:29] rillke: Apparently it's built-in to php these days. "This extension is enabled by default as of PHP 5.3.0." -- http://us1.php.net/manual/en/fileinfo.installation.php [15:27:29] On Labs, I got "text/plain" and on my homebrewn wiki, "application/acad" [15:30:39] Well [15:30:55] Now is when I would say "I'm working from home" but none of the in-office team members are here. [15:31:01] * marktraceur putzes around [15:31:19] marktraceur: You got up too early :) [15:31:36] Actually I slept in! [15:31:42] But WFHing means not commuting [15:31:58] And also the in-office team members are what you might call ABYSMAL at being on IRC all the time [15:32:40] bd808, did you see the https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings/2014-05-20 yet? [15:32:46] * bd808 fat fingered the close keyboard shortcut [15:34:04] rillke: I did see that. Unfortunately I have a conflicting meeting, but I'll try to scan my irc client when I can. [15:44:53] even in production, if you turn off the js-client validation: File extension ".mol" does not match the detected MIME type of the file (text/plain). [15:45:38] So I guess I have to write some code that validates files with *.mol extension ... and reports the correct MIME type [15:46:49] http://fab.wmflabs.org/T345 - bd808 [15:52:38] rillke: I do see "chemical/x-mdl-molfile mol" in /etc/mime.types on terbium. I guess you may need to trace through the code to see if there's a clear reason why this isn't being used. [15:54:14] (03PS6) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [15:54:48] (03CR) 10Gilles: "Thanks for the feedback, Timo, I'll address it afterwards, right now I'm just trying to make the build pass." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [16:19:40] tgr: fyi (and Fabrice's if he's around) I'm WFHing for to help keep my apartment mostly intact today [16:32:52] (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [16:32:58] (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [16:35:58] (03PS7) 10Gilles: Record sampling factor in EventLogging calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 [16:37:21] (03CR) 10Gilles: Record sampling factor in EventLogging calls (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [17:34:49] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c14 (10Tisza Gergő) Maybe something to revisit after the Phabricator switch as the bug tracker and the version control system is c... [17:52:54] (03CR) 10Aaron Schulz: [C: 04-1] Automatically re-add transcode jobs if transcode pending for 72h [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [18:30:40] (03CR) 10Krinkle: Record sampling factor in EventLogging calls (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134064 (owner: 10Gilles) [20:13:49] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c15 (10Rainer Rillke @commons.wikimedia) No, this isn't deployed yet :( so it will be on Tuesday, 27 May 2014 [20:17:50] 3MediaWiki extensions / 3UploadWizard: No error message in UploadWizard for files exceeding MP limit - 10https://bugzilla.wikimedia.org/65552 (10Dominic) 3NEW p:3Unprio s:3normal a:3None For UploadWizard, files exceeding the megapixel limit only display the broken thumbnail icon in the preview, but t... [20:35:04] 3MediaWiki extensions / 3PdfHandler: PDF fails to render on PostgreSQL and FreeBSD - 10https://bugzilla.wikimedia.org/59147#c19 (10Jeff Janes) Andre: I have not tested on FreeBSD, and can't readily do so. But I see no reason to think it behaves differently than Linux does in this regard, until someone else... [20:41:48] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c16 (10Tisza Gergő) What is the impact of this bug? We could do a backmerge if it affects a lot of uploads. [20:57:20] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c17 (10Rainer Rillke @commons.wikimedia) > What is the impact of this bug? We could do a backmerge if it affects a lot of > uploa... [21:22:18] 3MediaWiki extensions / 3MultimediaViewer: Lightbox closes when exiting fullscreen - 10https://bugzilla.wikimedia.org/62578#c4 (10Jarry1250) Has this been discussed? I too found it surprising. [21:23:43] bd808, did you get the invitation for code reviewing? https://gerrit.wikimedia.org/r/133069/ -- there is not much to do but I'd like to be sure all's sane.... [21:24:19] 3MediaWiki extensions / 3MultimediaViewer: Lightbox closes when exiting fullscreen - 10https://bugzilla.wikimedia.org/62578#c5 (10Tisza Gergő) (In reply to Jarry1250 from comment #4) > Has this been discussed? I too found it surprising. No, I meant to raise this on design-l but forgot. [21:24:43] rillke: I did. I haven't really looked at it yet though. :/ [21:24:55] It's not urgent. [21:44:43] (03CR) 10Gergő Tisza: [C: 031] Take sampling factor into account [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/134065 (owner: 10Gilles) [21:51:41] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c18 (10Tisza Gergő) That's about 20 images a day. We probably should not use a SWAT deploy for something like that. [22:32:21] tgr: Can you review Aaron's patch? https://gerrit.wikimedia.org/r/#/c/134503/1 [22:43:03] Which versions of IE aren't supported very well, again? <9? [22:43:19] For MMV, that is [22:45:35] marktraceur: on it [22:46:54] Keegan: if by "not very well" you mean "not at all" then yes [22:47:29] :) thanks [22:47:55] Is that due to OOjs? [22:50:03] Keegan: yes [22:51:41] although we probably have lots of incompatibilites in our own code as well [22:52:13] given the time limitations, we probably would have been forced to cut old IEs loose anyway [23:18:27] tgr: Did you not have +2 powers? [23:19:25] marktraceur: I do, I am just reluctant to use them in core [23:19:40] but I can +2 this if needed, it's relatively simple [23:19:51] I was hoping so [23:20:23] fabr crap [23:20:29] tgr: Is Fabrice near you? [23:20:44] haven't seen him for a while [23:20:53] He's in a room with James_F apparently [23:20:56] Ah well [23:20:56] do we plan on backporting this? [23:21:16] tgr: I would have if we hadn't missed the SWAT [23:21:22] Could probably put gi11es on point for tomorrow morning's SWAT [23:21:41] I don't particularly relish the idea of leaving it unfixed for much longer [23:28:10] i have no idea how to test the code though :( [23:28:24] there is no way to reupload a file with UW, right? [23:28:37] no intentional way I mean [23:29:13] eh, whatever [23:29:27] the same code path should be hit by a regular upload as well [23:31:42] shall I set up a SWAT then? [23:31:47] tgr: Sure [23:45:31] marktraceur: the parent patch is already backported: https://gerrit.wikimedia.org/r/#/c/134502/ [23:45:49] Well...gee. That's mighty silly. [23:45:59] that removes the FOR UPDATE from LocalFile::lock() so probably the exceptions are fixed already [23:46:13] Hm [23:46:37] https://gerrit.wikimedia.org/r/#/c/134505/ not backported [23:46:43] Ready to be, but not merged [23:48:06] oh yeah, my bad [23:48:21] so maybe it's scheduled for SWAT already? [23:49:34] Is it? [23:49:56] No, I don't see it scheduled [23:50:04] Might as well schedule both [23:51:21] fair enough