[00:01:31] (03PS2) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [00:24:35] tgr: Aaron says he'd test a protected method "via reflection", does he mean http://php.net/manual/en/book.reflection.php ? [00:24:50] yes [00:24:52] (don't send the frontend engineer to write PHP unit tests, but ah well) [00:24:55] OK [00:25:06] you can use ReflectionMethod to unprotect it [00:25:12] Fun times [00:25:42] but you can pass me the task if you prefer working on something else [00:25:51] and if it is not super urgent [00:25:53] Naw it's all right [00:26:10] It sounds like we'll need me to know this stuff anyway, focusing more on tech debt and all [00:26:23] And I'm not *totally* hopeless, just mostly [00:28:53] marktraceur: as I understand it, no one enjoys writing php unit tests, frontend or backend. so props. [00:29:01] Righto [00:29:49] I kind of like it [00:30:13] although I wouldn't if I had to test the media handling code [00:31:53] Yeh [00:32:01] Well, we'll see what I can whip up [00:32:12] I don't think it'll be too bad, we'll start with small steps. [07:16:19] (03PS3) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [07:22:35] (03CR) 10Gergő Tisza: "Could not actually test the last version due to bug 65386 (looks like my setup got messed up somehow)." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [08:29:13] (03CR) 10Gilles: [C: 032] Revert "Minimal zoom implementation". [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133539 (owner: 10Gergő Tisza) [08:29:50] (03Merged) 10jenkins-bot: Revert "Minimal zoom implementation". [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133539 (owner: 10Gergő Tisza) [09:06:51] (03PS1) 10Gilles: Fix IE9 history navigation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133682 [09:36:34] (03PS1) 10Gilles: Wait some more for the close button to appear [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133685 [11:56:08] hey gi11es, when you have a moment. i saw in fabrice's multimedia summary that a new throttle was applied to gwtoolset. what is the new throttle? i couldn't find it in the mediawiki-config. also i didn't think the problem had to do with throttling the app, but with trying to upload many large images at once, which is user controllable ... [11:57:16] dan-nl: hasn't been merged yet https://gerrit.wikimedia.org/r/#/c/132112/ [11:57:28] oh okay, good [11:57:36] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/535 [11:58:02] i think that if we notify a gwtoolset user then that should be enough, if they don't pay attention the commons bureacrats can remove them from the gwtoolset right [13:09:53] (03CR) 10Fomafix: "Sorry for the sarcasm. It was a response for not answering my questions." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [13:53:12] (03PS1) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [14:20:44] and Media Viewer is broken on beta... getFileSearchOptions() returns an empty array for articles [14:22:55] I'm looking for the breaking core change [14:27:34] found the culprit [14:30:01] https://gerrit.wikimedia.org/r/#/c/133652/ [14:30:24] tgr: since you weren't here, Media Viewer is broken on master/beta because of that core commit [14:33:11] gi11es: we could just get rid of getFileSearchOptions, IMO [14:33:31] and just load all the time? [14:34:22] well, it's a JS file, it's cached [14:35:02] it only makes a difference for users who would never visit any article with an image in it [14:35:15] that's probably not typical [14:36:10] right [14:36:15] and the main script would not load anyway [14:36:30] this just controls the head/bootstrap, right? [14:36:34] yes [14:37:04] should we at least check that it's in the article namespace, if there is one? [14:37:28] we might want to think about what are the contexts where we maybe don't want to load it, and getFileSearchOptions kept us out so far, like special pages [14:37:43] NS_MEDIAWIKI ? [14:37:55] NS_SPECIAL is separate [14:37:56] we haven't been limited to the article namespace until now [14:38:49] NS_MEDIAWIKI is harmless, you could exclude it but it would not mean any benefit [14:39:42] special pages and weird contexts like an article history view are the ones where I can imagine the click replaying to actually break something [14:40:26] also, we should ask someone who knows more about ResourceLoader, but loading it all the time might actually be more effective [14:41:15] because there are other scripts loaded all the time, and if you can always keep the same script group together, that means less split in JS cache [14:41:59] on modern browsers ResourceLoader uses local storage so it doesn't matter, I think, but on old ones it might help a little [14:44:41] or we could just fix getFileSearchOptions, looking at the commit it's probably just a missing public flag [14:47:17] (03CR) 10Gilles: [C: 04-1] "Something seems wrong with the schema loading, when opening UploadWizard it doesn't find it: https://www.dropbox.com/s/lzjeco3iy7f9xq4/Scr" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [14:48:44] (03CR) 10Gilles: "The schema dependency is declared differently in MediaViewer, might be worth looking at." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [14:50:01] gi11es: ori told me $wgEventLoggingSchemas is the hot new thing [14:50:18] the hot new thing that doesn't work, apparently :) [14:50:38] (which does not necessarily mean I am using it right) [14:50:57] that warning means that the event won't go through [14:51:26] we were having the same ones back when MediaViewer was trying to send events in head/bootstrap before the schema was available, before I fixed the dependency [14:52:00] it did work in the version of the patch I submitted Tuesday, though [14:52:26] right now my UW setup is utterly broken so I can't check [14:52:30] ¯\(°_o)/¯ [14:52:57] I had UW installed manually a while back [17:57:50] marktraceur: can you merge the zoom revert patch now? I am writing another patch that will conflict, and that would make backporting much less fun [17:58:39] ooh, its actually merged already, nice [17:59:27] Righto [17:59:31] Oh [18:02:16] (03CR) 10MarkTraceur: ""Sometime in the next twelve months" and "combined with other changes" sounds the best. Basically this will consist of me and other review" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [18:18:41] Oh, man, I forgot about what I was doing yesterday! Back to tests. [18:35:25] (03PS1) 10Rillke: MMV: Replace deprecated jQuery.browser with jQuery.client [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) [18:36:48] (03PS2) 10MarkTraceur: Replace deprecated jQuery.browser with jQuery.client [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [18:37:00] (03PS1) 10Gergő Tisza: Temp fix for core bug (getFileSearchOptions() stopped working) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133763 [18:37:22] marktraceur: ^^ [18:38:10] (03CR) 10Rillke: [C: 04-1] "oops" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [18:38:13] (03CR) 10MarkTraceur: [C: 04-1] "Your patch is better than mine, but I'd prefer to use the test method instead of string comparison, see:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [18:39:42] (03PS3) 10Rillke: Replace deprecated jQuery.browser with jQuery.client [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) [18:40:54] (03CR) 10MarkTraceur: [C: 04-1] "See comment on PS2" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [18:42:41] (03PS1) 10Gergő Tisza: Revert "Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot" [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/133765 [18:42:43] (03CR) 10jenkins-bot: [V: 04-1] Revert "Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot" [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/133765 (owner: 10Gergő Tisza) [18:43:11] (03CR) 10Gergő Tisza: [C: 032 V: 032] Revert "Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot" [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/133765 (owner: 10Gergő Tisza) [18:43:14] (03CR) 10Rillke: [C: 04-1] "See https://gerrit.wikimedia.org/r/#/c/74425/3/resources/mw.FormDataTransport.js" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (owner: 10MarkTraceur) [18:43:27] (03CR) 10MarkTraceur: [C: 032] "Well, here we go." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133763 (owner: 10Gergő Tisza) [18:44:51] (03Merged) 10jenkins-bot: Temp fix for core bug (getFileSearchOptions() stopped working) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133763 (owner: 10Gergő Tisza) [18:45:01] (03PS2) 10Rillke: Fix up one issue with jQuery 1.9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (https://bugzilla.wikimedia.org/65371) (owner: 10MarkTraceur) [18:45:14] (03PS1) 10Gergő Tisza: Add sampling to unsampled event logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133766 [18:45:22] marktraceur: ^^ this too please [18:47:11] (03CR) 10MarkTraceur: [C: 032] "Got me there. Cheers!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [18:47:29] (03CR) 10Rillke: "Well, okay in this context use seems to be appropriate... even if it looks a bit strange to have the map for just one browser (do you expe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (https://bugzilla.wikimedia.org/65371) (owner: 10MarkTraceur) [18:47:33] Thanks rillke [18:47:47] (03Merged) 10jenkins-bot: Replace deprecated jQuery.browser with jQuery.client [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133762 (https://bugzilla.wikimedia.org/65371) (owner: 10Rillke) [19:03:17] marktraceur: abandon? https://gerrit.wikimedia.org/r/132020 [19:06:24] * se4598 was confused. [19:19:17] (03PS1) 10Anomie: ApiQueryBase subclasses take an ApiQuery, not an ApiMain [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133772 (https://bugzilla.wikimedia.org/65407) [19:56:30] (03CR) 10Gergő Tisza: "Reverted because I was getting non-change-related errors again (jQuery update maybe?) and ops needed a quick fix for our analytics volume." [extensions/MultimediaViewer] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/133451 (owner: 10Krinkle) [20:25:08] (03CR) 10Gergő Tisza: [C: 031] ApiQueryBase subclasses take an ApiQuery, not an ApiMain [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133772 (https://bugzilla.wikimedia.org/65407) (owner: 10Anomie) [20:28:00] (03Abandoned) 10MarkTraceur: Fix up one issue with jQuery 1.9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (https://bugzilla.wikimedia.org/65371) (owner: 10MarkTraceur) [20:32:14] marktraceur: can i has review? https://gerrit.wikimedia.org/r/#/c/133766/ [20:33:15] Will do [20:44:55] (03CR) 10MarkTraceur: [C: 032] Add sampling to unsampled event logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133766 (owner: 10Gergő Tisza) [20:45:31] (03Merged) 10jenkins-bot: Add sampling to unsampled event logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133766 (owner: 10Gergő Tisza) [20:46:02] (03PS1) 10Gergő Tisza: Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133829 [20:46:35] (03CR) 10jenkins-bot: [V: 04-1] Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133829 (owner: 10Gergő Tisza) [20:47:24] Womp womp tgr [20:47:33] Oh it's a backport. [20:47:47] Oh because jquery [20:47:51] yes [20:47:57] GOD DAMN IT KRINKLE. [20:48:08] although I don't entirely undestand how, it being a backport [20:49:13] oh yeah, wmf5 does have that already [20:49:41] (03CR) 10Gergő Tisza: "Ignore the the test error, it's unrelated." [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133829 (owner: 10Gergő Tisza) [20:50:39] and I cannot even cherry-pick to wmf4 [20:50:44] this will be a fun day [21:05:05] (03PS1) 10Catrope: Fix API interaction code for MW core changes in 23632a4ecddd [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133834 (https://bugzilla.wikimedia.org/65407) [21:06:28] (03PS1) 10Gergő Tisza: Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133835 [21:07:00] (03CR) 10jenkins-bot: [V: 04-1] Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133835 (owner: 10Gergő Tisza) [21:08:44] (03CR) 10Gergő Tisza: "Ignore the test error, that's something broken by the jQuery upgrade. (Although how it affects 1.24wmf4, I have no clue...)" [extensions/MultimediaViewer] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133835 (owner: 10Gergő Tisza) [21:12:42] (03CR) 10Gergő Tisza: "I think anomie just patched this." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133834 (https://bugzilla.wikimedia.org/65407) (owner: 10Catrope) [21:14:58] (03Abandoned) 10Catrope: Fix API interaction code for MW core changes in 23632a4ecddd [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133834 (https://bugzilla.wikimedia.org/65407) (owner: 10Catrope) [21:15:12] (03CR) 10Catrope: [C: 032] ApiQueryBase subclasses take an ApiQuery, not an ApiMain [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133772 (https://bugzilla.wikimedia.org/65407) (owner: 10Anomie) [21:15:18] (03Merged) 10jenkins-bot: ApiQueryBase subclasses take an ApiQuery, not an ApiMain [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133772 (https://bugzilla.wikimedia.org/65407) (owner: 10Anomie) [21:15:53] (03CR) 10Ori.livneh: [C: 031] Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133829 (owner: 10Gergő Tisza) [21:17:28] (03CR) 10Ori.livneh: [C: 032 V: 032] Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133835 (owner: 10Gergő Tisza) [21:17:44] (03CR) 10Ori.livneh: [C: 032 V: 032] Add sampling to unsampled event logging [extensions/MultimediaViewer] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133829 (owner: 10Gergő Tisza) [21:39:45] the 'in the news' image on enwp main page does not open the viewer [21:39:51] maybe a different template? [21:43:19] tgr: Yes, I can reproduce this issue. Also, yesterday Jared clicked on another main page image that was not ‘in the news’, and it didn’t show either in MV. Then he clicked it again and it did show up in MV. Very strange. I didn’t file a ticket, because I couldn’t reproduce it myself afterwards, but I saw it happen several times — in a previous meeting with Howie, the same intermittent performance. I wonder if [21:43:19] there could be an issue with that main page, rather than the individual images? [21:45:17] fabriceflorin: strange things can happen on Thursdays [21:45:36] It's basically the twilight zone [21:45:38] I would ignore that unless replicated [21:46:27] but the Conchita image is very deterministically not working [21:47:10] tgr: Got it. But let’s keep an eye on this. I’ll try to reproduce whenever I can. BTW, my meeting with Howie was on a Wedesday. [21:47:59] oh, because they actually created a cropped version of the file just for the main page [21:48:29] I wonder if we should just open the file which is linked to in such cases [21:49:13] well that's not going to happen now [21:49:45] if they want to optimize for the viewer, they can just use CSS clipping [21:52:20] fabriceflorin: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#From_Tucvbif > can we add that to the FAQ? [22:02:55] (03PS1) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) [22:29:32] (03PS1) 10Jforrester: ApiQueryBase subclasses take an ApiQuery, not an ApiMain [extensions/TimedMediaHandler] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133852 (https://bugzilla.wikimedia.org/65407) [22:55:37] (03CR) 10Krinkle: "Superseded by I040cfba574fa0." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (https://bugzilla.wikimedia.org/65371) (owner: 10MarkTraceur) [22:56:17] (03CR) 10Krinkle: "Note, this wouldn't have caused any actual issues. It's a soft notice. The migration plugin covers this until we remove that compat layer." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132020 (https://bugzilla.wikimedia.org/65371) (owner: 10MarkTraceur) [23:09:15] (03PS1) 10Gergő Tisza: Revert "Temp fix for core bug (getFileSearchOptions() stopped working)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133860 [23:09:48] (03CR) 10Gergő Tisza: [C: 032] Revert "Temp fix for core bug (getFileSearchOptions() stopped working)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133860 (owner: 10Gergő Tisza) [23:10:21] (03Merged) 10jenkins-bot: Revert "Temp fix for core bug (getFileSearchOptions() stopped working)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133860 (owner: 10Gergő Tisza)