[00:06:48] marktraceur: we should properly namespace new UploadWizard classes instead of putting everything under mw [00:06:59] what do you think, mw.uw or just uw? [00:07:16] all the mw prefixing seemed a bit superfluous in MediaViewer [00:07:49] Yeah [00:08:23] tgr: It'll all get namespaced in the mw object, but we could probably just call it uw..* [00:12:03] or maybe call it uploadWizard and use closures to shorten it to uw, like we do it with mediaWiki? [00:14:51] Hm, maybe [00:15:31] tgr: You mean call it mediaWiki.uploadWizard and use closures like function ( mw, uw, $ ) { }( mediaWiki, mediaWiki.uploadWizard, jQuery) ? [00:16:01] yes, either that or just window.uploadWizard [00:16:50] Ehhhh [00:16:55] Please not :/ [00:17:28] one global object per extension does not seem excessive [00:17:36] but I'm fine with it either way [00:19:34] Yeah, because the next guy comes along and writes Extension:UnblockWizard and then everything goes to shit [00:19:44] Better not to mess with the global namespace if we can avoid it IMO [00:20:14] Like, yes, as long as you aren't using both in a closure, it's fine [00:20:22] But maybe enwiki's Upload Wizard has some desire to be window.uploadWizard [00:20:26] Or whatever. [00:20:38] good point [07:33:27] (03CR) 10Gilles: [C: 032] Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [07:34:03] (03Merged) 10jenkins-bot: Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [08:02:51] (03CR) 10Gilles: "I think it's one of those rare situations where displaying an image-based spinner gif would be more appropriate than the 404/small thumbna" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [08:31:41] (03CR) 10Gergő Tisza: "There are two ways to do this:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [09:20:29] (03CR) 10Gilles: "Swapping the spinner in when the 404 is detected sounds fine to me." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [10:02:47] (03PS1) 10Gilles: Fix IE9 support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133218 (https://bugzilla.wikimedia.org/65225) [10:03:31] (03CR) 10jenkins-bot: [V: 04-1] Fix IE9 support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133218 (https://bugzilla.wikimedia.org/65225) (owner: 10Gilles) [10:06:31] (03PS2) 10Gilles: Fix IE9 support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133218 (https://bugzilla.wikimedia.org/65225) [10:24:38] (03PS9) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [10:29:01] (03CR) 10Gilles: "This last change should address your concern, Gergo" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [11:58:57] (03PS1) 10Gilles: Generate SQL to a separate folder [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133223 [17:35:46] gi11es: https://www.mediawiki.org/wiki/Architecture_meetings/Performance_guidelines_discussion_2014-05-14 might be interesting [17:58:41] gi11es, marktraceur: re showing the number of people who disabled MediaViewer: there is a generic bug about accessing user props on labs, maybe we could help move that forward [17:58:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=58196 [18:10:06] Uhm [18:10:15] tgr: I think there's a bug about getting that data for BetaFeatures anyway [18:11:29] isn't that one about people who have disabled the beta feature? [18:11:48] Uh, yeah? [18:11:54] Wait, what is this [18:12:20] in the meeting we were talking about the normal disable pref, I thought [18:12:50] tgr: And showing the number of people who have disabled it...next to the preference? Or just on a metrics page somewhere? [18:13:20] just on a metrics page [18:13:40] Oh, sure. [18:13:42] I think we already have that data, just gotta fetch it. [18:14:11] we do, it's in the props table [18:14:27] the bug I mentioned is about making that table sort of public [18:14:40] tgr: Ehhhhhhhhhhh [18:15:11] people are planning a UI for it, that would make it unnecessary to do one-off tasks for getting the data every time something like this comes up [18:15:30] yeah, the "sort of" part is what makes it hard [18:17:25] I don't know, I'd rather not play with fire and just use the "right" tools for the job, we can generate a TSV for this [18:17:33] Like basically trivially. [18:19:18] sure [18:19:49] the main motivation for that bug is not WMF teams but all the other folks who do not have that privilege [18:19:57] Right. [18:20:06] it would just be a good chance to move it forward [18:20:26] * marktraceur isn't opposed [18:20:49] We do have a lot of work on the horizon, but if we can fit this in I'm a fan. [18:31:05] gmane for multimedia-l looks very broken: http://news.gmane.org/gmane.org.wikimedia.multimedia [18:31:21] it's like one in ten mails make it there [18:33:21] maybe a good time for us to jump on the mailman 3 train? https://bugzilla.wikimedia.org/show_bug.cgi?id=64547 [18:35:35] Huh. [18:35:52] tgr: I'd be down [19:20:40] (03CR) 10Gergő Tisza: [C: 032] Fix IE9 support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133218 (https://bugzilla.wikimedia.org/65225) (owner: 10Gilles) [19:21:15] (03Merged) 10jenkins-bot: Fix IE9 support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/133218 (https://bugzilla.wikimedia.org/65225) (owner: 10Gilles) [19:35:19] (03CR) 10Gergő Tisza: [C: 032] "Looking good, thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [19:35:52] (03Merged) 10jenkins-bot: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [19:38:42] Whoa, gi11es, suddenly Python [19:43:44] Also apparently automatic deployment. [19:44:17] (03CR) 10MarkTraceur: [C: 032 V: 032] "Let's see how this goes!" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133223 (owner: 10Gilles) [19:46:11] gi11es: There were untracked changes on stat1003 for some reason; I stashed them [19:46:23] * YuviPanda waves [19:46:27] Hoi YuviPanda [19:46:34] ohai +marktraceur [19:46:36] :P [19:47:18] saw the analytics list about how UW is going to be using a funnel based tracking for UW. The app is using something similar, so wanted to pop in and say hi [19:47:26] and also ask how you guys are planning on analyzing / visualizing it [19:47:29] if there's a plan at all atm [19:47:59] YuviPanda: Probably something like throwing sql and limn configs at it [19:48:03] That's the general way we do things [19:48:15] But I'm not really up to date on those plans [19:48:24] hmm, ok. sql is a bit of a PITA for these things, IIRC, hence asking [19:50:17] marktraceur: do you have a rough timeline on when that's going to happen? apps won't be doing any viz work for 2 more months, so if you guys are doing it before that we can perhaps piggy back. [19:51:00] Uh [19:51:15] YuviPanda: Probably within the next few weeks, not sure when exactly though [19:51:32] marktraceur: ah, cool. Can you keep me posted in some way when it happens? [19:51:59] Sure [19:52:17] ty! [20:18:40] (03PS1) 10MarkTraceur: Fix deploy and generation scripts to be nicer [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133353 [20:18:50] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix deploy and generation scripts to be nicer [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133353 (owner: 10MarkTraceur) [21:05:44] robla: https://en.wikipedia.org/wiki/Special:TemplateSandbox?prefix=User%3ATgr+%28WMF%29%2FTemplateSandbox%2Fmaps-nolink&page=Namibia&revid=&text= [21:06:22] * robla looks [21:13:28] Tgr: interestingly, the template documentation seems to imply that it should be possible to specify an empty link [21:14:19] it is, if you add |link=| [21:14:55] I just made it default [21:16:02] I mean if you add that in the Image label begin template [21:19:58] is changing the default for that template a reasonable thing to do? [21:20:10] (for real, not just in the sandbox?) [21:24:19] tgr, are you working on Bug 64883 ? [21:24:48] rillke: no [21:24:54] probably not this week [21:25:09] but we'll probably pick it for next week, looks pretty bad [21:26:30] okay ... try to find out more details in the meanwhile (on the uploadwizard side); IMHO there shouldn't be a general ignorewarnings but a specific "ignore-that-warning" [21:26:40] in the API [21:29:12] robla: from the users POV, going to a Commons image page is not at all helpful, and probably most of the time they just misclick a city label, in which case it is extra confusing [21:29:49] from a legal POV, some people are unhappy about using link= on images which are not PD [21:29:52] rillke: Hi! [21:30:03] I'm back now :) [21:30:38] (which is something that could be handled more sanely once we have structrured data btw) [21:30:43] Great to see that, bawolff. [21:31:02] * rillke struggled with all kind of stuff like recently Jenkins [21:31:43] I've been told it helps if you swear at it [21:31:52] * bawolff only partially kidding [21:33:33] bd808, I followed https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension but finally I am not able to upload the generated XML; only *wmf* guys are able to do that, I think [21:33:44] bawolff: I think if you swear at it, you just let it know you're coming. better to surprise it. [21:34:52] rillke: I think you can submit it somewhere, but wmf folks have to approve it. I've never actually done it, or tried to do it [21:35:03] rillke: Do you have the JJB config you want checked in yet? [21:35:16] Tgr: are you thinking of being bold and making the change? if not, we should probably at least say something on the talk page [21:36:34] rillke: I see that you put me on review for it already :) [21:36:39] robla: I'll go with the talk page [21:36:43] I'll try to get to that soon [21:37:09] I'm not being paid enough to try to be bold on the English Wikipedia :) [21:37:11] * rillke thanks [21:37:55] :-) [21:38:04] There's some default configuration for extension, I'd like to start with, bd808. [21:38:09] there was this mail thread recently about the "push to add drama" button... making changes on enwiki with a newbie account feels kind of like that [21:38:11] *extensions [21:40:53] tgr: Where was that (It sounds like it would be a funny thread) [21:43:04] bawolff: forgot but it was about this video being an accurate depiction of the Wikimedia experience: https://www.youtube.com/watch?v=316AzLYfAzw [21:43:27] lol [21:45:46] tgr: That’s a great video, thanks for sharing … we could all use that type of drama in our lives. :) [22:25:40] Hrm. [22:26:03] gi11es, tgr - the big code convention patch that's generally unoffensive but will conflict with every unmerged patch...how should we handle it? [22:26:10] I want to merge it but I don't want to rebase 50 old patches. [22:27:19] eh [22:27:56] that reminds me to those bots which fix stuff like space after == and cause edit conflicts and nasty diffs [22:28:06] I'd also be OK with the idea that we just update code we touch. [22:28:07] the usual wisdom is ban on sight :) [22:28:12] And abandon this patch. [22:28:16] yeah, I would prefer that [22:28:19] 'kay [22:28:24] I'll apologize to Fomafix. [22:28:31] Sorry to you too, gi11es [22:28:36] maybe even apply the patch per file whenever you touch that file? [22:29:08] not sure that's less work than doing it by hand though [22:29:39] (03Abandoned) 10MarkTraceur: Apply coding conventions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [22:30:52] It wouldn't be, no [22:39:13] tgr: Let me know when we’re ready to test #588 - Zoom Link for Media Viewer. I want to make sure we can deploy it tomorrow … [22:55:10] (03PS6) 10Gergő Tisza: Minimal zoom implementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 [22:55:14] (03CR) 10jenkins-bot: [V: 04-1] Minimal zoom implementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:59:07] (03PS7) 10Gergő Tisza: Minimal zoom implementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 [23:02:57] fabriceflorin: ^^ [23:03:03] needs a review + merge [23:03:50] tgr: Cool, thanks. marktraceur, do you think you could review and merge the zoom feature above, so I can test it today, in time for tomorrow’s release? [23:47:49] fabriceflorin: if you still have your vagrant box, you might be able to test it there [23:48:36] OK, let me give this a whirl, if I can remember how to do it. [23:48:36] VisualEditor is now on Commons! [23:48:38] As a BF. [23:49:11] marktraceur: Oh wow, I hope we don’t get caught up in that maelstorm. [23:49:23] fabriceflorin: the command to check out the version with a zoom is [23:49:35] I'm sure it's fine [23:49:47] cd /vagrant/mediawiki/extensions/MultimediaViewer && git review -d 132133 [23:49:48] marktraceur: At least it’s a beta feature, would be worse if it were live. [23:50:18] marktraceur: Should I try to test the zoom in vagrant, or wait for you to merge it to beta? [23:50:39] I wasn't looking at it even, but I can merge it...soon [23:50:48] Provided nothing's wrong [23:53:00] marktraceur: Cool. We really want to deploy this feature tomorrow, if possible, to address this largest issue, which represented about 21% of actionable user feedack. [23:53:51] fabriceflorin: Of the portion who responded. That 21% number is very misleading. [23:54:40] 76% didn't have any comments at all, so of the 24% who did, 21% wanted zoom. So about 5% total. And remember that there's bound to be response bias in the survey. [23:55:02] well lack of zoom was certainly the most reasonably-sounding complaint [23:55:07] Sure! [23:55:14] I'm just trying to put it in the right ontext [23:55:16] context. [23:55:18] as in, people could actually explain why it is a problem for them [23:55:44] marktraceur: If you study the detailed results, you will see that your statement above is not quite accurate: https://docs.google.com/a/wikimedia.org/spreadsheets/d/1ISmLR7roGk_5jvVPHrqPLLL78pX0s0wUTzXayOSlLjk/edit#gid=0 [23:56:21] I did to arrive at the numbers I just cited [23:56:58] fabriceflorin: 1727 people answered the survey, of whom 414 answered the "comments" question, of whom 85 wanted zoom. [23:57:04] 85 is not 21% of 1727 [23:57:59] 3 types of lies :P [23:59:22] We hand-coded about 1,140 comments and sorted them into 3 categories: Useful, or actionable suggestions (30%); No action needed (69%); and Inappropriate (1%). The change requests percentages are from the 'useful' category, as clearly stated in our report and spreadsheet: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Survey/Results_-_05-05-2014#Comments