[00:00:06] (03CR) 10Gergő Tisza: [C: 032] "Tried to test the bug, but Safari/Win via wine cannor run MediaViewer at all, and on virtualbox I run into the domain name issue (it alway" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131930 (owner: 10Gilles) [00:00:39] (03Merged) 10jenkins-bot: Improve post-fullscreen panel/image sizing logic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131930 (owner: 10Gilles) [00:42:31] (03PS6) 10Gergő Tisza: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 (owner: 10MarkTraceur) [00:42:34] (03CR) 10jenkins-bot: [V: 04-1] Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 (owner: 10MarkTraceur) [01:45:09] marktraceur: can I just leave you a bug link and assume you'll add it to the team's inbox/to-review? kthx: https://bugzilla.wikimedia.org/show_bug.cgi?id=49118 [01:46:27] Uhhhh [01:46:42] greg-g: Can you maybe email the Multimedia list? I don't scale. [01:46:50] FINE [01:48:47] marktraceur: {{done}} [01:48:52] Thanks [03:35:51] (03PS2) 10Gerrit Patch Uploader: Apply coding conventions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 [03:35:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [03:37:32] ... [06:05:25] (03PS3) 10Gerrit Patch Uploader: Apply coding conventions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 [06:05:28] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [06:27:22] (03PS4) 10Gerrit Patch Uploader: Apply coding conventions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 [06:27:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [06:34:48] tgr: I'm totally fine with you getting EventLogging data access. I believe all you need is the ability to ssh to tin.eqiad.wmnet, which you can request from ops if you don't have it. then I'll PM you about what's next [07:29:10] (03CR) 10Gilles: [C: 04-1] Apply coding conventions (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [07:44:06] (03PS5) 10Gerrit Patch Uploader: Apply coding conventions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 [07:44:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132957 (owner: 10Gerrit Patch Uploader) [07:52:57] (03CR) 10Gilles: [C: 032] UploadWizard: Add support for PostgreSQL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132328 (https://bugzilla.wikimedia.org/64067) (owner: 10Jjanes) [07:53:34] (03Merged) 10jenkins-bot: UploadWizard: Add support for PostgreSQL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132328 (https://bugzilla.wikimedia.org/64067) (owner: 10Jjanes) [07:54:00] (03CR) 10Gilles: [C: 032] Change colon to underscore in test file names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/132728 (https://bugzilla.wikimedia.org/65139) (owner: 10Gergő Tisza) [07:54:06] (03Merged) 10jenkins-bot: Change colon to underscore in test file names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/132728 (https://bugzilla.wikimedia.org/65139) (owner: 10Gergő Tisza) [08:19:20] (03CR) 10Gilles: [C: 032] Do not log a metadata event when the user presses the wrong key [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 (owner: 10Gergő Tisza) [08:19:58] (03Merged) 10jenkins-bot: Do not log a metadata event when the user presses the wrong key [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 (owner: 10Gergő Tisza) [08:29:45] (03CR) 10Gilles: [C: 04-1] "Breaks some CSS. With this changeset applied the progress bar appears in the wrong location, inside of the panel:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [08:35:10] (03CR) 10Gilles: [C: 04-1] "I'm not suggesting a full cleanup, it's just that all the zoom-related code introduced here follows a single theme (zoom) and could easily" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [09:38:41] Hey, any ideas why MediaViewe appears when I try to go to a file description page? [09:38:46] MediaViewer* [09:39:02] There is this small rectangle just under files when you use thumbnails [09:39:15] I tried to click it, but I get redirected to MediaViewer [09:39:52] (It does open fine if I right-click it and choose 'open in a new tab') [11:29:56] twkozlowski: this? https://www.dropbox.com/s/1rx37c774q71jvd/Screen%20Shot%202014-05-13%20at%2013.29.19.png [11:30:41] (03PS1) 10Gilles: Remove forced index and NOT NULL condition [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133061 [11:35:04] (03CR) 10Gilles: [C: 032] Remove forced index and NOT NULL condition [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133061 (owner: 10Gilles) [11:35:23] (03CR) 10Gilles: [V: 032] Remove forced index and NOT NULL condition [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/133061 (owner: 10Gilles) [11:49:55] gi11es: Yes, precisely [11:50:28] twkozlowski: media viewer has always caught clicks on that icon, as well as the image itself [11:50:45] so how do I go to file description page directly? [11:50:54] Without clicking through MV? [11:51:29] ctrl/cmd click [11:51:40] is probably what people do [11:51:52] or turning off media viewer, I guess [11:51:57] * twkozlowski grumbles at broken workflow [11:52:16] gi11es: Nah, I like it, just have the need to go straight to file description pages sometimes [11:52:38] twkozlowski: ctrl is actully good [11:53:00] I understand. it hasn't been brought up much, I think most people who want to keep their workflow would turn off media viewer [11:53:49] I'm pretty sure that the idea of having an icon go to the file page was discussed at some point [11:54:02] all of that was decided early on in the project, I imagine [12:06:07] gi11es: Any ideas when MMV will cover videos? [12:06:15] https://en.wikipedia.org/wiki/Mariya_Yaremchuk#2013.E2.80.93present:_Eurovision_Song_Contest_2014 for instance [12:07:19] twkozlowski: hard to say, we're going to pause media viewer development for a while because there are other projects that really need attention [12:07:31] timed media handler is one of them (the current video player) so it's kind of related [12:07:42] we're likely to update that before we get to video support in media viewer [12:08:16] I see [12:08:41] at the moment we're moving our attention to UploadWizard and image scalers (thumbnail generation) [16:55:39] Morning all [16:55:56] I was (unsurprisingly) tired and overslept, will be in late [18:46:33] (03CR) 10MarkTraceur: [C: 032 V: 032] "Cool beans, I'll push it out now" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/131954 (owner: 10Gilles) [18:47:09] gi11es: I'm thinking it might be time to set up a few sanity checks on the analytics/multimedia* repos [18:57:52] (03PS6) 10Gergő Tisza: Extract metadata panel scroll/log/animate logic into separate component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 [18:58:52] (03CR) 10Gergő Tisza: "I accidentally changed the order of creating the progressbar and drag bar elements. Should be fixed now." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [19:00:20] fabriceflorin: http://multimedia-metrics.wmflabs.org/graphs/mmv_image_views_global [19:00:29] You can accept it https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/529 [19:08:00] (03PS1) 10MarkTraceur: Add zoom-brush to all the graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133112 [19:10:45] (03CR) 10MarkTraceur: [C: 032 V: 032] Add zoom-brush to all the graphs [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133112 (owner: 10MarkTraceur) [19:13:08] (03PS1) 10MarkTraceur: Missed one graph for zoom-brush [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133114 [19:14:04] (03CR) 10MarkTraceur: [C: 032 V: 032] Missed one graph for zoom-brush [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133114 (owner: 10MarkTraceur) [19:20:09] (03CR) 10Gergő Tisza: "I still don't see how you would split up the class, zoom() uses fetch* calls all over the place. I'll try to refactor it in a child commit" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [19:20:27] tgr: OK, I have a feeling this will go over my head, but why "randomized rounding"? [19:21:27] it's basically what it did before, just in a way that was unfriendly towards arguments < 1 [19:21:40] Ah. [19:21:48] I guess the goal is to be exact on average [19:22:04] This sounds like a terrible way to do that but OK. [19:22:14] you have to wait integer seconds because everything uses unix zimestamps [19:22:37] *nod* [19:22:44] but if you say 1.5 seconds, then over a hundred calls you want it to be 150 seconds, not 100 or 200 [19:23:22] random rounding is the easiest way of doing that, you don't have to keep track of previous roundings [19:55:46] And if you say 1.25 you don't want the total over 100 to be 150. [19:55:58] (which is what it seems the previous code would accomplish?) [19:56:05] Er wait no. [19:56:10] * marktraceur tries again to grok [19:57:22] Yeah it was just terrible [20:43:28] fabriceflorin: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/601 could also be tested/moved into accepted by you if you'd like. [20:49:32] (03PS1) 10MarkTraceur: Add file page to zoomable, fix maps [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133165 [20:49:44] (03CR) 10MarkTraceur: [C: 032 V: 032] Add file page to zoomable, fix maps [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133165 (owner: 10MarkTraceur) [20:52:12] (03PS1) 10MarkTraceur: Fix a thinko in the geoperf and perf definitions [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133166 [20:52:29] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix a thinko in the geoperf and perf definitions [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133166 (owner: 10MarkTraceur) [20:54:21] (03PS1) 10MarkTraceur: Didn't actually enable zoom-pan [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133167 [20:54:42] (03CR) 10MarkTraceur: [C: 032 V: 032] Didn't actually enable zoom-pan [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133167 (owner: 10MarkTraceur) [21:00:05] (03PS1) 10MarkTraceur: Move zoom-pan to geo-map's children [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133169 [21:00:25] (03CR) 10MarkTraceur: [C: 032 V: 032] Move zoom-pan to geo-map's children [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/133169 (owner: 10MarkTraceur) [21:45:18] tgr: As discussed, I have split the Upload Wizard Data Collection card into two smaller tickets (#305 Data collection 1: Major Steps vs. #603 Data collection 2: Detailed Steps): https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/305 and https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/603 [21:47:36] tgr: So the first ticket should be a lot easier to do, and could be used right away for our funnel analysis (#541). I am not sure whether counting the number of files submitted versus accepted should be pushed back to the second ticket, but kept it in the first ticket for now, if it’s easy to track, since it is a measure of success and an indication of how many of these uploads are for multiple files. [21:48:11] Didn't we fix the Commons icon being too small? [21:48:25] Hm, guess not. [21:49:13] Oh, we fixed it for the button in the panel but not in the above-fold thing [21:57:44] marktraceur: Yeah, we forgot to fix the Commons button, so I just submitted a new ticket. Should be pretty straightforward, I hope. :) [21:57:55] 'kay [22:04:58] (03CR) 10Gergő Tisza: "Tried but gave up when the changes started growing. Moving methods to a separate file but keeping them in the same class (or using some so" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:11:15] fabriceflorin, tgr - was there discussion somewhere about the zoom scope change? [22:12:00] marktraceur: Yes, we reduced the Zoom scope to just be a link, but haven’t seen a discussion about that scope change yet. [22:12:10] OK, that's Bad [22:12:23] Sec. [22:12:31] Unless I'm missing something, it wasn't public [22:12:33] Not even to me [22:12:53] iirc we agreed at the last planning meeting to limit this sprint's work two 2 points [22:13:41] We all discussed this at the last team meeting, and agreed to start with the link, because it could be done faster: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/588 [22:13:46] OK [22:13:46] although in the end it did take much more than that due to all the deferred-juggling [22:14:02] For a basic version that would take a bit more time, check out this card #504: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/504 [22:14:02] Oh, right. [22:14:08] The mockup is blinding me [22:14:12] The card actually does say "link" [22:14:17] * marktraceur deletes mockup for sanity [22:14:54] so we might have been better off doing the more complex version, but hindsight is 20/20 [22:15:15] If we had more time, I would be up for the basic zoom (#504), but #588 gives us a temporary solution, and we still have a lot of other issues to address. [22:15:50] tgr: Darn, that’s too bad. But we must live and learn, and pay tuition :) [22:18:13] tgr: Maybe we can revisit #504 later this summer, when we’re caught up with some of the other tasks on our plate. Here are the small design tasks that I’m asking Pau to focus on right now: #544. #546, #589, #396 — as listed in section 3 of this design meeting agenda: http://etherpad.wikimedia.org/p/multimedia-design-05-15-2014 [22:19:54] Hm, the image scalers...may be taking a hit. I got an error on my local wiki for a commons image [22:20:16] Hm, nope [22:20:20] Weird. [22:27:08] (03CR) 10MarkTraceur: [C: 04-1] "I'm seeing weirdness." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:32:54] (03CR) 10Gergő Tisza: "That's sort of by design (see the long-winded comment about why it is necessary): if the thumbnail URL guessing fails, you get a 404, and " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:33:43] (03CR) 10MarkTraceur: "Hrm. I don't particularly like the solution that puts the user in front of a 404 page. Can we HEAD the thumbnail before window.open()ing?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:34:11] Oh, no. [22:34:14] Sorry, ignore me [22:35:23] (03CR) 10MarkTraceur: "Sorry, ignore me, we can't." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza) [22:36:31] (03CR) 10Gergő Tisza: "Unfortunately not. If you open the window in a function whose call chain does not contain a click or similar event, the popup blocker kick" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/132133 (owner: 10Gergő Tisza)