[00:20:40] (03PS3) 10MarkTraceur: jquery audit of mw.ApiUploadHandler.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) [00:22:45] (03PS4) 10MarkTraceur: jshint fixes for mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) [00:54:59] (03CR) 10Krinkle: jquery audit of mw.ApiUploadHandler.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [01:06:08] (03CR) 10Krinkle: jshint fixes for mw.UploadWizardDeed.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [06:59:54] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [07:08:26] (03PS5) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [07:10:06] (03CR) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [07:14:15] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [07:36:35] (03CR) 10Gilles: "Never rely on the client clock for absolute time, you'd be amazed how many people run their computers with completely wrong date and times" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [08:34:11] (03CR) 10Gilles: [C: 04-2] "We can't rely on connectStart/connectEnd or similar Resource Timing data, because most of the records don't have data for that. Either bec" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [08:36:51] (03PS3) 10Gilles: Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 [08:37:41] (03CR) 10jenkins-bot: [V: 04-1] Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [08:40:57] (03CR) 10Gilles: Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [08:41:52] (03PS4) 10Gilles: Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 [08:42:12] (03CR) 10jenkins-bot: [V: 04-1] Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [09:14:34] (03CR) 10Gilles: "The main test failure is coming from core: https://gerrit.wikimedia.org/r/131672" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [09:31:03] (03PS1) 10Gilles: Filter browser cache hits [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/131673 [10:36:42] left couple comments arising from translation [11:29:19] (03PS5) 10Gilles: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 [11:30:29] (03CR) 10jenkins-bot: [V: 04-1] Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [11:36:39] (03CR) 10Gilles: [C: 04-1] Do not log a metadata event when the user presses the wrong key (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131586 (owner: 10Gergő Tisza) [11:40:45] (03CR) 10Gilles: [C: 04-1] "Is there any new code to pay special attention to, or is this a plain move job?" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131618 (owner: 10Gergő Tisza) [11:56:25] (03CR) 10Gilles: [C: 032] jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [11:56:37] (03Merged) 10jenkins-bot: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [12:02:08] (03CR) 10Gilles: [C: 032] jshint fixes for mw.UploadWizardDetails.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [12:02:17] (03Merged) 10jenkins-bot: jshint fixes for mw.UploadWizardDetails.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (https://bugzilla.wikimedia.org/47161) (owner: 10MarkTraceur) [12:12:04] (03PS1) 10Gilles: Fix missed jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131685 (https://bugzilla.wikimedia.org/47161) [12:14:50] (03CR) 10Gilles: [C: 032] Fix missed jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131685 (https://bugzilla.wikimedia.org/47161) (owner: 10Gilles) [12:14:56] (03Merged) 10jenkins-bot: Fix missed jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131685 (https://bugzilla.wikimedia.org/47161) (owner: 10Gilles) [12:21:10] (03PS1) 10Gilles: Fix miscellaneous jshint issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131686 (https://bugzilla.wikimedia.org/47161) [12:34:54] (03CR) 10Gilles: [C: 031] "Needs a rebase since mw.UploadWizardDetails.js has just been cleaned up for jshint issues. Otherwise changeset looks good." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [12:41:18] "Needs a rebase since mw.UploadWizardDetails.js " ^^ noticed that with my second patchset I wanted to submit now ... [12:45:13] 686 insertions(+), 704 deletions(-) ... [12:45:21] * rillke throws stones at someone :) [13:01:49] (03PS6) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [13:01:52] (03PS1) 10Rillke: Accept files that have whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) [13:02:50] (03CR) 10Rillke: [C: 04-1] "made a mistake while re-basing" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [13:07:58] (03PS7) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [13:08:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [13:18:00] (03CR) 10Rillke: [C: 04-1] "again MediaWiki wiki -- don't know what I did wrong :(" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [13:20:43] (03PS8) 10Rillke: UploadWizard: Don't throw JS errors; instead report them in UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) [13:27:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131595 (https://bugzilla.wikimedia.org/64908) (owner: 10Rillke) [13:30:48] (03PS2) 10Rillke: Accept files that have whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) [13:40:47] (03PS3) 10Rillke: Accept files whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) [13:42:03] (03CR) 10Nemo bis: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [14:04:46] (03PS4) 10Rillke: Accept files whose name are invalid titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) [14:05:10] (03CR) 10Rillke: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [15:39:41] 2014-05-06 - 08:36:13 they schould fix UploadWirzard instead of spending too much time in betafeatures [15:39:45] From -commons [16:14:38] (03CR) 10Lupo: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [16:26:48] (03CR) 10Lupo: Accept files whose name are invalid titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/131691 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [16:59:54] (03PS5) 10MarkTraceur: Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [17:03:00] (03CR) 10MarkTraceur: [C: 032] Remove the threshold where a load is considered to be coming from the browser cache [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131428 (owner: 10Gilles) [17:03:21] Whooops [17:03:34] It's fine though, gate/submit is the same as test for us [17:04:32] (03CR) 10MarkTraceur: [C: 032 V: 032] Filter browser cache hits [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/131673 (owner: 10Gilles) [17:08:26] * marktraceur deploys analytics stuff [17:08:29] And things. [17:10:13] (03PS6) 10MarkTraceur: Improve DurationLogger test code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [17:41:04] gi11es: It may be that our SQL queries are hanging and that's why we don't have action counts [17:59:14] (03CR) 10MarkTraceur: [C: 04-1] Improve DurationLogger test code (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/131435 (owner: 10Gilles) [19:22:30] marktraceur tgr : Hi guys, here are first findings of Media Viewr survey results so far. Let me know what you think. Will compile French results next. https://docs.google.com/spreadsheets/d/1W0rEpgdLALK5XowN9gtnFvHCuBUOm6qUOeM0rHK87XY/edit?usp=sharing [19:23:01] Key finding from Dutch responses: about 30% of actionable comments are requesting some form of zoom, which matches feedback from discussions in other languages. I think we will have to bite the bullet and develop this feature for this release. [19:43:22] marktraceur tgr : It looks like some Media Viewer metrics dashboards may be showing missing data again. The global dashboard is back at 3 million daily image views, though I expected even more with the French and Dutch rollouts: http://multimedia-metrics.wmflabs.org/dashboards/mmv [19:43:50] But the French dashboard is not working at all: http://multimedia-metrics.wmflabs.org/dashboards/mmv_frwiki [19:44:23] And yet the English dashboard is showing some data: http://multimedia-metrics.wmflabs.org/dashboards/mmv_enwiki [19:44:47] tgr marktraceur : Have we heard from analytics if they completed their EventLogging migration yet? [20:05:34] So...try again [20:05:40] It may have just finished the frwiki [20:05:51] Yeah, looks like it [20:06:50] Krinkle: In order, here, Multimedia-l, mail to (mtraceur@member.fsf.org,gtisza@wikimedia.org,gdubuc@wikimedia.org), pinging individuals in IRC [20:07:41] Someone from nl.wikipedia (#wikipedia-nl) is complaining MMV broke Wikipedia completely and unacceptibly for nl.wikipedia on IE/Win7 [20:07:59] clicking an image no longer goes to the File page (not the end of the world), and instead he gets a black page with a cross (x) button. No image. [20:08:09] clicking the cross removes the cross, but leaves an indefinite black page [20:08:22] Krinkle: Ooh, fun bug. [20:08:23] No details yet, trying to get him to provide more details tomorrow. [20:08:45] probably an exception [20:08:46] Krinkle: Yeah, an error message would be doubleplushelpful [20:08:55] Is it using OOjs? [20:09:02] Parts of it are [20:09:12] If so, I assume it takes care not to load itself in browsers that mediawiki-startup.js supporst but OOjs does not? [20:09:20] Errrr maybe not. [20:09:32] Krinkle: Will file a bug [20:09:47] because otherwise, it will cause uncaught exceptions in a wide range of browsers that will introduce unrecoverable states like this [20:09:57] you need a feature test that will return early from the init moduel that binds the click handlers [20:10:06] OK :) [20:26:47] Krinkle: it does not, but it does catch exceptions that are thrown when loading the classes, and uninstalls itself [20:27:22] so you shouldn't see a black screen if it is an oojs compatibility issue [20:40:59] marktraceur, gi11es: if either of you has time to review GWToolset changes today/tomorrow, please look at https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/573 [20:41:15] we should merge it before the branch cut [20:43:42] might be a different exception, one thrown at run time [20:45:02] probably, but should not be OOjs-related then [20:45:41] we use OOjs for class inheritance only, and OOjs UI is loaded on demand when the share dialog is opened [21:09:26] tgr: Should all of the JobQueue::push() calls be wrapped in try/catch now? [21:09:49] * bd808 scans core patches that caused this [21:10:03] bd808: ideally, they should be already wrapped [21:10:20] extension throwing was not introduced by this patch [21:10:37] exception throwing i mean [21:11:26] also, ideally exceptions should be caught near the top, unless you are doing batch processing or something like that [21:11:29] I see you added a try/catch to includes/Helpers/GWTFileBackend.php but not other uses? [21:11:53] I tried to preserve existing behavior [21:12:21] Sure. I guess I'm just not sure if Dan new what that behavior was :) [21:12:52] at most places GWT just threw an MWException when false was returned, so no harm in not catching, I suppose [21:13:31] Yeah. I know Dan worked pretty hard to give pretty error messages when things blew up. [21:13:40] I would prefer exceptions not being caught unless that specific function has a really good idea how to recover from the error [21:14:18] but I don't feel like rewriting half the error handling in GWToolset [21:15:56] The intent for a lot of the catches/error checking was to throw something that had a message that the end user might understand. Core exception message strings aren't always transparent in their meaning [21:16:23] I think that intent was misguided [21:16:46] on one hand it makes the code unreadable, over half of the code is error message formatting [21:17:03] and it wasn't a clean code to start with [21:17:54] It was a pretty good attempt for someone learning php and mediawiki at the same time, but yeah [21:18:27] Nik would say that is suffers from "javafication" [21:19:08] not blaming it on Dan, he was thrown into the deep end and left alone there until the end of the project [21:19:40] but I don't think the way the extension does error handling is useful [21:20:41] it provides no value to the end user [21:21:31] saying stuff like "media upload job creation failed" is not helpful, they can't do anything to fix it anyway [21:22:10] an error message should provide information about how to mitigate/report, not irrelevant technical details [21:22:57] and that's something that should be built into the exception handling framework and not handled per function [21:23:17] * bd808 agrees [21:25:26] anyway, based on when @throws was added, JobQueueGroup::push has been throwing exceptions since 2012 [21:26:40] I don't know whether not catching those was intentional or not, so I tried not to change that [21:27:01] except for the setLastError stuff which seemed important [21:27:15] That works for me. [21:27:54] Do you want a merge or are you waiting for review from gi11es and marktraceur? [21:28:14] It seems like this should get in this week before it all melts. [21:29:02] I think the core patch went out on Monday [21:29:52] but yeah, it should be deployed this week, I would appreciate a merge [21:38:50] tgr: {{done}}. I'm not sure if it's too late for you to get a backport into today's SWAT or not. I suppose you should at least try to verify in beta first. [21:39:12] thanks [21:40:16] I got pretty used to +2'ing patches to that extension that I only mostly understood. ;) [21:40:57] I could live with it being broken for a week, it has to be throttled into oblivion due to the image scaler issue anyway [21:49:22] marktraceur tgr : Hi guys, I just tested and accepted as many of the current sprint tickets on Mingle as I could — the metadata panel naimation, progress bar flashing, RTL bug fixes, and various metrics dashboard tweaks. Let me know if there’s anything else you’d like me to test — the remaining bugs seem a bit too technical for me: http://ur1.ca/gtyrp [21:49:51] Cool. [21:50:05] I can test the rest [21:51:38] fabriceflorin: https://commons.wikimedia.org/wiki/Commons:GWToolset_users/table [21:51:48] this has the list of planned GWToolset uploads [21:51:58] probably incomplete at the moment [21:53:01] marktraceur: Sounds good. Going back to survey compilation mode for now, but ping me if you need anything else tested. [21:53:05] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/527 how would you suggest testing this? Need an IE user? [21:53:05] tgr: Thanks for the info about upcoming GWToolset uploads, very helpful :) [22:06:09] tgr, gi11es, I've left two things in that I couldn't test; your help would be appreciated [22:26:50] huh. apparently, we do disable MMV for old IE [22:30:26] Oh? [22:37:09] I wanted to test the click handler removal card on IE7, but not even the expand image button is created [22:41:08] Hm. Helpful. [23:31:20] I'm going to go home and probably catch up a little bit from there