[10:03:02] (03CR) 10Gilles: "My main concern with this change is that in the new code it's really hard to count how many assertions are happening. I used to have that " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [10:06:49] (03CR) 10Gilles: [C: 04-1] Add preferences link after "help" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129296 (owner: 10MarkTraceur) [13:50:17] (03PS4) 10Gilles: Set correct license link location in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 [14:09:56] (03PS1) 10Gilles: Preload Media Viewer js/css when hovering thumbs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 [14:49:05] (03PS1) 10Gilles: User custom user agent to identify production test runs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129438 [14:52:46] (03PS2) 10Gilles: User custom user agent to identify production test runs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129438 [16:18:30] Sigh, https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/435 is not estimated [16:18:40] Nor is https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/471 [16:18:55] Or https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/494 [16:19:46] (03CR) 10Mattflaschen: "Loading 'ext.uploadWizard' on every page is only temporary for testing, right?" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [17:34:07] tgr: imho the current percentiles are enough information. we should probably file histograms as a nice-to-have card, but I think it's not a good use of time to work on it now [17:34:39] ack [17:34:55] i'll file a card then [17:35:01] Are any of you familiar with the JPEG 2000 format? [17:35:23] gi11es: have you looked at how the NetworkTiming extension works? [17:35:49] tgr: uses the same API as we do, in a simpler fashion, afaik [17:35:56] they seem to use statsd+graphite to collect the data [17:36:09] ah, the graphs I haven't seen [17:36:18] might be interesting to ask what the advantages are from that [17:36:52] I don't know where the actual graphs are, I just stumbled into their puppet config [17:37:53] also, we could probably use that data to get more detailed file page loading times [17:38:04] percentiles and whatnot [17:39:02] file page load time != time it takes for the page and the image to be fully loaded, though [17:39:07] IIRC they use a slightly different browser API from us, which focuses on page event timing (DOM ready etc) instead of per-resource timing [17:39:18] big difference when it comes to comparing media viewer and the file description page [17:39:21] but I might remember wrong [17:39:38] well, the onload event is not a bad approximation [17:39:45] last time I looked at that extension's code it was using the navigation timing api [17:40:28] we use ResourceTiming, though [17:41:31] doesn't make sense to read performance.timing.navigationStart for media viewer [17:42:03] yes, it doesn't [17:42:14] but it might for file page loads [17:42:52] I think the loadEventEnd in NavigationTiming is the page onload event [17:43:00] which means all images have fully loaded [17:43:39] on a file page, the main image is the largest by far, so it probably loads last [17:43:51] if that extensions is collecting that data, it's a matter of digging in its stats [17:44:09] I don't think we should be reinventing the wheel and making measurements of the file description page of our own [17:44:19] so we just need to get the stats they already collect, filter by page namespace, and we would have the same stats for file page loads that we have for the viewer [17:44:26] right [17:45:57] should I mail analytics about that? [17:46:09] i'm gonna have a quick glance at the db [17:47:01] Dmcdevit: I guess that's a no, sorry [17:47:15] tgr: Heh, that’s fine. [17:47:23] event_pageId looks like the page being measured [17:47:31] it's an integer [17:47:46] no column looks like url nor page type [17:47:49] I’m trying to figure out if there is risk of quality loss when converting to something like JPG from JPEG 2000, and hoped someone might have an answer already. [17:48:10] https://meta.wikimedia.org/wiki/Schema:NavigationTiming [17:48:27] `page_id` of requested page. Unset for special pages. [17:48:52] does that apply to file description pages? [17:49:05] no [17:49:20] i mean, do those pages have a page_id? [17:49:27] they do [17:49:41] well, not necessarily [17:50:22] if the file is on Commons but you are looking at the description page on a local wiki, you are technically looking at a missing page [17:51:35] i think looking at the commons stats is enough [17:52:05] now the question is, how do we filter rows on that table to only keep page_id that are file pages? [17:52:37] or are we lucky enough that commons pages with page_id are all file description pages? [17:52:42] on commons, you can just join with commonswiki.page.page_id and use commonswiki.page.page_namespace to filter [17:53:00] i don't see why they would be [17:53:31] not the right dabatase :) [17:53:41] i'm looking at the eventlogging production db [17:53:59] i'm sure there is a way to access the wiki dbs from the same machine [17:54:26] cross-db queries are not fun but doable [17:54:55] for the commons db this is just a lookup by primary key, should be performant enough [17:58:09] i'll calculate the geometric mean, unfiltered [17:58:29] I imagine file description pages are the vast majority of commons pages [17:59:24] we can make a card for the real deal with crossdb queries [18:08:22] on a sample of 50000 requests to commons, the geometric mean for load event is 2.9 seconds [18:09:49] (03CR) 10Cmcmahon: "This seems reasonable, but should we wait until after https://gerrit.wikimedia.org/r/#/c/129082/ is merged to merge this?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [18:10:58] (03CR) 10Gilles: "We're running the test with Firefox on cloudbees, not Chrome. Merging this changeset now would bring back the test to green." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [18:13:08] yep, moving the offset I always get 2.8-3.0. with such a huge sample size, the figure seems very consistent [18:14:44] thanks for bringing that up tgr, it's low hanging fruit for useful data [18:18:33] (03CR) 10Cmcmahon: [C: 032] Set correct license link location in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [18:51:56] gi11es: about the NavigationTiming schema stats, probably does not make a difference, but they should be filtered for action = 'view', mobileMode IS NULL [18:52:31] that filters out (slow) special pages, page edits, etc [18:52:48] but probably those are rare enough to be insignificant [19:23:08] fabriceflorin: Media Viewer is live and working on all nine wikis [19:24:17] And it handles this map very nicely [19:24:20] https://he.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99#mediaviewer/%D7%A7%D7%95%D7%91%D7%A5:%D7%AA%D7%95%D7%9B%D7%A0%D7%99%D7%AA_%D7%94%D7%A4%D7%93%D7%A8%D7%A6%D7%99%D7%94.png [19:24:37] So thanks, gi11es, tgr, marktraceur, team :) [19:25:28] Keegan: Wonderful. Keep us posted on what you hear from our communities. Assuming all goes well, I’ll post an update in an hour or so. Let us know if any major discusson gets started on any of our sites, and please add any important links to the release plan. Thanks! [19:25:33] Hang on... [19:25:57] fabriceflorin: Check that link I just did. The descriptions are...wanting. There's no licensing link [19:26:01] (It's a local upload) [19:26:35] The local upload page isn't full so..meh well [19:26:37] Local problem [19:26:48] Whoa cool. RTL actually works. [19:27:25] Keegan: One thing I was unsure of was really long titles or authour/source things getting truncated in RTL [19:29:20] Thanks, Keegan: It sounds like the local file problem may be a greater issue on Hebrew than other sites. If it gets to be an very serious issue, we could consider removing it on that site, but that’s an absolute worst case scenario. Sound good? [19:29:44] Is this not another case of them not having machine-readable data? [19:30:14] I’m off to grab lunch with Erik for about an hour, will be back then to check in on the community response or any other issues. I have an email announcement almost ready to go, but want to wait an hour or so to send it, in case there are serious issues. [19:31:18] tipsy is very broken in RTL, I made a card about that a few days ago, but maybe we want to prioritize it up [19:32:55] marktraceur: Yes, it's a problem on he.wp's end with machine-readable data [19:33:08] it looks like they marked up their file description pages properly and we still do not show the data :( [19:33:12] I don't think we should disable due to *that*. I scratched my initial concern [19:33:28] And RTL works very nicely, relatively speaking [19:33:45] also the commons link is not RTL-friendly [19:33:50] tgr: Ah [19:34:03] * Keegan checks more he.wp files [19:34:28] The good news is that I didn't see this on the other wikis [19:34:37] I'll look more extensively in a bit [19:35:28] the license icon might be non-RTL-friendly either [19:35:51] although given it is usually latin text, I'm not even sure what the correct behavior would be [19:36:24] It looked fine on a page Amir A. and I tested through last week [19:36:59] I might be misunderstanding how it should look [19:37:08] bidi is complicated [19:37:25] but the commons icon is definitely on the wrong side [19:37:31] It /should/ look normalish [19:37:40] tgr: I've just added the parameters you mentioned and it only shaves off 0.05 seconds on the geometric average [19:38:07] txet LTR txet LTR [19:38:57] * Keegan goes to lunch as well [19:39:38] gi11es: cool [19:39:59] that means the vs test you wrote matches pretty well with the actual stats, right? [19:49:58] seems like it [19:52:37] (03PS1) 10MarkTraceur: WIP Add a basic hook interface for adding metadata [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129548 [19:52:57] (03CR) 10MarkTraceur: [C: 04-1] "Probably needs some design thoughts, ignore for now" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129548 (owner: 10MarkTraceur) [19:53:10] (03CR) 10jenkins-bot: [V: 04-1] WIP Add a basic hook interface for adding metadata [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129548 (owner: 10MarkTraceur) [20:02:58] (03CR) 10Gergő Tisza: "The weird assertion count is https://github.com/cjohansen/sinon-qunit/issues/10 - if we use the workaround described there, the assertion " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [20:21:08] gi11es: I'm porting the analytics crap to gerrit finally [20:25:16] marktraceur: which repo is that? I want to add it to the dashboard [20:25:52] tgr: analytics/multimedia and analytics/multimedia/config [20:28:41] Hi guys, I’m back from lunch now. Any new developments I should know about, before I post the email announcement? [20:29:21] (03PS1) 10Gergő Tisza: [WIP] Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 [20:32:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 (owner: 10Gergő Tisza) [20:32:31] marktraceur: the ellipsis seems to be at the wrong place here: https://he.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99#mediaviewer/%D7%A7%D7%95%D7%91%D7%A5:Mossad_seal.png [20:33:11] tgr: Well, sort of [20:33:12] what is actually chopped off is "by User:Fry19[chop]via CommonsHelper" [20:34:20] tgr: It's RTL, that's the issue [20:34:31] although this seems unrelated to anything we are actually doing [20:35:17] looks like the bidi algorithm came up with this on its own [20:52:11] (03PS1) 10Gergő Tisza: Add metric dashboards to the gerrit dashboard [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/129572 [20:52:46] (03CR) 10Gergő Tisza: [C: 032] Add metric dashboards to the gerrit dashboard [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/129572 (owner: 10Gergő Tisza) [20:54:58] (03CR) 10Gergő Tisza: [V: 032] Add metric dashboards to the gerrit dashboard [extensions/MultimediaViewer] (refs/meta/dashboards/custom) - 10https://gerrit.wikimedia.org/r/129572 (owner: 10Gergő Tisza) [21:03:46] gi11es: https://gerrit.wikimedia.org/r/#/q/%28project:analytics/multimedia/config+OR+project:analytics/multimedia%29+status:open,n,z [21:03:55] I think I got them all but confirmation might be good [21:13:25] (03CR) 10Gergő Tisza: [C: 04-1] "Is there a way to filter out mouseenters where the user just yanks the mouse over a thumbnail in the process of doing something else? Like" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129425 (owner: 10Gilles) [21:18:38] gi11es: how hard is it to get the 90th percentile for the Commons file page loading time? It would be interesting to compare with MMV percentiles [22:31:00] (03PS8) 10Gergő Tisza: Use sinon.js to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [22:35:58] fabriceflorin: I PM'd you, I know you sometimes don't see those [22:39:03] (03CR) 10Gergő Tisza: "Now with explicit asserts." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [23:13:42] (03CR) 10MarkTraceur: [C: 032] User custom user agent to identify production test runs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129438 (owner: 10Gilles) [23:14:17] (03Merged) 10jenkins-bot: User custom user agent to identify production test runs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129438 (owner: 10Gilles) [23:49:18] (03PS2) 10Gergő Tisza: Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 [23:49:50] (03CR) 10jenkins-bot: [V: 04-1] Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 (owner: 10Gergő Tisza) [23:51:20] (03PS3) 10Gergő Tisza: Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 [23:51:51] (03CR) 10jenkins-bot: [V: 04-1] Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564 (owner: 10Gergő Tisza) [23:55:14] http://multimedia-metrics.wmflabs.org/dashboards/mmv#geographical_network_performance-graphs-tab is back [23:55:35] (03PS4) 10Gergő Tisza: Make progress bar less erratic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129564